Skip to contentSkip to conversation

i2c: i801: Fix block process call transactions

PATCH Zakowski, Piotr 2 participants 2 messages Feb 21, 2024 – Feb 26, 2024 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

Piotr, does this change make your tests succeed?

Hi Jean,

I applied your change and test now passes the expectations.

Could I confirm with you ioctl() response convention:
It is expected from driver to return +1 Byte (Byte Count as first byte together with the actual data) in read block commands (i.e. Block Read Command and Block Write - Block Read Process Call)?

For example:

Data: 0x5a 0x82 0x64 0xB9 (4 Bytes)
Return of ioctl() call of Block Read command: 0x04 0x5a 0x82 0x64 0xB9

Best regards,
Piotr

#1 lore raw

Hi Piotr,

Quoted 2 lines · Piotr

I applied your change and test now passes the expectations.

Sweet, thanks for testing!

Quoted 9 lines

Could I confirm with you ioctl() response convention:
It is expected from driver to return +1 Byte (Byte Count as first byte together with the actual data) in read block commands (i.e. Block Read Command and Block Write - Block Read Process Call)?

For example:

Data: 0x5a 0x82 0x64 0xB9 (4 Bytes)
Return of ioctl() call of Block Read command: 0x04 0x5a 0x82 0x64 0xB9

Yes, this is the expected return.

Signature · 2 lines
Jean Delvare
SUSE L3 Support