Drivers: hv: Use meaningful errnos for hypercall status codes
Subsystems (2)
PATCH 1/1 Drivers: hv: Use meaningful errnos for hypercall status codes
Commit 3817854ba892 ("hyperv: Log hypercall status codes as strings") converted hv_result_to_errno() from a switch to a table and added status codes used for string logging. Statuses without an existing specific mapping were assigned the generic -EIO fallback even when a more specific errno was available.
Map HV_STATUS_ACCESS_DENIED and HV_STATUS_OPERATION_DENIED to -EACCES, HV_STATUS_UNKNOWN_PROPERTY and HV_STATUS_PROPERTY_VALUE_OUT_OF_RANGE to -EINVAL, and HV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTED to -EOPNOTSUPP. This lets callers distinguish permission, argument, and capability failures from generic I/O errors.
The table conversion also added duplicate HV_STATUS_INVALID_LP_INDEX and HV_STATUS_INVALID_REGISTER_VALUE entries. Remove the later -EIO entries, which are unreachable because find_hv_status_info() returns the first match.
--- drivers/hv/hv_common.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/hv/hv_common.c +5 -7
@@ -787,11 +787,11 @@ static const struct hv_status_info hv_status_infos[] = {_STATUS_INFO (HV_STATUS_INVALID_HYPERCALL_INPUT , -EINVAL ),_STATUS_INFO (HV_STATUS_INVALID_ALIGNMENT , -EIO ),_STATUS_INFO (HV_STATUS_INVALID_PARAMETER , -EINVAL ), -_STATUS_INFO (HV_STATUS_ACCESS_DENIED , -EIO ), +_STATUS_INFO (HV_STATUS_ACCESS_DENIED , -EACCES ),_STATUS_INFO (HV_STATUS_INVALID_PARTITION_STATE , -EIO ), -_STATUS_INFO (HV_STATUS_OPERATION_DENIED , -EIO ), -_STATUS_INFO (HV_STATUS_UNKNOWN_PROPERTY , -EIO ), -_STATUS_INFO (HV_STATUS_PROPERTY_VALUE_OUT_OF_RANGE , -EIO ), +_STATUS_INFO (HV_STATUS_OPERATION_DENIED , -EACCES ), +_STATUS_INFO (HV_STATUS_UNKNOWN_PROPERTY , -EINVAL ), +_STATUS_INFO (HV_STATUS_PROPERTY_VALUE_OUT_OF_RANGE , -EINVAL ),_STATUS_INFO (HV_STATUS_INSUFFICIENT_MEMORY , -ENOMEM ),_STATUS_INFO (HV_STATUS_INSUFFICIENT_CONTIGUOUS_MEMORY , -ENOMEM ), _STATUS_INFO(HV_STATUS_INSUFFICIENT_ROOT_MEMORY, -ENOMEM),
@@ -805,11 +805,9 @@ static const struct hv_status_info hv_status_infos[] = {_STATUS_INFO (HV_STATUS_NOT_ACKNOWLEDGED , -EIO ),_STATUS_INFO (HV_STATUS_INVALID_VP_STATE , -EIO ),_STATUS_INFO (HV_STATUS_NO_RESOURCES , -EIO ), -_STATUS_INFO (HV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTED , -EIO ), +_STATUS_INFO (HV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTED , -EOPNOTSUPP ),_STATUS_INFO (HV_STATUS_INVALID_LP_INDEX , -EINVAL ),_STATUS_INFO (HV_STATUS_INVALID_REGISTER_VALUE , -EINVAL ), -_STATUS_INFO (HV_STATUS_INVALID_LP_INDEX , -EIO ), -_STATUS_INFO (HV_STATUS_INVALID_REGISTER_VALUE , -EIO ),_STATUS_INFO (HV_STATUS_OPERATION_FAILED , -EIO ),_STATUS_INFO (HV_STATUS_TIME_OUT , -EIO ), _STATUS_INFO(HV_STATUS_CALL_PENDING, -EIO),
Signature · 1 line
2.34.1
Hi Hardik,
Quoted 17 lines · Hardik Garg
Commit
3817854ba892("hyperv: Log hypercall status codes as strings") convertedhv_result_to_errno()from a switch to a table and added status codes used for string logging. Statuses without an existing specific mapping were assigned the generic-EIOfallback even when a more specific errno was available.Map
HV_STATUS_ACCESS_DENIEDandHV_STATUS_OPERATION_DENIEDto-EACCES,HV_STATUS_UNKNOWN_PROPERTYandHV_STATUS_PROPERTY_VALUE_OUT_OF_RANGEto-EINVAL, andHV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTEDto-EOPNOTSUPP. This lets callers distinguish permission, argument, and capability failures from generic I/O errors.The table conversion also added duplicate
HV_STATUS_INVALID_LP_INDEXandHV_STATUS_INVALID_REGISTER_VALUEentries. Remove the later-EIOentries, which are unreachable becausefind_hv_status_info()returns the first match.
Quoted 5 lines
Signed-off-by Hardik Garg <[email protected]>--- drivers/hv/hv_common.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
Glad to see that this was something that bothered you as well. If you like, you can pick up feedback from Nuno on my attempt to solve this [1] and do a de-facto v3.
[1] https://lore.kernel.org/all/[email protected]/
Thanks,
Easwar (he/him)
Naman Jain
Reviewed-byQuoted 25 lines · Easwar Hariharan
Hi Hardik,
Quoted 17 lines · Hardik Garg
Commit
3817854ba892("hyperv: Log hypercall status codes as strings") convertedhv_result_to_errno()from a switch to a table and added status codes used for string logging. Statuses without an existing specific mapping were assigned the generic-EIOfallback even when a more specific errno was available.Map
HV_STATUS_ACCESS_DENIEDandHV_STATUS_OPERATION_DENIEDto-EACCES,HV_STATUS_UNKNOWN_PROPERTYandHV_STATUS_PROPERTY_VALUE_OUT_OF_RANGEto-EINVAL, andHV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTEDto-EOPNOTSUPP. This lets callers distinguish permission, argument, and capability failures from generic I/O errors.The table conversion also added duplicate
HV_STATUS_INVALID_LP_INDEXandHV_STATUS_INVALID_REGISTER_VALUEentries. Remove the later-EIOentries, which are unreachable becausefind_hv_status_info()returns the first match.Quoted 5 lines
Signed-off-by Hardik Garg <[email protected]>--- drivers/hv/hv_common.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
Quoted 7 lines
Glad to see that this was something that bothered you as well. If you like, you can pick up feedback from Nuno on my attempt to solve this [1] and do a de-facto v3.
[1] https://lore.kernel.org/all/[email protected]/
Thanks,
Easwar (he/him)
I see no harm but only benefits in returning meaningful error code corresponding to HV_STATUS_*, where we can, specially when such an error code exists. So I agree with the motivation of this exercise.
On this patch or a new v3 of previous patch, feel free to pick my review:
Regards,
Naman
Quoted 12 lines · Hardik Garg
Commit
3817854ba892("hyperv: Log hypercall status codes as strings") convertedhv_result_to_errno()from a switch to a table and added status codes used for string logging. Statuses without an existing specific mapping were assigned the generic-EIOfallback even when a more specific errno was available.Map
HV_STATUS_ACCESS_DENIEDandHV_STATUS_OPERATION_DENIEDto-EACCES,HV_STATUS_UNKNOWN_PROPERTYandHV_STATUS_PROPERTY_VALUE_OUT_OF_RANGEto-EINVAL, andHV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTEDto-EOPNOTSUPP. This lets callers distinguish permission, argument, and capability failures from generic I/O errors.
Quoted 6 lines
The table conversion also added duplicate
HV_STATUS_INVALID_LP_INDEXandHV_STATUS_INVALID_REGISTER_VALUEentries. Remove the later-EIOentries, which are unreachable becausefind_hv_status_info()returns the first match.Signed-off-by Hardik Garg <[email protected]>
Applied. Thanks.
Wei