Bluetooth: btintel: Set Per Platform Antenna Gain(PPAG)
PATCH v3 1/1 Bluetooth: btintel: Set Per Platform Antenna Gain(PPAG)
From: Seema Sreemantha <[email protected]>
Antenna gain is defined as the antenna’s ability to increase the Tx power in a given direction. Intel is certifying its products with fixed reference antenna peak gain values (3/5dBi). The feature takes into account the actual antenna gain, and increases output power values, which results in a performance improvement.
After firmware download is completed, driver reads from ACPI table and configures PPAG as required. ACPI table entry for PPAG is defined as below.
Name (PPAG, Package (0x02)
{
0x00000001,
Package (0x02)
{
0x00000012, /* Bluetooth Domain */
0x00000001 /* 1 - Enable PPAG, 0 - Disable PPAG */
}
})btmon log:
< HCI Command: Intel Configure Per Platform Antenna Gain (0x3f|0x0219) plen 12
Mcc: 0x00000000
Selector: Enable
Delta: 0x00000000Quoted 1 line
HCI Event: Command Complete (
0x0e) plen 4
Intel Configure Per Platform Antenna Gain (0x3f|0x0219) ncmd 1
Status: Success (0x00)---
changes in v2:
Fix review comments
changes in v3:
Fix compilation issue.
drivers/bluetooth/btintel.c | 116 ++++++++++++++++++++++++++++++++++++ drivers/bluetooth/btintel.h | 13 ++++ 2 files changed, 129 insertions(+)
drivers/bluetooth/btintel.c +116 -0
@@ -9,6 +9,7 @@#include <linux/module.h> #include <linux/firmware.h> #include <linux/regmap.h> +#include <linux/acpi.h> #include <asm/unaligned.h> #include <net/bluetooth/bluetooth.h>
@@ -24,6 +25,9 @@#define ECDSA_OFFSET 644#define ECDSA_HEADER_LEN 320 +#define BTINTEL_PPAG_NAME "PPAG" +#define BTINTEL_PPAG_PREFIX "\\_SB_.PCI0.XHCI.RHUB" +#define CMD_WRITE_BOOT_PARAMS 0xfc0estruct cmd_write_boot_params {__le32 boot_addr;
@@ -1278,6 +1282,63 @@ static int btintel_read_debug_features(struct hci_dev *hdev,return 0 ; } +static acpi_status btintel_ppag_callback (acpi_handle handle,u32 lvl,void *data, +void **ret) +{ +acpi_status status; +size_t len; +struct btintel_ppag *ppag = data; +union acpi_object *p, *elements; +struct acpi_buffer string = {ACPI_ALLOCATE_BUFFER ,NULL }; +struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER ,NULL }; +struct hci_dev *hdev = ppag->hdev; + + status =acpi_get_name (handle,ACPI_FULL_PATHNAME , &string); +if (ACPI_FAILURE (status)) { +bt_dev_warn (hdev,"ACPI Failure: %s" ,acpi_format_exception (status)); +return status; + } + +if (strncmp (BTINTEL_PPAG_PREFIX , string.pointer, +strlen (BTINTEL_PPAG_PREFIX ))) { +kfree (string.pointer); +return AE_OK ; + } + + len =strlen (string.pointer); +if (strncmp ((char *)string.pointer + len -4 ,BTINTEL_PPAG_NAME ,4 )) { +kfree (string.pointer); +return AE_OK ; + } +kfree (string.pointer); + + status =acpi_evaluate_object (handle,NULL ,NULL , &buffer); +if (ACPI_FAILURE (status)) { +bt_dev_warn (hdev,"ACPI Failure: %s" ,acpi_format_exception (status)); +return status; + } + + p = buffer.pointer; + ppag = (struct btintel_ppag *)data; + +if (p->type !=ACPI_TYPE_PACKAGE || p->package.count !=2 ) { +kfree (buffer.pointer); +bt_dev_warn (hdev,"Invalid object type: %d or package count: %d" , + p->type, p->package.count); +return AE_ERROR ; + } + + elements = p->package.elements; + +/* PPAG table is located at element[1] */ + p = &elements[1 ]; + + ppag->domain = (u32 )p->package.elements[0 ].integer.value; + ppag->mode = (u32 )p->package.elements[1 ].integer.value; +kfree (buffer.pointer); +return AE_CTRL_TERMINATE ; +} +static int btintel_set_debug_features (struct hci_dev *hdev,const struct intel_debug_features *features) {
@@ -2251,6 +2312,58 @@ static int btintel_configure_offload(struct hci_dev *hdev)return err; } +static void btintel_set_ppag (struct hci_dev *hdev,struct intel_version_tlv *ver) +{ +acpi_status status; +struct btintel_ppag ppag; +struct sk_buff *skb; +struct btintel_loc_aware_reg ppag_cmd; + +/* PPAG is not supported if CRF is HrP2, Jfp2, JfP1 */ +switch (ver->cnvr_top &0xFFF ) { +case 0x504 :/* Hrp2 */ +case 0x202 :/* Jfp2 */ +case 0x201 :/* Jfp1 */ +return ; + } + +memset (&ppag,0 ,sizeof (ppag)); + + ppag.hdev = hdev; + status =acpi_walk_namespace (ACPI_TYPE_ANY ,ACPI_ROOT_OBJECT , +ACPI_UINT32_MAX ,NULL , + btintel_ppag_callback, &ppag,NULL ); + +if (ACPI_FAILURE (status)) { +/* Do not log warning message if ACPI entry is not found */ +if (status ==AE_NOT_FOUND ) +return ; +bt_dev_warn (hdev,"PPAG: ACPI Failure: %s" ,acpi_format_exception (status)); +return ; + } + +if (ppag.domain !=0x12 ) { +bt_dev_warn (hdev,"PPAG-BT Domain disabled" ); +return ; + } + +/* PPAG mode, BIT0 = 0 Disabled, BIT0 = 1 Enabled */ +if (!(ppag.mode &BIT (0 ))) { +bt_dev_dbg (hdev,"PPAG disabled" ); +return ; + } + + ppag_cmd.mcc =cpu_to_le32 (0 ); + ppag_cmd.sel =cpu_to_le32 (0 );/* 0 - Enable , 1 - Disable, 2 - Testing mode */ + ppag_cmd.delta =cpu_to_le32 (0 ); + skb =__hci_cmd_sync (hdev,0xfe19 ,sizeof (ppag_cmd), &ppag_cmd,HCI_CMD_TIMEOUT ); +if (IS_ERR (skb)) { +bt_dev_warn (hdev,"Failed to send PPAG Enable (%ld)" ,PTR_ERR (skb)); +return ; + } +kfree_skb (skb); +} +static int btintel_bootloader_setup_tlv (struct hci_dev *hdev,struct intel_version_tlv *ver) {
@@ -2297,6 +2410,9 @@ static int btintel_bootloader_setup_tlv(struct hci_dev *hdev,hci_dev_clear_flag (hdev,HCI_QUALITY_REPORT ); +/* Set PPAG feature */ +btintel_set_ppag (hdev, ver); +/* Read the Intel version information after loading the FW */ err =btintel_read_version_tlv (hdev, &new_ver);if (err)
drivers/bluetooth/btintel.h +13 -0
@@ -137,6 +137,19 @@ struct intel_offload_use_cases {__u8 preset[8 ]; } __packed; +/* structure to store the PPAG data read from ACPI table */ +struct btintel_ppag { +u32 domain; +u32 mode; +struct hci_dev *hdev; +}; + +struct btintel_loc_aware_reg { +__le32 mcc; +__le32 sel; +__le32 delta; +} __packed; +#define INTEL_HW_PLATFORM (cnvx_bt) ((u8)(((cnvx_bt) & 0x0000ff00) >> 8))#define INTEL_HW_VARIANT (cnvx_bt) ((u8)(((cnvx_bt) & 0x003f0000) >> 16))#define INTEL_CNVX_TOP_TYPE (cnvx_top) ((cnvx_top) & 0x00000fff)
Signature · 1 line
2.17.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=719011
---Test result---
Test Summary:
CheckPatch FAIL 1.62 seconds GitLint PASS 0.26 seconds SubjectPrefix PASS 0.07 seconds BuildKernel PASS 31.77 seconds CheckAllWarning PASS 34.63 seconds CheckSparse PASS 38.56 seconds CheckSmatch PASS 107.45 seconds BuildKernel32 PASS 30.17 seconds TestRunnerSetup PASS 434.62 seconds TestRunner_l2cap-tester PASS 16.45 seconds TestRunner_iso-tester PASS 16.84 seconds TestRunner_bnep-tester PASS 5.40 seconds TestRunner_mgmt-tester PASS 108.59 seconds TestRunner_rfcomm-tester PASS 8.62 seconds TestRunner_sco-tester PASS 7.92 seconds TestRunner_ioctl-tester PASS 9.25 seconds TestRunner_mesh-tester PASS 6.83 seconds TestRunner_smp-tester PASS 7.91 seconds TestRunner_userchan-tester PASS 5.68 seconds IncrementalBuild PASS 27.83 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v3] Bluetooth: btintel: Set Per Platform Antenna Gain(PPAG)
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #92:
< HCI Command: Intel Configure Per Platform Antenna Gain (0x3f|0x0219) plen 12
total: 0 errors, 1 warnings, 165 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13129360.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 11 lines · On Mon, 6 Feb 2023 12:21:44 +0530 you wrote:
From: Seema Sreemantha <[email protected]>
Antenna gain is defined as the antenna’s ability to increase the Tx power in a given direction. Intel is certifying its products with fixed reference antenna peak gain values (3/5dBi). The feature takes into account the actual antenna gain, and increases output power values, which results in a performance improvement.
[...]
Here is the summary with links:
- [v3] Bluetooth: btintel: Set Per Platform Antenna Gain(PPAG)
https://git.kernel.org/bluetooth/bluetooth-next/c/b8ad6dcdc651
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html