Skip to contentSkip to conversation

USB: serial: option: add Lonsung U8300/U9300 product Update the USB serial option driver to support Longsung U8300/U9300.

PATCH In review Coia Prant 3 participants 3 messages Apr 2, 2024 – Apr 15, 2024

Subsystems (3)
lore
Share & tools
lore

Coia Prant

author
#0 lore raw

PATCH 1/2 USB: serial: option: add Lonsung U8300/U9300 product Update the USB serial option driver to support Longsung U8300/U9300.

ID 1c9e:9b05 OMEGA TECHNOLOGY (U8300)
ID 1c9e:9b3c OMEGA TECHNOLOGY (U9300)

U8300
/: Bus
|__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=option, 480M (Debug)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 1, Class=Vendor Specific Class, Driver=option, 480M (Modem / AT)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 2, Class=Vendor Specific Class, Driver=option, 480M (AT)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 3, Class=Vendor Specific Class, Driver=option, 480M (AT / Pipe / PPP)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 4, Class=Vendor Specific Class, Driver=qmi_wwan, 480M (NDIS / GobiNet / QMI WWAN)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 5, Class=Vendor Specific Class, Driver=, 480M (ADB)
ID 1c9e:9b05 OMEGA TECHNOLOGY

U9300
/: Bus
|__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=, 480M (ADB)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 1, Class=Vendor Specific Class, Driver=option, 480M (Modem / AT)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 2, Class=Vendor Specific Class, Driver=option, 480M (AT)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 3, Class=Vendor Specific Class, Driver=option, 480M (AT / Pipe / PPP)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 4, Class=Vendor Specific Class, Driver=qmi_wwan, 480M (NDIS / GobiNet / QMI WWAN)
ID 1c9e:9b3c OMEGA TECHNOLOGY

Tested successfully using Modem Manager on U9300.
Tested successfully AT commands using If=1, If=2 and If=3 on U9300.

---
 drivers/usb/serial/option.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/usb/serial/option.c +8 -0
index 55a65d941ccb..27a116901459 100644
@@ -412,6 +412,10 @@ static void option_instat_callback(struct urb *urb);
  */
 #define LONGCHEER_VENDOR_ID			0x1c9e
 
+/* Longsung products */
+#define LONGSUNG_U8300_PRODUCT_ID		0x9b05
+#define LONGSUNG_U9300_PRODUCT_ID		0x9b3c
+
 /* 4G Systems products */
 /* This one was sold as the VW and Skoda "Carstick LTE" */
 #define FOUR_G_SYSTEMS_PRODUCT_CARSTICK_LTE	0x7605
@@ -2054,6 +2058,10 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(4) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
+	{ USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U8300_PRODUCT_ID),
+	  .driver_info = RSVD(4) | RSVD(5) },
+	{ USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U9300_PRODUCT_ID),
+	  .driver_info = RSVD(0) | RSVD(4) },
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(HAIER_VENDOR_ID, HAIER_PRODUCT_CE81B, 0xff, 0xff, 0xff) },
 	/* Pirelli  */
Signature · 1 line
2.39.2
#1 lore raw
Quoted 56 lines · Coia Prant

ID 1c9e:9b05 OMEGA TECHNOLOGY (U8300)
ID 1c9e:9b3c OMEGA TECHNOLOGY (U9300)

U8300
/: Bus
|__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=option, 480M (Debug)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 1, Class=Vendor Specific Class, Driver=option, 480M (Modem / AT)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 2, Class=Vendor Specific Class, Driver=option, 480M (AT)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 3, Class=Vendor Specific Class, Driver=option, 480M (AT / Pipe / PPP)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 4, Class=Vendor Specific Class, Driver=qmi_wwan, 480M (NDIS / GobiNet / QMI WWAN)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 5, Class=Vendor Specific Class, Driver=, 480M (ADB)
ID 1c9e:9b05 OMEGA TECHNOLOGY

U9300
/: Bus
|__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=, 480M (ADB)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 1, Class=Vendor Specific Class, Driver=option, 480M (Modem / AT)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 2, Class=Vendor Specific Class, Driver=option, 480M (AT)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 3, Class=Vendor Specific Class, Driver=option, 480M (AT / Pipe / PPP)
ID 1c9e:9b3c OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 4, Class=Vendor Specific Class, Driver=qmi_wwan, 480M (NDIS / GobiNet / QMI WWAN)
ID 1c9e:9b3c OMEGA TECHNOLOGY

Tested successfully using Modem Manager on U9300.
Tested successfully AT commands using If=1, If=2 and If=3 on U9300.

---
  drivers/usb/serial/option.c | 8 ++++++++
  1 file changed, 8 insertions(+)
drivers/usb/serial/option.c +4 -0
index 55a65d941ccb..27a116901459 100644
@@ -412,6 +412,10 @@ static void option_instat_callback(struct urb *urb);
   */
  #define LONGCHEER_VENDOR_ID			0x1c9e
 
+/* Longsung products */
+#define LONGSUNG_U8300_PRODUCT_ID		0x9b05
+#define LONGSUNG_U9300_PRODUCT_ID		0x9b3c
+
  /* 4G Systems products */
  /* This one was sold as the VW and Skoda "Carstick LTE" */
  #define FOUR_G_SYSTEMS_PRODUCT_CARSTICK_LTE	0x7605

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 2067

Quoted 10 lines
drivers/usb/serial/option.c +4 -0
@@ -2054,6 +2058,10 @@ static const struct usb_device_id option_ids[] = {
  	  .driver_info = RSVD(4) },
  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
+	{ USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U8300_PRODUCT_ID),
+	  .driver_info = RSVD(4) | RSVD(5) },
+	{ USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U9300_PRODUCT_ID),
+	  .driver_info = RSVD(0) | RSVD(4) },
  	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
  	{ USB_DEVICE_AND_INTERFACE_INFO(HAIER_VENDOR_ID, HAIER_PRODUCT_CE81B, 0xff, 0xff, 0xff) },
  	/* Pirelli  */

Reviewed-by Lars Melin ([email protected]

added the maintainer to the recipient list

maintainer
#2 lore raw
Quoted 1 line · Lars Melin

On 2024-04-02 14:34, Coia Prant wrote:

You're Subject is missing two newline characters to separate the commit summary from the commit message.

Quoted 17 lines
Quoted 17 lines

ID 1c9e:9b05 OMEGA TECHNOLOGY (U8300)
ID 1c9e:9b3c OMEGA TECHNOLOGY (U9300)

U8300
/: Bus
|__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=option, 480M (Debug)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 1, Class=Vendor Specific Class, Driver=option, 480M (Modem / AT)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 2, Class=Vendor Specific Class, Driver=option, 480M (AT)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 3, Class=Vendor Specific Class, Driver=option, 480M (AT / Pipe / PPP)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 4, Class=Vendor Specific Class, Driver=qmi_wwan, 480M (NDIS / GobiNet / QMI WWAN)
ID 1c9e:9b05 OMEGA TECHNOLOGY
|__ Port 1: Dev 3, If 5, Class=Vendor Specific Class, Driver=, 480M (ADB)
ID 1c9e:9b05 OMEGA TECHNOLOGY

Could please use the more condensed output of the usb-devices command (for both devices) which is better suited for a commit message?

Quoted 3 lines

Reviewed-by Lars Melin ([email protected]

added the maintainer to the recipient list

Thanks for reviewing, Lars.

Coia, you can include Lars's Reviewed-by tag when you send a v2.

Johan