Skip to contentSkip to conversation

rtlwifi: de-dupe rtl8723b WiFi firmware

PATCH In review Peter Robinson 3 participants 3 messages Jul 6, 2021 – Jul 16, 2021 Arm/actions semi architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtlwifi: de-dupe rtl8723b WiFi firmware

The rtl8723bs and rtl8723bu WiFi firmware are identical according to sha256sum are identical so lets remove the dupes and link them.

CC Larry Finger <[email protected]>
CC Hans de Goede <[email protected]>

---
Hey Hans and Larry,

I'd like your feedback on this, both on the WiFi firmware but also the rtlwifi/rtl8723bs_bt.bin as I suspect that's a Bluetooth firmware put in the wrong location, I don't see it referenced in any upstream drivers, I suspect it's an older/newer version of rtl8723bs_fw.bin but given it's it's smaller size it could have less features.

I think it probably just needs to be removed in a follow up patch but let me know, if you have a change to test across your hardward, if you think it's a better option to other FW we have.

Peter

 WHENCE                          |   6 +++---
 rtlwifi/rtl8723bs_ap_wowlan.bin | Bin 20886 -> 0 bytes
 rtlwifi/rtl8723bs_nic.bin       | Bin 32108 -> 0 bytes
 rtlwifi/rtl8723bs_wowlan.bin    | Bin 26398 -> 0 bytes
 4 files changed, 3 insertions(+), 3 deletions(-)
 delete mode 100644 rtlwifi/rtl8723bs_ap_wowlan.bin
 delete mode 100644 rtlwifi/rtl8723bs_nic.bin
 delete mode 100644 rtlwifi/rtl8723bs_wowlan.bin
WHENCE +3 -3
index ca669ff..623935d 100644
@@ -3181,9 +3181,9 @@ Driver: rtl8723bs - Realtek 802.11n WLAN driver for RTL8723BS
 Info: Firmware files extracted from data statements in Realtek driver
       v4.3.5.5_12290.20140916_BTCOEX20140507-4E40.
 File: rtlwifi/rtl8723bs_bt.bin
-File: rtlwifi/rtl8723bs_nic.bin
-File: rtlwifi/rtl8723bs_ap_wowlan.bin
-File: rtlwifi/rtl8723bs_wowlan.bin
+Link: rtlwifi/rtl8723bs_nic.bin -> rtl8723bu_nic.bin
+Link: rtlwifi/rtl8723bs_ap_wowlan.bin -> rtl8723bu_ap_wowlan.bin
+Link: rtlwifi/rtl8723bs_wowlan.bin -> rtl8723bu_wowlan.bin
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 
rtlwifi/rtl8723bs_ap_wowlan.bin deleted binary +0 -0
deleted file mode 100644
index 944bc16c3d55d495c1660710dac1a59a7e60868a..0000000000000000000000000000000000000000
GIT binary patch
rtlwifi/rtl8723bs_nic.bin deleted binary +0 -0
deleted file mode 100644
index 8d534053823e47ba4e49c8600463af47fbec7306..0000000000000000000000000000000000000000
GIT binary patch
rtlwifi/rtl8723bs_wowlan.bin deleted binary +0 -0
deleted file mode 100644
index 473e29c3217fb06046aa0df7a22b2e613b331235..0000000000000000000000000000000000000000
GIT binary patch
Signature · 1 line
2.31.1
#1 lore raw

Hi,

Quoted 10 lines · Peter Robinson

The rtl8723bs and rtl8723bu WiFi firmware are identical according to sha256sum are identical so lets remove the dupes and link them.

CC Larry Finger <[email protected]>
CC Hans de Goede <[email protected]>

---
Hey Hans and Larry,

I'd like your feedback on this, both on the WiFi firmware

symlinking the wifi firmware seems fine to me. Note AFAICT the drivers/staging/rtl8723bs code only actually uses the rtlwifi/rtl8723bs_nic.bin file.

Quoted 5 lines

but also the
rtlwifi/rtl8723bs_bt.bin as I suspect that's a Bluetooth firmware put in the wrong location, I don't see it referenced in any upstream drivers, I suspect it's an older/newer version of rtl8723bs_fw.bin but given it's it's smaller size it could have less features.

It does sound like BT firmware, but it seems to be in a different format then rtl8723bs_fw.bin.

Quoted 4 lines

I think it probably just needs to be removed in a follow up patch but let me know, if you have a change to test across your hardward, if you think it's a better option to other FW we have.

I agree that nothing seems to be using it, so dropping it should be fine.

Regards,

Hans

Quoted 1,087 lines
 WHENCE                          |   6 +++---
 rtlwifi/rtl8723bs_ap_wowlan.bin | Bin 20886 -> 0 bytes
 rtlwifi/rtl8723bs_nic.bin       | Bin 32108 -> 0 bytes
 rtlwifi/rtl8723bs_wowlan.bin    | Bin 26398 -> 0 bytes
 4 files changed, 3 insertions(+), 3 deletions(-)
 delete mode 100644 rtlwifi/rtl8723bs_ap_wowlan.bin
 delete mode 100644 rtlwifi/rtl8723bs_nic.bin
 delete mode 100644 rtlwifi/rtl8723bs_wowlan.bin
WHENCE +3 -3
index ca669ff..623935d 100644
@@ -3181,9 +3181,9 @@ Driver: rtl8723bs - Realtek 802.11n WLAN driver for RTL8723BS
 Info: Firmware files extracted from data statements in Realtek driver
       v4.3.5.5_12290.20140916_BTCOEX20140507-4E40.
 File: rtlwifi/rtl8723bs_bt.bin
-File: rtlwifi/rtl8723bs_nic.bin
-File: rtlwifi/rtl8723bs_ap_wowlan.bin
-File: rtlwifi/rtl8723bs_wowlan.bin
+Link: rtlwifi/rtl8723bs_nic.bin -> rtl8723bu_nic.bin
+Link: rtlwifi/rtl8723bs_ap_wowlan.bin -> rtl8723bu_ap_wowlan.bin
+Link: rtlwifi/rtl8723bs_wowlan.bin -> rtl8723bu_wowlan.bin
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 
rtlwifi/rtl8723bs_ap_wowlan.bin deleted binary +0 -0
deleted file mode 100644
index 944bc16c3d55d495c1660710dac1a59a7e60868a..0000000000000000000000000000000000000000
GIT binary patch
rtlwifi/rtl8723bs_nic.bin deleted binary +0 -0
deleted file mode 100644
index 8d534053823e47ba4e49c8600463af47fbec7306..0000000000000000000000000000000000000000
GIT binary patch
rtlwifi/rtl8723bs_wowlan.bin deleted binary +0 -0
deleted file mode 100644
index 473e29c3217fb06046aa0df7a22b2e613b331235..0000000000000000000000000000000000000000
GIT binary patch
#2 lore raw
In reply to Peter Robinson

Applied and pushed out.

josh

Quoted 1,112 lines · Peter Robinson

The rtl8723bs and rtl8723bu WiFi firmware are identical according to sha256sum are identical so lets remove the dupes and link them.

CC Larry Finger <[email protected]>
CC Hans de Goede <[email protected]>

---
Hey Hans and Larry,

I'd like your feedback on this, both on the WiFi firmware but also the rtlwifi/rtl8723bs_bt.bin as I suspect that's a Bluetooth firmware put in the wrong location, I don't see it referenced in any upstream drivers, I suspect it's an older/newer version of rtl8723bs_fw.bin but given it's it's smaller size it could have less features.

I think it probably just needs to be removed in a follow up patch but let me know, if you have a change to test across your hardward, if you think it's a better option to other FW we have.

Peter

 WHENCE                          |   6 +++---
 rtlwifi/rtl8723bs_ap_wowlan.bin | Bin 20886 -> 0 bytes
 rtlwifi/rtl8723bs_nic.bin       | Bin 32108 -> 0 bytes
 rtlwifi/rtl8723bs_wowlan.bin    | Bin 26398 -> 0 bytes
 4 files changed, 3 insertions(+), 3 deletions(-)
 delete mode 100644 rtlwifi/rtl8723bs_ap_wowlan.bin
 delete mode 100644 rtlwifi/rtl8723bs_nic.bin
 delete mode 100644 rtlwifi/rtl8723bs_wowlan.bin
WHENCE +3 -3
index ca669ff..623935d 100644
@@ -3181,9 +3181,9 @@ Driver: rtl8723bs - Realtek 802.11n WLAN driver for RTL8723BS
 Info: Firmware files extracted from data statements in Realtek driver
       v4.3.5.5_12290.20140916_BTCOEX20140507-4E40.
 File: rtlwifi/rtl8723bs_bt.bin
-File: rtlwifi/rtl8723bs_nic.bin
-File: rtlwifi/rtl8723bs_ap_wowlan.bin
-File: rtlwifi/rtl8723bs_wowlan.bin
+Link: rtlwifi/rtl8723bs_nic.bin -> rtl8723bu_nic.bin
+Link: rtlwifi/rtl8723bs_ap_wowlan.bin -> rtl8723bu_ap_wowlan.bin
+Link: rtlwifi/rtl8723bs_wowlan.bin -> rtl8723bu_wowlan.bin
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 
rtlwifi/rtl8723bs_ap_wowlan.bin deleted binary +0 -0
deleted file mode 100644
index 944bc16c3d55d495c1660710dac1a59a7e60868a..0000000000000000000000000000000000000000
GIT binary patch
rtlwifi/rtl8723bs_nic.bin deleted binary +0 -0
deleted file mode 100644
index 8d534053823e47ba4e49c8600463af47fbec7306..0000000000000000000000000000000000000000
GIT binary patch
rtlwifi/rtl8723bs_wowlan.bin deleted binary +0 -1
deleted file mode 100644
index 473e29c3217fb06046aa0df7a22b2e613b331235..0000000000000000000000000000000000000000
GIT binary patch
 
--

2.31.1