Skip to contentSkip to conversation

fec_imx27: driver for FEC ethernet controller on i.MX27

PATCH New Fabio Estevam 2 participants 2 messages Jun 8, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 3/7 fec_imx27: driver for FEC ethernet controller on i.MX27

Quoted 9 lines · Ilya Yanok

From: Ilya Yanok <[email protected]>
Subject: Re: [U-Boot] [PATCH 3/7] fec_imx27: driver for FEC ethernet controller on i.MX27
To: "Ben Warren" <[email protected]>
Cc: u-boot at lists.denx.de
Date: Sunday, June 7, 2009, 8:08 PM
Hi Ben,

thanks for the review.

Quoted 8 lines
Quoted 1 line · Ben Warren

Naive question: Is this FEC truly unique to the

iMX27?? If not you

Quoted 1 line

should pick a more generic name.

Uh... I think the hardware is pretty the same as that is handled by
mcffec.c driver but merging won't be very easy...

There are other i.MX processors with FEC. As Ben pointed out I also think it would be better if you could use a more generic name for the FEC driver (fec_mxc for example, if the merge with the Coldfire driver is not easy)

Regards,

Fabio Estevam

#1 lore raw

PATCH 3/7 fec_imx27: driver for FEC ethernet controller on i.MX27

Hi Fabio,

Quoted 6 lines · Fabio Estevam
Quoted 4 lines

Uh... I think the hardware is pretty the same as that is handled by
mcffec.c driver but merging won't be very easy...

There are other i.MX processors with FEC.

Uh... I didn't know that... As far as I can see Linux driver supports only i.MX27...

Regards, Ilya.