net: dsa: qca8k: fix LEDS_CLASS dependency
Subsystems (3)
PATCH 1/1 net: dsa: qca8k: fix LEDS_CLASS dependency
From: Arnd Bergmann <[email protected]>
With LEDS_CLASS=m, a built-in qca8k driver fails to link:
arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'
Change the dependency to avoid the broken configuration.
--- drivers/net/dsa/qca/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/qca/Kconfig +1 -1
@@ -19,7 +19,7 @@ config NET_DSA_QCA8K config NET_DSA_QCA8K_LEDS_SUPPORT bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support" depends on NET_DSA_QCA8K - depends on LEDS_CLASS + depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K help This enabled support for LEDs present on the Qualcomm Atheros QCA8K Ethernet switch chips.
Signature · 1 line
2.39.2
Quoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
With LEDS_CLASS=m, a built-in qca8k driver fails to link:
arm-linux-gnueabi-ld:
drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'Change the dependency to avoid the broken configuration.
Fixes 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")Signed-off-by Arnd Bergmann <[email protected]>
Thanks a lot for the fix and sorry for the mess... LED_CLASS and PHY releated were really hell also for some reason this didn't got flagged in month of this series.
Again thanks for handling this!
Signature · 1 line
Ansuel
Quoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
With LEDS_CLASS=m, a built-in qca8k driver fails to link:
arm-linux-gnueabi-ld:
drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'Change the dependency to avoid the broken configuration.
Fixes 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")Signed-off-by Arnd Bergmann <[email protected]>
Signature · 1 line
Ansuel
Quoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
With LEDS_CLASS=m, a built-in qca8k driver fails to link:
arm-linux-gnueabi-ld:
drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'Change the dependency to avoid the broken configuration.
Fixes 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")Signed-off-by Arnd Bergmann <[email protected]>
Andrew
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 20 Apr 2023 23:36:31 +0200 you wrote:
From: Arnd Bergmann <[email protected]>
With LEDS_CLASS=m, a built-in qca8k driver fails to link:
arm-linux-gnueabi-ld:
drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'[...]
Here is the summary with links:
- net: dsa: qca8k: fix LEDS_CLASS dependency
https://git.kernel.org/netdev/net-next/c/33c1af8e2c75
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html