Skip to contentSkip to conversation

ASoC: Intel: Baytrail: Fix implicit fallthrough warning

PATCH In review Cezary Rojewski 3 participants 3 messages Aug 28, 2019 – Aug 30, 2019

Subsystems (3)
lore
Share & tools
lore

Cezary Rojewski

author maintainer
#0 lore raw

PATCH v2 1/1 ASoC: Intel: Baytrail: Fix implicit fallthrough warning

Append fallthrough statement to fix warning reported during compilation.

Fixes b80d19c166c4 ("ASoC: Intel: Restore Baytrail ADSP streams only when ADSP was in reset")

---

Changes from v1:
- made use of fallthrough statement as suggested by Pierre
- updated commit message

 sound/soc/intel/baytrail/sst-baytrail-pcm.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/baytrail/sst-baytrail-pcm.c +1 -0
index 9cbc982d46a9..54f2ee3010ee 100644
@@ -193,6 +193,7 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 		break;
 	case SNDRV_PCM_TRIGGER_SUSPEND:
 		pdata->restore_stream = false;
+		/* fallthrough */
 	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
 		sst_byt_stream_pause(byt, pcm_data->stream);
 		break;
Signature · 1 line
2.17.1
Acked-by on v2 1/1
#1 lore raw
Quoted 4 lines · Cezary Rojewski

Append fallthrough statement to fix warning reported during compilation.

Fixes b80d19c166c4 ("ASoC: Intel: Restore Baytrail ADSP streams only when ADSP was in reset")
Quoted 22 lines

---

Changes from v1:
- made use of fallthrough statement as suggested by Pierre
- updated commit message

  sound/soc/intel/baytrail/sst-baytrail-pcm.c | 1 +
  1 file changed, 1 insertion(+)
sound/soc/intel/baytrail/sst-baytrail-pcm.c +1 -0
index 9cbc982d46a9..54f2ee3010ee 100644
@@ -193,6 +193,7 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
  		break;
  	case SNDRV_PCM_TRIGGER_SUSPEND:
  		pdata->restore_stream = false;
+		/* fallthrough */
  	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
  		sst_byt_stream_pause(byt, pcm_data->stream);
  		break;
maintainer
#2 lore raw

Applied "ASoC: Intel: Baytrail: Fix implicit fallthrough warning" to the asoc tree

In reply to Cezary Rojewski

The patch

ASoC: Intel: Baytrail: Fix implicit fallthrough warning

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From cc9bbb6cde6c321706f1eff79d077b4a91cd5d12 Mon Sep 17 00:00:00 2001

From: Cezary Rojewski <[email protected]>
Date: Wed, 28 Aug 2019 11:51:02 +0200
Subject: [PATCH] ASoC: Intel: Baytrail: Fix implicit fallthrough warning

Append fallthrough statement to fix warning reported during compilation.

Fixes b80d19c166c4 ("ASoC: Intel: Restore Baytrail ADSP streams only when ADSP was in reset")
---
 sound/soc/intel/baytrail/sst-baytrail-pcm.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/baytrail/sst-baytrail-pcm.c +1 -0
index 9cbc982d46a9..54f2ee3010ee 100644
@@ -193,6 +193,7 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 		break;
 	case SNDRV_PCM_TRIGGER_SUSPEND:
 		pdata->restore_stream = false;
+		/* fallthrough */
 	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
 		sst_byt_stream_pause(byt, pcm_data->stream);
 		break;
Signature · 1 line
2.20.1