Skip to contentSkip to conversation

mm: get rid of odd jump labels in find_mergeable_anon_vma()

PATCH linmiaohe 1 participant 1 message Nov 18, 2019 Memory management

lore
Share & tools
lore

linmiaohe

author
#0 lore raw
Quoted 19 lines · David Hildenbrand
Quoted 4 lines · linmiaohe

From: Miaohe Lin <[email protected]>

The jump labels try_prev and none are not really needed in find_mergeable_anon_vma(), eliminate them to improve readability.

I think you can get rid of near completely as well

	if (vma->vm_next) {
		anon_vma = reusable_anon_vma(near, vma, vma->vm_next);
		if (anon_vma)
			return anon_vma;
	}

...

Apart from that looks good to me.

Quoted 1 line
Quoted 7 lines

Review

Quoted 7 lines
(quoted diff) +1 -5
-	anon_vma = reusable_anon_vma(near, vma, near);
-	if (anon_vma)
-		return anon_vma;
-try_prev:
+	/* Try prev next. */
  	near = vma->vm_prev;
-	if (!near)

Thanks for your advice again. I will get rid of near completely in v4. Thanks a lot.