Skip to contentSkip to conversation

KVM: Fix some writing mistakes

PATCH linmiaohe 1 participant 1 message Dec 12, 2019 KVM

lore
Share & tools
lore

linmiaohe

author
#0 lore raw
Quoted 5 lines · Sean Christopherson
Quoted 4 lines · linmiaohe

From: Miaohe Lin <[email protected]>

Fix some writing mistakes in the comments.

Quoted 7 lines

Review

Quoted 5 lines

---

(quoted diff) +1 -1
 	 * This context will save all necessary information to walk page tables
-	 * of the an L2 guest. This context is only initialized for page table
+	 * of the L2 guest. This context is only initialized for page table

I'd whack "the" instead of "and", i.e. ...walk page tables of an L2 guest, as KVM isn't limited to just one L2 guest.

I'd change this.

Quoted 4 lines
Quoted 2 lines

* walking and not for faulting since we never handle l2 page faults
on

While you're here, want to change "l2" to "L2"?

I do nothing here. :)

Quoted 10 lines
Quoted 9 lines
(quoted diff) +0 -0
 	 * the host.
 	 */

check_user_page_hwpoison(unsigned long addr)
/*
* The fast path to get the writable pfn which will be stored in @pfn,
* true indicates success, otherwise false is returned. It's also
the
- * only part that runs if we can are in atomic context.
+ * only part that runs if we can in atomic context.

Quoted 2 lines

This should remove "can" instead of "are", i.e. ...part that runs if we are in atomic context. The comment is calling out that hva_to_pfn() will return immediately if hva_to_pfn_fast() and the kernel is atomic context.

Many thanks for your explanation, I would change this too. And many thanks for your review.