Skip to contentSkip to conversation

fuse: cleanup fuse_wait_on_page_writeback

PATCH Applied Vasily Averin 2 participants 3 messages Jul 22, 2019 – Aug 1, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fuse: cleanup fuse_wait_on_page_writeback

From: Maxim Patlasov <[email protected]> fuse_wait_on_page_writeback() always returns zero and nobody cares. Let's make it void.

---
 fs/fuse/file.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/fuse/file.c +1 -2
index 5ae2828beb00..e076c2cf65b0 100644
@@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
  * Since fuse doesn't rely on the VM writeback tracking, this has to
  * use some other means.
  */
-static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
+static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
 {
 	struct fuse_inode *fi = get_fuse_inode(inode);
 
 	wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
-	return 0;
 }
 
 /*
Signature · 1 line
2.17.1
#1 lore raw

I forget to add this patch was used in OpenVZ kernels last few years.

Quoted 29 lines · Vasily Averin

From: Maxim Patlasov <[email protected]> fuse_wait_on_page_writeback() always returns zero and nobody cares. Let's make it void.

---
 fs/fuse/file.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/fuse/file.c +1 -2
index 5ae2828beb00..e076c2cf65b0 100644
@@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
  * Since fuse doesn't rely on the VM writeback tracking, this has to
  * use some other means.
  */
-static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
+static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
 {
 	struct fuse_inode *fi = get_fuse_inode(inode);
 
 	wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
-	return 0;
 }
 
 /*