Skip to contentSkip to conversation

next-20130805 - compile errors in drivers/staging/lustre/lustre/llite/file.c

DISCUSSION Valdis Kletnieks 2 participants 2 messages Aug 5, 2013 – Aug 6, 2013

lore
Share & tools
lore
#0 lore raw

Not sure how this train wreck happened - 'git log' shows the last patch to touch include/linux/aio.h was some stuff of Kent's back in May, and 'git blame' says the 2 lines of code that died were added on 2013-05-02.

It compiled when I build next-0730.

And yet, this morning, I get this building -0805:

CC [M] drivers/staging/lustre/lustre/llite/file.o
drivers/staging/lustre/lustre/llite/file.c: In function 'll_file_read':
drivers/staging/lustre/lustre/llite/file.c:1012:7: error: 'struct kiocb' has no member named 'ki_left'

  kiocb->ki_left = count;
       ^
drivers/staging/lustre/lustre/llite/file.c: In function 'll_file_write':
drivers/staging/lustre/lustre/llite/file.c:1071:7: error: 'struct kiocb' has no member named 'ki_left'
  kiocb->ki_left = count;
       ^

make[5]: *** [drivers/staging/lustre/lustre/llite/file.o] Error 1

Any ideas? Only thing I can think of is that Kent's stuff went into some tree in May, but only surfaced in linux-next in the last little bit...

#1 lore raw
Quoted 11 lines · Valdis Kletnieks

Not sure how this train wreck happened - 'git log' shows the last patch to touch include/linux/aio.h was some stuff of Kent's back in May, and 'git blame' says the 2 lines of code that died were added on 2013-05-02.

It compiled when I build next-0730.

And yet, this morning, I get this building -0805:

CC [M] drivers/staging/lustre/lustre/llite/file.o
drivers/staging/lustre/lustre/llite/file.c: In function 'll_file_read':
drivers/staging/lustre/lustre/llite/file.c:1012:7: error: 'struct kiocb' has no member named 'ki_left'

Quoted 6 lines
  kiocb->ki_left = count;
       ^
drivers/staging/lustre/lustre/llite/file.c: In function 'll_file_write':
drivers/staging/lustre/lustre/llite/file.c:1071:7: error: 'struct kiocb' has no member named 'ki_left'
  kiocb->ki_left = count;
       ^

Lustre doesn't on depend ki_left. We can just remove it but it seems we have missed kiocb->ki_nbytes here.

I'll fix this but please confirm whom the patch should go to? Benjamin LaHaise?

Thanks,
Tao

Quoted 5 lines

make[5]: *** [drivers/staging/lustre/lustre/llite/file.o] Error 1

Any ideas? Only thing I can think of is that Kent's stuff went into some tree in May, but only surfaced in linux-next in the last little bit...