Skip to contentSkip to conversation

maintainers: update for AMD xgbe and ccp crypto

PATCH Applied [email protected] 6 participants 9 messages Apr 27, 2020 – Apr 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maintainers: update for AMD xgbe and ccp crypto

From: Amaranath Somalapuram <[email protected]>

Ownership change.

---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -2
index d31a80929..c3dcedbb3 100644
@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst
 F: doc/guides/nics/features/ena.ini
 
 AMD axgbe
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>
 F: drivers/net/axgbe/
 F: doc/guides/nics/axgbe.rst
 F: doc/guides/nics/features/axgbe.ini
@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto
 F: doc/guides/cryptodevs/features/default.ini
 
 AMD CCP Crypto
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>
 F: drivers/crypto/ccp/
 F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

[AMD Public Use]

Quoted 41 lines

-----Original Message-----
From: Somalapuram, Amaranath <[email protected]>
Sent: Monday, April 27, 2020 11:42 AM
To: [email protected]
Cc: Kumar, Ravi1 <[email protected]>
Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

From: Amaranath Somalapuram <[email protected]>

Ownership change.

---
MAINTAINERS | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +0 -0
index d31a80929..c3dcedbb3 100644
@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst

F: doc/guides/nics/features/ena.ini

AMD axgbe

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/net/axgbe/
F: doc/guides/nics/axgbe.rst
F: doc/guides/nics/features/axgbe.ini

MAINTAINERS +0 -0
@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto

F: doc/guides/cryptodevs/features/default.ini

AMD CCP Crypto

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/crypto/ccp/
F: doc/guides/cryptodevs/ccp.rst
F: doc/guides/cryptodevs/features/ccp.ini

Signature · 1 line
2.17.1
Acked-by
#2 lore raw
Quoted 9 lines · On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:

[AMD Public Use]

Quoted 6 lines

-----Original Message-----
From: Somalapuram, Amaranath <[email protected]>
Sent: Monday, April 27, 2020 11:42 AM
To: [email protected]
Cc: Kumar, Ravi1 <[email protected]>
Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

I guess net driver is called 'axgbe', good to fix while merging.

Quoted 17 lines
Quoted 17 lines

From: Amaranath Somalapuram <[email protected]>

Ownership change.

---
MAINTAINERS | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +0 -0
index d31a80929..c3dcedbb3 100644
@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst

F: doc/guides/nics/features/ena.ini

Quoted 8 lines
Quoted 8 lines

AMD axgbe

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/net/axgbe/
F: doc/guides/nics/axgbe.rst
F: doc/guides/nics/features/axgbe.ini

MAINTAINERS +0 -0
@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto

F: doc/guides/cryptodevs/features/default.ini

Thanks Ravi, Welcome Somalapuram.

Quoted 10 lines
Quoted 10 lines

AMD CCP Crypto

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/crypto/ccp/
F: doc/guides/cryptodevs/ccp.rst
F: doc/guides/cryptodevs/features/ccp.ini

Signature · 1 line
2.17.1
Acked-by Ferruh Yigit
#3 lore raw

Hi Ferruh,

Do you want me to resubmit.

I see this below errors email:

From: [email protected]

Test-Label: travis-robot
Test-Status:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F69359&amp;data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&amp;sdata=WcqAv8%2BRhMq4z0YRZ9S09NuV8x7kjgc2TtX3jmvJlzA%3D&amp;reserved=0

_Travis build: errored_
Build URL: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.com%2Fovsrobot%2Fdpdk%2Fbuilds%2F162163735&amp;data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&amp;sdata=plABOXG44ijGqIo5CHCHWerbirVOlf5hujOFiWkysb4%3D&amp;reserved=0

Regards,
S.Amarnath

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Monday, April 27, 2020 4:29 PM
To: Kumar, Ravi1 <[email protected]>; Somalapuram, Amaranath <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

[CAUTION: External Email]

Quoted 9 lines · On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:

[AMD Public Use]

Quoted 6 lines

-----Original Message-----
From: Somalapuram, Amaranath <[email protected]>
Sent: Monday, April 27, 2020 11:42 AM
To: [email protected]
Cc: Kumar, Ravi1 <[email protected]>
Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

I guess net driver is called 'axgbe', good to fix while merging.

Quoted 17 lines
Quoted 17 lines

From: Amaranath Somalapuram <[email protected]>

Ownership change.

---
MAINTAINERS | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +0 -0
index d31a80929..c3dcedbb3 100644
@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst

F: doc/guides/nics/features/ena.ini

Quoted 8 lines
Quoted 8 lines

AMD axgbe

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/net/axgbe/
F: doc/guides/nics/axgbe.rst
F: doc/guides/nics/features/axgbe.ini

MAINTAINERS +0 -0
@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto

F: doc/guides/cryptodevs/features/default.ini

Thanks Ravi, Welcome Somalapuram.

Quoted 10 lines
Quoted 10 lines

AMD CCP Crypto

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/crypto/ccp/
F: doc/guides/cryptodevs/ccp.rst
F: doc/guides/cryptodevs/features/ccp.ini
--
2.17.1

#4 lore raw
Quoted 3 lines · Amaranath

Hi Ferruh,

Do you want me to resubmit.

Hi Amaranath,

No need to send a new version.

Quoted 11 lines

I see this below errors email:

From: [email protected]

Test-Label: travis-robot
Test-Status:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F69359&amp;data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&amp;sdata=WcqAv8%2BRhMq4z0YRZ9S09NuV8x7kjgc2TtX3jmvJlzA%3D&amp;reserved=0

_Travis build: errored_
Build URL: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.com%2Fovsrobot%2Fdpdk%2Fbuilds%2F162163735&amp;data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&amp;sdata=plABOXG44ijGqIo5CHCHWerbirVOlf5hujOFiWkysb4%3D&amp;reserved=0

The travis error seems unrelated [1], cc'ed David and Aaron for it.

[1] Two issues reported
a) ninja: build stopped: Error writing to build log: Disk quota exceeded.
b) No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Also community lab tests seems failing because of the mellanox performance report, but this patch is not something that can affect the performance. Cc'ed Raslan & Ali and lab for it.
https://lab.dpdk.org/results/dashboard/patchsets/10717/

Quoted 66 lines

Regards,
S.Amarnath

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Monday, April 27, 2020 4:29 PM
To: Kumar, Ravi1 <[email protected]>; Somalapuram, Amaranath <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

[CAUTION: External Email]

Quoted 9 lines · On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:

[AMD Public Use]

Quoted 6 lines

-----Original Message-----
From: Somalapuram, Amaranath <[email protected]>
Sent: Monday, April 27, 2020 11:42 AM
To: [email protected]
Cc: Kumar, Ravi1 <[email protected]>
Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

I guess net driver is called 'axgbe', good to fix while merging.

Quoted 17 lines
Quoted 17 lines

From: Amaranath Somalapuram <[email protected]>

Ownership change.

---
MAINTAINERS | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +0 -0
index d31a80929..c3dcedbb3 100644
@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst

F: doc/guides/nics/features/ena.ini

Quoted 8 lines
Quoted 8 lines

AMD axgbe

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/net/axgbe/
F: doc/guides/nics/axgbe.rst
F: doc/guides/nics/features/axgbe.ini

MAINTAINERS +0 -0
@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto

F: doc/guides/cryptodevs/features/default.ini

Thanks Ravi, Welcome Somalapuram.

Quoted 10 lines
Quoted 10 lines

AMD CCP Crypto

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/crypto/ccp/
F: doc/guides/cryptodevs/ccp.rst
F: doc/guides/cryptodevs/features/ccp.ini
--
2.17.1

#5 lore raw
Quoted 18 lines · Ferruh Yigit
Quoted 3 lines · Amaranath

Hi Ferruh,

Do you want me to resubmit.

Hi Amaranath,

No need to send a new version.

Quoted 9 lines

I see this below errors email:

From: [email protected]

Test-Label: travis-robot
Test-Status:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F69359&amp;data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&amp;sdata=WcqAv8%2BRhMq4z0YRZ9S09NuV8x7kjgc2TtX3jmvJlzA%3D&amp;reserved=0

Quoted 5 lines
Quoted 3 lines

_Travis build: errored_
Build URL:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.com%2Fovsrobot%2Fdpdk%2Fbuilds%2F162163735&amp;data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7ea93e6a2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235793258422338&amp;sdata=plABOXG44ijGqIo5CHCHWerbirVOlf5hujOFiWkysb4%3D&amp;reserved=0

The travis error seems unrelated [1], cc'ed David and Aaron for it.

I agree.

Quoted 3 lines

[1] Two issues reported
a) ninja: build stopped: Error writing to build log: Disk quota exceeded.

This occurs on some of the ARM64 builds. Travis is aware of the issue, but don't seem urgently fixing it. :-/ I think we have a series outstanding that should be applied to drop those builds for now.

Quoted 2 lines

b) No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

This is a future enhancement I need to work on. When a build has jobs that are stalled / errored, we need to restart them (at least once). Or otherwise flag it. It especially happens when internal travis infrastructure fails.

Quoted 73 lines

Also community lab tests seems failing because of the mellanox performance report, but this patch is not something that can affect the performance. Cc'ed Raslan & Ali and lab for it.
https://lab.dpdk.org/results/dashboard/patchsets/10717/

Quoted 67 lines

Regards,
S.Amarnath

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Monday, April 27, 2020 4:29 PM
To: Kumar, Ravi1 <[email protected]>; Somalapuram, Amaranath <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

[CAUTION: External Email]

Quoted 9 lines · On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:

[AMD Public Use]

Quoted 6 lines

-----Original Message-----
From: Somalapuram, Amaranath <[email protected]>
Sent: Monday, April 27, 2020 11:42 AM
To: [email protected]
Cc: Kumar, Ravi1 <[email protected]>
Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

I guess net driver is called 'axgbe', good to fix while merging.

Quoted 17 lines
Quoted 17 lines

From: Amaranath Somalapuram <[email protected]>

Ownership change.

---
MAINTAINERS | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +0 -0
index d31a80929..c3dcedbb3 100644
@@ -566,7 +566,7 @@ F: doc/guides/nics/ena.rst

F: doc/guides/nics/features/ena.ini

Quoted 8 lines
Quoted 8 lines

AMD axgbe

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/net/axgbe/
F: doc/guides/nics/axgbe.rst
F: doc/guides/nics/features/axgbe.ini

MAINTAINERS +0 -0
@@ -953,7 +953,7 @@ T: git://dpdk.org/next/dpdk-next-crypto

F: doc/guides/cryptodevs/features/default.ini

Thanks Ravi, Welcome Somalapuram.

Quoted 10 lines
Quoted 10 lines

AMD CCP Crypto

MAINTAINERS +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

F: drivers/crypto/ccp/
F: doc/guides/cryptodevs/ccp.rst
F: doc/guides/cryptodevs/features/ccp.ini
--
2.17.1

#6 lore raw

27/04/2020 14:58, Aaron Conole:

Quoted 8 lines
Quoted 3 lines · Ferruh Yigit

[1] Two issues reported
a) ninja: build stopped: Error writing to build log: Disk quota exceeded.

This occurs on some of the ARM64 builds. Travis is aware of the issue, but don't seem urgently fixing it. :-/ I think we have a series outstanding that should be applied to drop those builds for now.

I saw some "Disk quota exceeded" on x86 static builds. So I changed my mind, I am not sure dropping only Arm from Travis is a solution, even temporary.

Quoted 7 lines
Quoted 2 lines

b) No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

This is a future enhancement I need to work on. When a build has jobs that are stalled / errored, we need to restart them (at least once). Or otherwise flag it. It especially happens when internal travis infrastructure fails.

Yes Travis infrastructure fails. Always.
Travis is free, but it is not a reason to provide a randomly failing tool. I suggest switching to other platforms like OBS or our community lab, preferring the most reliable one.

#7 lore raw
Quoted 6 lines · Thomas Monjalon

27/04/2020 14:58, Aaron Conole:

Quoted 5 lines
Quoted 3 lines · Ferruh Yigit

[1] Two issues reported
a) ninja: build stopped: Error writing to build log: Disk quota exceeded.

Quoted 7 lines
Quoted 3 lines

This occurs on some of the ARM64 builds. Travis is aware of the issue, but don't seem urgently fixing it. :-/ I think we have a series outstanding that should be applied to drop those builds for now.

I saw some "Disk quota exceeded" on x86 static builds. So I changed my mind, I am not sure dropping only Arm from Travis is a solution, even temporary.

Okay.

Quoted 11 lines
Quoted 8 lines
Quoted 3 lines

b) No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

This is a future enhancement I need to work on. When a build has jobs that are stalled / errored, we need to restart them (at least once). Or otherwise flag it. It especially happens when internal travis infrastructure fails.

Yes Travis infrastructure fails. Always.
Travis is free, but it is not a reason to provide a randomly failing tool.

It has been quite useful - it shows us that we still have some incomplete unit tests and also some racy unit tests. I agree, it shouldn't be failing the way it is.

Quoted 2 lines

I suggest switching to other platforms like OBS or our community lab, preferring the most reliable one.

OBS and community lab isn't as easy for individual developers to integrate with. One thing that's been useful for me is to push to my github repo and see the results of all the build configurations. It doesn't require much effort from my side to ensure that code works. I don't always do this (but that's my bad habit), but when I do it proves very useful.

Maybe the new github-ci (I think it's called 'actions') would be good to investigate. Also, Cirrus-CI lets us test on windows and freebsd. And there's no reason we can't use all of them.

#8 lore raw
In reply to Ferruh Yigit

27/04/2020 12:58, Ferruh Yigit:

Quoted 12 lines · On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:
Quoted 9 lines

[AMD Public Use]

Quoted 6 lines

-----Original Message-----
From: Somalapuram, Amaranath <[email protected]>
Sent: Monday, April 27, 2020 11:42 AM
To: [email protected]
Cc: Kumar, Ravi1 <[email protected]>
Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

I guess net driver is called 'axgbe', good to fix while merging.

Fixed

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

From: Amaranath Somalapuram <[email protected]>

Changed email address to match the one filled in MAINTAINERS file and in previous contributions.

Quoted 11 lines
Quoted 8 lines

Review

Quoted 8 lines

Ownership change.

---
AMD axgbe

(quoted diff) +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

Thanks Ravi, Welcome Somalapuram.

Quoted 5 lines
Quoted 3 lines

Review

Quoted 3 lines

AMD CCP Crypto

(quoted diff) +1 -1
-M: Ravi Kumar <[email protected]>
+M: Somalapuram Amaranath <[email protected]>

Applied