Skip to contentSkip to conversation

eal:Change log output to DEBUG instead of INFO

PATCH Applied Keith Wiles 3 participants 6 messages Sep 10, 2015 – Mar 13, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal:Change log output to DEBUG instead of INFO

When log level is set to 7 (INFO) these messages are still displayed and should be set to DEBUG.

---
 lib/librte_eal/common/eal_common_memory.c  | 2 +-
 lib/librte_eal/common/eal_common_timer.c   | 2 +-
 lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
lib/librte_eal/common/eal_common_memory.c +1 -1
index b647573..6155752 100644
@@ -139,7 +139,7 @@ rte_eal_memdevice_init(void)
 int
 rte_eal_memory_init(void)
 {
-	RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n");
+	RTE_LOG(DEBUG, EAL, "Setting up physically contiguous memory...\n");
 
 	const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
 			rte_eal_hugepage_init() :
lib/librte_eal/common/eal_common_timer.c +1 -1
index 72371b8..c4227cd 100644
@@ -81,6 +81,6 @@ set_tsc_freq(void)
 	if (!freq)
 		freq = estimate_tsc_freq();
 
-	RTE_LOG(INFO, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
+	RTE_LOG(DEBUG, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
 	eal_tsc_resolution_hz = freq;
 }
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +1 -1
index 0e6c48a..e0c13de 100644
@@ -904,7 +904,7 @@ pci_vfio_enable(void)
 
 	/* return 0 if VFIO modules not loaded */
 	if (module_vfio_type1 == 0) {
-		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
+		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
 			"skip VFIO support...\n");
 		return 0;
 	}
Signature · 1 line
2.3.0
#1 lore raw

Sergio, Anatoly, David,
It is not so obvious to decide the log level. Please comment or ack.

2015-09-10 14:40, Keith Wiles:

Quoted 49 lines

When log level is set to 7 (INFO) these messages are still displayed and should be set to DEBUG.

---
 lib/librte_eal/common/eal_common_memory.c  | 2 +-
 lib/librte_eal/common/eal_common_timer.c   | 2 +-
 lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
lib/librte_eal/common/eal_common_memory.c +1 -1
index b647573..6155752 100644
@@ -139,7 +139,7 @@ rte_eal_memdevice_init(void)
 int
 rte_eal_memory_init(void)
 {
-	RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n");
+	RTE_LOG(DEBUG, EAL, "Setting up physically contiguous memory...\n");
 
 	const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
 			rte_eal_hugepage_init() :
lib/librte_eal/common/eal_common_timer.c +1 -1
index 72371b8..c4227cd 100644
@@ -81,6 +81,6 @@ set_tsc_freq(void)
 	if (!freq)
 		freq = estimate_tsc_freq();
 
-	RTE_LOG(INFO, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
+	RTE_LOG(DEBUG, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
 	eal_tsc_resolution_hz = freq;
 }
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +1 -1
index 0e6c48a..e0c13de 100644
@@ -904,7 +904,7 @@ pci_vfio_enable(void)
 
 	/* return 0 if VFIO modules not loaded */
 	if (module_vfio_type1 == 0) {
-		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
+		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
 			"skip VFIO support...\n");
 		return 0;
 	}
#2 lore raw

Hi

Apologies for late reply, was away. Can't comment on other lines, but

Quoted 7 lines
Quoted 7 lines
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +0 -0
index 0e6c48a..e0c13de 100644
@@ -904,7 +904,7 @@ pci_vfio_enable(void)
 
Quoted 9 lines

lib/librte_eal/linuxapp/eal/eal_pci_vfio.c pci_vfio_enable(void) · line 910

Quoted 8 lines
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +1 -1
 	/* return 0 if VFIO modules not loaded */
 	if (module_vfio_type1 == 0) {
-		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
+		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
 			"skip VFIO support...\n");
 		return 0;
 	}

Should people be forced to recompile DPDK with debug logs (and get all this additional debug output) just to see why VFIO doesn't get initialized? I would argue this message is not as serious an annoyance to warrant this change, but maybe Keith has a different opinion.

Either way, I don't feel strongly for or against the change.

Thanks,
Anatoly

#3 lore raw

2016-02-18 10:18, Burakov, Anatoly:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +0 -0
@@ -904,7 +904,7 @@ pci_vfio_enable(void)
 
Quoted 10 lines
Quoted 7 lines

lib/librte_eal/linuxapp/eal/eal_pci_vfio.c pci_vfio_enable(void) · line 910

Quoted 7 lines
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +1 -1
 	/* return 0 if VFIO modules not loaded */
 	if (module_vfio_type1 == 0) {
-		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
+		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
 			"skip VFIO support...\n");
 		return 0;
 	}

Should people be forced to recompile DPDK with debug logs (and get all this additional debug output) just to see why VFIO doesn't get initialized?

No, there is a run-time option --log-level.
The compiled max level must be set to DEBUG to be able to see this message with debug --log-level.

Quoted 5 lines

I would
argue this message is not as serious an annoyance to warrant this change, but maybe Keith has a different opinion.

Either way, I don't feel strongly for or against the change.

Thanks

#4 lore raw

Hi Thomas,

Quoted 16 lines

2016-02-18 10:18, Burakov, Anatoly:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +0 -0
@@ -904,7 +904,7 @@ pci_vfio_enable(void)
 
Quoted 10 lines
Quoted 7 lines

lib/librte_eal/linuxapp/eal/eal_pci_vfio.c pci_vfio_enable(void) · line 910

Quoted 7 lines
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +1 -1
 	/* return 0 if VFIO modules not loaded */
 	if (module_vfio_type1 == 0) {
-		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
+		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
 			"skip VFIO support...\n");
 		return 0;
 	}

Should people be forced to recompile DPDK with debug logs (and get all this additional debug output) just to see why VFIO doesn't get initialized?

Quoted 3 lines

No, there is a run-time option --log-level.
The compiled max level must be set to DEBUG to be able to see this message with debug --log-level.

Apologies, I wasn't aware of this feature. No objections then.

Thanks,
Anatoly