Skip to contentSkip to conversation

Do not disable interrupts in ia64_sn_plat_specific_err_print

PATCH New Keith Owens 1 participant 1 message Nov 3, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Do not disable interrupts in ia64_sn_plat_specific_err_print

ia64_sn_plat_specific_err_print() ends up calling vfree() which requires IPI which can deadlock if interrupts are disabled. Do not disable interrupts in ia64_sn_plat_specific_err_print().

Index: linux/include/asm-ia64/sn/sn_sal.h
=================================--- linux.orig/include/asm-ia64/sn/sn_sal.h Wed Nov 3 11:02:27 2004
+++ linux/include/asm-ia64/sn/sn_sal.h Wed Nov 3 11:54:21 2004
@@ -313,7 +313,7 @@ ia64_sn_plat_specific_err_print(int (*ho
ret_stuff.v0 = 0;
ret_stuff.v1 = 0;
ret_stuff.v2 = 0;
- SAL_CALL_NOLOCK(ret_stuff, SN_SAL_PRINT_ERROR, (uint64_t)hook, (uint64_t)rec, 0, 0, 0, 0, 0);
+ SAL_CALL_REENTRANT(ret_stuff, SN_SAL_PRINT_ERROR, (uint64_t)hook, (uint64_t)rec, 0, 0, 0, 0, 0);

return ret_stuff.status;
}