Skip to contentSkip to conversation

netmon: added PCI, TAC, SNR value

PATCH In review JongSeok Won 2 participants 2 messages Jul 31, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 netmon: added PCI, TAC, SNR value

To support cell type LTE, the value of PCI, TAC, SNR is added

---
 include/netmon.h |  3 +++
 src/netmon.c     | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)
include/netmon.h +3 -0
index a99d6ca9..53f9d393 100644
@@ -72,6 +72,9 @@ enum ofono_netmon_info {
 	OFONO_NETMON_INFO_EARFCN, /* int */
 	OFONO_NETMON_INFO_EBAND, /* int */
 	OFONO_NETMON_INFO_CQI, /* int */
+	OFONO_NETMON_INFO_PCI, /* int */
+	OFONO_NETMON_INFO_TAC, /* int */
+	OFONO_NETMON_INFO_SNR, /* int */
 	OFONO_NETMON_INFO_INVALID,
 };
 
src/netmon.c +21 -0
index 9eacb3ca..10e3ee2b 100644
@@ -213,6 +213,27 @@ static void netmon_cell_info_dict_append(DBusMessageIter *dict,
 					intval, uint8_t, DBUS_TYPE_BYTE);
 			break;
 
+		case OFONO_NETMON_INFO_PCI:
+			intval = va_arg(*arglist, int);
+
+			CELL_INFO_DICT_APPEND(dict, "PhysicalCellId",
+					intval, uint16_t, DBUS_TYPE_UINT16);
+			break;
+
+		case OFONO_NETMON_INFO_TAC:
+			intval = va_arg(*arglist, int);
+
+			CELL_INFO_DICT_APPEND(dict, "TrackingAreaCode",
+					intval, uint16_t, DBUS_TYPE_UINT16);
+			break;
+
+		case OFONO_NETMON_INFO_SNR:
+			intval = va_arg(*arglist, int);
+
+			ofono_dbus_dict_append(dict, "SingalToNoiseRatio",
+					DBUS_TYPE_INT32, &intval);
+			break;
+
 		case OFONO_NETMON_INFO_INVALID:
 			break;
 		}
Signature · 1 line
2.17.1
#1 lore raw

Hi JongSeok,

Quoted 6 lines · JongSeok Won

To support cell type LTE, the value of PCI, TAC, SNR is added

---
  include/netmon.h |  3 +++
  src/netmon.c     | 21 +++++++++++++++++++++
  2 files changed, 24 insertions(+)

All three applied, thanks.

Regards,
-Denis