Skip to contentSkip to conversation

pwm: meson: Fix confusing indentation

PATCH Applied Krzysztof Kozlowski 4 participants 4 messages Mar 14, 2020 – Apr 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pwm: meson: Fix confusing indentation

Fix indentation of return block. Smatch warning:
drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting

---
 drivers/pwm/pwm-meson.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/pwm-meson.c +1 -1
index 6245bbdb6e6c..8cf9129caa39 100644
@@ -136,7 +136,7 @@ static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
 			dev_err(dev, "failed to set parent %s for %s: %d\n",
 				__clk_get_name(channel->clk_parent),
 				__clk_get_name(channel->clk), err);
-				return err;
+			return err;
 		}
 	}
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Krzysztof Kozlowski

Fix indentation of return block. Smatch warning:
drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting

This exists since commit 211ed630753d ("pwm: Add support for Meson PWM Controller") in 2016. Added Neil to Cc:.

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
#2 lore raw
Quoted 7 lines · Uwe Kleine-König
Quoted 5 lines · Krzysztof Kozlowski

Fix indentation of return block. Smatch warning:
drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting

Quoted 8 lines

This exists since commit 211ed630753d ("pwm: Add support for Meson PWM Controller") in 2016. Added Neil to Cc:.

Thanks
Uwe

Missing

Fixes 211ed630753d ("pwm: Add support for Meson PWM Controller")

With that

Neil

#3 lore raw
In reply to Krzysztof Kozlowski
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).

Hello:

This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).

Quoted 8 lines · On Sat, 14 Mar 2020 12:35:24 +0100 you wrote:

Fix indentation of return block. Smatch warning:
drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting

---
 drivers/pwm/pwm-meson.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is a summary with links:
- pwm: meson: Fix confusing indentation

    https://git.kernel.org/khilman/linux-amlogic/c/b33d232e6112aa175f08e8105de0a4da14f5dcbb

You are awesome, thank you!

Signature · 7 lines
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic