Skip to contentSkip to conversation

Bluetooth: mgmt: Fix wrong param be used

PATCH In review [email protected] 3 participants 3 messages Jan 5, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: mgmt: Fix wrong param be used

From: Clancy Shang <[email protected]>

bluez lib could not receive MGMT_EV_DEVICE_FLAGS_CHANGED notifications after sending MGMT_OP_SET_DEVICE_FLAGS

---
 net/bluetooth/mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/mgmt.c +1 -1
index 9dd815b6603f..c74abdf3618f 100644
@@ -5177,7 +5177,7 @@ static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
 
 done:
 	if (status == MGMT_STATUS_SUCCESS)
-		device_flags_changed(sk, hdev, &cp->addr.bdaddr, cp->addr.type,
+		device_flags_changed(NULL, hdev, &cp->addr.bdaddr, cp->addr.type,
 				     supported_flags, current_flags);
 
 	return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_DEVICE_FLAGS, status,
Signature · 1 line
2.25.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=814542

---Test result---

Test Summary:

CheckPatch                    PASS      0.57 seconds
GitLint                       PASS      0.29 seconds
SubjectPrefix                 PASS      0.11 seconds
BuildKernel                   PASS      27.52 seconds
CheckAllWarning               PASS      31.19 seconds
CheckSparse                   PASS      36.28 seconds
CheckSmatch                   PASS      100.84 seconds
BuildKernel32                 PASS      27.35 seconds
TestRunnerSetup               PASS      440.50 seconds
TestRunner_l2cap-tester       PASS      24.18 seconds
TestRunner_iso-tester         PASS      45.43 seconds
TestRunner_bnep-tester        PASS      6.88 seconds
TestRunner_mgmt-tester        PASS      162.31 seconds
TestRunner_rfcomm-tester      PASS      10.74 seconds
TestRunner_sco-tester         PASS      14.33 seconds
TestRunner_ioctl-tester       PASS      12.19 seconds
TestRunner_mesh-tester        PASS      9.03 seconds
TestRunner_smp-tester         PASS      9.87 seconds
TestRunner_userchan-tester    PASS      7.21 seconds
IncrementalBuild              PASS      26.10 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to [email protected]

Dear Clancy,

Thank you for your patch.

Am 05.01.24 um 04:11 schrieb [email protected]:

Quoted 4 lines

From: Clancy Shang <[email protected]>

bluez lib could not receive MGMT_EV_DEVICE_FLAGS_CHANGED notifications after sending MGMT_OP_SET_DEVICE_FLAGS

Please add a dot/period at the end of sentences.

Please extend the commit message to describe your fix, and why it fixes the problem.

Quoted 10 lines
---
  net/bluetooth/mgmt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/mgmt.c +0 -0
index 9dd815b6603f..c74abdf3618f 100644

net/bluetooth/mgmt.c static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data, · line 5183

Quoted 8 lines
net/bluetooth/mgmt.c +1 -1
@@ -5177,7 +5177,7 @@ static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
 
  done:
  	if (status == MGMT_STATUS_SUCCESS)
-		device_flags_changed(sk, hdev, &cp->addr.bdaddr, cp->addr.type,
+		device_flags_changed(NULL, hdev, &cp->addr.bdaddr, cp->addr.type,
  				     supported_flags, current_flags);
 
  	return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_DEVICE_FLAGS, status,

Kind regards,

Paul