Skip to contentSkip to conversation

eeprom: at25: drop unneeded MODULE_ALIAS

PATCH In review Krzysztof Kozlowski 3 participants 10 messages Apr 14, 2024 – May 10, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 eeprom: at25: drop unneeded MODULE_ALIAS

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

---
 drivers/misc/eeprom/at25.c | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/eeprom/at25.c +0 -1
index 65d49a6de1a7..595ceb9a7126 100644
@@ -529,4 +529,3 @@ module_spi_driver(at25_driver);
 MODULE_DESCRIPTION("Driver for most SPI EEPROMs");
 MODULE_AUTHOR("David Brownell");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("spi:at25");
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/1 mtd: mchp23k256: drop unneeded MODULE_ALIAS

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

---
 drivers/mtd/devices/mchp23k256.c | 1 -
 1 file changed, 1 deletion(-)
drivers/mtd/devices/mchp23k256.c +0 -1
index d533475fda15..cef5f9677d39 100644
@@ -257,4 +257,3 @@ module_spi_driver(mchp23k256_driver);
 MODULE_DESCRIPTION("MTD SPI driver for MCHP23K256 RAM chips");
 MODULE_AUTHOR("Andrew Lunn <[email protected]>");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("spi:mchp23k256");
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/2 eeprom: 93xx46: drop unneeded MODULE_ALIAS

In reply to Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

---
 drivers/misc/eeprom/eeprom_93xx46.c | 2 --
 1 file changed, 2 deletions(-)
drivers/misc/eeprom/eeprom_93xx46.c +0 -2
index e78a76d74ff4..45c8ae0db8f9 100644
@@ -578,5 +578,3 @@ MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("Driver for 93xx46 EEPROMs");
 MODULE_AUTHOR("Anatolij Gustschin <[email protected]>");
 MODULE_ALIAS("spi:93xx46");
-MODULE_ALIAS("spi:eeprom-93xx46");
-MODULE_ALIAS("spi:93lc46b");
Signature · 1 line
2.34.1
#3 lore raw

Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

Quoted 3 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

...

Quoted 1 line

MODULE_ALIAS("spi:93xx46");

I was stumbled over this (leftover?).
Commit message doesn't elaborate this bit.
Any comments?

Quoted 2 lines
drivers/misc/eeprom/eeprom_93xx46.c +0 -2
-MODULE_ALIAS("spi:eeprom-93xx46");
-MODULE_ALIAS("spi:93lc46b");
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

Quoted 5 lines · Andy Shevchenko
Quoted 3 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

Quoted 7 lines

...

Quoted 1 line

MODULE_ALIAS("spi:93xx46");

I was stumbled over this (leftover?).
Commit message doesn't elaborate this bit.
Any comments?

It is not present in ID table and commit msg removes only duplicated aliases. That alias has meaning - someone might be actually relying on it.

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

...

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

MODULE_ALIAS("spi:93xx46");

I was stumbled over this (leftover?).
Commit message doesn't elaborate this bit.
Any comments?

It is not present in ID table and commit msg removes only duplicated aliases. That alias has meaning - someone might be actually relying on it.

It seems no users for it. The only user of platform data of this EEPROM uses board files which AFAIU bypasses modalias matching.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw

Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

Quoted 15 lines · Andy Shevchenko
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

...

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

MODULE_ALIAS("spi:93xx46");

I was stumbled over this (leftover?).
Commit message doesn't elaborate this bit.
Any comments?

Quoted 5 lines
Quoted 2 lines

It is not present in ID table and commit msg removes only duplicated aliases. That alias has meaning - someone might be actually relying on it.

It seems no users for it. The only user of platform data of this EEPROM uses board files which AFAIU bypasses modalias matching.

I don't think that's correct. The modalias of SPI board is there on purpose. Why do you think it is not used? IOW, what changed in kernel since the issue was encountered and fixed by adding that alias (see explanation and users in kernel of modalias from that commit)?

Best regards,
Krzysztof

maintainer
#7 lore raw

Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Andy Shevchenko
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

...

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

MODULE_ALIAS("spi:93xx46");

I was stumbled over this (leftover?).
Commit message doesn't elaborate this bit.
Any comments?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

It is not present in ID table and commit msg removes only duplicated aliases. That alias has meaning - someone might be actually relying on it.

It seems no users for it. The only user of platform data of this EEPROM uses board files which AFAIU bypasses modalias matching.

I don't think that's correct. The modalias of SPI board is there on purpose.

Right, but I think a better workaround would have been to change the board_info to pick a modalias that is part of the ID table:

drivers/misc/eeprom/digsy_mtc_eeprom.c +1 -1
@@ -76,7 +76,7 @@ static struct gpiod_lookup_table eeprom_spi_gpiod_table = {
 
 static struct spi_board_info digsy_mtc_eeprom_info[] __initdata = {
        {
-               .modalias               = "93xx46",
+               .modalias               = "eeprom-93xx46",
                .max_speed_hz           = 1000000,
                .bus_num                = EE_SPI_BUS_NUM,
                .chip_select            = 0,

Arnd

#8 lore raw

Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

Quoted 33 lines · Arnd Bergmann
Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Andy Shevchenko
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

...

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

MODULE_ALIAS("spi:93xx46");

I was stumbled over this (leftover?).
Commit message doesn't elaborate this bit.
Any comments?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

It is not present in ID table and commit msg removes only duplicated aliases. That alias has meaning - someone might be actually relying on it.

It seems no users for it. The only user of platform data of this EEPROM uses board files which AFAIU bypasses modalias matching.

I don't think that's correct. The modalias of SPI board is there on purpose.

Right, but I think a better workaround would have been to change the board_info to pick a modalias that is part of the ID table:

drivers/misc/eeprom/digsy_mtc_eeprom.c static struct gpiod_lookup_table eeprom_spi_gpiod_table = { · line 82

Quoted 8 lines
drivers/misc/eeprom/digsy_mtc_eeprom.c +1 -1
@@ -76,7 +76,7 @@ static struct gpiod_lookup_table eeprom_spi_gpiod_table = {
 
 static struct spi_board_info digsy_mtc_eeprom_info[] __initdata = {
        {
-               .modalias               = "93xx46",
+               .modalias               = "eeprom-93xx46",
                .max_speed_hz           = 1000000,
                .bus_num                = EE_SPI_BUS_NUM,
                .chip_select            = 0,

That's kind of independent change. This commit *only* removed duplicated aliases, thus should have not functional impact except dropping redundant code. What you propose is to change spi board matching, which is reasonable, just a different thing.

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

Quoted 34 lines · Krzysztof Kozlowski
Quoted 33 lines · Arnd Bergmann
Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Andy Shevchenko
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for SPI driver. Having another MODULE_ALIAS causes the alias to be duplicated.

...

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

MODULE_ALIAS("spi:93xx46");

I was stumbled over this (leftover?).
Commit message doesn't elaborate this bit.
Any comments?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

It is not present in ID table and commit msg removes only duplicated aliases. That alias has meaning - someone might be actually relying on it.

It seems no users for it. The only user of platform data of this EEPROM uses board files which AFAIU bypasses modalias matching.

I don't think that's correct. The modalias of SPI board is there on purpose.

Right, but I think a better workaround would have been to change the board_info to pick a modalias that is part of the ID table:

drivers/misc/eeprom/digsy_mtc_eeprom.c +0 -0
@@ -76,7 +76,7 @@ static struct gpiod_lookup_table eeprom_spi_gpiod_table = {
 
Quoted 10 lines

drivers/misc/eeprom/digsy_mtc_eeprom.c static struct gpiod_lookup_table eeprom_spi_gpiod_table = { · line 82

Quoted 8 lines
drivers/misc/eeprom/digsy_mtc_eeprom.c +1 -1
 static struct spi_board_info digsy_mtc_eeprom_info[] __initdata = {
        {
-               .modalias               = "93xx46",
+               .modalias               = "eeprom-93xx46",
                .max_speed_hz           = 1000000,
                .bus_num                = EE_SPI_BUS_NUM,
                .chip_select            = 0,

That's kind of independent change.

I have done similar change in my patch series, after which I am 100% sure the modalias can be removed. Can you look at that?

https://lore.kernel.org/r/[email protected]

Quoted 4 lines

This commit *only* removed duplicated
aliases, thus should have not functional impact except dropping redundant code. What you propose is to change spi board matching, which is reasonable, just a different thing.

Signature · 2 lines
With Best Regards,
Andy Shevchenko