Skip to contentSkip to conversation

Github pull requests

DISCUSSION Paul Eggleton 4 participants 6 messages Nov 30, 2018 – Dec 1, 2018

lore
Share & tools
lore
#0 lore raw

Hi folks

Someone pointed out that there are quite a few pull requests on github under
https://github.com/openembedded/. I know we don't accept these, but it seems to me we ought to clean up the ones that are there in order to avoid people thinking that they might be (and probably comment on the ones where we haven't done so or the submitter hasn't sent them to the mailing list already). I'll volunteer to clean them up, but I don't currently have access - can someone grant that to me?

Thanks,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#1 lore raw
Quoted 10 lines · Paul Eggleton

Hi folks

Someone pointed out that there are quite a few pull requests on github under
https://github.com/openembedded/. I know we don't accept these, but it seems to me we ought to clean up the ones that are there in order to avoid people thinking that they might be (and probably comment on the ones where we haven't done so or the submitter hasn't sent them to the mailing list already). I'll volunteer to clean them up, but I don't currently have access - can someone grant that to me?

I think that will be good. I have taken care of meta-oe ones but I can not close them

Quoted 14 lines

Thanks,
Paul

--
Paul Eggleton
Intel Open Source Technology Centre

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 12 lines · Khem Raj
Quoted 10 lines · Paul Eggleton

Hi folks

Someone pointed out that there are quite a few pull requests on github under
https://github.com/openembedded/. I know we don't accept these, but it seems to me we ought to clean up the ones that are there in order to avoid people thinking that they might be (and probably comment on the ones where we haven't done so or the submitter hasn't sent them to the mailing list already). I'll volunteer to clean them up, but I don't currently have access - can someone grant that to me?

Quoted 2 lines

I think that will be good. I have taken care of meta-oe ones but I can not close them

Do we need to adjust github privileges so you can close them? Let's chat next week and see what we can do to make this easier.

Philip

Quoted 15 lines
Quoted 15 lines

Thanks,
Paul

--
Paul Eggleton
Intel Open Source Technology Centre

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 13 lines · Philip Balister
Quoted 12 lines · Khem Raj
Quoted 10 lines · Paul Eggleton

Hi folks

Someone pointed out that there are quite a few pull requests on github under
https://github.com/openembedded/. I know we don't accept these, but it seems to me we ought to clean up the ones that are there in order to avoid people thinking that they might be (and probably comment on the ones where we haven't done so or the submitter hasn't sent them to the mailing list already). I'll volunteer to clean them up, but I don't currently have access - can someone grant that to me?

Quoted 5 lines
Quoted 2 lines

I think that will be good. I have taken care of meta-oe ones but I can not close them

Do we need to adjust github privileges so you can close them? Let's chat next week and see what we can do to make this easier.

Does this help?

http://nopullrequests.appspot.com/

Philip

Quoted 19 lines

Philip

Quoted 15 lines
Quoted 15 lines

Thanks,
Paul

--
Paul Eggleton
Intel Open Source Technology Centre

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 23 lines · Philip Balister
Quoted 2 lines · Philip Balister
Quoted 1 line · Khem Raj

On Thu, Nov 29, 2018 at 5:26 PM Paul Eggleton <[email protected]>

Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines

Hi folks

Someone pointed out that there are quite a few pull requests on github

under

Quoted 1 line
Quoted 1 line
Quoted 1 line

https://github.com/openembedded/. I know we don't accept these, but

it seems

Quoted 1 line
Quoted 1 line
Quoted 1 line

to me we ought to clean up the ones that are there in order to avoid

people

Quoted 1 line
Quoted 1 line
Quoted 1 line

thinking that they might be (and probably comment on the ones where we

haven't

Quoted 1 line
Quoted 1 line
Quoted 1 line

done so or the submitter hasn't sent them to the mailing list

already). I'll

Quoted 1 line
Quoted 1 line
Quoted 1 line

volunteer to clean them up, but I don't currently have access - can

someone

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

grant that to me?

I think that will be good. I have taken care of meta-oe ones but I can

not

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

close them

Do we need to adjust github privileges so you can close them? Let's chat next week and see what we can do to make this easier.

Does this help?

http://nopullrequests.appspot.com

Only if we can add clear instructions there on how to send patches

Many oe distros use gh mirrors for those repos
And users might think it’s following gh workflow disabling pulls might be confusing

Quoted 1 line

<http://nopullrequests.appspot.com/>

<http://nopullrequests.appspot.com/>

Quoted 26 lines

Philip

Quoted 19 lines

Philip

Quoted 15 lines
Quoted 15 lines

Thanks,
Paul

--
Paul Eggleton
Intel Open Source Technology Centre

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw
In reply to Khem Raj
Quoted 10 lines · Khem Raj
Quoted 9 lines · Paul Eggleton

Hi folks

Someone pointed out that there are quite a few pull requests on github under
https://github.com/openembedded/. I know we don't accept these, but it seems to me we ought to clean up the ones that are there in order to avoid people thinking that they might be (and probably comment on the ones where we haven't done so or the submitter hasn't sent them to the mailing list already). I'll volunteer to clean them up, but I don't currently have access - can someone grant that to me?

Quoted 2 lines

I think that will be good. I have taken care of meta-oe ones but I can not close them

Does that include the Stable branch requests?
-armin

Quoted 14 lines
Quoted 14 lines

Thanks,
Paul

--
Paul Eggleton
Intel Open Source Technology Centre

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel