Skip to contentSkip to conversation

roms: Add a 'make help' target alias

PATCH In review Philippe Mathieu-Daudé 4 participants 4 messages Sep 20, 2019 – Sep 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 roms: Add a 'make help' target alias

Various C projects provide a 'make help' target. Our root directory does so. The roms/ directory lacks a such rule, but already displays a help output when the default target is called.
Add a 'help' target aliased to the default one, to avoid:

  $ make -C roms help
  make: *** No rule to make target 'help'.  Stop.
---
 roms/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
roms/Makefile +1 -1
index 6cf07d3b44..3ffd13cc7e 100644
@@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
 #
 EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
 
-default:
+default help:
 	@echo "nothing is build by default"
 	@echo "available build targets:"
 	@echo "  bios               -- update bios.bin (seabios)"
Signature · 1 line
2.20.1
#1 lore raw
Quoted 19 lines · Philippe Mathieu-Daudé

Various C projects provide a 'make help' target. Our root directory does so. The roms/ directory lacks a such rule, but already displays a help output when the default target is called.
Add a 'help' target aliased to the default one, to avoid:

  $ make -C roms help
  make: *** No rule to make target 'help'.  Stop.
---
 roms/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
roms/Makefile +0 -0
index 6cf07d3b44..3ffd13cc7e 100644

roms/Makefile SEABIOS_EXTRAVERSION="-prebuilt.qemu.org" · line 55

Quoted 6 lines
roms/Makefile +1 -1
@@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
 #
 EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
 
-default:
+default help:
        @echo "nothing is build by default"

If you felt like fixing a typo, there's one here: should be "is built"...

Quoted 4 lines
roms/Makefile +0 -1
        @echo "available build targets:"
        @echo "  bios               -- update bios.bin (seabios)"
--

2.20.1

thanks
-- PMM

Reviewed-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 19 lines · Philippe Mathieu-Daudé

Various C projects provide a 'make help' target. Our root directory does so. The roms/ directory lacks a such rule, but already displays a help output when the default target is called.
Add a 'help' target aliased to the default one, to avoid:

  $ make -C roms help
  make: *** No rule to make target 'help'.  Stop.
---
 roms/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
roms/Makefile +0 -0
index 6cf07d3b44..3ffd13cc7e 100644

roms/Makefile SEABIOS_EXTRAVERSION="-prebuilt.qemu.org" · line 57

Quoted 8 lines
roms/Makefile +1 -1
@@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
 #
 EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
 
-default:
+default help:
 	@echo "nothing is build by default"
 	@echo "available build targets:"
 	@echo "  bios               -- update bios.bin (seabios)"

The typo can be fixed with a trivial patch or squashed into this fix, the purity of such things doesn't matter to me.

--js

Reviewed-by on v1 1/1
#3 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 19 lines · Philippe Mathieu-Daudé

Various C projects provide a 'make help' target. Our root directory does so. The roms/ directory lacks a such rule, but already displays a help output when the default target is called.
Add a 'help' target aliased to the default one, to avoid:

  $ make -C roms help
  make: *** No rule to make target 'help'.  Stop.
---
 roms/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
roms/Makefile +0 -0
index 6cf07d3b44..3ffd13cc7e 100644

roms/Makefile SEABIOS_EXTRAVERSION="-prebuilt.qemu.org" · line 57

Quoted 8 lines
roms/Makefile +1 -1
@@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
 #
 EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
 
-default:
+default help:
 	@echo "nothing is build by default"
 	@echo "available build targets:"
 	@echo "  bios               -- update bios.bin (seabios)"

How about we just print: "help yourself"?

Just kidding. :P

Thanks!
Laszlo