Skip to contentSkip to conversation

dmadev: clarify visibility of completed jobs

PATCH Applied Bruce Richardson 3 participants 3 messages May 12, 2022 – Jun 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmadev: clarify visibility of completed jobs

Clarify that once an operation has completed, the output of that operation is visible to all cores.

---

This follows on from the discussion on-list[1]. Owing to the lack of replies stating that hardware doesn't guarantee this property, I'm taking the optimistic view and assuming that this is generally supported by the DMA drivers. If not, I can do a different patch for some capability flags to indicate the presence or not of this visibility guarantee.

[1] https://lore.kernel.org/all/[email protected]/

---
 lib/dmadev/rte_dmadev.h | 4 ++++
 1 file changed, 4 insertions(+)
lib/dmadev/rte_dmadev.h +4 -0
index ad9e7a0975..a7081e633c 100644
@@ -1001,6 +1001,8 @@ rte_dma_submit(int16_t dev_id, uint16_t vchan)
  * @b EXPERIMENTAL: this API may change without prior notice.
  *
  * Return the number of operations that have been successfully completed.
+ * Once an operation has been reported as completed, the results of that
+ * operation will be visible to all cores on the system.
  *
  * @param dev_id
  *   The identifier of the device.
@@ -1058,6 +1060,8 @@ rte_dma_completed(int16_t dev_id, uint16_t vchan, const uint16_t nb_cpls,
  *
  * Return the number of operations that have been completed, and the operations
  * result may succeed or fail.
+ * Once an operation has been reported as completed successfully, the results of that
+ * operation will be visible to all cores on the system.
  *
  * @param dev_id
  *   The identifier of the device.
Signature · 1 line
2.34.1
#2 lore raw

12/05/2022 18:18, Morten Brørup:

Quoted 6 lines
Quoted 6 lines

From: Bruce Richardson [mailto:[email protected]]
Sent: Thursday, 12 May 2022 17.11

Clarify that once an operation has completed, the output of that operation is visible to all cores.

Quoted 6 lines
Quoted 2 lines

---

Since I can't confirm that all hardware guarantees this property, a Review sign-off would be inappropriate.

Applied, thanks.