bpf: add a verbose message if map limit is reached
PATCH v2 1/1 bpf: add a verbose message if map limit is reached
When more than 64 maps are used by a program and its subprograms the verifier returns -E2BIG. Add a verbose message which highlights the source of the error and also print the actual limit.
v1 -> v2:
* make the message more clear (Alexey)
--- kernel/bpf/verifier.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/bpf/verifier.c +2 -0
@@ -18348,6 +18348,8 @@ static int resolve_pseudo_ldimm64(struct bpf_verifier_env *env) }if (env->used_map_cnt >=MAX_USED_MAPS ) { +verbose (env,"The total number of maps per program is reached the limit of %u\n" , +MAX_USED_MAPS );fdput (f);return -E2BIG ; }
Signature · 1 line
2.34.1
Quoted 30 lines · Anton Protopopov
When more than 64 maps are used by a program and its subprograms the verifier returns
-E2BIG. Add a verbose message which highlights the source of the error and also print the actual limit.v1 -> v2:
* make the message more clear (Alexey)Signed-off-by Anton Protopopov <[email protected]>Acked-by Yonghong Song <[email protected]>--- kernel/bpf/verifier.c | 2 ++ 1 file changed, 2 insertions(+)kernel/bpf/verifier.c +2
-0@@ -18348,6 +18348,8 @@ static int resolve_pseudo_ldimm64(struct bpf_verifier_env *env) }if (env->used_map_cnt >=MAX_USED_MAPS ) { +verbose (env,"The total number of maps per program is reached the limit of %u\n" , +MAX_USED_MAPS );fdput (f);return -E2BIG ; }Signature · 1 line
2.34.1
LGTM thanks.
Quoted 34 lines · John Fastabend
Quoted 30 lines · Anton Protopopov
When more than 64 maps are used by a program and its subprograms the verifier returns
-E2BIG. Add a verbose message which highlights the source of the error and also print the actual limit.v1 -> v2:
* make the message more clear (Alexey)Signed-off-by Anton Protopopov <[email protected]>Acked-by Yonghong Song <[email protected]>--- kernel/bpf/verifier.c | 2 ++ 1 file changed, 2 insertions(+)kernel/bpf/verifier.c +2
-0@@ -18348,6 +18348,8 @@ static int resolve_pseudo_ldimm64(struct bpf_verifier_env *env) }if (env->used_map_cnt >=MAX_USED_MAPS ) { +verbose (env,"The total number of maps per program is reached the limit of %u\n" , +MAX_USED_MAPS );fdput (f);return -E2BIG ; }Signature · 1 line
2.34.1LGTM thanks.
Quoted 1 line
Acked-by John Fastabend <[email protected]>
Thanks. I will actually send yet another version, hopefully the last, with 'has reached' instead of 'is reached'