Skip to contentSkip to conversation

arm64: dts: hisilicon: hip05: move non-MMIO node out of soc

PATCH Applied Krzysztof Kozlowski 3 participants 15 messages Apr 2, 2024 – Apr 25, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/9 arm64: dts: hisilicon: hip05: move non-MMIO node out of soc

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property

---
 arch/arm64/boot/dts/hisilicon/hip05.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/hisilicon/hip05.dtsi +6 -6
index 65ddc0698f82..d0912ca5f237 100644
@@ -279,6 +279,12 @@ its_dsa: msi-controller@c6000000 {
 		};
 	};
 
+	refclk200mhz: refclk200mhz {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <200000000>;
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
@@ -298,12 +304,6 @@ soc {
 		#size-cells = <2>;
 		ranges;
 
-		refclk200mhz: refclk200mhz {
-			compatible = "fixed-clock";
-			#clock-cells = <0>;
-			clock-frequency = <200000000>;
-		};
-
 		uart0: serial@80300000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x0 0x80300000 0x0 0x10000>;
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/9 arm64: dts: hisilicon: hip05-d02: correct local-bus unit addresses

Correct local-bus children unit addresses to fix dtc W=1 warnings:

hip05-d02.dts:57.16-76.4: Warning (simple_bus_reg): /soc/local-bus@80380000/nor-flash@0,0: simple-bus unit address format error, expected "0" hip05-d02.dts:78.11-81.4: Warning (simple_bus_reg): /soc/local-bus@80380000/cpld@1,0: simple-bus unit address format error, expected "100000000"

---
 arch/arm64/boot/dts/hisilicon/hip05-d02.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/hisilicon/hip05-d02.dts +2 -2
index c4eaebbb448f..b7792d443189 100644
@@ -54,7 +54,7 @@ &lbc {
 	ranges = <0 0 0x0 0x90000000 0x08000000>,
 		 <1 0 0x0 0x98000000 0x08000000>;
 
-	nor-flash@0,0 {
+	nor-flash@0 {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "numonyx,js28f00a", "cfi-flash";
@@ -75,7 +75,7 @@ partition@1000000 {
 		};
 	};
 
-	cpld@1,0 {
+	cpld@100000000 {
 		compatible = "hisilicon,hip05-cpld";
 		reg = <1 0x0 0x100>;
 	};
Signature · 1 line
2.34.1
#2 lore raw

PATCH 3/9 arm64: dts: hisilicon: hip06: move non-MMIO node out of soc

In reply to Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

hip06.dtsi:377.18-381.5: Warning (simple_bus_reg): /soc/refclk: missing or empty reg/ranges property

---
 arch/arm64/boot/dts/hisilicon/hip06.dtsi | 84 ++++++++++++------------
 1 file changed, 42 insertions(+), 42 deletions(-)
arch/arm64/boot/dts/hisilicon/hip06.dtsi +42 -42
index f46c33d10750..249ca3b4b703 100644
@@ -258,6 +258,48 @@ its_dsa: msi-controller@c6000000 {
 		};
 	};
 
+	eth2: ethernet-0 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <0>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
+	eth3: ethernet-1 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <1>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
+	eth0: ethernet-4 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <4>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
+	eth1: ethernet-5 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <5>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
+	refclk: refclk {
+		compatible = "fixed-clock";
+		clock-frequency = <50000000>;
+		#clock-cells = <0>;
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
@@ -374,12 +416,6 @@ uart0: serial@2f8 {
 			};
 		};
 
-		refclk: refclk {
-			compatible = "fixed-clock";
-			clock-frequency = <50000000>;
-			#clock-cells = <0>;
-		};
-
 		usb_ohci: usb@a7030000 {
 			compatible = "generic-ohci";
 			reg = <0x0 0xa7030000 0x0 0x10000>;
@@ -570,42 +606,6 @@ port@5 {
 			};
 		};
 
-		eth0: ethernet-4 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <4>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
-		eth1: ethernet-5 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <5>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
-		eth2: ethernet-0 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <0>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
-		eth3: ethernet-1 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <1>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
 		sas0: sas@c3000000 {
 			compatible = "hisilicon,hip06-sas-v2";
 			reg = <0 0xc3000000 0 0x10000>;
Signature · 1 line
2.34.1
#3 lore raw

PATCH 4/9 arm64: dts: hisilicon: hip06: correct unit addresses

In reply to Krzysztof Kozlowski

Correct dsa and pcie unit addresses to fix dtc W=1 warnings:

hip06.dtsi:439.23-571.5: Warning (simple_bus_reg): /soc/dsa@c7000000: simple-bus unit address format error, expected "c5000000"

---
 arch/arm64/boot/dts/hisilicon/hip06.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/hisilicon/hip06.dtsi +2 -2
index 249ca3b4b703..3d7285e6700e 100644
@@ -472,7 +472,7 @@ phy1: ethernet-phy@1 {
 			};
 		};
 
-		dsaf0: dsa@c7000000 {
+		dsaf0: dsa@c5000000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			compatible = "hisilicon,hns-dsaf-v2";
@@ -733,7 +733,7 @@ sas2: sas@a3000000 {
 			status = "disabled";
 		};
 
-		pcie0: pcie@a0090000 {
+		pcie0: pcie@b0000000 {
 			compatible = "hisilicon,hip06-pcie-ecam";
 			reg = <0 0xb0000000 0 0x2000000>,
 			      <0 0xa0090000 0 0x10000>;
Signature · 1 line
2.34.1
#4 lore raw

PATCH 5/9 arm64: dts: hisilicon: hip07: move non-MMIO node out of soc

In reply to Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

hi p07.dtsi:1486.20-1493.5: Warning (unit_address_vs_reg): /soc/ethernet@4: node has a unit name, but no reg or ranges property

---
 arch/arm64/boot/dts/hisilicon/hip07.dtsi | 72 ++++++++++++------------
 1 file changed, 36 insertions(+), 36 deletions(-)
arch/arm64/boot/dts/hisilicon/hip07.dtsi +36 -36
index 81d907ef43ed..9d1e86553ea8 100644
@@ -1013,6 +1013,42 @@ p1_its_dsa_b: msi-controller@408c6000000 {
 		};
 	};
 
+	eth0: ethernet-0 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <4>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
+	eth1: ethernet-1 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <5>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
+	eth2: ethernet-2 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <0>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
+	eth3: ethernet-3 {
+		compatible = "hisilicon,hns-nic-v2";
+		ae-handle = <&dsaf0>;
+		port-idx-in-ae = <1>;
+		local-mac-address = [00 00 00 00 00 00];
+		status = "disabled";
+		dma-coherent;
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
@@ -1483,42 +1519,6 @@ port@5 {
 			};
 		};
 
-		eth0: ethernet@4 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <4>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
-		eth1: ethernet@5 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <5>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
-		eth2: ethernet@0 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <0>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
-		eth3: ethernet@1 {
-			compatible = "hisilicon,hns-nic-v2";
-			ae-handle = <&dsaf0>;
-			port-idx-in-ae = <1>;
-			local-mac-address = [00 00 00 00 00 00];
-			status = "disabled";
-			dma-coherent;
-		};
-
 		infiniband@c4000000 {
 			compatible = "hisilicon,hns-roce-v1";
 			reg = <0x0 0xc4000000 0x0 0x100000>;
Signature · 1 line
2.34.1
#5 lore raw

PATCH 6/9 arm64: dts: hisilicon: hip07: correct unit addresses

In reply to Krzysztof Kozlowski

Correct several nodes' unit addresses to fix dtc W=1 warnings:

arch/arm64/boot/dts/hisilicon/hip07.dtsi:1382.23-1520.5: Warning (simple_bus_reg): /soc/dsa@c7000000: simple-bus unit address format error, expected "c5000000" arch/arm64/boot/dts/hisilicon/hip07.dtsi:1727.29-1747.5: Warning (simple_bus_reg): /soc/pcie@a00a0000: simple-bus unit address format error, expected "af800000" arch/arm64/boot/dts/hisilicon/hip07.dtsi:1748.29-1788.5: Warning (simple_bus_reg): /soc/crypto@d2000000: simple-bus unit address format error, expected "d0000000"

---
 arch/arm64/boot/dts/hisilicon/hip07.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/hisilicon/hip07.dtsi +6 -6
index 9d1e86553ea8..00a6bfa7478c 100644
@@ -1379,7 +1379,7 @@ phy1: ethernet-phy@1 {
 			};
 		};
 
-		dsaf0: dsa@c7000000 {
+		dsaf0: dsa@c5000000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			compatible = "hisilicon,hns-dsaf-v2";
@@ -1724,7 +1724,7 @@ sas2: sas@a3000000 {
 			status = "disabled";
 		};
 
-		p0_pcie2_a: pcie@a00a0000 {
+		p0_pcie2_a: pcie@af800000 {
 			compatible = "hisilicon,hip07-pcie-ecam";
 			reg = <0 0xaf800000 0 0x800000>,
 			      <0 0xa00a0000 0 0x10000>;
@@ -1745,7 +1745,7 @@ p0_pcie2_a: pcie@a00a0000 {
 					 0x0 0 0 4 &mbigen_pcie2_a 671 4>;
 			status = "disabled";
 		};
-		p0_sec_a: crypto@d2000000 {
+		p0_sec_a: crypto@d0000000 {
 			compatible = "hisilicon,hip07-sec";
 			reg = <0x0 0xd0000000 0x0 0x10000>,
 			      <0x0 0xd2000000 0x0 0x10000>,
@@ -1786,7 +1786,7 @@ p0_sec_a: crypto@d2000000 {
 				     <605 1>, <606 4>,
 				     <607 1>, <608 4>;
 		};
-		p0_sec_b: crypto@8,d2000000 {
+		p0_sec_b: crypto@8d0000000 {
 			compatible = "hisilicon,hip07-sec";
 			reg = <0x8 0xd0000000 0x0 0x10000>,
 			      <0x8 0xd2000000 0x0 0x10000>,
@@ -1827,7 +1827,7 @@ p0_sec_b: crypto@8,d2000000 {
 				     <605 1>, <606 4>,
 				     <607 1>, <608 4>;
 		};
-		p1_sec_a: crypto@400,d2000000 {
+		p1_sec_a: crypto@400d0000000 {
 			compatible = "hisilicon,hip07-sec";
 			reg = <0x400 0xd0000000 0x0 0x10000>,
 			      <0x400 0xd2000000 0x0 0x10000>,
@@ -1868,7 +1868,7 @@ p1_sec_a: crypto@400,d2000000 {
 				     <605 1>, <606 4>,
 				     <607 1>, <608 4>;
 		};
-		p1_sec_b: crypto@408,d2000000 {
+		p1_sec_b: crypto@408d0000000 {
 			compatible = "hisilicon,hip07-sec";
 			reg = <0x408 0xd0000000 0x0 0x10000>,
 			      <0x408 0xd2000000 0x0 0x10000>,
Signature · 1 line
2.34.1
#6 lore raw

PATCH 7/9 arm64: dts: hisilicon: hi6220-hikey: add missing port@0 reg

In reply to Krzysztof Kozlowski

adv7533 ports should have "reg" propeties, as reported by dtc W=1 warnings:

hi6220-hikey.dts:516.11-520.6: Warning (unit_address_vs_reg): /soc/i2c@f7102000/adv7533@39/ports/port@0: node has a unit name, but no reg or ranges property

---
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +1 -0
index f0672ec65b26..a2aa17e4dfdf 100644
@@ -514,6 +514,7 @@ ports {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			port@0 {
+				reg = <0>;
 				adv7533_in: endpoint {
 					remote-endpoint = <&dsi_out0>;
 				};
Signature · 1 line
2.34.1
#7 lore raw

PATCH 8/9 arm64: dts: hisilicon: hi6220-hikey: drop unit addresses from fixed regulators

In reply to Krzysztof Kozlowski

Fixed regulators are not part of any MMIO bus, so they should not have unit addresses. This fixes dtc W=1 warnings:

hi6220-hikey.dts:85.26-92.4: Warning (unit_address_vs_reg): /regulator@0: node has a unit name, but no reg or ranges property hi6220-hikey.dts:94.27-102.4: Warning (unit_address_vs_reg): /regulator@1: node has a unit name, but no reg or ranges property hi6220-hikey.dts:104.26-113.4: Warning (unit_address_vs_reg): /regulator@2: node has a unit name, but no reg or ranges property

---
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +3 -3
index a2aa17e4dfdf..2d304efe081d 100644
@@ -82,7 +82,7 @@ reboot-mode {
 		};
 	};
 
-	reg_sys_5v: regulator@0 {
+	reg_sys_5v: regulator-0 {
 		compatible = "regulator-fixed";
 		regulator-name = "SYS_5V";
 		regulator-min-microvolt = <5000000>;
@@ -91,7 +91,7 @@ reg_sys_5v: regulator@0 {
 		regulator-always-on;
 	};
 
-	reg_vdd_3v3: regulator@1 {
+	reg_vdd_3v3: regulator-1 {
 		compatible = "regulator-fixed";
 		regulator-name = "VDD_3V3";
 		regulator-min-microvolt = <3300000>;
@@ -101,7 +101,7 @@ reg_vdd_3v3: regulator@1 {
 		vin-supply = <&reg_sys_5v>;
 	};
 
-	reg_5v_hub: regulator@2 {
+	reg_5v_hub: regulator-2 {
 		compatible = "regulator-fixed";
 		regulator-name = "5V_HUB";
 		regulator-min-microvolt = <5000000>;
Signature · 1 line
2.34.1
#8 lore raw

PATCH 9/9 arm64: dts: hisilicon: hi6220: correct tsensor unit addresses

In reply to Krzysztof Kozlowski

Correct unit address to fix dtc W=1 warnings:

hi6220.dtsi:855.31-862.5: Warning (simple_bus_reg): /soc/tsensor@0,f7030700: simple-bus unit address format error, expected "f7030700"

---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/hisilicon/hi6220.dtsi +1 -1
index be808bb2544e..a589954c29e2 100644
@@ -852,7 +852,7 @@ watchdog0: watchdog@f8005000 {
 			clock-names = "wdog_clk", "apb_pclk";
 		};
 
-		tsensor: tsensor@0,f7030700 {
+		tsensor: tsensor@f7030700 {
 			compatible = "hisilicon,tsensor";
 			reg = <0x0 0xf7030700 0x0 0x1000>;
 			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.34.1
#9 lore raw
In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Applied, thanks!

[1/9] arm64: dts: hisilicon: hip05: move non-MMIO node out of soc

      https://git.kernel.org/krzk/linux-dt/c/8ff69c1d04c8f2381164c5f97781d9fe79f71761
[2/9] arm64: dts: hisilicon: hip05-d02: correct local-bus unit addresses
      https://git.kernel.org/krzk/linux-dt/c/4e0e9c0b311e599c78f63942256ccf03e5ebb0f5
[3/9] arm64: dts: hisilicon: hip06: move non-MMIO node out of soc
      https://git.kernel.org/krzk/linux-dt/c/2283b9afc1b43ec941c66665cdc86dd32f9c2295
[4/9] arm64: dts: hisilicon: hip06: correct unit addresses
      https://git.kernel.org/krzk/linux-dt/c/6c55978774fd66c720e20e1f88a2af7daaa382df
[5/9] arm64: dts: hisilicon: hip07: move non-MMIO node out of soc
      https://git.kernel.org/krzk/linux-dt/c/5e607ec42116e0ecb387e2db79a662333f789fa2
[6/9] arm64: dts: hisilicon: hip07: correct unit addresses
      https://git.kernel.org/krzk/linux-dt/c/76dce22bc7ec9483ef37899a617f2dfde2a382c0
[7/9] arm64: dts: hisilicon: hi6220-hikey: add missing port@0 reg
      https://git.kernel.org/krzk/linux-dt/c/d6fcc43f764630863e3888d0b5c3ff4a09a4f094
[8/9] arm64: dts: hisilicon: hi6220-hikey: drop unit addresses from fixed regulators
      https://git.kernel.org/krzk/linux-dt/c/e6a91e9f20058629dca4f0c264de092049bd8e74
[9/9] arm64: dts: hisilicon: hi6220: correct tsensor unit addresses
      https://git.kernel.org/krzk/linux-dt/c/83d4c5e2a529e3eebde5b4d75e3ec0fe2fc92440

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
maintainer
#10 lore raw

Hi Krzysztof,

Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

Quoted 8 lines
Quoted 3 lines

hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Sorry for the late reply!
I am applying these patches which are in the following git repo.
https://github.com/hisilicon/linux-hisi/tree/next/dt64

And it is fine to me to go through your git tree.
Thanks!

Best Regards,
Wei

Quoted 23 lines

Applied, thanks!

[1/9] arm64: dts: hisilicon: hip05: move non-MMIO node out of soc

      https://git.kernel.org/krzk/linux-dt/c/8ff69c1d04c8f2381164c5f97781d9fe79f71761
[2/9] arm64: dts: hisilicon: hip05-d02: correct local-bus unit addresses
      https://git.kernel.org/krzk/linux-dt/c/4e0e9c0b311e599c78f63942256ccf03e5ebb0f5
[3/9] arm64: dts: hisilicon: hip06: move non-MMIO node out of soc
      https://git.kernel.org/krzk/linux-dt/c/2283b9afc1b43ec941c66665cdc86dd32f9c2295
[4/9] arm64: dts: hisilicon: hip06: correct unit addresses
      https://git.kernel.org/krzk/linux-dt/c/6c55978774fd66c720e20e1f88a2af7daaa382df
[5/9] arm64: dts: hisilicon: hip07: move non-MMIO node out of soc
      https://git.kernel.org/krzk/linux-dt/c/5e607ec42116e0ecb387e2db79a662333f789fa2
[6/9] arm64: dts: hisilicon: hip07: correct unit addresses
      https://git.kernel.org/krzk/linux-dt/c/76dce22bc7ec9483ef37899a617f2dfde2a382c0
[7/9] arm64: dts: hisilicon: hi6220-hikey: add missing port@0 reg
      https://git.kernel.org/krzk/linux-dt/c/d6fcc43f764630863e3888d0b5c3ff4a09a4f094
[8/9] arm64: dts: hisilicon: hi6220-hikey: drop unit addresses from fixed regulators
      https://git.kernel.org/krzk/linux-dt/c/e6a91e9f20058629dca4f0c264de092049bd8e74
[9/9] arm64: dts: hisilicon: hi6220: correct tsensor unit addresses
      https://git.kernel.org/krzk/linux-dt/c/83d4c5e2a529e3eebde5b4d75e3ec0fe2fc92440

Best regards,

#11 lore raw
Quoted 17 lines · Wei Xu

Hi Krzysztof,

Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

Quoted 8 lines
Quoted 3 lines

hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Quoted 6 lines

Sorry for the late reply!
I am applying these patches which are in the following git repo.
https://github.com/hisilicon/linux-hisi/tree/next/dt64

And it is fine to me to go through your git tree.
Thanks!

So you picked them up? Why you did not notify anyone? b4 does it almost automatically. How anyone can know what is happening with the patches?

I will drop them from my tree.

Best regards,
Krzysztof

#12 lore raw
Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Wei Xu

Hi Krzysztof,

Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

Quoted 8 lines
Quoted 3 lines

hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Sorry for the late reply!
I am applying these patches which are in the following git repo.
https://github.com/hisilicon/linux-hisi/tree/next/dt64

Quoted 7 lines
Quoted 2 lines

And it is fine to me to go through your git tree.
Thanks!

So you picked them up? Why you did not notify anyone? b4 does it almost automatically. How anyone can know what is happening with the patches?

I will drop them from my tree.

One more thing:

Even though you applied these patches few days ago, they are still not in linux-next (as of next-20240423), which suggests your tree is not in next.

Please read entire presentation "Beginner Linux kernel maintainer's toolbox" from LPC 2023 and improve your workflow by:
1. Properly notifying patch status.
2. Being part of the integration tree.
3. ... and more, as explained in above talk.

There is a link to video and slides:
https://lpc.events/event/17/contributions/1498/

Best regards,
Krzysztof

maintainer
#13 lore raw

Hi Krzysztof,

Quoted 23 lines · Krzysztof Kozlowski
Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Wei Xu

Hi Krzysztof,

Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

Quoted 8 lines
Quoted 3 lines

hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Sorry for the late reply!
I am applying these patches which are in the following git repo.
https://github.com/hisilicon/linux-hisi/tree/next/dt64

Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

And it is fine to me to go through your git tree.
Thanks!

So you picked them up? Why you did not notify anyone? b4 does it almost automatically. How anyone can know what is happening with the patches?

I will drop them from my tree.

OK.
I will pick up them.

Quoted 7 lines

One more thing:

Even though you applied these patches few days ago, they are still not in linux-next (as of next-20240423), which suggests your tree is not in next.

Quoted 8 lines

Please read entire presentation "Beginner Linux kernel maintainer's toolbox" from LPC 2023 and improve your workflow by:
1. Properly notifying patch status.
2. Being part of the integration tree.
3. ... and more, as explained in above talk.

There is a link to video and slides:
https://lpc.events/event/17/contributions/1498/

Got it.Thanks!
I will go through it.

Best Regards,
Wei

Quoted 6 lines

Best regards,
Krzysztof

.

maintainer
#14 lore raw
In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 23 lines · Krzysztof Kozlowski
Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Wei Xu

Hi Krzysztof,

Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

Quoted 8 lines
Quoted 3 lines

hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Sorry for the late reply!
I am applying these patches which are in the following git repo.
https://github.com/hisilicon/linux-hisi/tree/next/dt64

Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

And it is fine to me to go through your git tree.
Thanks!

So you picked them up? Why you did not notify anyone? b4 does it almost automatically. How anyone can know what is happening with the patches?

I will drop them from my tree.

Series applied to the HiSilicon arm64 dt tree:
https://github.com/hisilicon/linux-hisi/tree/next/dt64

Quoted 7 lines

One more thing:

Even though you applied these patches few days ago, they are still not in linux-next (as of next-20240423), which suggests your tree is not in next.

Quoted 8 lines

Please read entire presentation "Beginner Linux kernel maintainer's toolbox" from LPC 2023 and improve your workflow by:
1. Properly notifying patch status.
2. Being part of the integration tree.
3. ... and more, as explained in above talk.

There is a link to video and slides:
https://lpc.events/event/17/contributions/1498/

I have went through your slide which is very helpful and detailed. Thanks!

Best Regards,
Wei

Quoted 6 lines

Best regards,
Krzysztof

.