Skip to contentSkip to conversation

lib: Use PFN_PHYS() in devmem_is_allowed()

PATCH Applied Liang Wang 4 participants 4 messages Jul 31, 2021 – Aug 4, 2021

Subsystems (2)
lore
Share & tools
lore

Liang Wang

author
#0 lore raw

PATCH v3 1/1 lib: Use PFN_PHYS() in devmem_is_allowed()

The physical address may exceed 32 bits on 32-bit systems with more than 32 bits of physcial address,use PFN_PHYS() in devmem_is_allowed(), or the physical address may overflow and be truncated.
We found this bug when mapping a high addresses through devmem tool, when CONFIG_STRICT_DEVMEM is enabled on the ARM with ARM_LPAE and devmem is used to map a high address that is not in the iomem address range, an unexpected error indicating no permission is returned.

This bug was initially introduced from v2.6.37, and the function was moved to lib when v5.11.

Cc Luis Chamberlain <[email protected]>
Fixes 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
Cc [email protected] # v2.6.37

---
v3: update changelog suggested by Luis Chamberlain <[email protected]>

 lib/devmem_is_allowed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/devmem_is_allowed.c +1 -1
index c0d67c541849..60be9e24bd57 100644
@@ -19,7 +19,7 @@
  */
 int devmem_is_allowed(unsigned long pfn)
 {
-	if (iomem_is_exclusive(pfn << PAGE_SHIFT))
+	if (iomem_is_exclusive(PFN_PHYS(pfn)))
 		return 0;
 	if (!page_is_ram(pfn))
 		return 1;
Signature · 1 line
2.32.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 8 lines · Liang Wang

The physical address may exceed 32 bits on 32-bit systems with more than 32 bits of physcial address,use PFN_PHYS() in devmem_is_allowed(), or the physical address may overflow and be truncated.
We found this bug when mapping a high addresses through devmem tool, when CONFIG_STRICT_DEVMEM is enabled on the ARM with ARM_LPAE and devmem is used to map a high address that is not in the iomem address range, an unexpected error indicating no permission is returned.

Quoted 8 lines

This bug was initially introduced from v2.6.37, and the function was moved to lib when v5.11.

Cc Luis Chamberlain <[email protected]>
Fixes 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
Cc [email protected] # v2.6.37

Luis

Reviewed-by on v3 1/1
#2 lore raw
In reply to Liang Wang
Quoted 8 lines · Liang Wang

The physical address may exceed 32 bits on 32-bit systems with more than 32 bits of physcial address,use PFN_PHYS() in devmem_is_allowed(), or the physical address may overflow and be truncated.
We found this bug when mapping a high addresses through devmem tool, when CONFIG_STRICT_DEVMEM is enabled on the ARM with ARM_LPAE and devmem is used to map a high address that is not in the iomem address range, an unexpected error indicating no permission is returned.

Quoted 8 lines

This bug was initially introduced from v2.6.37, and the function was moved to lib when v5.11.

Cc Luis Chamberlain <[email protected]>
Fixes 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
Cc [email protected] # v2.6.37
#3 lore raw
Quoted 13 lines · On Tue, 03 Aug 2021 22:01:46 PDT (-0700), [email protected] wrote:
Quoted 11 lines · Liang Wang

The physical address may exceed 32 bits on 32-bit systems with more than 32 bits of physcial address,use PFN_PHYS() in devmem_is_allowed(), or the physical address may overflow and be truncated.
We found this bug when mapping a high addresses through devmem tool, when CONFIG_STRICT_DEVMEM is enabled on the ARM with ARM_LPAE and devmem is used to map a high address that is not in the iomem address range, an unexpected error indicating no permission is returned.

This bug was initially introduced from v2.6.37, and the function was moved to lib when v5.11.

Quoted 6 lines
Quoted 5 lines
Cc Luis Chamberlain <[email protected]>
Fixes 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
Cc [email protected] # v2.6.37

Weird, it's still only your replies that are coming through. Given that this only manifests on 32-bit Arm systems, I'm going to leave this up to them for now.