shared/gatt-server: Fix not using correct MTU for responses
Luiz Augusto von Dentz
maintainerPATCH 1/1 shared/gatt-server: Fix not using correct MTU for responses
From: Luiz Augusto von Dentz <[email protected]>
Responses shall use the bt_att_channel MTU not the bt_att MTU since the response shall be send over the same channel as the request.
--- attrib/gattrib.c | 8 ++-- src/shared/att.c | 5 ++- src/shared/att.h | 2 +- src/shared/gatt-client.c | 2 +- src/shared/gatt-server.c | 91 +++++++++++++++++++--------------------- 5 files changed, 53 insertions(+), 55 deletions(-)
attrib/gattrib.c +4 -4
@@ -237,9 +237,9 @@ static void attrib_callback_result(uint8_t opcode, const void *pdu,free (buf); } -static void attrib_callback_notify (struct bt_att_chan *chan,uint8_t opcode, -const void *pdu,uint16_t length, -void *user_data) +static void attrib_callback_notify (struct bt_att_chan *chan,uint16_t mtu, +uint8_t opcode,const void *pdu, +uint16_t length,void *user_data) {uint8_t *buf;struct attrib_callbacks *cb = user_data;
@@ -355,7 +355,7 @@ static void client_notify_cb(uint16_t value_handle, const uint8_t *value,if (length)memcpy (buf +2 , value, length); -attrib_callback_notify (NULL ,ATT_OP_HANDLE_NOTIFY , buf, length +2 , +attrib_callback_notify (NULL ,0 ,ATT_OP_HANDLE_NOTIFY , buf, length +2 , user_data); }
src/shared/att.c +3 -2
@@ -1009,8 +1009,9 @@ static void handle_notify(struct bt_att_chan *chan, uint8_t *pdu, found = true;if (notify->callback) - notify->callback (chan, opcode, pdu +1 , pdu_len -1 , - notify->user_data); + notify->callback (chan, chan->mtu, opcode, + pdu +1 , pdu_len -1 , + notify->user_data);/* callback could remove all entries from notify list */ if (queue_isempty (att->notify_list))
src/shared/att.h +1 -1
@@ -35,7 +35,7 @@ int bt_att_get_channels(struct bt_att *att);typedef void (*bt_att_response_func_t )(uint8_t opcode,const void *pdu,uint16_t length,void *user_data); -typedef void (*bt_att_notify_func_t )(struct bt_att_chan *chan, +typedef void (*bt_att_notify_func_t )(struct bt_att_chan *chan,uint16_t mtu,uint8_t opcode,const void *pdu,uint16_t length,void *user_data);typedef void (*bt_att_destroy_func_t )(void *user_data);
src/shared/gatt-client.c +1 -1
@@ -2228,7 +2228,7 @@ static void notify_handler(void *data, void *user_data) value_data->len, notify_data->user_data); } -static void notify_cb (struct bt_att_chan *chan,uint8_t opcode, +static void notify_cb (struct bt_att_chan *chan,uint16_t mtu,uint8_t opcode,const void *pdu,uint16_t length,void *user_data) {
src/shared/gatt-server.c +44 -47
267 lines not on this page · raw message
Signature · 1 line
2.45.2
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=869329
---Test result---
Test Summary:
CheckPatch PASS 0.32 seconds GitLint PASS 0.18 seconds BuildEll PASS 24.65 seconds BluezMake PASS 1673.25 seconds MakeCheck PASS 13.07 seconds MakeDistcheck PASS 178.50 seconds CheckValgrind PASS 253.43 seconds CheckSmatch WARNING 375.14 seconds bluezmakeextell PASS 119.80 seconds IncrementalBuild PENDING 60.41 seconds ScanBuild PENDING 1085.53 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:618:25: warning: Variable length array is used.src/shared/gatt-server.c:716:25: warning: Variable length array is used.src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:618:25: warning: Variable length array is used.src/shared/gatt-server.c:716:25: warning: Variable length array is used.src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:618:25: warning: Variable length array is used.src/shared/gatt-server.c:716:25: warning: Variable length array is used.
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
##############################
Test: ScanBuild - PENDING
Desc: Run Scan Build Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 11 lines · On Mon, 8 Jul 2024 11:28:23 -0400 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
Responses shall use the
bt_att_channelMTU not thebt_attMTU since the response shall be send over the same channel as the request.--- attrib/gattrib.c | 8 ++-- src/shared/att.c | 5 ++- src/shared/att.h | 2 +- src/shared/gatt-client.c | 2 +- src/shared/gatt-server.c | 91 +++++++++++++++++++--------------------- 5 files changed, 53 insertions(+), 55 deletions(-)
Here is the summary with links:
- [BlueZ,v1] shared/gatt-server: Fix not using correct MTU for responses
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=110a8b47a4f1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html