i2c: img-scb: remove duplicate dev_err()
Subsystems (2)
Quoted 2 lines
it will print an error message by itself when
platform_get_irq()goes wrong. so don't needdev_err()in here again.
I suggest to improve the change description.
Can you get any further inspiration by previous patches from other contributors according to the presented transformation pattern?
Would you like to adjust any more source files in the mentioned software area?
Regards,
Markus
Quoted 10 lines · Markus Elfring
Quoted 2 lines
it will print an error message by itself when
platform_get_irq()goes wrong. so don't needdev_err()in here again.I suggest to improve the change description.
Can you get any further inspiration by previous patches from other contributors according to the presented transformation pattern?Would you like to adjust any more source files in the mentioned software area?
Hi Markus:
Thanks for your comments, and maybe we can use coccinelle tools for more source files do this change in the mentioned software area.
BR,
Dejin
Quoted 2 lines
Regards,
Markus
Quoted 2 lines
Thanks for your comments, and maybe we can use coccinelle tools for more source files do this change in the mentioned software area.
I found 19 source files (for example in the directory “drivers/i2c” of the software “Linux next-20200408”) which seem to contain similar update candidates according to a known transformation pattern. Would you like to take another look at corresponding change possibilities?
Regards,
Markus
Quoted 8 lines · Markus Elfring
Quoted 2 lines
Thanks for your comments, and maybe we can use coccinelle tools for more source files do this change in the mentioned software area.
I found 19 source files (for example in the directory “drivers/i2c” of the software “Linux next-20200408”) which seem to contain similar update candidates according to a known transformation pattern. Would you like to take another look at corresponding change possibilities?
yes, I want to do it and thanks for your info.
BR,
Dejin
Quoted 2 lines
Regards,
Markus
Quoted 3 lines
Quoted 2 lines
Would you like to take another look at corresponding change possibilities?
yes, I want to do it and thanks for your info.
This positive feedback can lead to corresponding software development opportunities. Which directions would you like try out next?
Regards,
Markus
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Would you like to take another look at corresponding change possibilities?
yes, I want to do it and thanks for your info.
How do you think about to improve the clarification around potentially “odd fixes” (because of collateral evolution)?
I noticed your update suggestion “i2c: busses: convert to devm_platform_ioremap_resource”.
https://lore.kernel.org/linux-i2c/[email protected]/
https://lore.kernel.org/patchwork/patch/1222122/
https://lkml.org/lkml/2020/4/9/431
It seems that you got encouraged to contribute changes according to another transformation approach by a single patch for a directory hierarchy. How likely is it that such adjustments touch source code places where related error messages would be found for further software development considerations?
Would you like to wait until the integration of this update succeeded?
Will it be interesting in the meantime to become more familiar with applications around scripts for the semantic patch language?
Can the Coccinelle software make the discussed transformations more convenient also for your needs?
Regards,
Markus
Quoted 7 lines · Markus Elfring
Quoted 3 lines
Quoted 2 lines
Would you like to take another look at corresponding change possibilities?
yes, I want to do it and thanks for your info.
This positive feedback can lead to corresponding software development opportunities. Which directions would you like try out next?
May be related to usb, ethernet and pcie. My current job is related to these. Thanks!
BR,
Dejin
Quoted 2 lines
Regards,
Markus