Skip to contentSkip to conversation

staging:iio:accel:adis16029 fixed checkpatch issue - drop braces around single if statement

PATCH In review Andrea della Porta 2 participants 2 messages Mar 29, 2017 – Apr 2, 2017

Subsystems (4)
Staging IIO Analog Devices IIO drivers Staging - industrial io
lore
Share & tools
lore

Andrea della Porta

author
#0 lore raw

PATCH 1/1 staging:iio:accel:adis16029 fixed checkpatch issue - drop braces around single if statement

Fixed the followinf checkpatch warning:
WARNING: braces {} are not necessary for single statement blocks #258: FILE: drivers/staging/iio/accel/adis16209.c:258:
+ if (ret) {
+ return ret;
+ }

Signed-off-by Andrea della Porta <[email protected]>
---
 drivers/staging/iio/accel/adis16209.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/accel/adis16209.c +2 -2
index 52fa2e0..159a687 100644
@@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
 		}
 		addr = adis16209_addresses[chan->scan_index][0];
 		ret = adis_read_reg_16(st, addr, &val16);
-		if (ret) {
+		if (ret)
 			return ret;
-		}
+
 		val16 &= (1 << bits) - 1;
 		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
 		*val = val16;
Signature · 1 line
2.4.10
maintainer
#1 lore raw

See patch title. Check the part number...

Quoted 8 lines · Andrea della Porta

Fixed the followinf checkpatch warning:
WARNING: braces {} are not necessary for single statement blocks #258: FILE: drivers/staging/iio/accel/adis16209.c:258:

(quoted diff) +3 -0
+		if (ret) {
+			return ret;
+		}
Signed-off-by Andrea della Porta <[email protected]>

Was fixed about a week ago by Mark Stenglein.

Patch has made it through the IIO tree to staging yet though. Should be heading that way this afternoon (depending on how long Greg's backlog of emails still is ;)

Jonathan

Quoted 21 lines
---
 drivers/staging/iio/accel/adis16209.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/accel/adis16209.c +2 -2
index 52fa2e0..159a687 100644
@@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
 		}
 		addr = adis16209_addresses[chan->scan_index][0];
 		ret = adis_read_reg_16(st, addr, &val16);
-		if (ret) {
+		if (ret)
 			return ret;
-		}
+
 		val16 &= (1 << bits) - 1;
 		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
 		*val = val16;