Bluetooth: hci_core: Fix LE quote calculation
Subsystems (2)
Luiz Augusto von Dentz
maintainerPATCH 1/1 Bluetooth: hci_core: Fix LE quote calculation
From: Luiz Augusto von Dentz <[email protected]>
Function hci_sched_le needs to update the respective counter variable inplace other the likes of hci_quote_sent would attempt to use the possible outdated value of conn->{le_cnt,acl_cnt}.
--- net/bluetooth/hci_core.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-)
net/bluetooth/hci_core.c +7 -12
@@ -3664,19 +3664,19 @@ static void hci_sched_le(struct hci_dev *hdev) {struct hci_chan *chan;struct sk_buff *skb; -int quote, cnt, tmp; +int quote, *cnt, tmp;BT_DBG ("%s" , hdev->name);if (!hci_conn_num (hdev,LE_LINK ))return ; - cnt = hdev->le_pkts ? hdev->le_cnt : hdev->acl_cnt; + cnt = hdev->le_pkts ? &hdev->le_cnt : &hdev->acl_cnt; -__check_timeout (hdev, cnt,LE_LINK ); +__check_timeout (hdev, *cnt,LE_LINK ); - tmp = cnt; -while (cnt && (chan =hci_chan_sent (hdev,LE_LINK , "e))) { + tmp = *cnt; +while (*cnt && (chan =hci_chan_sent (hdev,LE_LINK , "e))) {u32 priority = (skb_peek (&chan->data_q))->priority;while (quote-- && (skb =skb_peek (&chan->data_q))) { BT_DBG("chan %p skb %p len %d priority %u", chan, skb,
@@ -3691,7 +3691,7 @@ static void hci_sched_le(struct hci_dev *hdev)hci_send_frame (hdev, skb); hdev->le_last_tx = jiffies; - cnt--; + (*cnt)--; chan->sent++; chan->conn->sent++;
@@ -3701,12 +3701,7 @@ static void hci_sched_le(struct hci_dev *hdev) } } -if (hdev->le_pkts) - hdev->le_cnt = cnt; -else - hdev->acl_cnt = cnt; - -if (cnt != tmp) +if (*cnt != tmp)hci_prio_recalculate (hdev,LE_LINK ); }
Signature · 1 line
2.46.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=878861
---Test result---
Test Summary:
CheckPatch PASS 0.53 seconds GitLint PASS 0.55 seconds SubjectPrefix PASS 0.08 seconds BuildKernel PASS 31.33 seconds CheckAllWarning PASS 33.35 seconds CheckSparse PASS 39.24 seconds CheckSmatch PASS 105.79 seconds BuildKernel32 PASS 29.11 seconds TestRunnerSetup PASS 531.41 seconds TestRunner_l2cap-tester PASS 22.08 seconds TestRunner_iso-tester PASS 30.80 seconds TestRunner_bnep-tester PASS 4.87 seconds TestRunner_mgmt-tester FAIL 113.00 seconds TestRunner_rfcomm-tester PASS 7.58 seconds TestRunner_sco-tester PASS 15.02 seconds TestRunner_ioctl-tester PASS 7.84 seconds TestRunner_mesh-tester PASS 5.94 seconds TestRunner_smp-tester PASS 6.90 seconds TestRunner_userchan-tester PASS 5.05 seconds IncrementalBuild PASS 27.86 seconds
Details
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2
Failed Test Cases
LL Privacy - Start Discovery 2 (Disable RL) Failed 0.175 seconds
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 11 lines · On Mon, 12 Aug 2024 11:32:19 -0400 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
Function
hci_sched_leneeds to update the respective counter variable inplace other the likes ofhci_quote_sentwould attempt to use the possible outdated value of conn->{le_cnt,acl_cnt}.Fixes 73d80deb7bdf ("Bluetooth: prioritizing data over HCI")Signed-off-by Luiz Augusto von Dentz <[email protected]>[...]
Here is the summary with links:
- [v1] Bluetooth: hci_core: Fix LE quote calculation
https://git.kernel.org/bluetooth/bluetooth-next/c/a8d17a97ecfd
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html