Skip to contentSkip to conversation

Drop BU27008 and BU27010

PATCH In review Matti Vaittinen 4 participants 8 messages Nov 28, 2024 – Nov 30, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Drop BU27008 and BU27010

Drop the support for ROHM BD72008 and BD72010 RGB sensors

I accidentally hit a BU27008 data-sheet which had a big red text saying "Obsolete". After a few queries I received a word that the ROHM BU27008 and BU27010 RGB sensors were cancelled and never entered mass production. Supporting not existing hardware makes no sense, so it's probably best to drop the drivers and dt-bindings.

There is still a RGB sensor from ROHM called BU27006.
https://www.rohm.com/products/sensors-mems/color-sensor-ics/bu27006muc-z-product
Based on a quick glance this should be very similar to the BU27010. If someone wants to create a driver for this, then the bu27008.c might be worth looking at.

As writing of this I don't have the BU27006 at my hands, and when I asked about creating a driver for this IC from the HQ ... I got an impression that at the moment ROHM rather pays me for doing something else. So, currently I have no plan to add support for the BD27006. We can always dig the bu27008.c from the depths of the git, if it later appears such a driver would be a good idea.

Matti Vaittinen (2):
iio: light: Drop BU27008 and BU27010
dt-bindings: iio: light: Drop BU27008 and BU27010

 .../bindings/iio/light/rohm,bu27008.yaml      |   49 -
 .../bindings/iio/light/rohm,bu27010.yaml      |   50 -
 MAINTAINERS                                   |    1 -
 drivers/iio/light/Kconfig                     |   16 -
 drivers/iio/light/Makefile                    |    1 -
 drivers/iio/light/rohm-bu27008.c              | 1635 -----------------
 6 files changed, 1752 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27008.yaml
 delete mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
 delete mode 100644 drivers/iio/light/rohm-bu27008.c

base-commit: a61ff7eac77e86de828fe28c4e42b8ae9ec2b195

Signature · 1 line
2.47.0
#1 lore raw

PATCH 1/2 iio: light: Drop BU27008 and BU27010

The ROHM BU27008 and BU27010 RGB sensors got cancelled. I was informed they never reached mass production stage.

Keeping the drivers around is waste of maintenance resources. Drop the drivers.

---
 MAINTAINERS                      |    1 -
 drivers/iio/light/Kconfig        |   16 -
 drivers/iio/light/Makefile       |    1 -
 drivers/iio/light/rohm-bu27008.c | 1635 ------------------------------
 4 files changed, 1653 deletions(-)
 delete mode 100644 drivers/iio/light/rohm-bu27008.c
MAINTAINERS +0 -1
index 3fd398d6e64f..932a113ffed2 100644
@@ -20038,7 +20038,6 @@ ROHM BU270xx LIGHT SENSOR DRIVERs
 M:	Matti Vaittinen <[email protected]>
 L:	[email protected]
 S:	Supported
-F:	drivers/iio/light/rohm-bu27008.c
 F:	drivers/iio/light/rohm-bu27034.c
 
 ROHM MULTIFUNCTION BD9571MWV-M PMIC DEVICE DRIVERS
drivers/iio/light/Kconfig +0 -16
index 29ffa8491927..074caa5597c7 100644
@@ -329,22 +329,6 @@ config JSA1212
 	  To compile this driver as a module, choose M here:
 	  the module will be called jsa1212.
 
-config ROHM_BU27008
-	tristate "ROHM BU27008 color (RGB+C/IR) sensor"
-	depends on I2C
-	select REGMAP_I2C
-	select IIO_GTS_HELPER
-	select IIO_BUFFER
-	select IIO_TRIGGERED_BUFFER
-	help
-	  Enable support for the ROHM BU27008 color sensor.
-	  The ROHM BU27008 is a sensor with 5 photodiodes (red, green,
-	  blue, clear and IR) with four configurable channels. Red and
-	  green being always available and two out of the rest three
-	  (blue, clear, IR) can be selected to be simultaneously measured.
-	  Typical application is adjusting LCD backlight of TVs,
-	  mobile phones and tablet PCs.
-
 config ROHM_BU27034
 	tristate "ROHM BU27034 ambient light sensor"
 	depends on I2C
drivers/iio/light/Makefile +0 -1
index f14a37442712..56beb324f34f 100644
@@ -43,7 +43,6 @@ obj-$(CONFIG_NOA1305)		+= noa1305.o
 obj-$(CONFIG_OPT3001)		+= opt3001.o
 obj-$(CONFIG_OPT4001)		+= opt4001.o
 obj-$(CONFIG_PA12203001)	+= pa12203001.o
-obj-$(CONFIG_ROHM_BU27008)	+= rohm-bu27008.o
 obj-$(CONFIG_ROHM_BU27034)	+= rohm-bu27034.o
 obj-$(CONFIG_RPR0521)		+= rpr0521.o
 obj-$(CONFIG_SI1133)		+= si1133.o
drivers/iio/light/rohm-bu27008.c deleted +0 -1635

1,635 lines not on this page · raw message

Signature · 1 line
2.47.0
#2 lore raw

PATCH 2/2 dt-bindings: iio: light: Drop BU27008 and BU27010

In reply to Matti Vaittinen

The ROHM BU27008 and BU27010 RGB sensors got cancelled. I was informed they never reached mass production stage.

Keeping the bindings around is waste of maintenance resources. Drop the bindings.

---
 .../bindings/iio/light/rohm,bu27008.yaml      | 49 ------------------
 .../bindings/iio/light/rohm,bu27010.yaml      | 50 -------------------
 2 files changed, 99 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27008.yaml
 delete mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
Documentation/devicetree/bindings/iio/light/rohm,bu27008.yaml deleted +0 -49
deleted file mode 100644
index 4f66fd47b016..000000000000
@@ -1,49 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/iio/light/rohm,bu27008.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: ROHM BU27008 color sensor
-
-maintainers:
-  - Matti Vaittinen <[email protected]>
-
-description:
-  The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear
-  and IR) with four configurable channels. Red and green being always
-  available and two out of the rest three (blue, clear, IR) can be
-  selected to be simultaneously measured. Typical application is adjusting
-  LCD backlight of TVs, mobile phones and tablet PCs.
-
-properties:
-  compatible:
-    const: rohm,bu27008
-
-  reg:
-    maxItems: 1
-
-  interrupts:
-    maxItems: 1
-
-  vdd-supply: true
-
-required:
-  - compatible
-  - reg
-
-additionalProperties: false
-
-examples:
-  - |
-    i2c {
-      #address-cells = <1>;
-      #size-cells = <0>;
-
-      light-sensor@38 {
-        compatible = "rohm,bu27008";
-        reg = <0x38>;
-      };
-    };
-
-...
Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml deleted +0 -50

50 lines not on this page · raw message

Signature · 1 line
2.47.0
Acked-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] dt-bindings: iio: light: Drop BU27008 and BU27010

Quoted 7 lines · Matti Vaittinen

The ROHM BU27008 and BU27010 RGB sensors got cancelled. I was informed they never reached mass production stage.

Keeping the bindings around is waste of maintenance resources. Drop the bindings.

Reviewed-by on the v1 series
#4 lore raw
In reply to Matti Vaittinen
Quoted 14 lines · Matti Vaittinen

Drop the support for ROHM BD72008 and BD72010 RGB sensors

I accidentally hit a BU27008 data-sheet which had a big red text saying "Obsolete". After a few queries I received a word that the ROHM BU27008 and BU27010 RGB sensors were cancelled and never entered mass production. Supporting not existing hardware makes no sense, so it's probably best to drop the drivers and dt-bindings.

There is still a RGB sensor from ROHM called BU27006.
https://www.rohm.com/products/sensors-mems/color-sensor-ics/bu27006muc-z-product
Based on a quick glance this should be very similar to the BU27010. If someone wants to create a driver for this, then the bu27008.c might be worth looking at.

Quoted 6 lines

As writing of this I don't have the BU27006 at my hands, and when I asked about creating a driver for this IC from the HQ ... I got an impression that at the moment ROHM rather pays me for doing something else. So, currently I have no plan to add support for the BD27006. We can always dig the bu27008.c from the depths of the git, if it later appears such a driver would be a good idea.

The best series ever from you, Matti, on which I have not a tiny disagreement with!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 22 lines · Andy Shevchenko
Quoted 14 lines · Matti Vaittinen

Drop the support for ROHM BD72008 and BD72010 RGB sensors

I accidentally hit a BU27008 data-sheet which had a big red text saying "Obsolete". After a few queries I received a word that the ROHM BU27008 and BU27010 RGB sensors were cancelled and never entered mass production. Supporting not existing hardware makes no sense, so it's probably best to drop the drivers and dt-bindings.

There is still a RGB sensor from ROHM called BU27006.
https://www.rohm.com/products/sensors-mems/color-sensor-ics/bu27006muc-z-product
Based on a quick glance this should be very similar to the BU27010. If someone wants to create a driver for this, then the bu27008.c might be worth looking at.

Quoted 6 lines

As writing of this I don't have the BU27006 at my hands, and when I asked about creating a driver for this IC from the HQ ... I got an impression that at the moment ROHM rather pays me for doing something else. So, currently I have no plan to add support for the BD27006. We can always dig the bu27008.c from the depths of the git, if it later appears such a driver would be a good idea.

Quoted 4 lines

The best series ever from you, Matti, on which I have not a tiny disagreement with!

Thanks for the review. I guess you might've had something to comment regarding the recipient list though XD

I don't really know what I did to get the patch names in recipients. Sorry.

maintainer
#6 lore raw
In reply to Matti Vaittinen
Quoted 14 lines · On Thu, 28 Nov 2024 21:34:54 +0200 Matti Vaittinen <[email protected]>…

Drop the support for ROHM BD72008 and BD72010 RGB sensors

I accidentally hit a BU27008 data-sheet which had a big red text saying "Obsolete". After a few queries I received a word that the ROHM BU27008 and BU27010 RGB sensors were cancelled and never entered mass production. Supporting not existing hardware makes no sense, so it's probably best to drop the drivers and dt-bindings.

There is still a RGB sensor from ROHM called BU27006.
https://www.rohm.com/products/sensors-mems/color-sensor-ics/bu27006muc-z-product
Based on a quick glance this should be very similar to the BU27010. If someone wants to create a driver for this, then the bu27008.c might be worth looking at.

Quoted 6 lines

As writing of this I don't have the BU27006 at my hands, and when I asked about creating a driver for this IC from the HQ ... I got an impression that at the moment ROHM rather pays me for doing something else. So, currently I have no plan to add support for the BD27006. We can always dig the bu27008.c from the depths of the git, if it later appears such a driver would be a good idea.

Applied. I'm not going to rush it in because a driver for hardware that no one has is not really a problem as long as no one does any more work on it. So queued up in my testing branch which will go upstream next merge cycle.

You have my sympathies wrt to wasted work!

Jonathan

Quoted 18 lines

Matti Vaittinen (2):
iio: light: Drop BU27008 and BU27010
dt-bindings: iio: light: Drop BU27008 and BU27010

 .../bindings/iio/light/rohm,bu27008.yaml      |   49 -
 .../bindings/iio/light/rohm,bu27010.yaml      |   50 -
 MAINTAINERS                                   |    1 -
 drivers/iio/light/Kconfig                     |   16 -
 drivers/iio/light/Makefile                    |    1 -
 drivers/iio/light/rohm-bu27008.c              | 1635 -----------------
 6 files changed, 1752 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27008.yaml
 delete mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
 delete mode 100644 drivers/iio/light/rohm-bu27008.c

base-commit: a61ff7eac77e86de828fe28c4e42b8ae9ec2b195

#7 lore raw
Quoted 24 lines · Jonathan Cameron
Quoted 14 lines · On Thu, 28 Nov 2024 21:34:54 +0200 Matti Vaittinen <[email protected]>…

Drop the support for ROHM BD72008 and BD72010 RGB sensors

I accidentally hit a BU27008 data-sheet which had a big red text saying "Obsolete". After a few queries I received a word that the ROHM BU27008 and BU27010 RGB sensors were cancelled and never entered mass production. Supporting not existing hardware makes no sense, so it's probably best to drop the drivers and dt-bindings.

There is still a RGB sensor from ROHM called BU27006.
https://www.rohm.com/products/sensors-mems/color-sensor-ics/bu27006muc-z-product
Based on a quick glance this should be very similar to the BU27010. If someone wants to create a driver for this, then the bu27008.c might be worth looking at.

Quoted 6 lines

As writing of this I don't have the BU27006 at my hands, and when I asked about creating a driver for this IC from the HQ ... I got an impression that at the moment ROHM rather pays me for doing something else. So, currently I have no plan to add support for the BD27006. We can always dig the bu27008.c from the depths of the git, if it later appears such a driver would be a good idea.

Quoted 4 lines

Applied. I'm not going to rush it in because a driver for hardware that no one has is not really a problem as long as no one does any more work on it. So queued up in my testing branch which will go upstream next merge cycle.

Thanks. This makes perfect sense, and I didn't expect them to go in sooner :)

Quoted 1 line

You have my sympathies wrt to wasted work!

It indeed hurts. You do always hope things you tinker with would be useful. Well, not the first cancelled product I am working with - and I believe not a last one either...

Yours,
-- Matti