memory: renesas-rpc-if: Fix missing setting address
PATCH 1/1 memory: renesas-rpc-if: Fix missing setting address
In the RPC manual mode, if the data direction is not set (such as the flash erase command), the address misses the setting.
--- drivers/memory/renesas-rpc-if.c | 1 + 1 file changed, 1 insertion(+)
drivers/memory/renesas-rpc-if.c +1 -0
@@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc) }break ;default : +regmap_write (rpc->regmap,RPCIF_SMADR , rpc->smadr);regmap_write (rpc->regmap,RPCIF_SMENR , rpc->enable);regmap_write (rpc->regmap,RPCIF_SMCR , rpc->smcr |RPCIF_SMCR_SPIE );
Signature · 1 line
2.17.1
Krzysztof Kozlowski
AppliedQuoted 5 lines · JaimeLiao
In the RPC manual mode, if the data direction is not set (such as the flash erase command), the address misses the setting.
Applied, thanks!
[1/1] memory: renesas-rpc-if: Fix missing setting address
https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>
Quoted 11 lines · Krzysztof Kozlowski
Quoted 5 lines · JaimeLiao
In the RPC manual mode, if the data direction is not set (such as the flash erase command), the address misses the setting.
Applied, thanks!
[1/1] memory: renesas-rpc-if: Fix missing setting address
https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3
And drop. Stop sending the same patch all over again...
Best regards,
Krzysztof
Hi Jaime,
CC linux-renesas-soc
Thanks for your patch!
Quoted 3 lines · JaimeLiao
In the RPC manual mode, if the data direction is not set (such as the flash erase command), the address misses the setting.
This patch never received review comments.
As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written before the switch() statement, hence this patch can be ignored.
See also
https://lore.kernel.org/all/CAMuHMdWpvuC2Cm41jCQm+rT8MZB5GN+Z0bPz941QzsHX17Ux-g@mail.gmail.com
drivers/memory/renesas-rpc-if.c int rpcif_manual_xfer(struct rpcif *rpc) · line 577
Quoted 12 lines
Signed-off-by JaimeLiao <[email protected]>drivers/memory/renesas-rpc-if.c +1
-0@@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc) }break ;default : +regmap_write (rpc->regmap,RPCIF_SMADR , rpc->smadr);regmap_write (rpc->regmap,RPCIF_SMENR , rpc->enable);regmap_write (rpc->regmap,RPCIF_SMCR , rpc->smcr |RPCIF_SMCR_SPIE );
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds