mesh: Implement lower transport layer for segmentation and reassembly
PATCH 1/4 mesh: Implement lower transport layer for segmentation and reassembly
Sections 4.2.48 and 4.2.49 of Mesh Protocol 1.1 define the transmission interval, number of retransmissions, retransmission interval, ack transmission, number of ack retransmissions, ack retransmission interval, ack retransmission interval, and discard time for SAR, which is a mutable state, and required a SAR implementation that conforms to the specification. The existing segmentation and reassembly were implemented before the specification was officially released, so they were fixed.
- In the previous implementation, the segments of the SAR were sent to the network layer immediately for every segO. This has been changed so that they are sent one after the other when the timer expires for each segment interval state.
- In the previous implementation, the SAR retransmission feature for multicast sent all segments to the network layer a fixed four times. This has been changed to send as many SAR retransmissions for multicast as the number of states.
- In the original implementation, the SAR retransmission feaure for unicast was persistent as long as the receiver was receiving additional segments. This has been changed to send as many SAR retransmissions for unicast as the number of states.
- In the previous implementation, the SAR transfer feature for the same destination worked as a single thread, so if SAR transfers were duplicated, queuing was used to delay the transfer, but if the upper transport layer required successive SAR transfers, the queue would stack up infinitely. This was solved by discarding existing SAR transmissions when SAR transmissions for the same destination are required.
- In the previous implementation, an ack was sent each time a segment was received for a SAR that had already been successfully received. This has been changed to sending an ACK only once within a certain period.
--- mesh/mesh.c | 45 ++++ mesh/mesh.h | 2 + mesh/net.c | 667 +++++++++++++++++++++++++++++++++++----------------- 3 files changed, 495 insertions(+), 219 deletions(-)
mesh/mesh.c +45 -0
@@ -95,6 +95,41 @@ static struct l_queue *pending_queue;static const char *storage_dir; +struct mesh_sar_transmitter { +uint8_t seg_int_step; +uint8_t unicast_rtx_cnt; +uint8_t unicast_rtx_without_prog_cnt; +uint8_t unicast_rtx_int_step; +uint8_t unicast_rtx_int_inc; +uint8_t multicast_rtx_cnt; +uint8_t multicast_rtx_int_step; +}; + +struct mesh_sar_receiver { +uint8_t seg_threshold; +uint8_t ack_delay_inc; +uint8_t ack_rtx_cnt; +uint8_t discard_timeout; +uint8_t receiver_seg_int_step; +}; + +static struct mesh_sar_transmitter mesh_sar_txr = { + .seg_int_step =5 , + .unicast_rtx_cnt =2 , + .unicast_rtx_without_prog_cnt =2 , + .unicast_rtx_int_step =7 , + .unicast_rtx_int_inc =1 , + .multicast_rtx_cnt =2 , + .multicast_rtx_int_step =8 +}; +static struct mesh_sar_receiver mesh_sar_rxr = { + .seg_threshold =3 , + .ack_delay_inc =1 , + .ack_rtx_cnt =0 , + .discard_timeout =1 , + .receiver_seg_int_step =5 +}; +/* Forward static decalrations */ static void def_attach (struct l_timeout *timeout,void *user_data);static void def_leave (struct l_timeout *timeout,void *user_data);
@@ -203,6 +238,16 @@ uint8_t mesh_get_friend_queue_size(void)return mesh.friend_queue_sz; } +void mesh_get_sar_transmitter (void *sar_txr) +{ +memcpy (sar_txr, &mesh_sar_txr,sizeof (struct mesh_sar_transmitter )); +} + +void mesh_get_sar_receiver (void *sar_rxr) +{ +memcpy (sar_rxr, &mesh_sar_rxr,sizeof (struct mesh_sar_receiver )); +} +static void parse_settings (const char *mesh_conf_fname) {struct l_settings *settings;
mesh/mesh.h +2 -0
@@ -43,3 +43,5 @@ bool mesh_relay_supported(void);bool mesh_friendship_supported (void );uint16_t mesh_get_crpl (void );uint8_t mesh_get_friend_queue_size (void ); +void mesh_get_sar_transmitter (void *sar_txr); +void mesh_get_sar_receiver (void *sar_rxr);
mesh/net.c +448 -219
949 lines not on this page · raw message
Signature · 1 line
2.34.1
RE: mesh: Fix segmentation behavior of Lower transport layer
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=895433
---Test result---
Test Summary:
CheckPatch FAIL 2.40 seconds GitLint FAIL 1.29 seconds BuildEll PASS 24.45 seconds BluezMake FAIL 79.14 seconds MakeCheck FAIL 2038.44 seconds MakeDistcheck FAIL 120.84 seconds CheckValgrind FAIL 59.10 seconds CheckSmatch FAIL 157.81 seconds bluezmakeextell FAIL 64.91 seconds IncrementalBuild FAIL 1490.12 seconds ScanBuild FAIL 748.18 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,1/4] mesh: Implement lower transport layer for segmentation and reassembly
ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - struct mesh_sar_tx *mesh_sar_tx_new() should probably be struct mesh_sar_tx *mesh_sar_tx_new(void) #399: FILE: mesh/net.c:619:
+static struct mesh_sar_tx *mesh_sar_tx_new()
ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - struct mesh_sar_rx *mesh_sar_rx_new() should probably be struct mesh_sar_rx *mesh_sar_rx_new(void) #421: FILE: mesh/net.c:641:
+static struct mesh_sar_rx *mesh_sar_rx_new()
WARNING:LONG_LINE_COMMENT: line length of 93 exceeds 80 columns #902: FILE: mesh/net.c:2207:
+ * [acknowledgment delay increment * segment reception interval]
ERROR:SPACING: space required before the open parenthesis '(' #1003: FILE: mesh/net.c:2283:
+ if(IS_UNICAST(dst)) {
WARNING:LINE_SPACING: Missing a blank line after declarations #1138: FILE: mesh/net.c:3565:
+ bool is_unicast = IS_UNICAST(dst);
+ sar_tx->ack_received = false;
/github/workspace/src/src/13821809.patch total: 3 errors, 2 warnings, 1011 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13821809.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,4/4] mesh: Add features of Segmented Control message WARNING:BRACES: braces {} are not necessary for any arm of this statement #317: FILE: mesh/net.c:2253:
+ if (ctl) {
[...]
+ } else {
[...]
WARNING:LINE_SPACING: Missing a blank line after declarations #469: FILE: mesh/net.c:3482:
+ struct mesh_sar_tx *drop_sar_tx;
+ payload->flags = 0xffffffff >> (31 - segN);
WARNING:LINE_SPACING: Missing a blank line after declarations #494: FILE: mesh/net.c:3507:
+ bool is_unicast = IS_UNICAST(payload->remote);
+ sar_tx->ack_received = false;
/github/workspace/src/src/13821812.patch total: 0 errors, 3 warnings, 584 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13821812.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,1/4] mesh: Implement lower transport layer for segmentation and reassembly
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (81>80): "[BlueZ,1/4] mesh: Implement lower transport layer for segmentation and reassembly"
##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:
tools/mgmt-tester.c: In function ‘main’:tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12725 | int main(int argc, char *argv[])
| ^~~~
unit/test-mesh-crypto.c: In function ‘check_encrypt’:unit/test-mesh-crypto.c:1090:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
|
unit/test-mesh-crypto.c:1090:14: error: ‘SEG_MAX’ undeclared (first use in this function)
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^~~~~~~unit/test-mesh-crypto.c:1090:14: note: each undeclared identifier is reported only once for each function it appears in unit/test-mesh-crypto.c:1100:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1100 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 4);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
| make[1]: *** [Makefile:11270: unit/test_mesh_crypto-test-mesh-crypto.o] Error 1 make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:
unit/test-avdtp.c: In function ‘main’:unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
766 | int main(int argc, char *argv[])
| ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
989 | int main(int argc, char *argv[])
| ^~~~unit/test-mesh-crypto.c: In function ‘check_encrypt’:unit/test-mesh-crypto.c:1090:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
|
unit/test-mesh-crypto.c:1090:14: error: ‘SEG_MAX’ undeclared (first use in this function)
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^~~~~~~unit/test-mesh-crypto.c:1090:14: note: each undeclared identifier is reported only once for each function it appears in unit/test-mesh-crypto.c:1100:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1100 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 4);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
| make[1]: *** [Makefile:11270: unit/test_mesh_crypto-test-mesh-crypto.o] Error 1
make: *** [Makefile:12355: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:
Package cups was not found in the pkg-config search path.
Perhaps you should add the directory containing `cups.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cups' found../../unit/test-mesh-crypto.c: In function ‘check_encrypt’:../../unit/test-mesh-crypto.c:1090:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^
In file included from ../../mesh/crypto.c:21,
from ../../unit/test-mesh-crypto.c:20:
../../mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
|
../../unit/test-mesh-crypto.c:1090:14: error: ‘SEG_MAX’ undeclared (first use in this function)
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^~~~~~~../../unit/test-mesh-crypto.c:1090:14: note: each undeclared identifier is reported only once for each function it appears in ../../unit/test-mesh-crypto.c:1100:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1100 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 4);
| ^
In file included from ../../mesh/crypto.c:21,
from ../../unit/test-mesh-crypto.c:20:
../../mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
| make[4]: *** [Makefile:11270: unit/test_mesh_crypto-test-mesh-crypto.o] Error 1 make[4]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:11924: check-TESTS] Error 2
make[2]: *** [Makefile:12353: check-am] Error 2
make[1]: *** [Makefile:12355: check] Error 2
make: *** [Makefile:12276: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:
tools/mgmt-tester.c: In function ‘main’:tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12725 | int main(int argc, char *argv[])
| ^~~~
unit/test-mesh-crypto.c: In function ‘check_encrypt’:unit/test-mesh-crypto.c:1090:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
|
unit/test-mesh-crypto.c:1090:14: error: ‘SEG_MAX’ undeclared (first use in this function)
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^~~~~~~unit/test-mesh-crypto.c:1090:14: note: each undeclared identifier is reported only once for each function it appears in unit/test-mesh-crypto.c:1100:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1100 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 4);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
| make[1]: *** [Makefile:11270: unit/test_mesh_crypto-test-mesh-crypto.o] Error 1 make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:12355: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
src/shared/crypto.c:271:21: warning: Variable length array is used. src/shared/crypto.c:272:23: warning: Variable length array is used. src/shared/gatt-helpers.c:768:31: warning: Variable length array is used. src/shared/gatt-helpers.c:830:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used. src/shared/gatt-server.c:278:25: warning: Variable length array is used. src/shared/gatt-server.c:618:25: warning: Variable length array is used. src/shared/gatt-server.c:716:25: warning: Variable length array is used. src/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' src/shared/crypto.c:271:21: warning: Variable length array is used. src/shared/crypto.c:272:23: warning: Variable length array is used. src/shared/gatt-helpers.c:768:31: warning: Variable length array is used. src/shared/gatt-helpers.c:830:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used. src/shared/gatt-server.c:278:25: warning: Variable length array is used. src/shared/gatt-server.c:618:25: warning: Variable length array is used. src/shared/gatt-server.c:716:25: warning: Variable length array is used. src/shared/bap.c:288:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' tools/mesh-cfgtest.c:1453:17: warning: unknown escape sequence: '\%'tools/sco-tester.c: note: in included file:./lib/bluetooth.h:219:15: warning: array of flexible structures./lib/bluetooth.h:224:31: warning: array of flexible structurestools/bneptest.c:634:39: warning: unknown escape sequence: '\%'tools/seq2bseq.c:57:26: warning: Variable length array is used.tools/obex-client-tool.c: note: in included file (through /usr/include/readline/readline.h):/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' android/avctp.c:505:34: warning: Variable length array is used.android/avctp.c:556:34: warning: Variable length array is used.unit/test-avrcp.c:373:26: warning: Variable length array is used. unit/test-avrcp.c:398:26: warning: Variable length array is used. unit/test-avrcp.c:414:24: warning: Variable length array is used. android/avrcp-lib.c:1085:34: warning: Variable length array is used. android/avrcp-lib.c:1583:34: warning: Variable length array is used. android/avrcp-lib.c:1612:34: warning: Variable length array is used. android/avrcp-lib.c:1638:34: warning: Variable length array is used. unit/test-mesh-crypto.c:1090:35: error: macro "SEG_MAX" requires 3 arguments, but only 2 given unit/test-mesh-crypto.c:1100:35: error: macro "SEG_MAX" requires 3 arguments, but only 2 given unit/test-mesh-crypto.c: In function ‘check_encrypt’:unit/test-mesh-crypto.c:1090:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
|
unit/test-mesh-crypto.c:1090:14: error: ‘SEG_MAX’ undeclared (first use in this function)
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^~~~~~~unit/test-mesh-crypto.c:1090:14: note: each undeclared identifier is reported only once for each function it appears in unit/test-mesh-crypto.c:1100:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1100 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 4);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
| make[1]: *** [Makefile:11270: unit/test_mesh_crypto-test-mesh-crypto.o] Error 1 make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:
unit/test-mesh-crypto.c: In function ‘check_encrypt’:unit/test-mesh-crypto.c:1090:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
|
unit/test-mesh-crypto.c:1090:14: error: ‘SEG_MAX’ undeclared (first use in this function)
1090 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 8);
| ^~~~~~~unit/test-mesh-crypto.c:1090:14: note: each undeclared identifier is reported only once for each function it appears in unit/test-mesh-crypto.c:1100:54: error: macro "SEG_MAX" requires 3 arguments, but only 2 given
1100 | seg_max = SEG_MAX(keys->segmented, app_msg_len + 4);
| ^
In file included from ./mesh/crypto.c:21,
from unit/test-mesh-crypto.c:20:./mesh/net.h:41: note: macro "SEG_MAX" defined here
41 | #define SEG_MAX(ctl, seg, len) ((ctl) ? CTL_SEG_MAX((seg), (len)) : \
| make[1]: *** [Makefile:11270: unit/test_mesh_crypto-test-mesh-crypto.o] Error 1 make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
##############################
Test: IncrementalBuild - FAIL
Desc: Incremental build with the patches in the series
Output:
[BlueZ,1/4] mesh: Implement lower transport layer for segmentation and reassembly
tools/mgmt-tester.c: In function ‘main’:tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12725 | int main(int argc, char *argv[])
| ^~~~
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
766 | int main(int argc, char *argv[])
| ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
989 | int main(int argc, char *argv[])
| ^~~~mesh/net.c: In function ‘seg_rxed’:mesh/net.c:2156:36: error: unused variable ‘largest’ [-Werror=unused-variable]
2156 | uint32_t expected, this_seg_flag, largest, seqAuth;
| ^~~~~~~mesh/net.c: In function ‘mesh_net_app_send’:mesh/net.c:3483:10: error: unused variable ‘seg’ [-Werror=unused-variable]
3483 | uint8_t seg, seg_max;
| ^~~
mesh/net.c: In function ‘send_next_seg_to’:
mesh/net.c:1838:24: error: ‘interval_ms’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
1838 | sar_tx->seg_timeout = l_timeout_create_ms(interval_ms, send_next_seg_to,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1839 | net, NULL);
| ~~~~~~~~~~ cc1: all warnings being treated as errors
make[1]: *** [Makefile:7872: mesh/net.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
##############################
Test: ScanBuild - FAIL
Desc: Run Scan Build
Output:
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2145:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2153:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3242:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3264:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2145:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2153:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3242:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3264:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
tools/hciattach.c:817:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:865:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:887:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:909:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:930:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:974:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 6)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings generated.
src/oui.c:50:2: warning: Value stored to 'hwdb' is never read
hwdb = udev_hwdb_unref(hwdb);
^ ~~~~~~~~~~~~~~~~~~~~~
src/oui.c:53:2: warning: Value stored to 'udev' is never read
udev = udev_unref(udev);
^ ~~~~~~~~~~~~~~~~
2 warnings generated.
tools/hcidump.c:180:9: warning: Potential leak of memory pointed to by 'dp'
if (fds[i].fd == sock)
^~~
tools/hcidump.c:248:17: warning: Assigned value is garbage or undefined
dh->ts_sec = htobl(frm.ts.tv_sec);
^ ~~~~~~~~~~~~~~~~~~~~
tools/hcidump.c:326:9: warning: 1st function call argument is an uninitialized value
if (be32toh(dp.flags) & 0x02) {
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:341:20: warning: 1st function call argument is an uninitialized value
frm.data_len = be32toh(dp.len);
^~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:346:14: warning: 1st function call argument is an uninitialized value
opcode = be32toh(dp.flags) & 0xffff;
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:384:17: warning: Assigned value is garbage or undefined
frm.data_len = btohs(dh.len);
^ ~~~~~~~~~~~~~
tools/hcidump.c:394:11: warning: Assigned value is garbage or undefined
frm.len = frm.data_len;
^ ~~~~~~~~~~~~
tools/hcidump.c:398:9: warning: 1st function call argument is an uninitialized value
ts = be64toh(ph.ts);
^~~~~~~~~~~~~~
/usr/include/endian.h:51:22: note: expanded from macro 'be64toh'
# define be64toh(x) __bswap_64 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:403:13: warning: 1st function call argument is an uninitialized value
frm.in = be32toh(dp.flags) & 0x01;
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:408:11: warning: Assigned value is garbage or undefined
frm.in = dh.in;
^ ~~~~~
tools/hcidump.c:437:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
fd = open(file, open_flags, 0644);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
11 warnings generated.
tools/rfcomm.c:234:3: warning: Value stored to 'i' is never read
i = execvp(cmdargv[0], cmdargv);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:234:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
i = execvp(cmdargv[0], cmdargv);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:354:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:497:14: warning: Assigned value is garbage or undefined
req.channel = raddr.rc_channel;
^ ~~~~~~~~~~~~~~~~
tools/rfcomm.c:515:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.
src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
3 warnings generated.
tools/ciptool.c:350:7: warning: 5th function call argument is an uninitialized value
sk = do_connect(ctl, dev_id, &src, &dst, psm, (1 << CMTP_LOOPBACK));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/sdptool.c:941:26: warning: Result of 'malloc' is converted to a pointer of type 'uint32_t', which is incompatible with sizeof operand type 'int'
uint32_t *value_int = malloc(sizeof(int));
~~~~~~~~~~ ^~~~~~ ~~~~~~~~~~~
tools/sdptool.c:980:4: warning: 1st function call argument is an uninitialized value
free(allocArray[i]);
^~~~~~~~~~~~~~~~~~~
tools/sdptool.c:3777:2: warning: Potential leak of memory pointed to by 'si.name'
return add_service(0, &si);
^~~~~~~~~~~~~~~~~~~~~~~~~~
tools/sdptool.c:4112:4: warning: Potential leak of memory pointed to by 'context.svc'
return -1;
^~~~~~~~~
4 warnings generated.
tools/avtest.c:225:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:235:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:244:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~tools/avtest.c:258:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~tools/avtest.c:265:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~tools/avtest.c:272:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~tools/avtest.c:279:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~tools/avtest.c:291:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:295:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:304:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:308:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:317:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:324:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:346:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:350:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:359:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:363:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:376:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:380:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:387:4: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:397:4: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:562:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:570:3: warning: Value stored to 'len' is never read
len = write(sk, buf, invalid ? 2 : 3);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:584:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 4 + sizeof(media_transport));
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:597:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:607:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:619:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:634:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:646:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:655:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:662:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:698:2: warning: Value stored to 'len' is never read
len = write(sk, buf, AVCTP_HEADER_LENGTH + sizeof(play_pressed));
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
32 warnings generated.
tools/btproxy.c:836:15: warning: Null pointer passed to 1st parameter expecting 'nonnull'
tcp_port = atoi(optarg);
^~~~~~~~~~~~
tools/btproxy.c:839:8: warning: Null pointer passed to 1st parameter expecting 'nonnull'
if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3))
^~~~~~~~~~~~~~
2 warnings generated.
tools/create-image.c:76:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:84:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:92:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:105:2: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
4 warnings generated.
tools/btgatt-client.c:1824:2: warning: Value stored to 'argv' is never read
argv += optind;
^ ~~~~~~
1 warning generated.
tools/btgatt-server.c:1212:2: warning: Value stored to 'argv' is never read
argv -= optind;
^ ~~~~~~
1 warning generated.
tools/check-selftest.c:42:3: warning: Value stored to 'ptr' is never read
ptr = fgets(result, sizeof(result), fp);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/gatt-service.c:294:2: warning: 2nd function call argument is an uninitialized value
chr_write(chr, value, len);
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/obex-server-tool.c:133:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
data->fd = open(name, O_WRONLY | O_CREAT | O_NOCTTY, 0600);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/obex-server-tool.c:192:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
data->fd = open(name, O_RDONLY | O_NOCTTY, 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
tools/btpclientctl.c:402:3: warning: Value stored to 'bit' is never read
bit = 0;
^ ~
tools/btpclientctl.c:1655:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull'
memcpy(cp->data, ad_data, ad_len);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t'
pElem = malloc(sizeof(uint16_t));
^~~~~~ ~~~~~~~~~~~~~~~~
src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t'
pElem = malloc(sizeof(uint32_t));
^~~~~~ ~~~~~~~~~~~~~~~~
2 warnings generated.
android/avrcp-lib.c:1968:3: warning: 1st function call argument is an uninitialized value
g_free(text[i]);
^~~~~~~~~~~~~~~
1 warning generated.
profiles/health/hdp.c:644:3: warning: Use of memory after it is freed
hdp_tmp_dc_data_unref(dc_data);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:800:19: warning: Use of memory after it is freed
path = g_strdup(chan->path);
^~~~~~~~~~
profiles/health/hdp.c:1779:6: warning: Use of memory after it is freed
hdp_tmp_dc_data_ref(hdp_conn),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:1836:30: warning: Use of memory after it is freed
reply = g_dbus_create_error(data->msg, ERROR_INTERFACE ".HealthError",
^~~~~~~~~
4 warnings generated.
profiles/health/hdp_util.c:1052:2: warning: Use of memory after it is freed
conn_data->func(conn_data->data, gerr);
^~~~~~~~~~~~~~~
1 warning generated.
attrib/gatt.c:970:2: warning: Potential leak of memory pointed to by 'long_write'
return prepare_write(long_write);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t'
pElem = malloc(sizeof(uint16_t));
^~~~~~ ~~~~~~~~~~~~~~~~
src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t'
pElem = malloc(sizeof(uint32_t));
^~~~~~ ~~~~~~~~~~~~~~~~
2 warnings generated.
src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
3 warnings generated.
src/sdp-client.c:353:14: warning: Access to field 'cb' results in a dereference of a null pointer
(*ctxt)->cb = cb;
~~~~~~~~~~~~^~~~
1 warning generated.
src/gatt-database.c:1156:10: warning: Value stored to 'bits' during its initialization is never read
uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING,
^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
gobex/gobex-header.c:95:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull'
memcpy(to, from, count);
^~~~~~~~~~~~~~~~~~~~~~~1 warning generated.gobex/gobex-transfer.c:423:7: warning: Use of memory after it is freed
if (!g_slist_find(transfers, transfer))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.mesh/net.c: In function ‘seg_rxed’:mesh/net.c:2156:36: error: unused variable ‘largest’ [-Werror=unused-variable]
2156 | uint32_t expected, this_seg_flag, largest, seqAuth;
| ^~~~~~~mesh/net.c: In function ‘mesh_net_app_send’:mesh/net.c:3483:10: error: unused variable ‘seg’ [-Werror=unused-variable]
3483 | uint8_t seg, seg_max;
| ^~~cc1: all warnings being treated as errors
make[1]: *** [Makefile:7872: mesh/net.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4690: all] Error 2
---
Regards,
Linux Bluetooth
Hi Junho,
There are some check-patch failures on your patchset.
Can you fix these (and any others you find with check-patch) and resubmit?
The ones below are only from patch 1 of 4... patch 3 applied cleanly, but 2 and 4 also could not be applied until patch 1 is fixed.
Thanks,
Brian
mesh/net.c static bool seg_rxed(struct mesh_net *net, bool frnd, uint32_t iv_index, · line 2207
Quoted 8 lines · Junho Lee
mesh/net.c +7
-1-send_net_ack (net, sar_in, expected); +if (sar->flags == expected) { +/* +* According to MshPRTv1.1: 3.5.3.4, if the destination +* is a unicast address and a segment is received for a +* completed message, it sends one acknowledgment within +* a period of: +* [acknowledgment delay increment * segment reception interval]
WARNING:LONG_LINE_COMMENT: line over 80 characters
#774: FILE: mesh/net.c:2207:
+ * [acknowledgment delay increment * segment reception interval]
mesh/net.c static bool seg_rxed(struct mesh_net *net, bool frnd, uint32_t iv_index, · line 2283
Quoted 7 lines
/* Msg length only definitive on last segment */ if (segO == segN)
mesh/net.c +4
-1- sar_in->len = segN *MAX_SEG_LEN + size; + sar->len = segN *MAX_SEG_LEN + size; + +/* Send ACK only if DST is unicast address. */ +if (IS_UNICAST (dst)) {
ERROR:SPACING: space required before the open parenthesis '(' #875: FILE: mesh/net.c:2283:
+ if(IS_UNICAST(dst)) {
mesh/net.c bool mesh_net_app_send(struct mesh_net *net, bool frnd_cred, uint16_t src, · line 3565
Quoted 7 lines
mesh/net.c +7
-0+* segmented. Flush if it is not segmented or if the transmission +* failed. +*/ +if (result && segmented) { +struct mesh_sar_tx *sar_tx =mesh_sar_tx_new (); +bool is_unicast =IS_UNICAST (dst); + sar_tx->ack_received = false;
WARNING:LINE_SPACING: Missing a blank line after declarations #1010: FILE: mesh/net.c:3565:
+ bool is_unicast = IS_UNICAST(dst);
+ sar_tx->ack_received = false;
Hi Brian,
Quoted 11 lines · Brian Gix
Hi Junho,
There are some check-patch failures on your patchset.
Can you fix these (and any others you find with check-patch) and resubmit? The ones below are only from patch 1 of 4... patch 3 applied cleanly, but 2 and 4 also could not be applied until patch 1 is fixed.
Thanks,
Brian
Sure. I had already fixed that part, but I didn't resubmit it because I was writing in some unit tests as Luiz advised.
I resubmitted it a while ago, so please check it. If I run into any patch issues again, I'll fix it and resubmit.
Quoted 39 lines · Junho Lee
mesh/net.c static bool seg_rxed(struct mesh_net *net, bool frnd, uint32_t iv_index, · line 2207
Quoted 8 lines
mesh/net.c +7
-1-send_net_ack (net, sar_in, expected); +if (sar->flags == expected) { +/* +* According to MshPRTv1.1: 3.5.3.4, if the destination +* is a unicast address and a segment is received for a +* completed message, it sends one acknowledgment within +* a period of: +* [acknowledgment delay increment * segment reception interval] WARNING:LONG_LINE_COMMENT: line over 80 characters
#774: FILE:mesh/net.c:2207:
+ * [acknowledgment delay increment * segment reception interval]mesh/net.c static bool seg_rxed(struct mesh_net *net, bool frnd, uint32_t iv_index, · line 2283
Quoted 7 lines
/* Msg length only definitive on last segment */ if (segO == segN)
mesh/net.c +4
-1- sar_in->len = segN *MAX_SEG_LEN + size; + sar->len = segN *MAX_SEG_LEN + size; + +/* Send ACK only if DST is unicast address. */ +if (IS_UNICAST (dst)) {ERROR:SPACING: space required before the open parenthesis '(' #875: FILE:
mesh/net.c:2283:
+ if(IS_UNICAST(dst)) {mesh/net.c bool mesh_net_app_send(struct mesh_net *net, bool frnd_cred, uint16_t src, · line 3565
Quoted 7 lines
mesh/net.c +7
-0+* segmented. Flush if it is not segmented or if the transmission +* failed. +*/ +if (result && segmented) { +struct mesh_sar_tx *sar_tx =mesh_sar_tx_new (); +bool is_unicast =IS_UNICAST (dst); + sar_tx->ack_received = false;WARNING:LINE_SPACING: Missing a blank line after declarations #1010: FILE:
mesh/net.c:3565:
+ boolis_unicast=IS_UNICAST(dst);
+sar_tx->ack_received= false;