Skip to contentSkip to conversation

mesh: Fix segmentation behavior of Lower transport layer

PATCH Superseded Junho Lee 3 participants 4 messages Oct 4, 2024 – Oct 11, 2024 Bluetooth drivers

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Junho Lee

author
#0 lore raw

cover mesh: Fix segmentation behavior of Lower transport layer

These is implementations of segmentation and reassembly, except for the friend feature for LPN nodes, implemented according to Mesh Protocol 1.1 section 3.5.

Junho Lee (4):
mesh: Implement lower transport layer for segmentation and reassembly
mesh: Add mesh conf for SAR Transmitter and Receiver
mesh: Fix inserting NULL into bool type arguments to false
mesh: Add features of Segmented Control message

 mesh/crypto.c       |  69 ++--
 mesh/mesh-main.conf | 107 ++++++
 mesh/mesh.c         | 125 ++++++-
 mesh/mesh.h         |   2 +
 mesh/net.c          | 868 ++++++++++++++++++++++++++++++--------------
 mesh/net.h          |  33 +-
 6 files changed, 881 insertions(+), 323 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

Hi,

Quoted 19 lines · Junho Lee

These is implementations of segmentation and reassembly, except for the friend feature for LPN nodes, implemented according to Mesh Protocol 1.1 section 3.5.

Junho Lee (4):
mesh: Implement lower transport layer for segmentation and reassembly
mesh: Add mesh conf for SAR Transmitter and Receiver
mesh: Fix inserting NULL into bool type arguments to false
mesh: Add features of Segmented Control message

 mesh/crypto.c       |  69 ++--
 mesh/mesh-main.conf | 107 ++++++
 mesh/mesh.c         | 125 ++++++-
 mesh/mesh.h         |   2 +
 mesh/net.c          | 868 ++++++++++++++++++++++++++++++--------------
 mesh/net.h          |  33 +-
 6 files changed, 881 insertions(+), 323 deletions(-)
Quoted 4 lines

--
2.34.1

Lets see if Brian has some free time to review this set, one thing that might help in the future is if we do some unit testing to cover the testing spec, it is probably a lot of work but I think we add them over time, with that it would be a lot easier to check if something breaks.

Signature · 1 line
Luiz Augusto von Dentz
author
#2 lore raw

Hi,

Sorry, resending with a bad cc.

Quoted 27 lines · Luiz Augusto von Dentz

Hi,

Quoted 19 lines · Junho Lee

These is implementations of segmentation and reassembly, except for the friend feature for LPN nodes, implemented according to Mesh Protocol 1.1 section 3.5.

Junho Lee (4):
mesh: Implement lower transport layer for segmentation and reassembly
mesh: Add mesh conf for SAR Transmitter and Receiver
mesh: Fix inserting NULL into bool type arguments to false
mesh: Add features of Segmented Control message

 mesh/crypto.c       |  69 ++--
 mesh/mesh-main.conf | 107 ++++++
 mesh/mesh.c         | 125 ++++++-
 mesh/mesh.h         |   2 +
 mesh/net.c          | 868 ++++++++++++++++++++++++++++++--------------
 mesh/net.h          |  33 +-
 6 files changed, 881 insertions(+), 323 deletions(-)
Quoted 4 lines

--
2.34.1

Quoted 8 lines

Lets see if Brian has some free time to review this set, one thing that might help in the future is if we do some unit testing to cover the testing spec, it is probably a lot of work but I think we add them over time, with that it would be a lot easier to check if something breaks.

Signature · 1 line
Luiz Augusto von Dentz

Thanks for your reply. I agree with what you said. If so, what is something I should or can do? I hope this commit can be approved, as the existing code is actually causing performance issues.

Regards,
Junho Lee

#3 lore raw

I’m sorry, I was away on holiday until earlier this week. I will review these patches this weekend.

Quoted 49 lines · Junho Lee

Hi,

Sorry, resending with a bad cc.

Quoted 28 lines · Luiz Augusto von Dentz

Hi,

Quoted 20 lines · Junho Lee

These is implementations of segmentation and reassembly, except for the friend feature for LPN nodes, implemented according to Mesh Protocol 1.1 section 3.5.

Junho Lee (4):
mesh: Implement lower transport layer for segmentation and reassembly
mesh: Add mesh conf for SAR Transmitter and Receiver
mesh: Fix inserting NULL into bool type arguments to false
mesh: Add features of Segmented Control message

mesh/crypto.c       |  69 ++--
mesh/mesh-main.conf | 107 ++++++
mesh/mesh.c         | 125 ++++++-
mesh/mesh.h         |   2 +
mesh/net.c          | 868 ++++++++++++++++++++++++++++++--------------
mesh/net.h          |  33 +-
6 files changed, 881 insertions(+), 323 deletions(-)
Quoted 4 lines

--
2.34.1

Quoted 8 lines

Lets see if Brian has some free time to review this set, one thing that might help in the future is if we do some unit testing to cover the testing spec, it is probably a lot of work but I think we add them over time, with that it would be a lot easier to check if something breaks.

--
Luiz Augusto von Dentz

Thanks for your reply. I agree with what you said. If so, what is something I should or can do? I hope this commit can be approved, as the existing code is actually causing performance issues.

Regards,
Junho Lee