Skip to contentSkip to conversation

Should MODULE_DESCRIPTION be mandatory ?

DISCUSSION [email protected] 2 participants 2 messages Apr 15, 2009 – Apr 16, 2009

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

on x86_64 allmodconfig (2.6.30-rc2), here are the "missing"s that are reported:

WARNING: modpost: missing MODULE_DESCRIPTION() in Documentation/filesystems/configfs/configfs_example_explicit.o
WARNING: modpost: missing MODULE_DESCRIPTION() in Documentation/filesystems/configfs/configfs_example_macros.o
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/ia32/ia32_aout.o

Quoted 12 lines
Quoted 3 lines

...
We need to bring that list down before we apply the patch. Is it worth it?

I see 424 modules without MODULE_DESCRIPTION (in the list above) and 3127 .c files that contain "MODULE_DESCRIPTION".

To me it's a Nice to have but not Required. (i.e., not worth it IMO)

Signature · 1 line
~Randy

i can offer spending an afternoon (or more) on compiling a list of modulenames + missing description for review. if that list is complete and ack`ed, i could create a patch or patch series from that.
(maybe the list could be split into logical parts, too)

would that be welcomed ?

roland

____________________________________________________________________
Psssst! Schon vom neuen WEB.DE MultiMessenger gehört?
Der kann`s mit allen: http://www.produkte.web.de/messenger/?did=3123

#1 lore raw
Quoted 5 lines
Quoted 1 line

i can offer spending an afternoon (or more) on compiling a list of modulenames + missing description for review. if that list is complete and ack`ed, i could create a patch or patch series from that.
(maybe the list could be split into logical parts, too)

If you do this then you should feed the patches via the maintainers. I suggest to start out with the network stuff and see if netdev/David Miller will take them.

Sam