Skip to contentSkip to conversation

dhcp command not populating dnsip environment variable

U-Boot Duncan Hare 2 participants 5 messages Mar 15, 2018 – Mar 16, 2018

lore
Share & tools
lore
#0 lore raw

In the latest version of u-boot, the dhcp command appears not to populate the environment variable dnsip. This used to be the behaviour.

The dns command works, if dnsip is populated manually.

Is the a Kconfig variable controlling this? Or is there a new environment variable?

Thanks

Duncan Hare

#1 lore raw
Quoted 2 lines · Duncan Hare

In the latest version of u-boot, the dhcp command appears not to populate the environment variable dnsip. This used to be the behaviour.

Is it possible that your DHCP server isn't sending it? It seems like the code isn't changed.

Quoted 13 lines

The dns command works, if dnsip is populated manually.

Is the a Kconfig variable controlling this? Or is there a new environment variable?

Thanks

Duncan Hare
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#2 lore raw

From: Joe Hershberger <[email protected]>
To: Duncan Hare <[email protected]>
Cc: u-boot <[email protected]>; Joe Hershberger <[email protected]>
Sent: Thursday, March 15, 2018 1:29 PM
Subject: Re: [U-Boot] dhcp command not populating dnsip environment variable

Quoted 2 lines · Duncan Hare

In the latest version of u-boot, the dhcp command appears not to populate the environment variable dnsip. This used to be the behaviour.

Is it possible that your DHCP server isn't sending it? It seems like the code isn't changed.

Quoted 6 lines

The dns command works, if dnsip is populated manually.

Is the a Kconfig variable controlling this? Or is there a new environment variable?

Quoted 7 lines

Thanks

Duncan Hare
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Joe
Thanks, you gave me an idea.

I fired up wireshark
See attached.

Old release: Before Kconfig work options requested (many) including DNS server address

After: No options

I see no where in u-boot to set DHCP options.

Kconfig is a good idea. HOWEVER, the previous defaults should be selected as the base set. Choosing The NULL set is a very unfriendly choice.

What do we do to resolve this?
 Duncan Hare

714 931 7952

#3 lore raw
In reply to Joe Hershberger
Quoted 2 lines · Duncan Hare

In the latest version of u-boot, the dhcp command appears not to populate the environment variable dnsip. This used to be the behaviour.

 _______________________________________________
The bootp.c code was changed with the addition of Kconfig control of Bootp.c (of which dhcp is a part).There does not appear to be the cond in net/ Kconfig to manage the Bootp config in menuconfig. The change log at the top of bootp.c has no note to indicate the module was changed.
Adding the note would appears to be the proper process.
How many other source code modules have been changed without a change note?Finding this has taken two or three days.
I can find no entries in .config nor in menuconfig to configure the bootp options.

Would you like me to prepare a patch for net/Kconfig? Duncan Hare

#4 lore raw

Hi Duncan,

Quoted 8 lines · Duncan Hare
Quoted 2 lines · Duncan Hare

In the latest version of u-boot, the dhcp command appears not to populate the environment variable dnsip. This used to be the behaviour.

_______________________________________________
The bootp.c code was changed with the addition of Kconfig control of Bootp.c (of which dhcp is a part).There does not appear to be the cond in net/ Kconfig to manage the Bootp config in menuconfig.

Are you referring to commit 3b3ea2c56ec4bc5588281fd103c744e608f8b25c ("Kconfig: cmd: Make networking command dependent on NET")?

Quoted 4 lines

The change log at the top of bootp.c has no note to indicate the module was changed.
Adding the note would appears to be the proper process.
How many other source code modules have been changed without a change note?Finding this has taken two or three days. I can find no entries in .config nor in menuconfig to configure the bootp options.

commit d021e942107a1f7304a879cec99286ca462f7be3 ("Convert CONFIG_BOOTP_BOOTPATH et al to Kconfig") moved CONFIG_BOOTP_DNS, but not CONFIG_BOOTP_DNS2 for some reason. The README was changed to delete the description of both, though.

Quoted 1 line

Would you like me to prepare a patch for net/Kconfig?

Sure, that sounds great.

Quoted 1 line

Duncan Hare

Thanks,
-Joe