Skip to contentSkip to conversation

ASoC: dt-bindings: ti,pcm1862: convert to dtschema

PATCH Superseded Ranganath V N 2 participants 2 messages Nov 4, 2025

Subsystems (3)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 ASoC: dt-bindings: ti,pcm1862: convert to dtschema

convert the Texas Instruments PCM186x Universal audio ADC bindings to DT schema.
Added the #sound-dai-cells as per the framework.

---
Convert the Texas Instruments PCM186x audio ADC bindings to DT schema.
---
Changes in v6:
- Corrected the Subject Asoc->ASoC, dt_bindings -> dt-bindings and ti,pcm186x -> ti,pcm1862
- Updated the commit message.
- added the missed Description from the old binding.
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Resolved previous patch warnings/errors
- dtschema/dtc warnings/errors:
- /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/ti,pcm1862.yaml:
- $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
- $id: http://devicetree.org/schemas/sound/ti,pcm186x.yaml
- file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/ti,pcm1862.yaml
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Corrected subject dt_bindings:sound to Asoc: dt_bindings:
- Corrected the filename to match one of the compitables in the file
- ti,pcm186x.yaml to ti,pcm1862.yaml
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Unicode FEFF character was present in the begining of the file,
- Removed unicode character.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Fixes as per the reviews suggested for the v1.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../devicetree/bindings/sound/pcm186x.txt          | 42 ------------
 .../devicetree/bindings/sound/ti,pcm1862.yaml      | 76 ++++++++++++++++++++++
 2 files changed, 76 insertions(+), 42 deletions(-)
Documentation/devicetree/bindings/sound/pcm186x.txt deleted +0 -42
deleted file mode 100644
index 1087f4855980..000000000000
@@ -1,42 +0,0 @@
-Texas Instruments PCM186x Universal Audio ADC
-
-These devices support both I2C and SPI (configured with pin strapping
-on the board).
-
-Required properties:
-
- - compatible : "ti,pcm1862",
-                "ti,pcm1863",
-                "ti,pcm1864",
-                "ti,pcm1865"
-
- - reg : The I2C address of the device for I2C, the chip select
-         number for SPI.
-
- - avdd-supply: Analog core power supply (3.3v)
- - dvdd-supply: Digital core power supply
- - iovdd-supply: Digital IO power supply
-        See regulator/regulator.txt for more information
-
-CODEC input pins:
- * VINL1
- * VINR1
- * VINL2
- * VINR2
- * VINL3
- * VINR3
- * VINL4
- * VINR4
-
-The pins can be used in referring sound node's audio-routing property.
-
-Example:
-
-	pcm186x: audio-codec@4a {
-		compatible = "ti,pcm1865";
-		reg = <0x4a>;
-
-		avdd-supply = <&reg_3v3_analog>;
-		dvdd-supply = <&reg_3v3>;
-		iovdd-supply = <&reg_1v8>;
-	};
Documentation/devicetree/bindings/sound/ti,pcm1862.yaml new file +76 -0

76 lines not on this page · raw message

---
base-commit: 211ddde0823f1442e4ad052a2f30f050145ccada
change-id: 20251021-dtbs-3a31f699c461

Best regards,

Signature · 1 line
Ranganath V N <[email protected]>
#1 lore raw
Quoted 3 lines · Ranganath V N

convert the Texas Instruments PCM186x Universal audio ADC bindings to DT schema.
Added the #sound-dai-cells as per the framework.

Last sentence makes no sense. Framework tells me nothing about the hardware. I actually do not know what framework you are talking about.

I gave you hint how to justify a change in the bindings ("If this is DAI, then you miss ref to dai-common and use").

Best regards,
Krzysztof