Bluetooth: Unnecessary braces around single line statment.
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Bluetooth: Unnecessary braces around single line statment.
From: Jeremy Clifton <[email protected]>
Warning found with checkpatch.pl script. Removed unnecessary braces.
--- drivers/bluetooth/bfusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/bluetooth/bfusb.c +1 -2
@@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) buf +=3 ; } -if (count < len) { +if (count < len)bt_dev_err (data->hdev,"block extends over URB buffer ranges" ); - }if ((hdr &0xe1 ) ==0xc1 )bfusb_recv_block (data, hdr, buf, len);
Signature · 1 line
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=928341
---Test result---
Test Summary:
CheckPatch PENDING 0.38 seconds GitLint PENDING 0.29 seconds SubjectPrefix PASS 0.08 seconds BuildKernel PASS 24.18 seconds CheckAllWarning PASS 27.35 seconds CheckSparse PASS 29.96 seconds BuildKernel32 PASS 23.86 seconds TestRunnerSetup PASS 428.25 seconds TestRunner_l2cap-tester PASS 24.14 seconds TestRunner_iso-tester PASS 29.51 seconds TestRunner_bnep-tester PASS 4.79 seconds TestRunner_mgmt-tester PASS 119.15 seconds TestRunner_rfcomm-tester PASS 7.47 seconds TestRunner_sco-tester PASS 9.27 seconds TestRunner_ioctl-tester PASS 7.89 seconds TestRunner_mesh-tester PASS 5.93 seconds TestRunner_smp-tester PASS 6.85 seconds TestRunner_userchan-tester PASS 4.94 seconds IncrementalBuild PENDING 1.12 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
Dear Jeremy,
Thank you for your patch. Could you please make the summary/title a statement, and remove the dot/period at the end:
Bluetooth: Remove unnecessary braces around single line statement
Am 25.01.25 um 17:58 schrieb [email protected]:
Quoted 3 lines
From: Jeremy Clifton <[email protected]>
Warning found with checkpatch.pl script. Removed unnecessary braces.
I’d use imperative mood for the second sentence:
Remove unnecessary braces.
Also please add a Fixes: tag.
Quoted 10 lines
Signed-off-by Jeremy Clifton <[email protected]>--- drivers/bluetooth/bfusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/bluetooth/bfusb.c +0
-0
drivers/bluetooth/bfusb.c static void bfusb_rx_complete(struct urb *urb) · line 372
Quoted 10 lines
drivers/bluetooth/bfusb.c +1
-2@@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) buf +=3 ; } -if (count < len) { +if (count < len)bt_dev_err (data->hdev,"block extends over URB buffer ranges" ); - }if ((hdr &0xe1 ) ==0xc1 )bfusb_recv_block (data, hdr, buf, len);
Kind regards,
Paul
Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement
Dear Paul,
I have changed the subject.
Quoted 44 lines · Paul Menzel
Dear Jeremy,
Thank you for your patch. Could you please make the summary/title a statement, and remove the dot/period at the end:
Bluetooth: Remove unnecessary braces around single line statement
Am 25.01.25 um 17:58 schrieb [email protected]:
Quoted 3 lines
From: Jeremy Clifton <[email protected]>
Warning found with checkpatch.pl script. Removed unnecessary braces.
I’d use imperative mood for the second sentence:
Remove unnecessary braces.
Also please add a Fixes: tag.
Quoted 10 lines
Signed-off-by Jeremy Clifton <[email protected]>--- drivers/bluetooth/bfusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/bluetooth/bfusb.c +0
-0drivers/bluetooth/bfusb.c static void bfusb_rx_complete(struct urb *urb) · line 370
Quoted 8 lines
drivers/bluetooth/bfusb.c +1
-2@@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) buf +=3 ; } -if (count < len) { +if (count < len)bt_dev_err (data->hdev,"block extends over URB buffer ranges" ); - }if ((hdr &0xe1 ) ==0xc1 )bfusb_recv_block (data, hdr, buf, len);Reviewed-by Paul Menzel <[email protected]>Kind regards,
Paul
Re: Bluetooth: Remove unnecessary braces around single line statement
Quoted 3 lines
I have changed the subject.
Fixes Coding style, unnecessary braces
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145
Is such a tag really relevant for a coding style adjustment?
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
Regards,
Markus
Re: Bluetooth: Remove unnecessary braces around single line statement
Quoted 2 lines · Markus Elfring
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145
I read it.
Quoted 1 line
Is such a tag really relevant for a coding style adjustment?
Is it? I think it would work. So before I submit my patch I'll need to add a Fixes: line. I have already edited my commit message. How can I find the SHA-1code of my commit from 1-25
Luiz Augusto von Dentz
maintainerRe: Bluetooth: Remove unnecessary braces around single line statement
Hi Jeremy,
Quoted 11 lines · Jeremy Dean
Quoted 2 lines · Markus Elfring
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145I read it.
Quoted 1 line
Is such a tag really relevant for a coding style adjustment?
Is it? I think it would work. So before I submit my patch I'll need to add a Fixes: line. I have already edited my commit message. How can I find the SHA-1code of my commit from 1-25
I normally don't require Fixes tag for coding style adjustments submitted to bluetooth-next, these are not typically backported since there is no change on the logic or final binary.
Signature · 1 line
Luiz Augusto von Dentz
Re: Bluetooth: Remove unnecessary braces around single line statement
On Mon, Jan 27, 2025 at 04:38:22PM -0500, Luiz Augusto von Dentz wrote:
Luiz,
Quoted 3 lines
I normally don't require Fixes tag for coding style adjustments submitted to bluetooth-next, these are not typically backported since there is no change on the logic or final binary.
And so the only thing you need is the subject/title rewritten?
Regards, Jeremy
Luiz Augusto von Dentz
maintainerRe: Bluetooth: Remove unnecessary braces around single line statement
Hi Jeremy,
Quoted 9 lines · Jeremy Dean
On Mon, Jan 27, 2025 at 04:38:22PM -0500, Luiz Augusto von Dentz wrote:
Luiz,Quoted 3 lines
I normally don't require Fixes tag for coding style adjustments submitted to bluetooth-next, these are not typically backported since there is no change on the logic or final binary.
And so the only thing you need is the subject/title rewritten?
Are referring to:
https://patchwork.kernel.org/project/bluetooth/patch/[email protected]/?
Id just include the output of checkpatch and perhaps reword it to something like:
Bluetooth: Fix code style warning
Subject should be short so it fits on 80 columns, the description can have output of things like checkpatch, compiler warnings, etc, but otherwise also limit to 80 columns or rather 72 since git log does add its own indentation.
Quoted 1 line
Regards, Jeremy
Signature · 1 line
Luiz Augusto von Dentz
Re: Bluetooth: Remove unnecessary braces around single line statement
On Mon, Jan 27, 2025 at 05:02:22PM -0500, Luiz Augusto von Dentz wrote:
Luiz,
Quoted 8 lines
Are referring to:
https://patchwork.kernel.org/project/bluetooth/patch/[email protected]/?
Id just include the output of checkpatch and perhaps reword it to something like:
Bluetooth: Fix code style warning
I could not find a way to change the subject/title to remove the typo in my first patch submision. For this reason I created a new patch it can be found at the following link:
https://patchwork.kernel.org/project/bluetooth/patch/[email protected]/
This submission is perferred because it removes the typo.
The question remains: How do I close this patch submission?
Jeremy D C
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Sat, 25 Jan 2025 17:58:02 +0100 you wrote:
From: Jeremy Clifton <[email protected]>
Warning found with checkpatch.pl script. Removed unnecessary braces.
Signed-off-by Jeremy Clifton <[email protected]>--- drivers/bluetooth/bfusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
- Bluetooth: Unnecessary braces around single line statment.
https://git.kernel.org/bluetooth/bluetooth-next/c/a2a245849af8
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html