general protection fault in native_tss_update_io_bitmap
Subsystems (3)
syzbot
syzbotHello,
syzbot found the following issue on:
HEAD commit: e5d3fd687aac Add linux-next specific files for 20250218 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13fcd7f8580000 kernel config: https://syzkaller.appspot.com/x/.config?x=4e945b2fe8e5992f dashboard link: https://syzkaller.appspot.com/bug?extid=e2b1803445d236442e54 compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=149427a4580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11ed06e4580000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ef079ccd2725/disk-e5d3fd68.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/99f2123d6831/vmlinux-e5d3fd68.xz
kernel image: https://storage.googleapis.com/syzbot-assets/eadfc9520358/bzImage-e5d3fd68.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] CPU: 1 UID: 0 PID: 5891 Comm: iou-sqp-5889 Not tainted 6.14.0-rc3-next-20250218-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 RIP: 0010:native_tss_update_io_bitmap+0x1f5/0x640 arch/x86/kernel/process.c:471 Code: ff df 48 89 44 24 50 42 80 3c 38 00 74 08 48 89 df e8 cf 75 c7 00 48 89 5c 24 58 4c 8b 2b 4c 89 f0 48 c1 e8 03 48 89 44 24 48 <42> 80 3c 38 00 74 08 4c 89 f7 e8 ac 75 c7 00 49 8b 1e 4c 89 ef 48 RSP: 0018:ffffc900042cf280 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffff8880b870a068 RCX: dffffc0000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: ffffc900042cf380 R08: ffffffff81620a34 R09: 1ffff1100fbacb40 R10: dffffc0000000000 R11: ffffed100fbacb41 R12: 1ffff92000859e5c R13: 0000000000000014 R14: 0000000000000000 R15: dffffc0000000000 FS: 0000555565746480(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f62e5469170 CR3: 000000002a054000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> task_update_io_bitmap+0xb8/0xf0 arch/x86/kernel/ioport.c:47 io_bitmap_exit+0x62/0xf0 arch/x86/kernel/ioport.c:57 exit_thread+0x76/0xa0 arch/x86/kernel/process.c:123 copy_process+0x277d/0x3cf0 kernel/fork.c:2638 create_io_thread+0x16a/0x1e0 kernel/fork.c:2746 create_io_worker+0x176/0x540 io_uring/io-wq.c:862 io_wq_create_worker io_uring/io-wq.c:332 [inline] io_wq_enqueue+0x7b5/0xa00 io_uring/io-wq.c:989 io_queue_iowq+0x433/0x670 io_uring/io_uring.c:542 io_submit_state_end io_uring/io_uring.c:2215 [inline] io_submit_sqes+0x1940/0x1cf0 io_uring/io_uring.c:2335 __io_sq_thread io_uring/sqpoll.c:189 [inline] io_sq_thread+0xc8c/0x1fd0 io_uring/sqpoll.c:312 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:148 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245 </TASK> Modules linked in: ---[ end trace 0000000000000000 ]--- RIP: 0010:native_tss_update_io_bitmap+0x1f5/0x640 arch/x86/kernel/process.c:471 Code: ff df 48 89 44 24 50 42 80 3c 38 00 74 08 48 89 df e8 cf 75 c7 00 48 89 5c 24 58 4c 8b 2b 4c 89 f0 48 c1 e8 03 48 89 44 24 48 <42> 80 3c 38 00 74 08 4c 89 f7 e8 ac 75 c7 00 49 8b 1e 4c 89 ef 48 RSP: 0018:ffffc900042cf280 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffff8880b870a068 RCX: dffffc0000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: ffffc900042cf380 R08: ffffffff81620a34 R09: 1ffff1100fbacb40 R10: dffffc0000000000 R11: ffffed100fbacb41 R12: 1ffff92000859e5c R13: 0000000000000014 R14: 0000000000000000 R15: dffffc0000000000 FS: 0000555565746480(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f62e5469170 CR3: 000000002a054000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 ---------------- Code disassembly (best guess), 1 bytes skipped: 0: df 48 89 fisttps -0x77(%rax) 3: 44 24 50 rex.R and $0x50,%al 6: 42 80 3c 38 00 cmpb $0x0,(%rax,%r15,1) b: 74 08 je 0x15 d: 48 89 df mov %rbx,%rdi 10: e8 cf 75 c7 00 call 0xc775e4 15: 48 89 5c 24 58 mov %rbx,0x58(%rsp) 1a: 4c 8b 2b mov (%rbx),%r13 1d: 4c 89 f0 mov %r14,%rax 20: 48 c1 e8 03 shr $0x3,%rax 24: 48 89 44 24 48 mov %rax,0x48(%rsp) * 29: 42 80 3c 38 00 cmpb $0x0,(%rax,%r15,1) <-- trapping instruction 2e: 74 08 je 0x38 30: 4c 89 f7 mov %r14,%rdi 33: e8 ac 75 c7 00 call 0xc775e4 38: 49 8b 1e mov (%r14),%rbx 3b: 4c 89 ef mov %r13,%rdi 3e: 48 rex.W
---
This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at [email protected].
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
Jens Axboe
maintainerQuoted 18 lines · syzbot
Hello,
syzbot found the following issue on:
HEAD commit: e5d3fd687aac Add linux-next specific files for 20250218 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13fcd7f8580000 kernel config: https://syzkaller.appspot.com/x/.config?x=4e945b2fe8e5992f dashboard link: https://syzkaller.appspot.com/bug?extid=e2b1803445d236442e54 compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=149427a4580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11ed06e4580000Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ef079ccd2725/disk-e5d3fd68.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/99f2123d6831/vmlinux-e5d3fd68.xz
kernel image: https://storage.googleapis.com/syzbot-assets/eadfc9520358/bzImage-e5d3fd68.xz
Quoted 8 lines
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by [email protected]Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] CPU: 1 UID: 0 PID: 5891 Comm: iou-sqp-5889 Not tainted 6.14.0-rc3-next-20250218-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 RIP: 0010:native_tss_update_io_bitmap+0x1f5/0x640 arch/x86/kernel/process.c:471
This doesn't look io_uring related at all, it looks more like something missing for error injection and early failure handling in the fork path for the x86 io bitmap handling. Possibly related to PF_IO_WORKER, didn't poke deep enough to see if it's specific to that or not. Presumably a change slated for 6.15? It's testing an older linux-next, so also quite possible that this is known and already fixed, it's a week old.
#syz set subsystems: kernel
Signature · 1 line
Jens Axboe
PATCH 1/1 x86/iopl: Cure TIF_IO_BITMAP inconsistencies
In reply to syzbotio_bitmap_exit() is invoked from exit_thread() when a task exists or when a fork fails. In the latter case the exit_thread() cleans up resources which were allocated during fork().
io_bitmap_exit() invokes task_update_io_bitmap(), which in turn ends up in tss_update_io_bitmap(). tss_update_io_bitmap() operates on the current task. If current has TIF_IO_BITMAP set, but no bitmap installed, tss_update_io_bitmap() crashes with a NULL pointer dereference.
There are two issues, which lead to that problem:
1) io_bitmap_exit() should not invoke task_update_io_bitmap() when the task, which is cleaned up, is not the current task. That's a clear indicator for a cleanup after a failed fork().
2) A task should not have TIF_IO_BITMAP set and neither a bitmap installed nor IOPL emulation level 3 activated.
This happens, when a kernel thread is created in the context of a user space thread, which has TIF_IO_BITMAP set as the thread flags are copied and the IO bitmap pointer is cleared.
Other than in the failed fork() case this has no impact because kernel threads including IO workers never return to user space and therefore never invoke tss_update_io_bitmap().
Cure this by adding the missing cleanups and checks:
1) Prevent io_bitmap_exit() to invoke task_update_io_bitmap() if the to be cleaned up task is not the current task.
2) Clear TIF_IO_BITMAP in copy_thread() unconditionally. For user space forks it is set later, when the IO bitmap is inherited in io_bitmap_share().
For paranoia sake, add a warning into tss_update_io_bitmap() to catch the case, when that code is invoked with inconsistent state.
---
arch/x86/kernel/ioport.c +9 -4
@@ -33,8 +33,9 @@ void io_bitmap_share(struct task_structset_tsk_thread_flag (tsk,TIF_IO_BITMAP ); } -static void task_update_io_bitmap (struct task_struct *tsk) +static void task_update_io_bitmap (void ) { +struct task_struct *tsk = current;struct thread_struct *t = &tsk->thread;if (t->iopl_emul ==3 || t->io_bitmap) {
@@ -54,7 +55,12 @@ void io_bitmap_exit(struct task_struct *struct io_bitmap *iobm = tsk->thread.io_bitmap; tsk->thread.io_bitmap =NULL ; -task_update_io_bitmap (tsk); +/* +* Don't touch the TSS when invoked on a failed fork(). TSS +* reflects the state of @current and not the state of @tsk. +*/ +if (tsk == current) +task_update_io_bitmap ();if (iobm &&refcount_dec_and_test (&iobm->refcnt))kfree (iobm); }
@@ -192,8 +198,7 @@ SYSCALL_DEFINE1(iopl, unsigned int, leve } t->iopl_emul = level; -task_update_io_bitmap (current); - +task_update_io_bitmap ();return 0 ; }
arch/x86/kernel/process.c +6 -0
@@ -176,6 +176,7 @@ int copy_thread(struct task_struct *p, c frame->ret_addr = (unsigned long ) ret_from_fork_asm; p->thread.sp = (unsigned long ) fork_frame; p->thread.io_bitmap =NULL ; +clear_tsk_thread_flag (p,TIF_IO_BITMAP ); p->thread.iopl_warn =0 ;memset (p->thread.ptrace_bps,0 ,sizeof (p->thread.ptrace_bps));
@@ -464,6 +465,11 @@ void native_tss_update_io_bitmap(void) }else {struct io_bitmap *iobm = t->io_bitmap; +if (WARN_ON_ONCE (!iobm)) { +clear_thread_flag (TIF_IO_BITMAP ); +native_tss_invalidate_io_bitmap (); + } +/* * Only copy bitmap data when the sequence number differs. The * update time is accounted to the incoming task.
[tip: x86/urgent] x86/iopl: Cure TIF_IO_BITMAP inconsistencies
The following commit has been merged into the x86/urgent branch of tip:
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 8b68e978718f14fdcb080c2a7791c52a0d09bc6d Gitweb: https://git.kernel.org/tip/8b68e978718f14fdcb080c2a7791c52a0d09bc6d Author: Thomas Gleixner <[email protected]> AuthorDate: Wed, 26 Feb 2025 16:01:57 +01:00 Committer: Borislav Petkov (AMD) <[email protected]> CommitterDate: Tue, 03 Jun 2025 15:56:39 +02:00
x86/iopl: Cure TIF_IO_BITMAP inconsistencies
io_bitmap_exit() is invoked from exit_thread() when a task exists or when a fork fails. In the latter case the exit_thread() cleans up resources which were allocated during fork().
io_bitmap_exit() invokes task_update_io_bitmap(), which in turn ends up in tss_update_io_bitmap(). tss_update_io_bitmap() operates on the current task. If current has TIF_IO_BITMAP set, but no bitmap installed, tss_update_io_bitmap() crashes with a NULL pointer dereference.
There are two issues, which lead to that problem:
1) io_bitmap_exit() should not invoke task_update_io_bitmap() when the task, which is cleaned up, is not the current task. That's a clear indicator for a cleanup after a failed fork().
2) A task should not have TIF_IO_BITMAP set and neither a bitmap installed nor IOPL emulation level 3 activated.
This happens when a kernel thread is created in the context of a user space thread, which has TIF_IO_BITMAP set as the thread flags are copied and the IO bitmap pointer is cleared.
Other than in the failed fork() case this has no impact because kernel threads including IO workers never return to user space and therefore never invoke tss_update_io_bitmap().
Cure this by adding the missing cleanups and checks:
1) Prevent io_bitmap_exit() to invoke task_update_io_bitmap() if the to be cleaned up task is not the current task.
2) Clear TIF_IO_BITMAP in copy_thread() unconditionally. For user space forks it is set later, when the IO bitmap is inherited in io_bitmap_share().
For paranoia sake, add a warning into tss_update_io_bitmap() to catch the case, when that code is invoked with inconsistent state.
--- arch/x86/kernel/ioport.c | 13 +++++++++---- arch/x86/kernel/process.c | 6 ++++++ 2 files changed, 15 insertions(+), 4 deletions(-)
arch/x86/kernel/ioport.c +9 -4
@@ -33,8 +33,9 @@ void io_bitmap_share(struct task_struct *tsk)set_tsk_thread_flag (tsk,TIF_IO_BITMAP ); } -static void task_update_io_bitmap (struct task_struct *tsk) +static void task_update_io_bitmap (void ) { +struct task_struct *tsk = current;struct thread_struct *t = &tsk->thread;if (t->iopl_emul ==3 || t->io_bitmap) {
@@ -54,7 +55,12 @@ void io_bitmap_exit(struct task_struct *tsk)struct io_bitmap *iobm = tsk->thread.io_bitmap; tsk->thread.io_bitmap =NULL ; -task_update_io_bitmap (tsk); +/* +* Don't touch the TSS when invoked on a failed fork(). TSS +* reflects the state of @current and not the state of @tsk. +*/ +if (tsk == current) +task_update_io_bitmap ();if (iobm &&refcount_dec_and_test (&iobm->refcnt))kfree (iobm); }
@@ -192,8 +198,7 @@ SYSCALL_DEFINE1(iopl, unsigned int, level) } t->iopl_emul = level; -task_update_io_bitmap (current); - +task_update_io_bitmap ();return 0 ; }
arch/x86/kernel/process.c +6 -0
@@ -176,6 +176,7 @@ int copy_thread(struct task_struct *p, const struct kernel_clone_args *args) frame->ret_addr = (unsigned long ) ret_from_fork_asm; p->thread.sp = (unsigned long ) fork_frame; p->thread.io_bitmap =NULL ; +clear_tsk_thread_flag (p,TIF_IO_BITMAP ); p->thread.iopl_warn =0 ;memset (p->thread.ptrace_bps,0 ,sizeof (p->thread.ptrace_bps));
@@ -464,6 +465,11 @@ void native_tss_update_io_bitmap(void) }else {struct io_bitmap *iobm = t->io_bitmap; +if (WARN_ON_ONCE (!iobm)) { +clear_thread_flag (TIF_IO_BITMAP ); +native_tss_invalidate_io_bitmap (); + } +/* * Only copy bitmap data when the sequence number differs. The * update time is accounted to the incoming task.