Skip to contentSkip to conversation

gatt-client: Fix Handle property of descriptors

PATCH Applied Luiz Augusto von Dentz 3 participants 3 messages Mar 13, 2025 – Mar 14, 2025 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 gatt-client: Fix Handle property of descriptors

From: Luiz Augusto von Dentz <[email protected]>

Patch cda5549f2475 ("gatt-client: Add read-only handles to dbus") introduced support for Handle properties to GATT attributes but the function descriptor_get_handle do access the user_pointer as it was a service not a descriptor.

---
 src/gatt-client.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
src/gatt-client.c +2 -2
index da7c16fc14af..3c31a422eaba 100644
@@ -141,8 +141,8 @@ static bool uuid_cmp(const bt_uuid_t *uuid, uint16_t u16)
 static gboolean descriptor_get_handle(const GDBusPropertyTable *property,
 					DBusMessageIter *iter, void *data)
 {
-	struct service *desc = data;
-	uint16_t handle = desc->start_handle;
+	struct descriptor *desc = data;
+	uint16_t handle = desc->handle;
 
 	dbus_message_iter_append_basic(iter, DBUS_TYPE_UINT16, &handle);
 
Signature · 1 line
2.48.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=943694

---Test result---

Test Summary:

CheckPatch                    PENDING   0.16 seconds
GitLint                       PENDING   0.16 seconds
BuildEll                      PASS      21.12 seconds
BluezMake                     PASS      1474.58 seconds
MakeCheck                     PASS      12.72 seconds
MakeDistcheck                 PASS      159.38 seconds
CheckValgrind                 PASS      215.52 seconds
CheckSmatch                   PASS      285.85 seconds
bluezmakeextell               PASS      98.75 seconds
IncrementalBuild              PENDING   0.24 seconds
ScanBuild                     PASS      871.10 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Thu, 13 Mar 2025 16:54:04 -0400 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

Patch cda5549f2475 ("gatt-client: Add read-only handles to dbus") introduced support for Handle properties to GATT attributes but the function descriptor_get_handle do access the user_pointer as it was a service not a descriptor.

[...]

Here is the summary with links:
- [BlueZ,v1] gatt-client: Fix Handle property of descriptors

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=21d45dda01da

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html