staging: media: Fix indentation to use tabs instead of spaces
Subsystems (4)
PATCH 1/1 staging: media: Fix indentation to use tabs instead of spaces
Quoted 1 line
From
d6a08153171ac52b438b6ddc1da50ebdd3550951Mon Sep 17 00:00:00 2001
From: Gabriel Shahrouzi <[email protected]>
Date: Tue, 1 Apr 2025 22:04:25 -0400
Subject: [PATCH] staging: media: Fix indentation to use tabs instead of spaces
Replace spaces with tab to comply with kernel coding style.
--- .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c +1 -1
@@ -114,7 +114,7 @@ configure_dma( }int ia_css_vf_configure (const struct ia_css_binary *binary, -const struct ia_css_frame_info *out_info, +const struct ia_css_frame_info *out_info,struct ia_css_frame_info *vf_info,unsigned int *downscale_log2) {
Signature · 1 line
2.43.0
On Wed, Apr 2, 2025 at 5:40 AM <[email protected]> wrote:
Is it your first patch to the Linux kernel? See my comments below.
Quoted 4 lines
Quoted 1 line
From
d6a08153171ac52b438b6ddc1da50ebdd3550951Mon Sep 17 00:00:00 2001From: Gabriel Shahrouzi <[email protected]>
Date: Tue, 1 Apr 2025 22:04:25 -0400
Subject: [PATCH] staging: media: Fix indentation to use tabs instead of spaces
First of all, your patch is mangled. You want to use proper tools, perhaps. One of which is git format-patch ... and another one is git send-email ...
Quoted 1 line
Replace spaces with tab to comply with kernel coding style.
Change 'tab' to 'TAB'.
...
Change itself is okay, but is this the only one case in the entire driver (which is something like 100k LoCs long)? Even though, and while for the training purposes this is fine, you can also think about checking the common style of other functions, which may be shifted with TABs, but still having not enough spaces or so.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
On Wed, Apr 2, 2025 at 5:40 AM <[email protected]> wrote:
Is it your first patch to the Linux kernel? See my comments below.
It's among the first patches I've submitted.
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
From
d6a08153171ac52b438b6ddc1da50ebdd3550951Mon Sep 17 00:00:00 2001From: Gabriel Shahrouzi <[email protected]>
Date: Tue, 1 Apr 2025 22:04:25 -0400
Subject: [PATCH] staging: media: Fix indentation to use tabs instead of spacesFirst of all, your patch is mangled. You want to use proper tools, perhaps. One of which is
git format-patch ...and another one isgit send-email ...
I was using git format-patch but not git send-email which seems to have been the issue. The meta-data from the patch was getting appended to the top.
Quoted 4 lines
Quoted 2 lines
Replace spaces with tab to comply with kernel coding style.
Change 'tab' to 'TAB'.
Got it.
Quoted 8 lines
...
Change itself is okay, but is this the only one case in the entire driver (which is something like 100k LoCs long)? Even though, and while for the training purposes this is fine, you can also think about checking the common style of other functions, which may be shifted with TABs, but still having not enough spaces or so.
Good point. Regarding formatting, it probably makes the most sense to
address these issues comprehensively in a single cleanup pass (similar
to https://lore.kernel.org/linux-staging/[email protected]/T/#t).
This particular instance caught my attention because I initially
thought the author might have accidentally used spaces instead of
tabs. The line in question used 2 tabs + 8 spaces, while subsequent similarly-aligned lines used 3 tabs. However, after examining
different files in the driver, I noticed that while the formatting
appears inconsistent, it likely exists for specific reasons. It's
probably better to avoid changing a single detail without considering
the broader formatting approach, and to treat checkpatch.pl more as a
guide than the final authority.
Quoted 5 lines
--
With Best Regards,
Andy Shevchenko
Quoted 6 lines · Gabriel
Quoted 3 lines · Andy Shevchenko
On Wed, Apr 2, 2025 at 5:40 AM <[email protected]> wrote:
Is it your first patch to the Linux kernel? See my comments below.
It's among the first patches I've submitted.
Good start!
...
Quoted 11 lines
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
From
d6a08153171ac52b438b6ddc1da50ebdd3550951Mon Sep 17 00:00:00 2001From: Gabriel Shahrouzi <[email protected]>
Date: Tue, 1 Apr 2025 22:04:25 -0400
Subject: [PATCH] staging: media: Fix indentation to use tabs instead of spacesFirst of all, your patch is mangled. You want to use proper tools, perhaps. One of which is
git format-patch ...and another one isgit send-email ...I was using git format-patch but not git send-email which seems to have been the issue. The meta-data from the patch was getting appended to the top.
These are just normal headers for an email. They may be used by tools such as git send-email ... or mutt -H ....
...
Quoted 6 lines
Quoted 5 lines
Change itself is okay, but is this the only one case in the entire driver (which is something like 100k LoCs long)? Even though, and while for the training purposes this is fine, you can also think about checking the common style of other functions, which may be shifted with TABs, but still having not enough spaces or so.
Quoted 12 lines
Good point. Regarding formatting, it probably makes the most sense to
address these issues comprehensively in a single cleanup pass (similar
to https://lore.kernel.org/linux-staging/[email protected]/T/#t).
This particular instance caught my attention because I initially
thought the author might have accidentally used spaces instead of
tabs. The line in question used 2 tabs + 8 spaces, while subsequent similarly-aligned lines used 3 tabs. However, after examining
different files in the driver, I noticed that while the formatting
appears inconsistent, it likely exists for specific reasons. It's
probably better to avoid changing a single detail without considering
the broader formatting approach, and to treat checkpatch.pl more as a
guide than the final authority.
Okay! In any case this patch is fine to me in case you want to send a v2.
Signature · 2 lines
With Best Regards, Andy Shevchenko