staging: sm750fb: change sii164GetDeviceID to snake_case
PATCH 1/8 staging: sm750fb: change sii164GetDeviceID to snake_case
Change camelCase function name sii164GetDeviceID to sii164_reset_chip to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetDeviceID>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { { .init = sii164_init_chip, .get_vendor_id = sii164_get_vendor_id, - .get_device_id = sii164GetDeviceID, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164ResetChip, .get_chip_string = sii164GetChipString,
drivers/staging/sm750fb/ddk750_sii164.c +3 -3
@@ -48,13 +48,13 @@ unsigned short sii164_get_vendor_id(void) }/* -* sii164GetDeviceID +* sii164_get_device_id * This function gets the device ID of the DVI controller chip. * * Output: * Device ID */ -unsigned short sii164GetDeviceID (void ) +unsigned short sii164_get_device_id (void ) {unsigned short deviceID;
@@ -141,7 +141,7 @@ long sii164_init_chip(unsigned char edge_select,/* Check if SII164 Chip exists */ if ((sii164_get_vendor_id () ==SII164_VENDOR_ID ) && - (sii164GetDeviceID () ==SII164_DEVICE_ID )) { + (sii164_get_device_id () ==SII164_DEVICE_ID )) {/* * Initialize SII164 controller chip. */
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -28,7 +28,7 @@ long sii164_init_chip(unsigned char edgeSelect, unsigned char pllFilterValue);unsigned short sii164_get_vendor_id (void ); -unsigned short sii164GetDeviceID (void ); +unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS void sii164ResetChip (void );
Signature · 1 line
2.39.5
Quoted 2 lines · Richard Akintola
Change camelCase function name sii164GetDeviceID to
sii164_reset_chip
Just noticed a typo here, would send another that has the correct commit message.
Greg KH
maintainerQuoted 8 lines · Richard Akintola
Quoted 2 lines · Richard Akintola
Change camelCase function name sii164GetDeviceID to
sii164_reset_chipJust noticed a typo here, would send another that has the correct commit message.
All of these need to be linked together, you are sending them individually. Please use a tool like 'git send-email' that does this automatically for you, because as-is, I can't take these, sorry.
thanks,
greg k-h
Quoted 3 lines · Greg KH
All of these need to be linked together, you are sending them individually. Please use a tool like 'git send-email' that does this automatically for you, because as-is, I can't take these, sorry.
Noted, would do just that.
Thanks.
Richard Akintola