staging: sm750fb: change sii164GetDeviceID to snake_case
PATCH 1/8 staging: sm750fb: change sii164GetDeviceID to snake_case
Change camelCase function name sii164GetDeviceID to sii164_get_device_id to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetDeviceID>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { { .init = sii164_init_chip, .get_vendor_id = sii164_get_vendor_id, - .get_device_id = sii164GetDeviceID, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164ResetChip, .get_chip_string = sii164GetChipString,
drivers/staging/sm750fb/ddk750_sii164.c +3 -3
@@ -48,13 +48,13 @@ unsigned short sii164_get_vendor_id(void) }/* -* sii164GetDeviceID +* sii164_get_device_id * This function gets the device ID of the DVI controller chip. * * Output: * Device ID */ -unsigned short sii164GetDeviceID (void ) +unsigned short sii164_get_device_id (void ) {unsigned short deviceID;
@@ -141,7 +141,7 @@ long sii164_init_chip(unsigned char edge_select,/* Check if SII164 Chip exists */ if ((sii164_get_vendor_id () ==SII164_VENDOR_ID ) && - (sii164GetDeviceID () ==SII164_DEVICE_ID )) { + (sii164_get_device_id () ==SII164_DEVICE_ID )) {/* * Initialize SII164 controller chip. */
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -28,7 +28,7 @@ long sii164_init_chip(unsigned char edgeSelect, unsigned char pllFilterValue);unsigned short sii164_get_vendor_id (void ); -unsigned short sii164GetDeviceID (void ); +unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS void sii164ResetChip (void );
Signature · 1 line
2.39.5
Greg KH
maintainerQuoted 71 lines · Richard Akintola
Change camelCase function name sii164GetDeviceID to
sii164_get_device_idto conform to kernel code styles as reported by checkpatch.plCHECK: Avoid camelCase: <sii164GetDeviceID>
Signed-off-by Richard Akintola <[email protected]>--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)drivers/staging/sm750fb/ddk750_dvi.c +1
-1@@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { { .init = sii164_init_chip, .get_vendor_id = sii164_get_vendor_id, - .get_device_id = sii164GetDeviceID, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164ResetChip, .get_chip_string = sii164GetChipString,drivers/staging/sm750fb/ddk750_sii164.c +3
-3@@ -48,13 +48,13 @@ unsigned short sii164_get_vendor_id(void) }/* -* sii164GetDeviceID +* sii164_get_device_id * This function gets the device ID of the DVI controller chip. * * Output: * Device ID */ -unsigned short sii164GetDeviceID (void ) +unsigned short sii164_get_device_id (void ) {unsigned short deviceID;@@ -141,7 +141,7 @@ long sii164_init_chip(unsigned char edge_select,/* Check if SII164 Chip exists */ if ((sii164_get_vendor_id () ==SII164_VENDOR_ID ) && - (sii164GetDeviceID () ==SII164_DEVICE_ID )) { + (sii164_get_device_id () ==SII164_DEVICE_ID )) {/* * Initialize SII164 controller chip. */ drivers/staging/sm750fb/ddk750_sii164.h +1
-1@@ -28,7 +28,7 @@ long sii164_init_chip(unsigned char edgeSelect, unsigned char pllFilterValue);unsigned short sii164_get_vendor_id (void ); -unsigned short sii164GetDeviceID (void ); +unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS void sii164ResetChip (void );Signature · 1 line
2.39.5
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot