Bluetooth: hci_conn: Fix not setting conn_timeout for Broadcast Receiver
Subsystems (2)
Luiz Augusto von Dentz
maintainerPATCH v5 1/4 Bluetooth: hci_conn: Fix not setting conn_timeout for Broadcast Receiver
From: Luiz Augusto von Dentz <[email protected]>
Broadcast Receiver requires creating PA sync but the command just generates a status so this makes use of __hci_cmd_sync_status_sk to wait for HCI_EV_LE_PA_SYNC_ESTABLISHED, also because of this chance it is not longer necessary to use a custom method to serialize the process of creating the PA sync since the cmd_work_sync itself ensures only one command would be pending which now awaits for HCI_EV_LE_PA_SYNC_ESTABLISHED before proceeding to next connection.
--- include/net/bluetooth/hci.h | 2 + include/net/bluetooth/hci_core.h | 13 +++-- include/net/bluetooth/hci_sync.h | 2 + net/bluetooth/hci_conn.c | 92 +------------------------------- net/bluetooth/hci_event.c | 6 +-- net/bluetooth/hci_sync.c | 87 ++++++++++++++++++++++++++++-- 6 files changed, 95 insertions(+), 107 deletions(-)
include/net/bluetooth/hci.h +2 -0
@@ -1932,6 +1932,8 @@ struct hci_cp_le_pa_create_sync {__u8 sync_cte_type; } __packed; +#define HCI_OP_LE_PA_CREATE_SYNC_CANCEL 0x2045 +#define HCI_OP_LE_PA_TERM_SYNC 0x2046struct hci_cp_le_pa_term_sync {__le16 handle;
include/net/bluetooth/hci_core.h +6 -7
@@ -1116,10 +1116,8 @@ static inline struct hci_conn *hci_conn_hash_lookup_bis(struct hci_dev *hdev,return NULL ; } -static inline struct hci_conn *hci_conn_hash_lookup_sid (struct hci_dev *hdev, -__u8 sid, -bdaddr_t *dst, -__u8 dst_type) +static inline struct hci_conn * +hci_conn_hash_lookup_create_pa_sync (struct hci_dev *hdev) {struct hci_conn_hash *h = &hdev->conn_hash;struct hci_conn *c;
@@ -1127,8 +1125,10 @@ static inline struct hci_conn *hci_conn_hash_lookup_sid(struct hci_dev *hdev,rcu_read_lock ();list_for_each_entry_rcu (c, &h->list, list) { -if (c->type !=ISO_LINK ||bacmp (&c->dst, dst) || - c->dst_type != dst_type || c->sid != sid) +if (c->type !=ISO_LINK ) +continue ; + +if (!test_bit (HCI_CONN_CREATE_PA_SYNC , &c->flags))continue ;rcu_read_unlock ();
@@ -1527,7 +1527,6 @@ bool hci_setup_sync(struct hci_conn *conn, __u16 handle);void hci_sco_setup (struct hci_conn *conn,__u8 status);bool hci_iso_setup_path (struct hci_conn *conn);int hci_le_create_cis_pending (struct hci_dev *hdev); -int hci_pa_create_sync_pending (struct hci_dev *hdev);int hci_le_big_create_sync_pending (struct hci_dev *hdev);int hci_conn_check_create_cis (struct hci_conn *conn);
include/net/bluetooth/hci_sync.h +2 -0
@@ -185,3 +185,5 @@ int hci_connect_le_sync(struct hci_dev *hdev, struct hci_conn *conn);int hci_cancel_connect_sync (struct hci_dev *hdev,struct hci_conn *conn);int hci_le_conn_update_sync (struct hci_dev *hdev,struct hci_conn *conn,struct hci_conn_params *params); + +int hci_connect_pa_sync (struct hci_dev *hdev,struct hci_conn *conn);
net/bluetooth/hci_conn.c +2 -90
107 lines not on this page · raw message
net/bluetooth/hci_event.c +1 -5
@@ -6378,8 +6378,7 @@ static void hci_le_pa_sync_estabilished_evt(struct hci_dev *hdev, void *data,hci_dev_clear_flag (hdev,HCI_PA_SYNC ); - conn =hci_conn_hash_lookup_sid (hdev, ev->sid, &ev->bdaddr, - ev->bdaddr_type); + conn =hci_conn_hash_lookup_create_pa_sync (hdev);if (!conn) { bt_dev_err(hdev, "Unable to find connection for dst %pMR sid 0x%2.2x",
@@ -6418,9 +6417,6 @@ static void hci_le_pa_sync_estabilished_evt(struct hci_dev *hdev, void *data, } unlock: -/* Handle any other pending PA sync command */ -hci_pa_create_sync_pending (hdev); -hci_dev_unlock (hdev); }
net/bluetooth/hci_sync.c +82 -5
101 lines not on this page · raw message
Signature · 1 line
2.49.0
Luiz Augusto von Dentz
maintainerPATCH v5 2/4 Bluetooth: hci_conn: Fix not setting timeout for BIG Create Sync
From: Luiz Augusto von Dentz <[email protected]>
BIG Create Sync requires the command to just generates a status so this makes use of __hci_cmd_sync_status_sk to wait for HCI_EVT_LE_BIG_SYNC_ESTABLISHED, also because of this chance it is not longer necessary to use a custom method to serialize the process of creating the BIG sync since the cmd_work_sync itself ensures only one command would be pending which now awaits for HCI_EVT_LE_BIG_SYNC_ESTABLISHED before proceeding to next connection.
--- include/net/bluetooth/hci.h | 2 +- include/net/bluetooth/hci_core.h | 7 ++- include/net/bluetooth/hci_sync.h | 1 + net/bluetooth/hci_conn.c | 89 ++------------------------------ net/bluetooth/hci_event.c | 9 ++-- net/bluetooth/hci_sync.c | 63 ++++++++++++++++++++++ net/bluetooth/iso.c | 26 +++++----- 7 files changed, 88 insertions(+), 109 deletions(-)
include/net/bluetooth/hci.h +1 -1
@@ -2833,7 +2833,7 @@ struct hci_evt_le_create_big_complete {__le16 bis_handle[]; } __packed; -#define HCI_EVT_LE_BIG_SYNC_ESTABILISHED 0x1d +#define HCI_EVT_LE_BIG_SYNC_ESTABLISHED 0x1dstruct hci_evt_le_big_sync_estabilished {__u8 status;__u8 handle;
include/net/bluetooth/hci_core.h +3 -4
@@ -1527,7 +1527,6 @@ bool hci_setup_sync(struct hci_conn *conn, __u16 handle);void hci_sco_setup (struct hci_conn *conn,__u8 status);bool hci_iso_setup_path (struct hci_conn *conn);int hci_le_create_cis_pending (struct hci_dev *hdev); -int hci_le_big_create_sync_pending (struct hci_dev *hdev);int hci_conn_check_create_cis (struct hci_conn *conn); struct hci_conn *hci_conn_add(struct hci_dev *hdev, int type, bdaddr_t *dst,
@@ -1568,9 +1567,9 @@ struct hci_conn *hci_connect_bis(struct hci_dev *hdev, bdaddr_t *dst, __u8 data_len, __u8 *data);struct hci_conn *hci_pa_create_sync (struct hci_dev *hdev,bdaddr_t *dst,__u8 dst_type,__u8 sid,struct bt_iso_qos *qos); -int hci_le_big_create_sync (struct hci_dev *hdev,struct hci_conn *hcon, -struct bt_iso_qos *qos, -__u16 sync_handle,__u8 num_bis,__u8 bis[]); +int hci_conn_big_create_sync (struct hci_dev *hdev,struct hci_conn *hcon, +struct bt_iso_qos *qos,__u16 sync_handle, +__u8 num_bis,__u8 bis[]);int hci_conn_check_link_mode (struct hci_conn *conn);int hci_conn_check_secure (struct hci_conn *conn,__u8 sec_level); int hci_conn_security(struct hci_conn *conn, __u8 sec_level, __u8 auth_type,
include/net/bluetooth/hci_sync.h +1 -0
@@ -187,3 +187,4 @@ int hci_le_conn_update_sync(struct hci_dev *hdev, struct hci_conn *conn, struct hci_conn_params *params);int hci_connect_pa_sync (struct hci_dev *hdev,struct hci_conn *conn); +int hci_connect_big_sync (struct hci_dev *hdev,struct hci_conn *conn);
net/bluetooth/hci_conn.c +5 -84
103 lines not on this page · raw message
net/bluetooth/hci_event.c +3 -6
@@ -6928,7 +6928,7 @@ static void hci_le_big_sync_established_evt(struct hci_dev *hdev, void *data,bt_dev_dbg (hdev,"status 0x%2.2x" , ev->status); -if (!hci_le_ev_skb_pull (hdev, skb,HCI_EVT_LE_BIG_SYNC_ESTABILISHED , +if (!hci_le_ev_skb_pull (hdev, skb,HCI_EVT_LE_BIG_SYNC_ESTABLISHED ,flex_array_size (ev, bis, ev->num_bis)))return ;
@@ -6999,9 +6999,6 @@ static void hci_le_big_sync_established_evt(struct hci_dev *hdev, void *data, } unlock: -/* Handle any other pending BIG sync command */ -hci_le_big_create_sync_pending (hdev); -hci_dev_unlock (hdev); }
@@ -7123,8 +7120,8 @@ static const struct hci_le_ev { hci_le_create_big_complete_evt, sizeof(struct hci_evt_le_create_big_complete), HCI_MAX_EVENT_SIZE), -/* [0x1d = HCI_EV_LE_BIG_SYNC_ESTABILISHED] */ -HCI_LE_EV_VL (HCI_EVT_LE_BIG_SYNC_ESTABILISHED , +/* [0x1d = HCI_EV_LE_BIG_SYNC_ESTABLISHED] */ +HCI_LE_EV_VL (HCI_EVT_LE_BIG_SYNC_ESTABLISHED ,hci_le_big_sync_established_evt , sizeof(struct hci_evt_le_big_sync_estabilished), HCI_MAX_EVENT_SIZE),
net/bluetooth/hci_sync.c +63 -0
66 lines not on this page · raw message
net/bluetooth/iso.c +12 -14
@@ -1462,14 +1462,13 @@ static void iso_conn_big_sync(struct sock *sk)lock_sock (sk);if (!test_and_set_bit (BT_SK_BIG_SYNC , &iso_pi (sk)->flags)) { - err =hci_le_big_create_sync (hdev,iso_pi (sk)->conn->hcon, - &iso_pi (sk)->qos, -iso_pi (sk)->sync_handle, -iso_pi (sk)->bc_num_bis, -iso_pi (sk)->bc_bis); + err =hci_conn_big_create_sync (hdev,iso_pi (sk)->conn->hcon, + &iso_pi (sk)->qos, +iso_pi (sk)->sync_handle, +iso_pi (sk)->bc_num_bis, +iso_pi (sk)->bc_bis);if (err) -bt_dev_err (hdev,"hci_le_big_create_sync: %d" , - err); +bt_dev_err (hdev,"hci_big_create_sync: %d" , err); }release_sock (sk);
@@ -1922,7 +1921,7 @@ static void iso_conn_ready(struct iso_conn *conn) hcon); }else if (test_bit (HCI_CONN_BIG_SYNC_FAILED , &hcon->flags)) { ev =hci_recv_event_data (hcon->hdev, -HCI_EVT_LE_BIG_SYNC_ESTABILISHED ); +HCI_EVT_LE_BIG_SYNC_ESTABLISHED );/* Get reference to PA sync parent socket, if it exists */ parent = iso_get_sock(&hcon->src, &hcon->dst,
@@ -2113,12 +2112,11 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags)if (!test_bit (BT_SK_DEFER_SETUP , &bt_sk (sk)->flags) && !test_and_set_bit (BT_SK_BIG_SYNC , &iso_pi (sk)->flags)) { - err =hci_le_big_create_sync (hdev, - hcon, - &iso_pi (sk)->qos, -iso_pi (sk)->sync_handle, -iso_pi (sk)->bc_num_bis, -iso_pi (sk)->bc_bis); + err =hci_conn_big_create_sync (hdev, hcon, + &iso_pi (sk)->qos, +iso_pi (sk)->sync_handle, +iso_pi (sk)->bc_num_bis, +iso_pi (sk)->bc_bis);if (err) {bt_dev_err (hdev,"hci_le_big_create_sync: %d" , err);
Signature · 1 line
2.49.0
Luiz Augusto von Dentz
maintainerPATCH v5 3/4 Bluetooth: ISO: Fix not using SID from adv report
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
Up until now it has been assumed that the application would be able to enter the advertising SID in sockaddr_iso_bc.bc_sid, but userspace has no access to SID since the likes of MGMT_EV_DEVICE_FOUND cannot carry it, so it was left unset (0x00) which means it would be unable to synchronize if the broadcast source is using a different SID e.g. 0x04:
Quoted 1 line
HCI Event: LE Meta Event (
0x3e) plen 57
LE Extended Advertising Report (0x0d)
Num reports: 1
Entry 0
Event type: 0x0000
Props: 0x0000
Data status: Complete
Address type: Random (0x01)
Address: 0B:82:E8:50:6D:C8 (Non-Resolvable)
Primary PHY: LE 1M
Secondary PHY: LE 2M
SID: 0x04
TX power: 127 dBm
RSSI: -55 dBm (0xc9)
Periodic advertising interval: 180.00 msec (0x0090)
Direct address type: Public (0x00)
Direct address: 00:00:00:00:00:00 (OUI 00-00-00)
Data length: 0x1f
06 16 52 18 5b 0b e1 05 16 56 18 04 00 11 30 4c ..R.[....V....0L
75 69 7a 27 73 20 53 32 33 20 55 6c 74 72 61 uiz's S23 Ultra
Service Data: Broadcast Audio Announcement (0x1852)
Broadcast ID: 14748507 (0xe10b5b)
Service Data: Public Broadcast Announcement (0x1856)
Data[2]: 0400
Unknown EIR field 0x30[16]: 4c75697a27732053323320556c747261
< HCI Command: LE Periodic Advertising Create Sync (0x08|0x0044) plen 14
Options: 0x0000
Use advertising SID, Advertiser Address Type and address
Reporting initially enabled
SID: 0x00 (<- Invalid)
Adv address type: Random (0x01)
Adv address: 0B:82:E8:50:6D:C8 (Non-Resolvable)
Skip: 0x0000
Sync timeout: 20000 msec (0x07d0)
Sync CTE type: 0x0000So instead this changes now allow application to set HCI_SID_INVALID which will make hci_le_pa_create_sync to wait for a report, update the conn->sid using the report SID and only then issue PA create sync command:
< HCI Command: LE Periodic Advertising Create Sync
Options: 0x0000
Use advertising SID, Advertiser Address Type and address
Reporting initially enabled
SID: 0x04
Adv address type: Random (0x01)
Adv address: 0B:82:E8:50:6D:C8 (Non-Resolvable)
Skip: 0x0000
Sync timeout: 20000 msec (0x07d0)
Sync CTE type: 0x0000Quoted 1 line
HCI Event: LE Meta Event (
0x3e) plen 16
LE Periodic Advertising Sync Established (0x0e)
Status: Success (0x00)
Sync handle: 64
Advertising SID: 0x04
Advertiser address type: Random (0x01)
Advertiser address: 0B:82:E8:50:6D:C8 (Non-Resolvable)
Advertiser PHY: LE 2M (0x02)
Periodic advertising interval: 180.00 msec (0x0090)
Advertiser clock accuracy: 0x05--- net/bluetooth/hci_conn.c | 2 ++ net/bluetooth/hci_core.c | 13 +++++----- net/bluetooth/hci_event.c | 16 +++++++++++- net/bluetooth/hci_sync.c | 51 ++++++++++++++++++++++++++++++++++----- net/bluetooth/iso.c | 9 +++++-- 5 files changed, 76 insertions(+), 15 deletions(-)
net/bluetooth/hci_conn.c +2 -0
@@ -2070,6 +2070,8 @@ struct hci_conn *hci_pa_create_sync(struct hci_dev *hdev, bdaddr_t *dst, {struct hci_conn *conn; +bt_dev_dbg (hdev,"dst %pMR type %d sid %d" , dst, dst_type, sid); + conn =hci_conn_add_unset (hdev,ISO_LINK , dst,HCI_ROLE_SLAVE );if (IS_ERR (conn))return conn;
net/bluetooth/hci_core.c +7 -6
@@ -4068,10 +4068,13 @@ static void hci_send_cmd_sync(struct hci_dev *hdev, struct sk_buff *skb)return ; } - err =hci_send_frame (hdev, skb); -if (err <0 ) { -hci_cmd_sync_cancel_sync (hdev, -err); -return ; +if (hci_skb_opcode (skb) !=HCI_OP_NOP ) { + err =hci_send_frame (hdev, skb); +if (err <0 ) { +hci_cmd_sync_cancel_sync (hdev, -err); +return ; + } +atomic_dec (&hdev->cmd_cnt); } if (hdev->req_status == HCI_REQ_PEND &&
@@ -4079,8 +4082,6 @@ static void hci_send_cmd_sync(struct hci_dev *hdev, struct sk_buff *skb)kfree_skb (hdev->req_skb); hdev->req_skb =skb_clone (hdev->sent_cmd,GFP_KERNEL ); } - -atomic_dec (&hdev->cmd_cnt); }static void hci_cmd_work (struct work_struct *work)
net/bluetooth/hci_event.c +15 -1
@@ -6340,6 +6340,17 @@ static void hci_le_ext_adv_report_evt(struct hci_dev *hdev, void *data, info->secondary_phy &=0x1f ; } +/* Check if PA Sync is pending and if the hci_conn SID has not +* been set update it. +*/ +if (hci_dev_test_flag (hdev,HCI_PA_SYNC )) { +struct hci_conn *conn; + + conn =hci_conn_hash_lookup_create_pa_sync (hdev); +if (conn && conn->sid ==HCI_SID_INVALID ) + conn->sid = info->sid; + } +if (legacy_evt_type !=LE_ADV_INVALID ) { process_adv_report(hdev, legacy_evt_type, &info->bdaddr, info->bdaddr_type, NULL, 0,
@@ -7144,7 +7155,8 @@ static void hci_le_meta_evt(struct hci_dev *hdev, void *data,/* Only match event if command OGF is for LE */ if (hdev->req_skb && -hci_opcode_ogf (hci_skb_opcode (hdev->req_skb)) ==0x08 && + (hci_opcode_ogf (hci_skb_opcode (hdev->req_skb)) ==0x08 || +hci_skb_opcode (hdev->req_skb) ==HCI_OP_NOP ) &&hci_skb_event (hdev->req_skb) == ev->subevent) { *opcode =hci_skb_opcode (hdev->req_skb); hci_req_cmd_complete(hdev, *opcode, 0x00, req_complete,
@@ -7500,8 +7512,10 @@ void hci_event_packet(struct hci_dev *hdev, struct sk_buff *skb) goto done; } +hci_dev_lock (hdev);kfree_skb (hdev->recv_event); hdev->recv_event =skb_clone (skb,GFP_KERNEL ); +hci_dev_unlock (hdev); event = hdr->evt;if (!event) {
net/bluetooth/hci_sync.c +45 -6
80 lines not on this page · raw message
net/bluetooth/iso.c +7 -2
@@ -941,7 +941,7 @@ static int iso_sock_bind_bc(struct socket *sock, struct sockaddr *addr,iso_pi (sk)->dst_type = sa->iso_bc->bc_bdaddr_type; -if (sa->iso_bc->bc_sid >0x0f ) +if (sa->iso_bc->bc_sid >0x0f && sa->iso_bc->bc_sid !=HCI_SID_INVALID )return -EINVAL ;iso_pi (sk)->bc_sid = sa->iso_bc->bc_sid;
@@ -2029,6 +2029,9 @@ static bool iso_match_sid(struct sock *sk, void *data) {struct hci_ev_le_pa_sync_established *ev = data; +if (iso_pi (sk)->bc_sid ==HCI_SID_INVALID ) +return true; +return ev->sid ==iso_pi (sk)->bc_sid; }
@@ -2075,8 +2078,10 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags)if (ev1) { sk =iso_get_sock (&hdev->bdaddr, bdaddr,BT_LISTEN , iso_match_sid, ev1); -if (sk && !ev1->status) +if (sk && !ev1->status) {iso_pi (sk)->sync_handle =le16_to_cpu (ev1->handle); +iso_pi (sk)->bc_sid = ev1->sid; + } goto done; }
Signature · 1 line
2.49.0
Luiz Augusto von Dentz
maintainerPATCH v5 4/4 Bluetooth: ISO: Fix getpeername not returning sockaddr_iso_bc fields
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
If the socket is a broadcast receiver fields from sockaddr_iso_bc shall be part of the values returned to getpeername since some of these fields are updated while doing the PA and BIG sync procedures.
--- net/bluetooth/iso.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
net/bluetooth/iso.c +14 -3
@@ -1330,6 +1330,7 @@ static int iso_sock_getname(struct socket *sock, struct sockaddr *addr, {struct sockaddr_iso *sa = (struct sockaddr_iso *)addr;struct sock *sk = sock->sk; +int len =sizeof (struct sockaddr_iso );BT_DBG ("sock %p, sk %p" , sock, sk);
@@ -1338,12 +1339,20 @@ static int iso_sock_getname(struct socket *sock, struct sockaddr *addr,if (peer) {bacpy (&sa->iso_bdaddr, &iso_pi (sk)->dst); sa->iso_bdaddr_type =iso_pi (sk)->dst_type; + +if (test_bit (BT_SK_PA_SYNC , &iso_pi (sk)->flags)) { + sa->iso_bc->bc_sid =iso_pi (sk)->bc_sid; + sa->iso_bc->bc_num_bis =iso_pi (sk)->bc_num_bis; +memcpy (sa->iso_bc->bc_bis,iso_pi (sk)->bc_bis, +ISO_MAX_NUM_BIS ); + len +=sizeof (struct sockaddr_iso_bc ); + } }else {bacpy (&sa->iso_bdaddr, &iso_pi (sk)->src); sa->iso_bdaddr_type =iso_pi (sk)->src_type; } -return sizeof (struct sockaddr_iso ); +return len; } static int iso_sock_sendmsg(struct socket *sock, struct msghdr *msg,
@@ -1988,11 +1997,13 @@ static void iso_conn_ready(struct iso_conn *conn) hcon->dst_type =iso_pi (parent)->dst_type; } -if (ev3) { +if (test_bit (HCI_CONN_PA_SYNC , &hcon->flags)) {iso_pi (sk)->qos =iso_pi (parent)->qos; hcon->iso_qos =iso_pi (sk)->qos; +iso_pi (sk)->bc_sid =iso_pi (parent)->bc_sid;iso_pi (sk)->bc_num_bis =iso_pi (parent)->bc_num_bis; -memcpy (iso_pi (sk)->bc_bis,iso_pi (parent)->bc_bis,ISO_MAX_NUM_BIS ); +memcpy (iso_pi (sk)->bc_bis,iso_pi (parent)->bc_bis, +ISO_MAX_NUM_BIS );set_bit (BT_SK_PA_SYNC , &iso_pi (sk)->flags); }
Signature · 1 line
2.49.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=954159
---Test result---
Test Summary:
CheckPatch PENDING 0.37 seconds GitLint PENDING 0.26 seconds SubjectPrefix PASS 0.39 seconds BuildKernel PASS 24.81 seconds CheckAllWarning PASS 39.30 seconds CheckSparse WARNING 34.72 seconds BuildKernel32 PASS 25.04 seconds TestRunnerSetup PASS 456.94 seconds TestRunner_l2cap-tester PASS 20.81 seconds TestRunner_iso-tester PASS 30.51 seconds TestRunner_bnep-tester PASS 4.70 seconds TestRunner_mgmt-tester FAIL 125.08 seconds TestRunner_rfcomm-tester PASS 7.76 seconds TestRunner_sco-tester PASS 12.52 seconds TestRunner_ioctl-tester PASS 8.29 seconds TestRunner_mesh-tester PASS 5.89 seconds TestRunner_smp-tester PASS 7.15 seconds TestRunner_userchan-tester PASS 5.03 seconds IncrementalBuild PENDING 0.84 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 483 (98.6%), Failed: 3, Not Run: 4
Failed Test Cases
LL Privacy - Add Device 2 (2 Devices to AL) Failed 0.179 seconds LL Privacy - Add Device 3 (AL is full) Failed 0.189 seconds LL Privacy - Set Flags 1 (Add to RL) Failed 0.155 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 11 lines · On Wed, 16 Apr 2025 15:55:23 -0400 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
Broadcast Receiver requires creating PA sync but the command just generates a status so this makes use of
__hci_cmd_sync_status_skto wait forHCI_EV_LE_PA_SYNC_ESTABLISHED, also because of this chance it is not longer necessary to use a custom method to serialize the process of creating the PA sync since thecmd_work_syncitself ensures only one command would be pending which now awaits forHCI_EV_LE_PA_SYNC_ESTABLISHEDbefore proceeding to next connection.[...]
Here is the summary with links:
- [v5,1/4] Bluetooth: hci_conn: Fix not setting conn_timeout for Broadcast Receiver
https://git.kernel.org/bluetooth/bluetooth-next/c/58ddd115fe06 - [v5,2/4] Bluetooth: hci_conn: Fix not setting timeout for BIG Create Sync https://git.kernel.org/bluetooth/bluetooth-next/c/c3b6a7cfa98c - [v5,3/4] Bluetooth: ISO: Fix not using SID from adv report https://git.kernel.org/bluetooth/bluetooth-next/c/8144831f8c8d - [v5,4/4] Bluetooth: ISO: Fix getpeername not returning sockaddr_iso_bc fields https://git.kernel.org/bluetooth/bluetooth-next/c/ffd068349018
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html