io_uring/poll: disable level triggered poll
Jens Axboe
maintainerPATCH 1/1 io_uring/poll: disable level triggered poll
Stefan reports that there are issues with the level triggered notification. Since we're late in the cycle, and it was introduced for the 6.0 release, just disable it at prep time and we can bring this back when Samba is happy with it.
---
io_uring/poll.c +1 -1
@@ -857,7 +857,7 @@ int io_poll_add_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)if (sqe->buf_index || sqe->off || sqe->addr)return -EINVAL ; flags =READ_ONCE (sqe->len); -if (flags & ~(IORING_POLL_ADD_MULTI |IORING_POLL_ADD_LEVEL )) +if (flags & ~IORING_POLL_ADD_MULTI )return -EINVAL ;if ((flags &IORING_POLL_ADD_MULTI ) && (req->flags &REQ_F_CQE_SKIP ))return -EINVAL ;
Signature · 1 line
Jens Axboe
Hi Jens,
Quoted 7 lines
Stefan reports that there are issues with the level triggered notification. Since we're late in the cycle, and it was introduced for the 6.0 release, just disable it at prep time and we can bring this back when Samba is happy with it.
Reported-by Stefan Metzmacher <[email protected]>Signed-off-by Jens Axboe <[email protected]>
Also reviewed by me.
Thanks!
metze
Jens Axboe
maintainerQuoted 11 lines · Stefan Metzmacher
Hi Jens,
Quoted 7 lines
Stefan reports that there are issues with the level triggered notification. Since we're late in the cycle, and it was introduced for the 6.0 release, just disable it at prep time and we can bring this back when Samba is happy with it.
Reported-by Stefan Metzmacher <[email protected]>Signed-off-by Jens Axboe <[email protected]>Also reviewed by me.
Added, thanks!
Signature · 1 line
Jens Axboe