Basic recovery for machine checks inside SGX
Subsystems (9)
Tony Luck
reviewercover Basic recovery for machine checks inside SGX
Cover the easy cases:
1) memory errors reported by patrol scrubber in unused SGX pages
2) machine checks due to poison consumption from SGX_PAGE_TYPE_REG pages
3) When poison is consumed in an enclave inside a guest, just kill the guest.
Tony Luck (4):
x86/sgx: Track phase and type of SGX EPC pages
x86/sgx: Add basic infrastructure to recover from errors in SGX memory x86/sgx: Hook sgx_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/sgx.h | 6 + arch/x86/kernel/cpu/sgx/encl.c | 4 +- arch/x86/kernel/cpu/sgx/ioctl.c | 4 +- arch/x86/kernel/cpu/sgx/main.c | 147 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 17 +- arch/x86/kernel/cpu/sgx/virt.c | 11 +- drivers/acpi/apei/einj.c | 3 +- include/linux/mm.h | 15 ++ mm/memory-failure.c | 4 + 10 files changed, 219 insertions(+), 11 deletions(-)
base-commit: 62fb9874f5da54fdb243003b386128037319b219
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH 1/4 x86/sgx: Track phase and type of SGX EPC pages
Memory errors can be reported either synchronously as memory is accessed, or asynchronously by speculative access or by a memory controller page scrubber. The life cycle of an EPC page takes it through:
dirty -> free -> in-use -> free.
Memory errors are reported using physical addresses. It is a simple matter to find which sgx_epc_page structure maps a given address. But then recovery code needs to be able to determine the current use of the page to take the appropriate recovery action. Within the "in-use" phase different actions are needed based on how the page is used in the enclave.
Add new flags bits to describe the phase (with an extra bit for the new phase of "poisoned"). Drop pages marked as poisoned instead of adding them to a free list to make sure they are not re-used.
Add a type field to struct epc_page for how an in-use page has been allocated. Re-use "enum sgx_page_type" for this type, with a couple of additions for s/w types.
--- arch/x86/include/asm/sgx.h | 6 ++++++ arch/x86/kernel/cpu/sgx/encl.c | 4 ++-- arch/x86/kernel/cpu/sgx/ioctl.c | 4 ++-- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++++++++++-- arch/x86/kernel/cpu/sgx/sgx.h | 14 ++++++++++++-- arch/x86/kernel/cpu/sgx/virt.c | 2 +- 6 files changed, 42 insertions(+), 9 deletions(-)
arch/x86/include/asm/sgx.h +6 -0
@@ -216,6 +216,8 @@ struct sgx_pageinfo {* %SGX_PAGE_TYPE_REG: a regular page * %SGX_PAGE_TYPE_VA: a VA page * %SGX_PAGE_TYPE_TRIM: a page in trimmed state +* +* Also used to track current use of &struct sgx_epc_page */ enum sgx_page_type {SGX_PAGE_TYPE_SECS ,
@@ -223,6 +225,10 @@ enum sgx_page_type {SGX_PAGE_TYPE_REG ,SGX_PAGE_TYPE_VA ,SGX_PAGE_TYPE_TRIM , + +/* sgx_epc_page.type */ +SGX_PAGE_TYPE_FREE =100 , + SGX_PAGE_TYPE_KVM = 101, };#define SGX_NR_PAGE_TYPES 5
arch/x86/kernel/cpu/sgx/encl.c +2 -2
@@ -72,7 +72,7 @@ static struct sgx_epc_page *sgx_encl_eldu(struct sgx_encl_page *encl_page,struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (encl_page, false); + epc_page =sgx_alloc_epc_page (encl_page,SGX_PAGE_TYPE_REG , false);if (IS_ERR (epc_page))return epc_page;
@@ -679,7 +679,7 @@ struct sgx_epc_page *sgx_alloc_va_page(void)struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (NULL ,SGX_PAGE_TYPE_VA , true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);
arch/x86/kernel/cpu/sgx/ioctl.c +2 -2
@@ -83,7 +83,7 @@ static int sgx_encl_create(struct sgx_encl *encl, struct sgx_secs *secs) encl->backing = backing; - secs_epc =sgx_alloc_epc_page (&encl->secs, true); + secs_epc =sgx_alloc_epc_page (&encl->secs,SGX_PAGE_TYPE_SECS , true);if (IS_ERR (secs_epc)) { ret =PTR_ERR (secs_epc); goto err_out_backing;
@@ -300,7 +300,7 @@ static int sgx_encl_add_page(struct sgx_encl *encl, unsigned long src,if (IS_ERR (encl_page))return PTR_ERR (encl_page); - epc_page =sgx_alloc_epc_page (encl_page, true); + epc_page =sgx_alloc_epc_page (encl_page,SGX_PAGE_TYPE_REG , true);if (IS_ERR (epc_page)) {kfree (encl_page);return PTR_ERR (epc_page);
arch/x86/kernel/cpu/sgx/main.c +19 -2
@@ -401,7 +401,12 @@ static void sgx_reclaim_pages(void) section = &sgx_epc_sections[epc_page->section]; node = section->node; +/* drop poison pages instead of adding to free list */ +if (epc_page->flags &SGX_EPC_PAGE_POISON ) +continue ; +spin_lock (&node->lock); + epc_page->flags =SGX_EPC_PAGE_FREE ;list_add_tail (&epc_page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);
@@ -560,6 +565,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page * @owner: the owner of the EPC page +* @type: type of page being allocated * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a
@@ -574,7 +580,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* an EPC page, * -errno on error */ -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim) +struct sgx_epc_page *sgx_alloc_epc_page (void *owner,enum sgx_page_type type,bool reclaim) {struct sgx_epc_page *page;
@@ -582,6 +588,8 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) page =__sgx_alloc_epc_page ();if (!IS_ERR (page)) { page->owner = owner; + page->type = type; + page->flags =0 ;break ; }
@@ -616,14 +624,22 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)* responsibility to make sure that the page is in uninitialized state. In other * words, do EREMOVE, EWB or whatever operation is necessary before calling * this function. +* +* Note that if the page has been tagged as poisoned, it is simply +* dropped on the floor instead of added to the free list to make +* sure we do not re-use it. */ void sgx_free_epc_page (struct sgx_epc_page *page) {struct sgx_epc_section *section = &sgx_epc_sections[page->section];struct sgx_numa_node *node = section->node; +if (page->flags &SGX_EPC_PAGE_POISON ) +return ; +spin_lock (&node->lock); + page->flags =SGX_EPC_PAGE_FREE ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
@@ -651,7 +667,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; - section->pages[i].flags =0 ; + section->pages[i].flags =SGX_EPC_PAGE_DIRTY ; + section->pages[i].type =SGX_PAGE_TYPE_FREE ; section->pages[i].owner =NULL ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +12 -2
@@ -26,9 +26,19 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Pages, on the "sgx_dirty_page_list" */ +#define SGX_EPC_PAGE_DIRTY BIT(1) + +/* Pages, on one of the node free lists */ +#define SGX_EPC_PAGE_FREE BIT(2) + +/* Pages, with h/w poison errors */ +#define SGX_EPC_PAGE_POISON BIT(3) +struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 type;struct sgx_encl_page *owner;struct list_head list; };
@@ -82,7 +92,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page);void sgx_mark_page_reclaimable (struct sgx_epc_page *page);int sgx_unmark_page_reclaimable (struct sgx_epc_page *page); -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim); +struct sgx_epc_page *sgx_alloc_epc_page (void *owner,enum sgx_page_type type,bool reclaim);#ifdef CONFIG_X86_SGX_KVM int __init sgx_vepc_init (void );
arch/x86/kernel/cpu/sgx/virt.c +1 -1
@@ -46,7 +46,7 @@ static int __sgx_vepc_fault(struct sgx_vepc *vepc,if (epc_page)return 0 ; - epc_page =sgx_alloc_epc_page (vepc, false); + epc_page =sgx_alloc_epc_page (vepc,SGX_PAGE_TYPE_KVM , false);if (IS_ERR (epc_page))return PTR_ERR (epc_page);
Signature · 1 line
2.29.2
Jarkko Sakkinen
maintainerRe: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
Quoted 147 lines · Tony Luck
Memory errors can be reported either synchronously as memory is accessed, or asynchronously by speculative access or by a memory controller page scrubber. The life cycle of an EPC page takes it through:
dirty -> free -> in-use -> free.Memory errors are reported using physical addresses. It is a simple matter to find which
sgx_epc_pagestructure maps a given address. But then recovery code needs to be able to determine the current use of the page to take the appropriate recovery action. Within the "in-use" phase different actions are needed based on how the page is used in the enclave.Add new flags bits to describe the phase (with an extra bit for the new phase of "poisoned"). Drop pages marked as poisoned instead of adding them to a free list to make sure they are not re-used.
Add a type field to struct
epc_pagefor how an in-use page has been allocated. Re-use "enumsgx_page_type" for this type, with a couple of additions for s/w types.Signed-off-by Tony Luck <[email protected]>--- arch/x86/include/asm/sgx.h | 6 ++++++ arch/x86/kernel/cpu/sgx/encl.c | 4 ++-- arch/x86/kernel/cpu/sgx/ioctl.c | 4 ++-- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++++++++++-- arch/x86/kernel/cpu/sgx/sgx.h | 14 ++++++++++++-- arch/x86/kernel/cpu/sgx/virt.c | 2 +- 6 files changed, 42 insertions(+), 9 deletions(-)arch/x86/include/asm/sgx.h +6
-0@@ -216,6 +216,8 @@ struct sgx_pageinfo {* %SGX_PAGE_TYPE_REG: a regular page * %SGX_PAGE_TYPE_VA: a VA page * %SGX_PAGE_TYPE_TRIM: a page in trimmed state +* +* Also used to track current use of &struct sgx_epc_page */ enum sgx_page_type {SGX_PAGE_TYPE_SECS ,@@ -223,6 +225,10 @@ enum sgx_page_type {SGX_PAGE_TYPE_REG ,SGX_PAGE_TYPE_VA ,SGX_PAGE_TYPE_TRIM , + +/* sgx_epc_page.type */ +SGX_PAGE_TYPE_FREE =100 , + SGX_PAGE_TYPE_KVM = 101, };#define SGX_NR_PAGE_TYPES 5arch/x86/kernel/cpu/sgx/encl.c +2
-2@@ -72,7 +72,7 @@ static struct sgx_epc_page *sgx_encl_eldu(struct sgx_encl_page *encl_page,struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (encl_page, false); + epc_page =sgx_alloc_epc_page (encl_page,SGX_PAGE_TYPE_REG , false);if (IS_ERR (epc_page))return epc_page;@@ -679,7 +679,7 @@ struct sgx_epc_page *sgx_alloc_va_page(void)struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (NULL ,SGX_PAGE_TYPE_VA , true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);arch/x86/kernel/cpu/sgx/ioctl.c +2
-2@@ -83,7 +83,7 @@ static int sgx_encl_create(struct sgx_encl *encl, struct sgx_secs *secs) encl->backing = backing; - secs_epc =sgx_alloc_epc_page (&encl->secs, true); + secs_epc =sgx_alloc_epc_page (&encl->secs,SGX_PAGE_TYPE_SECS , true);if (IS_ERR (secs_epc)) { ret =PTR_ERR (secs_epc); goto err_out_backing;@@ -300,7 +300,7 @@ static int sgx_encl_add_page(struct sgx_encl *encl, unsigned long src,if (IS_ERR (encl_page))return PTR_ERR (encl_page); - epc_page =sgx_alloc_epc_page (encl_page, true); + epc_page =sgx_alloc_epc_page (encl_page,SGX_PAGE_TYPE_REG , true);if (IS_ERR (epc_page)) {kfree (encl_page);return PTR_ERR (epc_page);arch/x86/kernel/cpu/sgx/main.c +11
-1@@ -401,7 +401,12 @@ static void sgx_reclaim_pages(void) section = &sgx_epc_sections[epc_page->section]; node = section->node; +/* drop poison pages instead of adding to free list */ +if (epc_page->flags &SGX_EPC_PAGE_POISON ) +continue ; +spin_lock (&node->lock); + epc_page->flags =SGX_EPC_PAGE_FREE ;list_add_tail (&epc_page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);@@ -560,6 +565,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page * @owner: the owner of the EPC page +* @type: type of page being allocated * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a @@ -574,7 +580,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* an EPC page, * -errno on error */ -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim) +struct sgx_epc_page *sgx_alloc_epc_page (void *owner,enum sgx_page_type type,bool reclaim) {struct sgx_epc_page *page;@@ -582,6 +588,8 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) page =__sgx_alloc_epc_page ();if (!IS_ERR (page)) { page->owner = owner; + page->type = type; + page->flags =0 ;break ; }@@ -616,14 +624,22 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)* responsibility to make sure that the page is in uninitialized state. In other * words, do EREMOVE, EWB or whatever operation is necessary before calling * this function. +* +* Note that if the page has been tagged as poisoned, it is simply
arch/x86/kernel/cpu/sgx/main.c struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) · line 638
Quoted 10 lines
arch/x86/kernel/cpu/sgx/main.c +4
-0+* dropped on the floor instead of added to the free list to make +* sure we do not re-use it. */ void sgx_free_epc_page (struct sgx_epc_page *page) {struct sgx_epc_section *section = &sgx_epc_sections[page->section];struct sgx_numa_node *node = section->node; +if (page->flags &SGX_EPC_PAGE_POISON ) +return ;
I tend to think that it would be nice to collect them somewhere instead purposely leaking. E.g. this gives possibility to examine list with debugging tools.
/Jarkko
Jarkko Sakkinen
maintainerRe: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
Quoted 156 lines · Jarkko Sakkinen
Quoted 155 lines · Tony Luck
Memory errors can be reported either synchronously as memory is accessed, or asynchronously by speculative access or by a memory controller page scrubber. The life cycle of an EPC page takes it through:
dirty -> free -> in-use -> free.Memory errors are reported using physical addresses. It is a simple matter to find which
sgx_epc_pagestructure maps a given address. But then recovery code needs to be able to determine the current use of the page to take the appropriate recovery action. Within the "in-use" phase different actions are needed based on how the page is used in the enclave.Add new flags bits to describe the phase (with an extra bit for the new phase of "poisoned"). Drop pages marked as poisoned instead of adding them to a free list to make sure they are not re-used.
Add a type field to struct
epc_pagefor how an in-use page has been allocated. Re-use "enumsgx_page_type" for this type, with a couple of additions for s/w types.Signed-off-by Tony Luck <[email protected]>--- arch/x86/include/asm/sgx.h | 6 ++++++ arch/x86/kernel/cpu/sgx/encl.c | 4 ++-- arch/x86/kernel/cpu/sgx/ioctl.c | 4 ++-- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++++++++++-- arch/x86/kernel/cpu/sgx/sgx.h | 14 ++++++++++++-- arch/x86/kernel/cpu/sgx/virt.c | 2 +- 6 files changed, 42 insertions(+), 9 deletions(-)arch/x86/include/asm/sgx.h +6
-0@@ -216,6 +216,8 @@ struct sgx_pageinfo {* %SGX_PAGE_TYPE_REG: a regular page * %SGX_PAGE_TYPE_VA: a VA page * %SGX_PAGE_TYPE_TRIM: a page in trimmed state +* +* Also used to track current use of &struct sgx_epc_page */ enum sgx_page_type {SGX_PAGE_TYPE_SECS ,@@ -223,6 +225,10 @@ enum sgx_page_type {SGX_PAGE_TYPE_REG ,SGX_PAGE_TYPE_VA ,SGX_PAGE_TYPE_TRIM , + +/* sgx_epc_page.type */ +SGX_PAGE_TYPE_FREE =100 , + SGX_PAGE_TYPE_KVM = 101, };#define SGX_NR_PAGE_TYPES 5arch/x86/kernel/cpu/sgx/encl.c +2
-2@@ -72,7 +72,7 @@ static struct sgx_epc_page *sgx_encl_eldu(struct sgx_encl_page *encl_page,struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (encl_page, false); + epc_page =sgx_alloc_epc_page (encl_page,SGX_PAGE_TYPE_REG , false);if (IS_ERR (epc_page))return epc_page;@@ -679,7 +679,7 @@ struct sgx_epc_page *sgx_alloc_va_page(void)struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (NULL ,SGX_PAGE_TYPE_VA , true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);arch/x86/kernel/cpu/sgx/ioctl.c +2
-2@@ -83,7 +83,7 @@ static int sgx_encl_create(struct sgx_encl *encl, struct sgx_secs *secs) encl->backing = backing; - secs_epc =sgx_alloc_epc_page (&encl->secs, true); + secs_epc =sgx_alloc_epc_page (&encl->secs,SGX_PAGE_TYPE_SECS , true);if (IS_ERR (secs_epc)) { ret =PTR_ERR (secs_epc); goto err_out_backing;@@ -300,7 +300,7 @@ static int sgx_encl_add_page(struct sgx_encl *encl, unsigned long src,if (IS_ERR (encl_page))return PTR_ERR (encl_page); - epc_page =sgx_alloc_epc_page (encl_page, true); + epc_page =sgx_alloc_epc_page (encl_page,SGX_PAGE_TYPE_REG , true);if (IS_ERR (epc_page)) {kfree (encl_page);return PTR_ERR (epc_page);arch/x86/kernel/cpu/sgx/main.c +13
-1@@ -401,7 +401,12 @@ static void sgx_reclaim_pages(void) section = &sgx_epc_sections[epc_page->section]; node = section->node; +/* drop poison pages instead of adding to free list */ +if (epc_page->flags &SGX_EPC_PAGE_POISON ) +continue ; +spin_lock (&node->lock); + epc_page->flags =SGX_EPC_PAGE_FREE ;list_add_tail (&epc_page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);@@ -560,6 +565,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page * @owner: the owner of the EPC page +* @type: type of page being allocated * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a @@ -574,7 +580,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* an EPC page, * -errno on error */ -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim) +struct sgx_epc_page *sgx_alloc_epc_page (void *owner,enum sgx_page_type type,bool reclaim) {struct sgx_epc_page *page;@@ -582,6 +588,8 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) page =__sgx_alloc_epc_page ();if (!IS_ERR (page)) { page->owner = owner; + page->type = type; + page->flags =0 ;break ; }@@ -616,14 +624,22 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)* responsibility to make sure that the page is in uninitialized state. In other * words, do EREMOVE, EWB or whatever operation is necessary before calling * this function. +* +* Note that if the page has been tagged as poisoned, it is simply +* dropped on the floor instead of added to the free list to make +* sure we do not re-use it. */ void sgx_free_epc_page (struct sgx_epc_page *page) {struct sgx_epc_section *section = &sgx_epc_sections[page->section];struct sgx_numa_node *node = section->node;
Quoted 6 lines
arch/x86/kernel/cpu/sgx/main.c struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) · line 638
Quoted 2 lines
arch/x86/kernel/cpu/sgx/main.c +2
-0+if (page->flags &SGX_EPC_PAGE_POISON ) +return ;I tend to think that it would be nice to collect them somewhere instead purposely leaking. E.g. this gives possibility to examine list with debugging tools.
I'm not also sure why free and dirty pages need to be tagged. Why a poison flag is enough? This could be better explained in the commit message.
Re: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
In reply to Tony LuckHi Tony,
Quoted 4 lines · Tony Luck
Add a type field to struct
epc_pagefor how an in-use page has been allocated. Re-use "enumsgx_page_type" for this type, with a couple of additions for s/w types.
Tracking the enclave page type is a useful addition that will also help the SGX2 support where some instructions (ENCLS[EMODPR]) are only allowed on pages with particular type.
Could this tracking be done at the enclave page (struct sgx_encl_page) instead? The enclave page's EPC page information is not available when the page is in swap and it would be useful to know the page type without loading the page from swap. The information would continue to be accessible from struct epc_page via the owner pointer that may make some of the changes easier since it would not be needed to pass the page type around so much and thus possibly address the SECS page issue that Sean pointed out in
https://lore.kernel.org/lkml/[email protected]/
Quoted 12 lines
arch/x86/kernel/cpu/sgx/sgx.h +4
-0@@ -26,9 +26,19 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Pages, on the "sgx_dirty_page_list" */ +#define SGX_EPC_PAGE_DIRTY BIT(1) + +/* Pages, on one of the node free lists */
arch/x86/kernel/cpu/sgx/sgx.h line 41
Quoted 10 lines
arch/x86/kernel/cpu/sgx/sgx.h +7
-1+#define SGX_EPC_PAGE_FREE BIT(2) + +/* Pages, with h/w poison errors */ +#define SGX_EPC_PAGE_POISON BIT(3) +struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 type;
Could this be "enum sgx_page_type type" ?
Reinette
Luck, Tony
reviewerRE: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
Quoted 2 lines
Could this tracking be done at the enclave page (struct
sgx_encl_page) instead?
In principle yes. Though Sean has some issues with me tracking types at all.
Quoted 8 lines
The enclave page's EPC page information is not available when the page is in swap and it would be useful to know the page type without loading the page from swap. The information would continue to be accessible from struct
epc_pagevia the owner pointer that may make some of the changes easier since it would not be needed to pass the page type around so much and thus possibly address the SECS page issue that Sean pointed out in
https://lore.kernel.org/lkml/[email protected]/
I think I noticed that the "owner" pointer in sgx_encl_page doesn't point back to the epc_page for all types of SGX pages. So some additional changes would be needed. I'm not at all sure why this is different (or what use the non-REG pages use "owner" for.
Quoted 7 lines
arch/x86/kernel/cpu/sgx/sgx.h line 41
Quoted 5 lines
struct sgx_epc_page { unsigned int section;arch/x86/kernel/cpu/sgx/sgx.h +2
-1-unsigned int flags; +u16 flags; +u16 type;Could this be "enum
sgx_page_typetype" ?
Maybe. I thought I needed extra types (like FREE and DIRTY). But Sean pointed out how to avoid some of them.
-Tony
Re: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
Hi Tony,
Quoted 5 lines · Tony
Quoted 2 lines
Could this tracking be done at the enclave page (struct
sgx_encl_page) instead?In principle yes. Though Sean has some issues with me tracking types at all.
For the SGX2 work knowing the page types are useful. Some instructions only work on certain page types and knowing beforehand whether an instruction could work helps to avoid dealing with the errors when it does not work.
Quoted 9 lines
Quoted 8 lines
The enclave page's EPC page information is not available when the page is in swap and it would be useful to know the page type without loading the page from swap. The information would continue to be accessible from struct
epc_pagevia the owner pointer that may make some of the changes easier since it would not be needed to pass the page type around so much and thus possibly address the SECS page issue that Sean pointed out in
https://lore.kernel.org/lkml/[email protected]/
Quoted 4 lines
I think I noticed that the "owner" pointer in
sgx_encl_pagedoesn't point back to theepc_pagefor all types of SGX pages. So some additional changes would be needed. I'm not at all sure why this is different (or what use the non-REG pages use "owner" for.
This may be VA pages? struct sgx_va_page also contains a pointer to an EPC page. I did not consider that for this case. Perhaps these could be identified uniquely.
Reinette
Re: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
Quoted 8 lines · Reinette Chatre
Hi Tony,
Quoted 5 lines · Tony
Quoted 2 lines
Could this tracking be done at the enclave page (struct
sgx_encl_page) instead?In principle yes. Though Sean has some issues with me tracking types at all.
I've no objection to tracking the type for SGX2, my argument in the context of #MC support is that there should be no need to track the type. Either the #MC is recoverable or it isn't, and the enclave is toast regardless of what type of page hit the #MC.
There might be a need to identify track vEPC pages, e.g. to avoid the retpoline associated with a virtual function table, but IMO that would be better done as a new flag instead of overloading the page type. E.g. a page can be both a vEPC page and an SECS/REG/VA page depending on its use in the guest.
Quoted 3 lines
For the SGX2 work knowing the page types are useful. Some instructions only work on certain page types and knowing beforehand whether an instruction could work helps to avoid dealing with the errors when it does not work.
Yes, but the SGX2 use case is specific to "native" enclaves, i.e. it can and should be limited to sgx_encl_page, as opposed to being shoved into sgx_epc_page.
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
The enclave page's EPC page information is not available when the page is in swap and it would be useful to know the page type without loading the page from swap. The information would continue to be accessible from struct
epc_pagevia the owner pointer that may make some of the changes easier since it would not be needed to pass the page type around so much and thus possibly address the SECS page issue that Sean pointed out in
https://lore.kernel.org/lkml/[email protected]/
Quoted 8 lines
Quoted 4 lines
I think I noticed that the "owner" pointer in
sgx_encl_pagedoesn't point back to theepc_pagefor all types of SGX pages. So some additional changes would be needed. I'm not at all sure why this is different (or what use the non-REG pages use "owner" for.This may be VA pages? struct
sgx_va_pagealso contains a pointer to an EPC page. I did not consider that for this case. Perhaps these could be identified uniquely.
The "owner" is currently only used for reclaim. IIRC, the proposed EPC cgroup also used "owner" to enable forced "reclaim", i.e. reclaiming EPC by nuking the owning entity, e.g. tearing down a virtual EPC section. And I believe the cgroup also used the aforementioned vEPC flag to invoke the correct EPC OOM reaper.
Luck, Tony
reviewerRE: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
Quoted 4 lines
I've no objection to tracking the type for SGX2, my argument in the context of #MC support is that there should be no need to track the type. Either the #MC is recoverable or it isn't, and the enclave is toast regardless of what type of page hit the #MC.
I'll separate the "phase" from the "type".
Here phase is used for the life-cycle of EPC pages:
DIRTY -> FREE -> IN-USE -> DIRTY
Errors can be reported by memory controller page scrubbers for pages that are not "IN-USE" ... and the recovery action is just to make sure that they are never allocated.
When a page is IN-USE ... it has a "type". I currently only have a way to inject errors into SGX_PAGE_TYPE_REG pages. That means initial recovery code is going to focus on those since that is all I can test. But I'll try not to special case them as far as possible.
-Tony
Re: [PATCH 1/4] x86/sgx: Track phase and type of SGX EPC pages
Quoted 10 lines · Tony
Quoted 4 lines
I've no objection to tracking the type for SGX2, my argument in the context of #MC support is that there should be no need to track the type. Either the #MC is recoverable or it isn't, and the enclave is toast regardless of what type of page hit the #MC.
I'll separate the "phase" from the "type".
Here phase is used for the life-cycle of EPC pages:
DIRTY -> FREE -> IN-USE -> DIRTY
Not that it affects anything, but that's not quite true. In hardware, pages are either FREE or IN-USE, there is no concept of DIRTY. DIRTY is the kernel's arbitrary description of a page that has not been sanitized and so is considered to be in an unknown state, i.e. the kernel doesn't know if it's FREE or IN-USE.
Once a page is sanitized (during boot), its state is known and the page is never put back on the so called dirty list, i.e. the software flow is:
DIRTY -> FREE -> IN-USE -> FREE
Quoted 8 lines
Errors can be reported by memory controller page scrubbers for pages that are not "IN-USE" ... and the recovery action is just to make sure that they are never allocated.
When a page is IN-USE ... it has a "type". I currently only have a way to inject errors into
SGX_PAGE_TYPE_REGpages. That means initial recovery code is going to focus on those since that is all I can test. But I'll try not to special case them as far as possible.
Inability to test expected behavior doesn't mean we shouldn't implement towards the expected behavior, i.e. someone somewhere must know how SECS and VA pages behave in response to a memory error.
Tony Luck
reviewerPATCH 2/4 x86/sgx: Add basic infrastructure to recover from errors in SGX memory
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error.
Add an end_phys_addr field to the sgx_epc_section structure and a new function sgx_paddr_to_page() that searches all such structures to see if a physical address is part of an SGX EPC page.
The ACPI EINJ module has a sanity check that the injection address is valid. Add and export a function sgx_is_epc_page() so that it can be changed to allow injection to SGX EPC pages.
Provide a recovery function sgx_memory_failure(). If the poison was consumed synchronously inside the enclave send a SIGBUS just the same as for poison consumption outside of an enclave.
For asynchronously reported errors the easiest cases are when the page is currently free. Just drop the page from the free list so that it will never be allocated.
An SGX_PAGE_TYPE_REG page can just be unmapped from the enclave. If the enclave doesn't ever touch that page again all is well. If it does touch the page it will die. Possible future enhancement here to mark the unmapped PTE so that it will cause a SIGBUS.
SGX_PAGE_TYPE_KVM pages may be recoverable depending on how they are being used by guests. To fix that properly requires injecting the machine check into the guest. For now just kill it.
--- arch/x86/kernel/cpu/sgx/main.c | 126 +++++++++++++++++++++++++++++++++ arch/x86/kernel/cpu/sgx/sgx.h | 3 +- arch/x86/kernel/cpu/sgx/virt.c | 9 +++ 3 files changed, 137 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/main.c +126 -0
@@ -664,6 +664,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ;for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -676,6 +677,131 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; +int i; + +for (i =0 ; i <ARRAY_SIZE (sgx_epc_sections); i++) { + section = &sgx_epc_sections[i]; + +if (paddr < section->phys_addr || paddr > section->end_phys_addr) +continue ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; + } + +return NULL ; +} + +bool sgx_is_epc_page (u64 paddr) +{ +return !!sgx_paddr_to_page (paddr); +} +EXPORT_SYMBOL_GPL (sgx_is_epc_page); + +void __attribute__((weak))sgx_memory_failure_vepc (struct sgx_epc_page *epc_page) +{ +} + +/* +* This can be called in three ways: +* a) When an enclave has just consumed poison. In this case +* calling process context is the owner of the enclave. +* b) For some asychronous poison notification (e.g. patrol +* scrubber or speculative execution saw the poison.) +* In this case calling context is a kernel thread. +* c) Someone asked to take a page offline using the +* /sys/devices/system/memory/{hard,soft}_offline_page. +* In this case caller is the process writing these files. +*/ +int sgx_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *epc_page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_encl_page *encl_page; +struct sgx_numa_node *node; +unsigned long addr; +u16 page_flags; + +if (!epc_page) +return -ENXIO ; + +spin_lock (&sgx_reclaimer_lock); + + page_flags = epc_page->flags; + epc_page->flags |=SGX_EPC_PAGE_POISON ; + +/* +* Poison was synchronously consumed by an enclave in the current +* task. Send a SIGBUS here. Hardware should prevent this enclave +* from being re-entered, so no concern that the poisoned page +* will be touched a second time. The poisoned EPC page will be +* dropped as pages are freed during task exit. +*/ +if (flags &MF_ACTION_REQUIRED ) { +if (epc_page->type ==SGX_PAGE_TYPE_REG ) { + encl_page = epc_page->owner; + addr = encl_page->desc &PAGE_MASK ; +force_sig_mceerr (BUS_MCEERR_AR , (void *)addr,PAGE_SHIFT ); + }else { +force_sig (SIGBUS ); + } + goto unlock; + } + + section = &sgx_epc_sections[epc_page->section]; + node = section->node; + +if (page_flags &SGX_EPC_PAGE_POISON ) + goto unlock; + +if (page_flags &SGX_EPC_PAGE_DIRTY ) { +list_del (&epc_page->list); + }else if (page_flags &SGX_EPC_PAGE_FREE ) { +spin_lock (&node->lock); + epc_page->owner =NULL ; +list_del (&epc_page->list); + sgx_nr_free_pages--; +spin_unlock (&node->lock); + goto unlock; + } + +switch (epc_page->type) { +case SGX_PAGE_TYPE_REG : + encl_page = epc_page->owner; +/* Unmap the page, unless it was already in progress to be freed */ +if (kref_get_unless_zero (&encl_page->encl->refcount) !=0 ) { +spin_unlock (&sgx_reclaimer_lock); +sgx_reclaimer_block (epc_page); +kref_put (&encl_page->encl->refcount, sgx_encl_release); + goto done; + } +break ; + +case SGX_PAGE_TYPE_KVM : +spin_unlock (&sgx_reclaimer_lock); +sgx_memory_failure_vepc (epc_page); +break ; + +default : +/* +* I don't expect SECS, TCS, VA pages would result +* in recoverable machine checks. If it turns out +* that they do, then add cases for recovery for +* each of them. +*/ +panic ("Poisoned active SGX page type %d\n" , epc_page->type); +break ; + } + goto done; + +unlock: +spin_unlock (&sgx_reclaimer_lock); +done: +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -39,7 +39,7 @@ struct sgx_epc_page {unsigned int section;u16 flags;u16 type; -struct sgx_encl_page *owner; +void *owner;struct list_head list; };
@@ -60,6 +60,7 @@ struct sgx_numa_node {*/ struct sgx_epc_section {unsigned long phys_addr; +unsigned long end_phys_addr;void *virt_addr;struct sgx_epc_page *pages;struct sgx_numa_node *node;
arch/x86/kernel/cpu/sgx/virt.c +9 -0
@@ -21,6 +21,7 @@struct sgx_vepc {struct xarray page_array;struct mutex lock; +struct task_struct *task; };/*
@@ -218,6 +219,13 @@ static int sgx_vepc_release(struct inode *inode, struct file *file)return 0 ; } +void sgx_memory_failure_vepc (struct sgx_epc_page *epc_page) +{ +struct sgx_vepc *vepc = epc_page->owner; + +send_sig (SIGBUS , vepc->task, false); +} +static int sgx_vepc_open (struct inode *inode,struct file *file) {struct sgx_vepc *vepc;
@@ -227,6 +235,7 @@ static int sgx_vepc_open(struct inode *inode, struct file *file)return -ENOMEM ;mutex_init (&vepc->lock);xa_init (&vepc->page_array); + vepc->task = current; file->private_data = vepc;
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH 3/4 x86/sgx: Hook sgx_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
--- include/linux/mm.h | 9 +++++++++ mm/memory-failure.c | 4 ++++ 2 files changed, 13 insertions(+)
include/linux/mm.h +9 -0
@@ -3251,5 +3251,14 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +#else +static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +4 -0
@@ -1453,6 +1453,10 @@ int memory_failure(unsigned long pfn, int flags) p =pfn_to_online_page (pfn);if (!p) { + res =sgx_memory_failure (pfn, flags); +if (res ==0 ) +return 0 ; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL );if (pgmap)
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH 4/4 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- include/linux/mm.h | 6 ++++++ 3 files changed, 27 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !sgx_is_epc_page(base_addr))) return -EINVAL; inject:
include/linux/mm.h +6 -0
@@ -3253,11 +3253,17 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)#ifdef CONFIG_X86_SGX int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr);#else static inline int sgx_memory_failure (unsigned long pfn,int flags) {return -ENXIO ; } + +static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +}#endif #endif /* __KERNEL__ */
Signature · 1 line
2.29.2
Tony Luck
reviewerv2 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckVery different from version 1 based on feedback.
Sean: Didn't like tracking types of SGX pages, so that's all gone now. I
do track the life cycle (in patch 1) using the "owner" field to determine whether a page is in use vs. dirty/free. Currently this series doesn't make use of that ... so patch 1 could be dropped. But it is very small, and I think a pre-requisite for future improvements to take pre-emptive action for asynch poison notification (rather that just hoping that the enclave will exit without accessing poison, or that if it does consume the poison the error will be recoverable).
I think we should defer the whole asynch action to a subsequent series that can build on top of this (and do it properly ... my version 1 sent out SIGBUS signals without regard for system (/proc/sys/vm/memory_failure_early_kill) or per-task (prctl PR_MCE_KILL) policies).
Jarkko: Said poison pages should not just be dropped on the floor. They
should be added to a list for future tools to examine. I tried the list approach, but safely removing pages from free/dirty lists involved some complex locking, so I skipped ahead to the "tools" idea and just added files in debugfs to show the count of poison pages and a list of addresses (maybe the count is redundant? Could just "wc -l poison_page_list"?).
Other: I got a complaint that after a poison page is handled Linux
spits out this message:
Could not invalidate pfn=0x2000c4d from 1:1 map
this is from set_mce_nospec() and happens because EPC pages are not in the 1:1 map. Add code to check and ignore them.
Tony Luck (6):
x86/sgx: Provide indication of life-cycle of EPC pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook sgx_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/encl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 137 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 6 +- drivers/acpi/apei/einj.c | 3 +- include/linux/mm.h | 15 ++ mm/memory-failure.c | 19 ++- 8 files changed, 195 insertions(+), 10 deletions(-)
base-commit: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v2 1/6 x86/sgx: Provide indication of life-cycle of EPC pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the sgx_epc_page->owner field as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller, sgx_alloc_va_page(), that calls with NULL.
Make the following changes:
1) Change the type of "owner" to "void *" (it can have other types besides "struct sgx_encl_page *).
2) Update sgx_alloc_va_page() to pass in a dummy non-NULL value in this case.
3) Add a check to sgx_free_epc_page() to prevent calling with NULL.
4) Reset owner to NULL in sgx_free_epc_page().
--- arch/x86/kernel/cpu/sgx/encl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 6 ++++++ arch/x86/kernel/cpu/sgx/sgx.h | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/encl.c +1 -1
@@ -679,7 +679,7 @@ struct sgx_epc_page *sgx_alloc_va_page(void)struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page ("Not NULL!" , true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);
arch/x86/kernel/cpu/sgx/main.c +6 -0
@@ -578,6 +578,11 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) {struct sgx_epc_page *page; +if (!owner) { +WARN_ON_ONCE (1 ); +return NULL ; + } +for ( ; ; ) { page =__sgx_alloc_epc_page ();if (!IS_ERR (page)) {
@@ -624,6 +629,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->owner =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
arch/x86/kernel/cpu/sgx/sgx.h +1 -1
@@ -29,7 +29,7 @@struct sgx_epc_page {unsigned int section;unsigned int flags; -struct sgx_encl_page *owner; +void *owner;struct list_head list; };
Signature · 1 line
2.29.2
Re: [PATCH v2 1/6] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 2 lines · Tony Luck
1) Change the type of "owner" to "void *" (it can have other types besides "struct
sgx_encl_page*).
I see:
static int __sgx_vepc_fault(struct sgx_vepc *vepc, {
...
epc_page = sgx_alloc_epc_page(vepc, false);
where sgx_alloc_epc_page() sets page->owner=vepc. But, I don't see a *reader* anywhere. Do we actually use that vepc anywhere?
Re: [PATCH v2 1/6] x86/sgx: Provide indication of life-cycle of EPC pages
In reply to Tony LuckQuoted 36 lines · Tony Luck
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\ ^ | \-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the
sgx_epc_page->ownerfield as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller,sgx_alloc_va_page(), that calls with NULL.Make the following changes:
1) Change the type of "owner" to "void *" (it can have other types besides "struct
sgx_encl_page*).
2) Updatesgx_alloc_va_page()to pass in a dummy non-NULL value in this case.
3) Add a check tosgx_free_epc_page()to prevent calling with NULL.
4) Reset owner to NULL insgx_free_epc_page().Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/encl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 6 ++++++ arch/x86/kernel/cpu/sgx/sgx.h | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-)arch/x86/kernel/cpu/sgx/encl.c +0
-0
arch/x86/kernel/cpu/sgx/encl.c struct sgx_epc_page *sgx_alloc_va_page(void) · line 682
Quoted 5 lines
arch/x86/kernel/cpu/sgx/encl.c +1
-1@@ -679,7 +679,7 @@ struct sgx_epc_page *sgx_alloc_va_page(void)struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page ("Not NULL!" , true);
I would instead set owner to epc_page inside sgx_alloc_epc_page(), when NULL is passed to owner. That would be semantically sound.
/Jarkko
Tony Luck
reviewerPATCH v2 2/6 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
Add an end_phys_addr field to the sgx_epc_section structure and a new function sgx_paddr_to_page() that searches all such structures and returns the struct sgx_epc_page pointer if the address is an EPC page. This function is only intended for use within SGX code.
Export a function sgx_is_epc_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel.
--- arch/x86/kernel/cpu/sgx/main.c | 24 ++++++++++++++++++++++++ arch/x86/kernel/cpu/sgx/sgx.h | 1 + 2 files changed, 25 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +24 -0
@@ -654,6 +654,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ;for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -665,6 +666,29 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; +int i; + +for (i =0 ; i <ARRAY_SIZE (sgx_epc_sections); i++) { + section = &sgx_epc_sections[i]; + +if (paddr < section->phys_addr || paddr > section->end_phys_addr) +continue ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; + } + +return NULL ; +} + +bool sgx_is_epc_page (u64 paddr) +{ +return !!sgx_paddr_to_page (paddr); +} +EXPORT_SYMBOL_GPL (sgx_is_epc_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
arch/x86/kernel/cpu/sgx/sgx.h +1 -0
@@ -50,6 +50,7 @@ struct sgx_numa_node {*/ struct sgx_epc_section {unsigned long phys_addr; +unsigned long end_phys_addr;void *virt_addr;struct sgx_epc_page *pages;struct sgx_numa_node *node;
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v2 3/6 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add a new flag bit (SGX_EPC_PAGE_POISON) that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When allocating pages
3) When freeing epc pages
In all cases drop the poisoned page to make sure it will not be reallocated.
Add debugfs files /sys/kernel/debug/sgx/poison_page_{count,list} so that system administrators can see how many enclave pages have been dropped and get a list of those pages.
--- arch/x86/kernel/cpu/sgx/main.c | 50 +++++++++++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++ 2 files changed, 52 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/main.c +49 -1
@@ -11,6 +11,7 @@#include <linux/sched/mm.h> #include <linux/sched/signal.h> #include <linux/slab.h> +#include <linux/debugfs.h> #include <asm/sgx.h> #include "driver.h" #include "encl.h"
@@ -34,6 +35,9 @@ static unsigned long sgx_nr_free_pages;/* Nodes with one or more EPC sections. */ static nodemask_t sgx_numa_mask; +/* Maintain a count of poison pages */ +static u32 poison_page_count; +/* * Array with one list_head for each possible NUMA node. Each * list contains all the sgx_epc_section's which are on that
@@ -47,6 +51,9 @@ static LIST_HEAD(sgx_dirty_page_list);* Reset post-kexec EPC pages to the uninitialized state. The pages are removed * from the input list, and made available for the page allocator. SECS pages * prepending their children in the input list are left intact. +* +* Don't try to clean a poisoned page. That might trigger a machine check. +* Just drop the page and move on. */ static void __sgx_sanitize_pages (struct list_head *dirty_page_list) {
@@ -61,6 +68,11 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->flags &SGX_EPC_PAGE_POISON ) { +list_del (&page->list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -567,6 +579,9 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* @reclaim is set to true, directly reclaim pages when we are out of pages. No * mm's can be locked when @reclaim is set to true. * +* A page on the free list might have been reported as poisoned by the patrol +* scrubber. If so, skip this page, and try again. +* * Finally, wake up ksgxd when the number of pages goes below the watermark * before returning back to the caller. *
@@ -585,6 +600,10 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)for ( ; ; ) { page =__sgx_alloc_epc_page (); + +if (page->flags &SGX_EPC_PAGE_POISON ) +continue ; +if (!IS_ERR (page)) { page->owner = owner;break ;
@@ -621,6 +640,8 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)* responsibility to make sure that the page is in uninitialized state. In other * words, do EREMOVE, EWB or whatever operation is necessary before calling * this function. +* +* Drop poison pages so they won't be reallocated. */ void sgx_free_epc_page (struct sgx_epc_page *page) {
@@ -630,7 +651,8 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); page->owner =NULL ; -list_add_tail (&page->list, &node->free_page_list); +if (!(page->flags &SGX_EPC_PAGE_POISON )) +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);
@@ -820,8 +842,30 @@ int sgx_set_attribute(unsigned long *allowed_attributes, }EXPORT_SYMBOL_GPL (sgx_set_attribute); +static int poison_list_show (struct seq_file *m,void *private) +{ +struct sgx_epc_section *section; +struct sgx_epc_page *page; +unsigned long addr; +int i; + +for (i =0 ; i <SGX_MAX_EPC_SECTIONS ; i++) { + section = &sgx_epc_sections[i]; + page = section->pages; +for (addr = section->phys_addr; addr < section->end_phys_addr; + addr +=PAGE_SIZE , page++) { +if (page->flags &SGX_EPC_PAGE_POISON ) +seq_printf (m,"0x%lx\n" , addr); + } + } +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (poison_list); +static int __init sgx_init (void ) { +struct dentry *dir;int ret;int i;
@@ -853,6 +897,10 @@ static int __init sgx_init(void)if (sgx_vepc_init () && ret) goto err_provision; + dir =debugfs_create_dir ("sgx" ,NULL ); +debugfs_create_u32 ("poison_page_count" ,0400 , dir, &poison_page_count); +debugfs_create_file ("poison_page_list" ,0400 , dir,NULL , &poison_list_fops); +return 0 ; err_provision:
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Poisoned pages */ +#define SGX_EPC_PAGE_POISON BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Signature · 1 line
2.29.2
Re: [PATCH v2 3/6] x86/sgx: Initial poison handling for dirty and free pages
arch/x86/kernel/cpu/sgx/main.c static int __init sgx_init(void) · line 902
Quoted 3 lines · Tony Luck
arch/x86/kernel/cpu/sgx/main.c +3
-0+ dir =debugfs_create_dir ("sgx" ,NULL ); +debugfs_create_u32 ("poison_page_count" ,0400 , dir, &poison_page_count); +debugfs_create_file ("poison_page_list" ,0400 , dir,NULL , &poison_list_fops);
I'm adding debugfs attributes in my reclaimer kselftest patch set. The feedback that I got from Boris for that is that these must be documented in Documentation/x86/sgx.rst.
/Jarkko
Tony Luck
reviewerPATCH v2 4/6 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
--- arch/x86/kernel/cpu/sgx/main.c | 57 ++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +57 -0
@@ -711,6 +711,63 @@ bool sgx_is_epc_page(u64 paddr) }EXPORT_SYMBOL_GPL (sgx_is_epc_page); +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int sgx_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + +/* Already poisoned? Nothing more to do */ +if (page->flags &SGX_EPC_PAGE_POISON ) +return 0 ; + + page->flags |=SGX_EPC_PAGE_POISON ; + poison_page_count++; + +/* +* Nothing more to do here for dirty/free pages. +* They will be added to the poison list when +* they get to the head of their lists. +*/ +if (!page->owner) +return 0 ; + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ + +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v2 5/6 x86/sgx: Hook sgx_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 15 +++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 3 files changed, 32 insertions(+), 6 deletions(-)
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (sgx_is_epc_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +15 -0
@@ -3283,5 +3283,20 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else +static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} + +static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1626,21 +1626,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =sgx_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v2 6/6 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !sgx_is_epc_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.29.2
Quoted 51 lines · Tony Luck
Very different from version 1 based on feedback.
Sean: Didn't like tracking types of SGX pages, so that's all gone now. I
do track the life cycle (in patch 1) using the "owner" field to determine whether a page is in use vs. dirty/free. Currently this series doesn't make use of that ... so patch 1 could be dropped. But it is very small, and I think a pre-requisite for future improvements to take pre-emptive action for asynch poison notification (rather that just hoping that the enclave will exit without accessing poison, or that if it does consume the poison the error will be recoverable).I think we should defer the whole asynch action to a subsequent series that can build on top of this (and do it properly ... my version 1 sent out SIGBUS signals without regard for system (
/proc/sys/vm/memory_failure_early_kill) or per-task (prctlPR_MCE_KILL) policies).Jarkko: Said poison pages should not just be dropped on the floor. They
should be added to a list for future tools to examine. I tried the list approach, but safely removing pages from free/dirty lists involved some complex locking, so I skipped ahead to the "tools" idea and just added files in debugfs to show the count of poison pages and a list of addresses (maybe the count is redundant? Could just "wc -lpoison_page_list"?).Other: I got a complaint that after a poison page is handled Linux
spits out this message:
Could not invalidate pfn=0x2000c4d from 1:1 map
this is fromset_mce_nospec()and happens because EPC pages are not in the 1:1 map. Add code to check and ignore them.Tony Luck (6):
x86/sgx: Provide indication of life-cycle of EPC pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hooksgx_memory_failure()into mainline code x86/sgx: Add hook to error injection address validation.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/encl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 137 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 6 +- drivers/acpi/apei/einj.c | 3 +- include/linux/mm.h | 15 ++ mm/memory-failure.c | 19 ++- 8 files changed, 195 insertions(+), 10 deletions(-)
Quoted 1 line
base-commit:
2734d6c1b1a089fb593ef6a23d4b70903526fe0c
Use [email protected] in future versions.
/Jarkko
Tony Luck
reviewerv3 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckChanges since v2:
Jarkko:
1) Don't provide a dummy non-NULL value for "owner" of new SGX EPC pages at the call site. Instead change sgx_alloc_epc_page() to provide a non-NULL value.
2) Add description of the new debugfs files to sgx.rst [Added a whole section on uncorrected memory errors]
Tony Luck (7):
x86/sgx: Provide indication of life-cycle of EPC pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook sgx_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add documentation for SGX memory errors
.../firmware-guide/acpi/apei/einj.rst | 19 +++ Documentation/x86/sgx.rst | 26 ++++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/main.c | 134 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 6 +- drivers/acpi/apei/einj.c | 3 +- include/linux/mm.h | 15 ++ mm/memory-failure.c | 19 ++- 8 files changed, 216 insertions(+), 10 deletions(-)
base-commit: ff1176468d368232b684f75e82563369208bc371
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v3 1/7 x86/sgx: Provide indication of life-cycle of EPC pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the sgx_epc_page->owner field as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller, sgx_alloc_va_page(), that calls with NULL.
Make the following changes:
1) Change the type of "owner" to "void *" (it can have other types besides "struct sgx_encl_page *).
2) Add a check to sgx_free_epc_page(). If the caller specified the owner as NULL, then set the owner field to self-reference the SGX epc page itself.
3) Reset owner to NULL in sgx_free_epc_page().
--- arch/x86/kernel/cpu/sgx/main.c | 3 ++- arch/x86/kernel/cpu/sgx/sgx.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +2 -1
@@ -581,7 +581,7 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)for ( ; ; ) { page =__sgx_alloc_epc_page ();if (!IS_ERR (page)) { - page->owner = owner; + page->owner = owner ? owner : page;break ; }
@@ -624,6 +624,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->owner =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
arch/x86/kernel/cpu/sgx/sgx.h +1 -1
@@ -29,7 +29,7 @@struct sgx_epc_page {unsigned int section;unsigned int flags; -struct sgx_encl_page *owner; +void *owner;struct list_head list; };
Signature · 1 line
2.29.2
Re: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
arch/x86/kernel/cpu/sgx/main.c struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) · line 586
Quoted 9 lines · Tony Luck
+++
b/arch/x86/kernel/cpu/sgx/main.carch/x86/kernel/cpu/sgx/main.c +1
-1@@ -581,7 +581,7 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)for ( ; ; ) { page =__sgx_alloc_epc_page ();if (!IS_ERR (page)) { - page->owner = owner; + page->owner = owner ? owner : page;break ; }
I'm a little worried about this.
Let's say we get confused about the type of the page and dereference page->owner. If it's NULL, we get a nice oops. If it's a real, valid pointer, we get real valid memory back that we can scribble on.
Wouldn't it be safer to do something like:
page->owner = owner ? owner : (void *)-1;
-1 is non-NULL, but also invalid, which makes it harder for us to poke ourselves in the eye.
Luck, Tony
reviewerRE: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 6 lines
Wouldn't it be safer to do something like:
page->owner = owner ? owner : (void *)-1;-1 is non-NULL, but also invalid, which makes it harder for us to poke ourselves in the eye.
Does Linux have some #define INVALID_POINTER thing that provides a guaranteed bad (e.g. non-canonical) value?
(void *)-1 seems hacky.
-Tony
Re: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 10 lines · Tony
Quoted 6 lines
Wouldn't it be safer to do something like:
page->owner = owner ? owner : (void *)-1;-1 is non-NULL, but also invalid, which makes it harder for us to poke ourselves in the eye.
Does Linux have some #define
INVALID_POINTERthing that provides a guaranteed bad (e.g. non-canonical) value?(void *)-1 seems hacky.
ERR_PTR(-SOMETHING) wouldn't be too bad. I guess it could even be:
page->owner = ERR_PTR(SGX_EPC_PAGE_VA);
and then:
#define SGX_EPC_PAGE_VA 0xffff...something...greppable
I *thought* we had a file full of these magic values, but maybe I'm misremembering the uapi magic header.
Re: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 14 lines · Dave Hansen
Quoted 10 lines · Tony
Quoted 6 lines
Wouldn't it be safer to do something like:
page->owner = owner ? owner : (void *)-1;-1 is non-NULL, but also invalid, which makes it harder for us to poke ourselves in the eye.
Does Linux have some #define
INVALID_POINTERthing that provides a guaranteed bad (e.g. non-canonical) value?(void *)-1 seems hacky.
ERR_PTR(-SOMETHING)wouldn't be too bad. I guess it could even be:
Quoted 8 lines
page->owner = ERR_PTR(SGX_EPC_PAGE_VA);and then:
#define
SGX_EPC_PAGE_VA0xffff...something...greppableI *thought* we had a file full of these magic values, but maybe I'm misremembering the uapi magic header.
Rather than use a magic const, just pass in the actual va_page. The only reason NULL is passed is that prior to virtual EPC, there were only enclave pages and VA pages, and assiging a non-NULL pointer to sgx_epc_page.owner, which is a struct sgx_encl_page, was gross. Virtual EPC sets owner somewhat prematurely; it's needed iff an EPC cgroup is added, to support OOM EPC killing (and a pointer to va_page is also needed in this case).
sgx_epc_page.owner can even be converted to 'void *' without additional changes since all consumers capture it in a local sgx_encl_page variable.
arch/x86/kernel/cpu/sgx/encl.c +2 -2
@@ -674,12 +674,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page) {struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (va_page, true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);
arch/x86/kernel/cpu/sgx/encl.h +1 -1
@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);
arch/x86/kernel/cpu/sgx/sgx.h +1 -1
@@ -29,7 +29,7 @@struct sgx_epc_page {unsigned int section;unsigned int flags; -struct sgx_encl_page *owner; +void *owner;struct list_head list; };
Luck, Tony
reviewerRE: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
arch/x86/kernel/cpu/sgx/encl.c int sgx_encl_test_and_clear_young(struct mm_struct *mm, · line 682
Quoted 2 lines
arch/x86/kernel/cpu/sgx/encl.c +1
-1- epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (va_page, true);
Providing a real value for the owner seems much better than all the hacks to invent a value to use instead of NULL.
Can you add a "Signed-off-by"? Then I'll replace my part 0001 with your version.
-Tony
[Just need to coax you into re-writing all the other parts for me now :-) ]
Re: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 7 lines · Tony
arch/x86/kernel/cpu/sgx/encl.c int sgx_encl_test_and_clear_young(struct mm_struct *mm, · line 682
Quoted 2 lines
arch/x86/kernel/cpu/sgx/encl.c +1
-1- epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (va_page, true);Providing a real value for the owner seems much better than all the hacks to invent a value to use instead of NULL.
Can you add a "Signed-off-by"? Then I'll replace my part 0001 with your version.
Quoted 3 lines
-Tony
[Just need to coax you into re-writing all the other parts for me now :-) ]
LOL, it might be easier to convince folks to just kill off SGX ;-)
Luck, Tony
reviewerRe: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 8 lines · Sean Christopherson
Quoted 7 lines · Tony
Review
Quoted 2 lines
(quoted diff) +1
-1- epc_page = sgx_alloc_epc_page(NULL, true); + epc_page = sgx_alloc_epc_page(va_page, true);Providing a real value for the owner seems much better than all the hacks to invent a value to use instead of NULL.
Can you add a "Signed-off-by"? Then I'll replace my part 0001 with your version.
My commit comment (updated to match how the code actually changed). Sean's code.
N.B. I added the kernel doc entry for the new argument to sgx_alloc_va_page()
+ * @va_page: struct sgx_va_page connected to this VA page
If you have something better, then I will swap that line out too.
-Tony
From: Sean Christopherson <[email protected]>
Subject: [PATCH] x86/sgx: Provide indication of life-cycle of EPC pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the sgx_epc_page->owner field as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller, sgx_alloc_va_page(), that calls with NULL.
Fix up the one holdout to provide a non-NULL owner.
Also change the type of "owner" to "void *" (since it can have other types besides "struct sgx_encl_page *").
--- arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/sgx.h | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-)
arch/x86/kernel/cpu/sgx/encl.c +3 -2
@@ -667,6 +667,7 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,/** * sgx_alloc_va_page() - Allocate a Version Array (VA) page +* @va_page: struct sgx_va_page connected to this VA page * * Allocate a free EPC page and convert it to a Version Array (VA) page. *
@@ -674,12 +675,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page) {struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (va_page, true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);
arch/x86/kernel/cpu/sgx/encl.h +1 -1
@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);
arch/x86/kernel/cpu/sgx/sgx.h +1 -1
@@ -29,7 +29,7 @@struct sgx_epc_page {unsigned int section;unsigned int flags; -struct sgx_encl_page *owner; +void *owner;struct list_head list; };
Signature · 1 line
2.29.2
Jarkko Sakkinen
maintainerRe: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
In reply to Luck, TonyQuoted 7 lines · Tony
Quoted 6 lines
Wouldn't it be safer to do something like:
page->owner = owner ? owner : (void *)-1;-1 is non-NULL, but also invalid, which makes it harder for us to poke ourselves in the eye.
Quoted 6 lines
Does Linux have some #define
INVALID_POINTERthing that provides a guaranteed bad (e.g. non-canonical) value?(void *)-1 seems hacky.
-Tony
MAP_FAILED?
/Jarkko
Jarkko Sakkinen
maintainerRe: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
In reply to Dave HansenQuoted 17 lines · Dave Hansen
arch/x86/kernel/cpu/sgx/main.c struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim) · line 586
Quoted 9 lines · Tony Luck
+++
b/arch/x86/kernel/cpu/sgx/main.carch/x86/kernel/cpu/sgx/main.c +1
-1@@ -581,7 +581,7 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)for ( ; ; ) { page =__sgx_alloc_epc_page ();if (!IS_ERR (page)) { - page->owner = owner; + page->owner = owner ? owner : page;break ; }I'm a little worried about this.
Let's say we get confused about the type of the page and dereference
page->owner. If it's NULL, we get a nice oops. If it's a real, valid pointer, we get real valid memory back that we can scribble on.
Quoted 6 lines
Wouldn't it be safer to do something like:
page->owner = owner ? owner : (void *)-1;-1 is non-NULL, but also invalid, which makes it harder for us to poke ourselves in the eye.
Works for me.
/Jarkko
Tony Luck
reviewerPATCH v3 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
Add an end_phys_addr field to the sgx_epc_section structure and a new function sgx_paddr_to_page() that searches all such structures and returns the struct sgx_epc_page pointer if the address is an EPC page. This function is only intended for use within SGX code.
Export a function sgx_is_epc_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel.
--- arch/x86/kernel/cpu/sgx/main.c | 24 ++++++++++++++++++++++++ arch/x86/kernel/cpu/sgx/sgx.h | 1 + 2 files changed, 25 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +24 -0
@@ -649,6 +649,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ;for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -660,6 +661,29 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; +int i; + +for (i =0 ; i <ARRAY_SIZE (sgx_epc_sections); i++) { + section = &sgx_epc_sections[i]; + +if (paddr < section->phys_addr || paddr > section->end_phys_addr) +continue ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; + } + +return NULL ; +} + +bool sgx_is_epc_page (u64 paddr) +{ +return !!sgx_paddr_to_page (paddr); +} +EXPORT_SYMBOL_GPL (sgx_is_epc_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
arch/x86/kernel/cpu/sgx/sgx.h +1 -0
@@ -50,6 +50,7 @@ struct sgx_numa_node {*/ struct sgx_epc_section {unsigned long phys_addr; +unsigned long end_phys_addr;void *virt_addr;struct sgx_epc_page *pages;struct sgx_numa_node *node;
Signature · 1 line
2.29.2
Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 2 lines · Tony Luck
Export a function
sgx_is_epc_page()that simply reports whether an address is an EPC page for use elsewhere in the kernel.
It would be really nice to mention why this needs to be exported to modules. I assume it's the error injection driver or something that can be built as a module, but this export was a surprise when I saw it.
It's probably also worth noting that this is a sloooooooow implementation compared to the core VM code that does something
analogous: pfn_to_page(). It's fine for error handling, but we should probably have a comment to this effect so that more liberal use doesn't creep in anywhere.
Jarkko Sakkinen
maintainerRe: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 8 lines · Dave Hansen
Quoted 2 lines · Tony Luck
Export a function
sgx_is_epc_page()that simply reports whether an address is an EPC page for use elsewhere in the kernel.It would be really nice to mention why this needs to be exported to modules. I assume it's the error injection driver or something that can be built as a module, but this export was a surprise when I saw it.
Quoted 5 lines
It's probably also worth noting that this is a sloooooooow implementation compared to the core VM code that does something
analogous:pfn_to_page(). It's fine for error handling, but we should probably have a comment to this effect so that more liberal use doesn't creep in anywhere.
You could also create an xarray to track physical EPC address ranges, and make the query fast.
/Jarkko
Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 9 lines · Jarkko Sakkinen
Quoted 8 lines · Dave Hansen
Quoted 2 lines · Tony Luck
Export a function
sgx_is_epc_page()that simply reports whether an address is an EPC page for use elsewhere in the kernel.It would be really nice to mention why this needs to be exported to modules. I assume it's the error injection driver or something that can be built as a module, but this export was a surprise when I saw it.
Quoted 8 lines
Quoted 5 lines
It's probably also worth noting that this is a sloooooooow implementation compared to the core VM code that does something
analogous:pfn_to_page(). It's fine for error handling, but we should probably have a comment to this effect so that more liberal use doesn't creep in anywhere.You could also create an xarray to track physical EPC address ranges, and make the query fast.
Eh, it's not _that_ slow due to the constraints on the number of EPC sections. The hard limit is currently '8', and practically speaking there will be one section per socket. Turning a linear search into a binary search in this case isn't going to buy much.
Out of curiosity, on multi-socket systems, are EPC sections clustered in a single address range, or are they interleaved with regular RAM? If they're clustered, you could track the min/max across all sections to optimize the common case that an address isn't in any EPC section.
static struct sgx_epc_page *sgx_paddr_to_page(u64 paddr)
{
struct sgx_epc_section *section;
int i;
if (paddr < min_epc_pa || paddr > max_epc_pa)
return NULL;
for (i = 0; i < ARRAY_SIZE(sgx_epc_sections); i++) {
section = &sgx_epc_sections[i];
if (paddr < section->phys_addr || paddr > section->end_phys_addr)
continue;
return §ion->pages[PFN_DOWN(paddr - section->phys_addr)];
}
return NULL;
}Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 4 lines · Sean Christopherson
Out of curiosity, on multi-socket systems, are EPC sections clustered in a single address range, or are they interleaved with regular RAM? If they're clustered, you could track the min/max across all sections to optimize the common case that an address isn't in any EPC section.
They're interleaved on the systems that I've seen:
Socket 0 - RAM
Socket 0 - EPC
Socket 1 - RAM
Socket 1 - EPC
It would probably be pretty expensive in terms of the physical address remapping resources to cluster them.
Luck, Tony
reviewerRe: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 8 lines · Dave Hansen
Quoted 4 lines · Sean Christopherson
Out of curiosity, on multi-socket systems, are EPC sections clustered in a single address range, or are they interleaved with regular RAM? If they're clustered, you could track the min/max across all sections to optimize the common case that an address isn't in any EPC section.
They're interleaved on the systems that I've seen:
Quoted 7 lines
Socket 0 - RAM
Socket 0 - EPC
Socket 1 - RAM
Socket 1 - EPCIt would probably be pretty expensive in terms of the physical address remapping resources to cluster them.
I thought xarray was overkill ... and it is ... but it makes the code considerably shorter/simpler!
I think I'm going to go with it. Thanks to Jarkko for the suggestion.
Also added comments based on Dave's feedback on why the function is exported, and that sgx_is_epc_page() will be slower than people might expect.
-Tony
From 7026de93f5bf370be9d067cdc068a4a2a54bbd3e Mon Sep 17 00:00:00 2001
From: Tony Luck <[email protected]>
Date: Fri, 30 Jul 2021 11:39:45 -0700
Subject: [PATCH] x86/sgx: Add infrastructure to identify SGX EPC pages
X86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function sgx_is_epc_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that sgx_is_epc_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
--- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++++++++++++ arch/x86/kernel/cpu/sgx/sgx.h | 1 + 2 files changed, 22 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +21 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (epc_page_ranges);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -649,6 +650,9 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ; +xa_store_range (&epc_page_ranges, section->phys_addr, + section->end_phys_addr, section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -660,6 +664,23 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&epc_page_ranges, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +bool sgx_is_epc_page (u64 paddr) +{ +return !!xa_load (&epc_page_ranges, paddr); +} +EXPORT_SYMBOL_GPL (sgx_is_epc_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
arch/x86/kernel/cpu/sgx/sgx.h +1 -0
@@ -50,6 +50,7 @@ struct sgx_numa_node {*/ struct sgx_epc_section {unsigned long phys_addr; +unsigned long end_phys_addr;void *virt_addr;struct sgx_epc_page *pages;struct sgx_numa_node *node;
Signature · 1 line
2.29.2
Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 655
Quoted 7 lines · Tony
arch/x86/kernel/cpu/sgx/main.c +3
-0@@ -649,6 +650,9 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ; +xa_store_range (&epc_page_ranges, section->phys_addr, + section->end_phys_addr, section,GFP_KERNEL );
That is compact, but how much memory does it eat? I'm a little worried about this hunk of xa_store_range():
Quoted 7 lines
(quoted diff) +0
-0do { xas_set_range(&xas, first, last); xas_store(&xas, entry);if (xas_error(&xas)) goto unlock; first += xas_size(&xas); } while (first <= last);
That makes it look like it's iterating over the whole range and making loads of individual array instead of doing something super clever like keeping an extent-style structure.
Let's say we have 1TB of EPC. How big is the array to store these indexes? Would this be more compact if instead of doing a physical address range:
xa_store_range(&epc_page_ranges, section->phys_addr, section->end_phys_addr, ...);
... you did it based on PFNs:
xa_store_range(&epc_page_ranges, section->phys_addr >> PAGE_SHIFT, section->end_phys_addr >> PAGE_SHIFT, ...);
SGX sections are at *least* page-aligned, so this should be fine.
Luck, Tony
reviewerRE: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 11 lines
xa_store_range(&epc_page_ranges, section->phys_addr, section->end_phys_addr, ...);... you did it based on PFNs:
xa_store_range(&epc_page_ranges, section->phys_addr >> PAGE_SHIFT, section->end_phys_addr >> PAGE_SHIFT, ...);SGX sections are at *least* page-aligned, so this should be fine.
I found xa_dump() (hidden inside #ifdef XA_DEBUG)
Trying both with and without the >> PAGE_SHIFT made no difference to the number of lines of console output that xa_dump() spits out. 266 either way.
There are only two ranges on this system
[ 11.937592] sgx: EPC section 0x8000c00000-0x807f7fffff [ 11.945811] sgx: EPC section 0x10000c00000-0x1007fffffff
So I'm a little bit sad that xarray appears to have broken them up into a bunch of pieces.
-Tony
Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 18 lines · Tony
Quoted 11 lines
xa_store_range(&epc_page_ranges, section->phys_addr, section->end_phys_addr, ...);... you did it based on PFNs:
xa_store_range(&epc_page_ranges, section->phys_addr >> PAGE_SHIFT, section->end_phys_addr >> PAGE_SHIFT, ...);SGX sections are at *least* page-aligned, so this should be fine.
I found
xa_dump()(hidden inside #ifdefXA_DEBUG)Trying both with and without the >>
PAGE_SHIFTmade no difference to the number of lines of console output thatxa_dump()spits out. 266 either way.
Quoted 7 lines
There are only two ranges on this system
[ 11.937592] sgx: EPC section 0x8000c00000-0x807f7fffff [ 11.945811] sgx: EPC section 0x10000c00000-0x1007fffffffSo I'm a little bit sad that xarray appears to have broken them up into a bunch of pieces.
That's inherent in the (current) back end data structure, I'm afraid. As a radix tree, it can only look up based on the N bits available at each level of the tree, so if your entry is an aligned power-of-64, everything is nice and neat, and you're a single entry at one level of the tree. If you're an arbitrary range, things get more complicated, and I have to do a little dance to redirect the lookup towards the canonical entry.
Liam and I are working on a new replacement data structure called the Maple Tree, but it's not yet ready to replace the radix tree back end. It looks like it would be perfect for your case; there would be five entries in it, stored in one 256-byte node:
NULL0x8000bfffff
p1 0x807f7fffff NULL 0x10000c00000 p2
0x1007fffffff
NULL
0xffff'ffff'ffff'ffff
It would actually turn into a linear scan, because that's just the fastest way to find something in a list of five elements. A third range would take us to a list of seven elements, which still fits in a single node. Once we get to more than that, you'd have a two-level tree, which would work until you have more than ~20 ranges.
We could do better for your case by storing 10x (start, end, p) in each leaf node, but we're (currently) optimising for VMAs which tend to be tightly packed, meaning that an implicit 'start' element is a better choice as it gives us 15x (end, p) pairs.
Luck, Tony
reviewerRe: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Sent from my iPhone
Quoted 24 lines
On Aug 3, 2021, at 14:47, Matthew Wilcox
Liam and I are working on a new replacement data structure called the Maple Tree, but it's not yet ready to replace the radix tree back end. It looks like it would be perfect for your case; there would be five entries in it, stored in one 256-byte node:
NULL
0x8000bfffff
p10x807f7fffff
NULL0x10000c00000
p20x1007fffffff
NULL
0xffff'ffff'ffff'ffffIt would actually turn into a linear scan, because that's just the fastest way to find something in a list of five elements. A third range would take us to a list of seven elements, which still fits in a single node. Once we get to more than that, you'd have a two-level tree, which would work until you have more than ~20 ranges.
Quoted 4 lines
We could do better for your case by storing 10x (start, end, p) in each leaf node, but we're (currently) optimising for VMAs which tend to be tightly packed, meaning that an implicit 'start' element is a better choice as it gives us 15x (end, p) pairs.
That’s good to know. While current xarray implementation might be a bit wasteful[1], things will get better.
I’m still going with xarray to keep the source simple.
-Tony
[1] A few KBytes extra doesn’t even sound too terrible to manage tens of MBytes (or more) of SGX EPC memory on a system with a half TByte total memory.
Jarkko Sakkinen
maintainerRe: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Luck, TonyQuoted 14 lines · Tony
Quoted 13 lines · Dave Hansen
Quoted 4 lines · Sean Christopherson
Out of curiosity, on multi-socket systems, are EPC sections clustered in a single address range, or are they interleaved with regular RAM? If they're clustered, you could track the min/max across all sections to optimize the common case that an address isn't in any EPC section.
They're interleaved on the systems that I've seen:
Socket 0 - RAM
Socket 0 - EPC
Socket 1 - RAM
Socket 1 - EPC
Quoted 7 lines
Quoted 2 lines
It would probably be pretty expensive in terms of the physical address remapping resources to cluster them.
I thought xarray was overkill ... and it is ... but it makes the code considerably shorter/simpler!
I think I'm going to go with it. Thanks to Jarkko for the suggestion.
If it makes the code considerably simpler, that in my opinion justifies the minor size increase.
/Jarkko
Jarkko Sakkinen
maintainerRe: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Dave HansenQuoted 8 lines · Dave Hansen
Quoted 4 lines · Sean Christopherson
Out of curiosity, on multi-socket systems, are EPC sections clustered in a single address range, or are they interleaved with regular RAM? If they're clustered, you could track the min/max across all sections to optimize the common case that an address isn't in any EPC section.
They're interleaved on the systems that I've seen:
Quoted 7 lines
Socket 0 - RAM
Socket 0 - EPC
Socket 1 - RAM
Socket 1 - EPCIt would probably be pretty expensive in terms of the physical address remapping resources to cluster them.
If they were clustered, wouldn't that also break up our initialization code for NUMA? It's based on detecting of which NUMA nodes address range is the given EPC section.
I.e. there should be some meta-data to draw the connection to the correct NUMA node, if they were clustered (which does not exist).
/Jarkko
Jarkko Sakkinen
maintainerRe: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Sean ChristophersonQuoted 16 lines · Sean Christopherson
Quoted 15 lines · Jarkko Sakkinen
Quoted 13 lines · Dave Hansen
Quoted 2 lines · Tony Luck
Export a function
sgx_is_epc_page()that simply reports whether an address is an EPC page for use elsewhere in the kernel.It would be really nice to mention why this needs to be exported to modules. I assume it's the error injection driver or something that can be built as a module, but this export was a surprise when I saw it.
It's probably also worth noting that this is a sloooooooow implementation compared to the core VM code that does something
analogous:pfn_to_page(). It's fine for error handling, but we should probably have a comment to this effect so that more liberal use doesn't creep in anywhere.
Quoted 7 lines
Quoted 2 lines
You could also create an xarray to track physical EPC address ranges, and make the query fast.
Eh, it's not _that_ slow due to the constraints on the number of EPC sections. The hard limit is currently '8', and practically speaking there will be one section per socket. Turning a linear search into a binary search in this case isn't going to buy much.
Also, consumes more memory.
Just pointing out that it is possible to improve without much fuzz, if ever required, for instance by using DEFINE_XARRAY() to be define file-scope xarray.
Quoted 4 lines
Out of curiosity, on multi-socket systems, are EPC sections clustered in a single address range, or are they interleaved with regular RAM? If they're clustered, you could track the min/max across all sections to optimize the common case that an address isn't in any EPC section.
Given that physical address ranges of different NUMA nodes are disjoint, and each has EPC section is reserved from one such section, I would presume that they are interleaved.
Quoted 11 lines
static struct
sgx_epc_page*sgx_paddr_to_page(u64 paddr){ struct sgx_epc_section *section; int i; if (paddr < min_epc_pa || paddr > max_epc_pa) return NULL; for (i = 0; i < ARRAY_SIZE(sgx_epc_sections); i++) { section = &sgx_epc_sections[i];
Quoted 8 lines
if (paddr < section->phys_addr || paddr > section->end_phys_addr) continue; return §ion->pages[PFN_DOWN(paddr - section->phys_addr)]; } return NULL; }
/Jarkko
Tony Luck
reviewerPATCH v3 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add a new flag bit (SGX_EPC_PAGE_POISON) that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When allocating pages
3) When freeing epc pages
In all cases drop the poisoned page to make sure it will not be reallocated.
Add debugfs files /sys/kernel/debug/sgx/poison_page_{count,list} so that system administrators can see how many enclave pages have been dropped and get a list of those pages.
--- arch/x86/kernel/cpu/sgx/main.c | 50 +++++++++++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++ 2 files changed, 52 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/main.c +49 -1
@@ -11,6 +11,7 @@#include <linux/sched/mm.h> #include <linux/sched/signal.h> #include <linux/slab.h> +#include <linux/debugfs.h> #include <asm/sgx.h> #include "driver.h" #include "encl.h"
@@ -34,6 +35,9 @@ static unsigned long sgx_nr_free_pages;/* Nodes with one or more EPC sections. */ static nodemask_t sgx_numa_mask; +/* Maintain a count of poison pages */ +static u32 poison_page_count; +/* * Array with one list_head for each possible NUMA node. Each * list contains all the sgx_epc_section's which are on that
@@ -47,6 +51,9 @@ static LIST_HEAD(sgx_dirty_page_list);* Reset post-kexec EPC pages to the uninitialized state. The pages are removed * from the input list, and made available for the page allocator. SECS pages * prepending their children in the input list are left intact. +* +* Don't try to clean a poisoned page. That might trigger a machine check. +* Just drop the page and move on. */ static void __sgx_sanitize_pages (struct list_head *dirty_page_list) {
@@ -61,6 +68,11 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->flags &SGX_EPC_PAGE_POISON ) { +list_del (&page->list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -567,6 +579,9 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* @reclaim is set to true, directly reclaim pages when we are out of pages. No * mm's can be locked when @reclaim is set to true. * +* A page on the free list might have been reported as poisoned by the patrol +* scrubber. If so, skip this page, and try again. +* * Finally, wake up ksgxd when the number of pages goes below the watermark * before returning back to the caller. *
@@ -580,6 +595,10 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)for ( ; ; ) { page =__sgx_alloc_epc_page (); + +if (page->flags &SGX_EPC_PAGE_POISON ) +continue ; +if (!IS_ERR (page)) { page->owner = owner ? owner : page;break ;
@@ -616,6 +635,8 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)* responsibility to make sure that the page is in uninitialized state. In other * words, do EREMOVE, EWB or whatever operation is necessary before calling * this function. +* +* Drop poison pages so they won't be reallocated. */ void sgx_free_epc_page (struct sgx_epc_page *page) {
@@ -625,7 +646,8 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); page->owner =NULL ; -list_add_tail (&page->list, &node->free_page_list); +if (!(page->flags &SGX_EPC_PAGE_POISON )) +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);
@@ -815,8 +837,30 @@ int sgx_set_attribute(unsigned long *allowed_attributes, }EXPORT_SYMBOL_GPL (sgx_set_attribute); +static int poison_list_show (struct seq_file *m,void *private) +{ +struct sgx_epc_section *section; +struct sgx_epc_page *page; +unsigned long addr; +int i; + +for (i =0 ; i <SGX_MAX_EPC_SECTIONS ; i++) { + section = &sgx_epc_sections[i]; + page = section->pages; +for (addr = section->phys_addr; addr < section->end_phys_addr; + addr +=PAGE_SIZE , page++) { +if (page->flags &SGX_EPC_PAGE_POISON ) +seq_printf (m,"0x%lx\n" , addr); + } + } +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (poison_list); +static int __init sgx_init (void ) { +struct dentry *dir;int ret;int i;
@@ -848,6 +892,10 @@ static int __init sgx_init(void)if (sgx_vepc_init () && ret) goto err_provision; + dir =debugfs_create_dir ("sgx" ,NULL ); +debugfs_create_u32 ("poison_page_count" ,0400 , dir, &poison_page_count); +debugfs_create_file ("poison_page_list" ,0400 , dir,NULL , &poison_list_fops); +return 0 ; err_provision:
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Poisoned pages */ +#define SGX_EPC_PAGE_POISON BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Signature · 1 line
2.29.2
Jarkko Sakkinen
maintainerRe: [PATCH v3 3/7] x86/sgx: Initial poison handling for dirty and free pages
arch/x86/kernel/cpu/sgx/main.c static int __init sgx_init(void) · line 895
Quoted 1 line · Tony Luck
arch/x86/kernel/cpu/sgx/main.c +1
-0+ dir =debugfs_create_dir ("sgx" ,NULL );
dir = debugfs_create_dir("sgx", arch_debugfs_dir);
/Jarkko
Tony Luck
reviewerPATCH v3 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
--- arch/x86/kernel/cpu/sgx/main.c | 57 ++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +57 -0
@@ -706,6 +706,63 @@ bool sgx_is_epc_page(u64 paddr) }EXPORT_SYMBOL_GPL (sgx_is_epc_page); +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int sgx_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + +/* Already poisoned? Nothing more to do */ +if (page->flags &SGX_EPC_PAGE_POISON ) +return 0 ; + + page->flags |=SGX_EPC_PAGE_POISON ; + poison_page_count++; + +/* +* Nothing more to do here for dirty/free pages. +* They will be added to the poison list when +* they get to the head of their lists. +*/ +if (!page->owner) +return 0 ; + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ + +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.29.2
Re: [PATCH v3 4/7] x86/sgx: Add SGX infrastructure to recover from poison
Quoted 2 lines · Tony Luck
arch/x86/kernel/cpu/sgx/main.c +2
-0+int sgx_memory_failure (unsigned long pfn,int flags) +{
...
arch/x86/kernel/cpu/sgx/main.c bool sgx_is_epc_page(u64 paddr) · line 742
Quoted 1 line
arch/x86/kernel/cpu/sgx/main.c +1
-0+ page->flags |=SGX_EPC_PAGE_POISON ;
Is this safe outside of any locks?
I see the reclaimer doing things like:
epc_page->flags &= ~SGX_EPC_PAGE_RECLAIMER_TRACKED;
I'd worry that this code and other non-atomic epc_page->flags manipulation could trample on each other.
This might need to some some atomic bit manipulation *and* convert all the other epc_page->flags users.
Re: [PATCH v3 4/7] x86/sgx: Add SGX infrastructure to recover from poison
Quoted 7 lines · Dave Hansen
Quoted 2 lines · Tony Luck
arch/x86/kernel/cpu/sgx/main.c +2
-0+int sgx_memory_failure (unsigned long pfn,int flags) +{...
arch/x86/kernel/cpu/sgx/main.c bool sgx_is_epc_page(u64 paddr) · line 742
Quoted 1 line
arch/x86/kernel/cpu/sgx/main.c +1
-0+ page->flags |=SGX_EPC_PAGE_POISON ;Is this safe outside of any locks?
It's safe outside of sgx_reclaimer_lock iff this can guarantee nothing else can reach the page. I'm pretty sure that doesn't hold true here.
Quoted 9 lines
I see the reclaimer doing things like:
epc_page->flags &= ~SGX_EPC_PAGE_RECLAIMER_TRACKED;I'd worry that this code and other non-atomic
epc_page->flagsmanipulation could trample on each other.This might need to some some atomic bit manipulation *and* convert all the other
epc_page->flagsusers.
I don't think atomics would be sufficient as that would open all sorts of possible races. E.g. this new code in __sgx_sanitize_pages()
page = list_first_entry(dirty_page_list, struct sgx_epc_page, list);
+ if (page->flags & SGX_EPC_PAGE_POISON) {
+ list_del(&page->list);
+ continue;
+ }
+
***HERE***
ret = __eremove(sgx_get_epc_virt_addr(page));could attempt EREMOVE on a freshly POISONed page. That appears to be "benign" since ENCLS is wrapped with_ASM_EXTABLE_FAULT, but it feels wrong to add a check that we know can race.
And similar races for allocation/free could hand out a poisoned page or add one to the free list.
@@ -585,6 +600,10 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)
for ( ; ; ) {
page = __sgx_alloc_epc_page();
+
+ if (page->flags & SGX_EPC_PAGE_POISON)
+ continue;
*** HERE ***+
@@ -630,7 +651,8 @@ void sgx_free_epc_page(struct sgx_epc_page *page)
spin_lock(&node->lock);
page->owner = NULL;
- list_add_tail(&page->list, &node->free_page_list);
+ if (!(page->flags & SGX_EPC_PAGE_POISON))
*** HERE ***+ list_add_tail(&page->list, &node->free_page_list);
Setting POISON and hoping we eventually notice doesn't sound robust. Maybe some of these races are unavoidable due to the nature of #MC delivery, but I would hope the kernel can at least avoid handing out a poisoned page to a different enclave.
Tony Luck
reviewerPATCH v3 5/7 x86/sgx: Hook sgx_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 15 +++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 3 files changed, 32 insertions(+), 6 deletions(-)
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (sgx_is_epc_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +15 -0
@@ -3283,5 +3283,20 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else +static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} + +static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1626,21 +1626,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =sgx_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v3 6/7 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !sgx_is_epc_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v3 7/7 x86/sgx: Add documentation for SGX memory errors
In reply to Tony LuckError handling is a bit different for SGX pages. Add a section describing how asynchronous and consumed errors are handled and the two new debugfs files that show the count and list of pages with uncorrected memory errors.
--- Documentation/x86/sgx.rst | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
Documentation/x86/sgx.rst +26 -0
@@ -250,3 +250,29 @@ user wants to deploy SGX applications both on the host and in guests on the same machine, the user should reserve enough EPC (by taking out total virtual EPC size of all SGX VMs from the physical EPC size) for host SGX applications so they can run with acceptable performance. + +Uncorrected memory errors +========================= +Systems that support machine check recovery and have local machine +check delivery enabled can recover from uncorrected memory errors in +many situations. + +Errors in SGX pages that are not currently in use will prevent those +pages from being allocated. + +Errors asynchronously reported against active SGX pages will simply note +that the page has an error. If the enclave terminates without accessing +the page Linux will not return it to the free list for reallocation. + +When an uncorrected memory error is consumed from within an enclave the +h/w will mark that enclave so that it cannot be re-entered. Linux will +send a SIGBUS to the current task. + +In addition to console log entries from processing the machine check or +corrected machine check interrupt, Linux also provides debugfs files to +indicate the number of SGX enclave pages that have reported errors and +the physical addresses of each page: + +/sys/kernel/debug/sgx/poison_page_count + +/sys/kernel/debug/sgx/poison_page_list
Signature · 1 line
2.29.2
Tony Luck
reviewerv4 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckHere's version 4 (just 38 more to go if I want to meet the bar set by the base SGX series :-) )
Changes since v3:
Dave Hansen:
1) Concerns about assigning a default value to the "owner" pointer if the caller of sgx_alloc_epc_page() called with a NULL value.
Resolved: Sean provided a patch to fix the only caller that was using NULL. I merged it in here.
2) Better commit message to explain why sgx_is_epc_page() is exported.
Done.
3) Unhappy with "void *owner" in struct sgx_epc_page. Would be better to use an anonymous union of all the types.
Done.
Sean Christopherson:
1) Races updating bits in flags field.
Resolved: "poison" is now a separate field.
2) More races. When poison alert happens while moving a page on/off a free/dirty list.
Resolved: Well mostly. All the run time changes are now done while holding the node->lock. There's a gap while moving pages from dirty list to free list. But that's a short-ish window during boot, and the races are mostly harmless. Worst is that we might call __eremove() for a page that just got marked as poisoned. But then sgx_free_epc_page() will see the poison flag and do the right thing.
Jarkko Sakkinen:
1) Use xarray to keep track of which pages are the special SGX EPC ones.
This spawned a short discussion on whether it was overkill. But xarray makes the source much simpler, and there are improvements in the pipeline for xarray that will make it handle this use case more efficiently. So I made this change.
2) Move the sgx debugfs directory under arch_debugfs_dir. Done.
Tony Luck (6):
x86/sgx: Provide indication of life-cycle of EPC pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook sgx_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/encl.c | 5 +- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 140 ++++++++++++++++-- arch/x86/kernel/cpu/sgx/sgx.h | 14 +- drivers/acpi/apei/einj.c | 3 +- include/linux/mm.h | 15 ++ mm/memory-failure.c | 19 ++- 10 files changed, 196 insertions(+), 27 deletions(-)
base-commit: e22ce8eb631bdc47a4a4ea7ecf4e4ba499db4f93
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v4 1/6 x86/sgx: Provide indication of life-cycle of EPC pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the sgx_epc_page->owner field as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller, sgx_alloc_va_page(), that calls with NULL.
Since there are multiple uses of the "owner" field with different types change the sgx_epc_page structure to define an anonymous union with each of the uses explicitly called out.
Start epc_pages out with a non-NULL owner while they are in DIRTY state.
Fix up the one holdout to provide a non-NULL owner.
Refactor the allocation sequence so that changes to/from NULL value happen together with adding/removing the epc_page from a free list while the node->lock is held.
--- arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 23 ++++++++++++----------- arch/x86/kernel/cpu/sgx/sgx.h | 12 ++++++++---- 5 files changed, 25 insertions(+), 19 deletions(-)
arch/x86/kernel/cpu/sgx/encl.c +3 -2
@@ -667,6 +667,7 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,/** * sgx_alloc_va_page() - Allocate a Version Array (VA) page +* @va_page: struct sgx_va_page connected to this VA page * * Allocate a free EPC page and convert it to a Version Array (VA) page. *
@@ -674,12 +675,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page) {struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (va_page, true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);
arch/x86/kernel/cpu/sgx/encl.h +1 -1
@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);
arch/x86/kernel/cpu/sgx/main.c +12 -11
@@ -457,7 +457,7 @@ static bool __init sgx_page_reclaimer_init(void)return true; } -static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (int nid) +static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (void *private,int nid) {struct sgx_numa_node *node = &sgx_numa_nodes[nid];struct sgx_epc_page *page =NULL ;
@@ -471,6 +471,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); + page->private = private; sgx_nr_free_pages--;spin_unlock (&node->lock);
@@ -480,6 +481,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)/** * __sgx_alloc_epc_page() - Allocate an EPC page +* @owner: the owner of the EPC page * * Iterate through NUMA nodes and reserve ia free EPC page to the caller. Start * from the NUMA node, where the caller is executing.
@@ -488,14 +490,14 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)* - an EPC page: A borrowed EPC pages were available. * - NULL: Out of EPC pages. */ -struct sgx_epc_page *__sgx_alloc_epc_page (void ) +struct sgx_epc_page *__sgx_alloc_epc_page (void *private) {struct sgx_epc_page *page;int nid_of_current =numa_node_id ();int nid = nid_of_current;if (node_isset (nid_of_current, sgx_numa_mask)) { - page =__sgx_alloc_epc_page_from_node (nid_of_current); + page =__sgx_alloc_epc_page_from_node (private, nid_of_current);if (page)return page; }
@@ -506,7 +508,7 @@ struct sgx_epc_page *__sgx_alloc_epc_page(void)if (nid == nid_of_current)break ; - page =__sgx_alloc_epc_page_from_node (nid); + page =__sgx_alloc_epc_page_from_node (private, nid);if (page)return page; }
@@ -559,7 +561,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page -* @owner: the owner of the EPC page +* @private: per-caller private data * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a
@@ -574,16 +576,14 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* an EPC page, * -errno on error */ -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim) +struct sgx_epc_page *sgx_alloc_epc_page (void *private,bool reclaim) {struct sgx_epc_page *page;for ( ; ; ) { - page =__sgx_alloc_epc_page (); -if (!IS_ERR (page)) { - page->owner = owner; + page =__sgx_alloc_epc_page (private); +if (!IS_ERR (page))break ; - }if (list_empty (&sgx_active_page_list))return ERR_PTR (-ENOMEM );
@@ -624,6 +624,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->private =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
@@ -652,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; - section->pages[i].owner =NULL ; + section->pages[i].private ="dirty" ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +8 -4
@@ -28,8 +28,12 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; -struct sgx_encl_page *owner; +int flags; +union { +void *private; +struct sgx_encl_page *owner; +struct sgx_encl_page *vepc; + };struct list_head list; };
@@ -77,12 +81,12 @@ static inline void *sgx_get_epc_virt_addr(struct sgx_epc_page *page)return section->virt_addr + index *PAGE_SIZE ; } -struct sgx_epc_page *__sgx_alloc_epc_page (void ); +struct sgx_epc_page *__sgx_alloc_epc_page (void *private);void sgx_free_epc_page (struct sgx_epc_page *page);void sgx_mark_page_reclaimable (struct sgx_epc_page *page);int sgx_unmark_page_reclaimable (struct sgx_epc_page *page); -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim); +struct sgx_epc_page *sgx_alloc_epc_page (void *private,bool reclaim);#ifdef CONFIG_X86_SGX_KVM int __init sgx_vepc_init (void );
Signature · 1 line
2.29.2
Jarkko Sakkinen
maintainerRe: [PATCH v4 1/6] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 49 lines · Tony Luck
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\ ^ | \-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the
sgx_epc_page->ownerfield as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller,sgx_alloc_va_page(), that calls with NULL.Since there are multiple uses of the "owner" field with different types change the
sgx_epc_pagestructure to define an anonymous union with each of the uses explicitly called out.Start
epc_pagesout with a non-NULL owner while they are in DIRTY state.Fix up the one holdout to provide a non-NULL owner.
Refactor the allocation sequence so that changes to/from NULL value happen together with adding/removing the
epc_pagefrom a free list while thenode->lockis held.Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 23 ++++++++++++----------- arch/x86/kernel/cpu/sgx/sgx.h | 12 ++++++++---- 5 files changed, 25 insertions(+), 19 deletions(-)arch/x86/kernel/cpu/sgx/encl.c +1
-0@@ -667,6 +667,7 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,/** * sgx_alloc_va_page() - Allocate a Version Array (VA) page +* @va_page: struct sgx_va_page connected to this VA page * * Allocate a free EPC page and convert it to a Version Array (VA) page. *
arch/x86/kernel/cpu/sgx/encl.c int sgx_encl_test_and_clear_young(struct mm_struct *mm, · line 678
Quoted 5 lines
arch/x86/kernel/cpu/sgx/encl.c +1
-1@@ -674,12 +675,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page)
Why not just
struct sgx_epc_page *sgx_alloc_va_page(void *owner)
arch/x86/kernel/cpu/sgx/encl.c int sgx_encl_test_and_clear_young(struct mm_struct *mm, · line 683
Quoted 6 lines
arch/x86/kernel/cpu/sgx/encl.c +1
-1{struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (va_page, true);
epc_page = sgx_alloc_epc_page(owner, true);
arch/x86/kernel/cpu/sgx/encl.c int sgx_encl_test_and_clear_young(struct mm_struct *mm, · line 685
Quoted 2 lines
arch/x86/kernel/cpu/sgx/encl.c +0
-0if (IS_ERR (epc_page))return ERR_CAST (epc_page);
This function does not do anything with the internals of struct sgx_va_page.
Quoted 119 lines
arch/x86/kernel/cpu/sgx/encl.h +1
-1@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);arch/x86/kernel/cpu/sgx/ioctl.c +1
-1@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);arch/x86/kernel/cpu/sgx/main.c +11
-10@@ -457,7 +457,7 @@ static bool __init sgx_page_reclaimer_init(void)return true; } -static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (int nid) +static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (void *private,int nid) {struct sgx_numa_node *node = &sgx_numa_nodes[nid];struct sgx_epc_page *page =NULL ;@@ -471,6 +471,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); + page->private = private; sgx_nr_free_pages--;spin_unlock (&node->lock);@@ -480,6 +481,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)/** * __sgx_alloc_epc_page() - Allocate an EPC page +* @owner: the owner of the EPC page * * Iterate through NUMA nodes and reserve ia free EPC page to the caller. Start * from the NUMA node, where the caller is executing. @@ -488,14 +490,14 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)* - an EPC page: A borrowed EPC pages were available. * - NULL: Out of EPC pages. */ -struct sgx_epc_page *__sgx_alloc_epc_page (void ) +struct sgx_epc_page *__sgx_alloc_epc_page (void *private) {struct sgx_epc_page *page;int nid_of_current =numa_node_id ();int nid = nid_of_current;if (node_isset (nid_of_current, sgx_numa_mask)) { - page =__sgx_alloc_epc_page_from_node (nid_of_current); + page =__sgx_alloc_epc_page_from_node (private, nid_of_current);if (page)return page; }@@ -506,7 +508,7 @@ struct sgx_epc_page *__sgx_alloc_epc_page(void)if (nid == nid_of_current)break ; - page =__sgx_alloc_epc_page_from_node (nid); + page =__sgx_alloc_epc_page_from_node (private, nid);if (page)return page; }@@ -559,7 +561,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page -* @owner: the owner of the EPC page +* @private: per-caller private data * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a @@ -574,16 +576,14 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* an EPC page, * -errno on error */ -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim) +struct sgx_epc_page *sgx_alloc_epc_page (void *private,bool reclaim) {struct sgx_epc_page *page;for ( ; ; ) { - page =__sgx_alloc_epc_page (); -if (!IS_ERR (page)) { - page->owner = owner; + page =__sgx_alloc_epc_page (private); +if (!IS_ERR (page))break ; - }if (list_empty (&sgx_active_page_list))return ERR_PTR (-ENOMEM );@@ -624,6 +624,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->private =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 656
Quoted 5 lines
arch/x86/kernel/cpu/sgx/main.c +1
-1@@ -652,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; - section->pages[i].owner =NULL ; + section->pages[i].private ="dirty" ;
#define DIRTY ((void *)-1)
section->pages[i].owner = DIRTY;
Quoted 9 lines
arch/x86/kernel/cpu/sgx/main.c +0
-0list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }arch/x86/kernel/cpu/sgx/sgx.h +0
-0@@ -28,8 +28,12 @@
arch/x86/kernel/cpu/sgx/sgx.h line 36
Quoted 10 lines
arch/x86/kernel/cpu/sgx/sgx.h +6
-2struct sgx_epc_page {unsigned int section; -unsigned int flags; -struct sgx_encl_page *owner; +int flags; +union { +void *private; +struct sgx_encl_page *owner; +struct sgx_encl_page *vepc; + };
Why not just keep it as void *owner, and cast it as seen appropriate?
Quoted 8 lines
arch/x86/kernel/cpu/sgx/sgx.h +0
-1struct list_head list; };@@ -77,12 +81,12 @@ static inline void *sgx_get_epc_virt_addr(struct sgx_epc_page *page)return section->virt_addr + index *PAGE_SIZE ; } -struct sgx_epc_page *__sgx_alloc_epc_page (void );
arch/x86/kernel/cpu/sgx/sgx.h static inline void *sgx_get_epc_virt_addr(struct sgx_epc_page *page) · line 92
Quoted 10 lines
arch/x86/kernel/cpu/sgx/sgx.h +2
-1+struct sgx_epc_page *__sgx_alloc_epc_page (void *private);void sgx_free_epc_page (struct sgx_epc_page *page);void sgx_mark_page_reclaimable (struct sgx_epc_page *page);int sgx_unmark_page_reclaimable (struct sgx_epc_page *page); -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim); +struct sgx_epc_page *sgx_alloc_epc_page (void *private,bool reclaim);#ifdef CONFIG_X86_SGX_KVM int __init sgx_vepc_init (void );
/Jarkko
Tony Luck
reviewerPATCH v4 2/6 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function sgx_is_epc_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that sgx_is_epc_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
--- arch/x86/kernel/cpu/sgx/main.c | 10 ++++++++++ arch/x86/kernel/cpu/sgx/sgx.h | 1 + 2 files changed, 11 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +10 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (epc_page_ranges);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -649,6 +650,9 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ; +xa_store_range (&epc_page_ranges, section->phys_addr, + section->end_phys_addr, section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -660,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool sgx_is_epc_page (u64 paddr) +{ +return !!xa_load (&epc_page_ranges, paddr); +} +EXPORT_SYMBOL_GPL (sgx_is_epc_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
arch/x86/kernel/cpu/sgx/sgx.h +1 -0
@@ -54,6 +54,7 @@ struct sgx_numa_node {*/ struct sgx_epc_section {unsigned long phys_addr; +unsigned long end_phys_addr;void *virt_addr;struct sgx_epc_page *pages;struct sgx_numa_node *node;
Signature · 1 line
2.29.2
Jarkko Sakkinen
maintainerRe: [PATCH v4 2/6] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 30 lines · Tony Luck
X86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function
sgx_is_epc_page()that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.Note that
sgx_is_epc_page()will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/main.c | 10 ++++++++++ arch/x86/kernel/cpu/sgx/sgx.h | 1 + 2 files changed, 11 insertions(+)arch/x86/kernel/cpu/sgx/main.c +0
-0
arch/x86/kernel/cpu/sgx/main.c struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS]; · line 23
Quoted 4 lines
arch/x86/kernel/cpu/sgx/main.c +1
-0@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (epc_page_ranges);
Maybe we could just call this "sgx_epc_address_space"?
/Jarkko
Tony Luck
reviewerPATCH v4 3/6 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Add debugfs files /sys/kernel/debug/sgx/poison_page_list so that system administrators get a list of those pages that have been dropped because of poison.
--- arch/x86/kernel/cpu/sgx/main.c | 30 +++++++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 31 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +29 -1
@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2016-20 Intel Corporation. */ +#include <linux/debugfs.h> #include <linux/file.h> #include <linux/freezer.h> #include <linux/highmem.h>
@@ -43,6 +44,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
@@ -62,6 +64,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +634,10 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); page->private =NULL ; -list_add_tail (&page->list, &node->free_page_list); +if (page->poison) +list_add (&page->list, &sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);
@@ -657,6 +668,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; + section->pages[i].poison =0 ; section->pages[i].private ="dirty" ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
@@ -801,8 +813,21 @@ int sgx_set_attribute(unsigned long *allowed_attributes, }EXPORT_SYMBOL_GPL (sgx_set_attribute); +static int poison_list_show (struct seq_file *m,void *private) +{ +struct sgx_epc_page *page; + +list_for_each_entry (page, &sgx_poison_page_list, list) +seq_printf (m,"0x%lx\n" ,sgx_get_epc_phys_addr (page)); + +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (poison_list); +static int __init sgx_init (void ) { +struct dentry *dir;int ret;int i;
@@ -834,6 +859,9 @@ static int __init sgx_init(void)if (sgx_vepc_init () && ret) goto err_provision; + dir =debugfs_create_dir ("sgx" , arch_debugfs_dir); +debugfs_create_file ("poison_page_list" ,0400 , dir,NULL , &poison_list_fops); +return 0 ; err_provision:
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -28,7 +28,8 @@struct sgx_epc_page {unsigned int section; -int flags; +u16 flags; +u16 poison;union {void *private;struct sgx_encl_page *owner;
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v4 4/6 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 77 ++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +77 -0
@@ -682,6 +682,83 @@ bool sgx_is_epc_page(u64 paddr) }EXPORT_SYMBOL_GPL (sgx_is_epc_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&epc_page_ranges, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int sgx_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If there is no owner, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->private) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.29.2
Tony Luck
reviewerPATCH v4 5/6 x86/sgx: Hook sgx_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 15 +++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 3 files changed, 32 insertions(+), 6 deletions(-)
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (sgx_is_epc_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +15 -0
@@ -3283,5 +3283,20 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else +static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} + +static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =sgx_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.29.2
Jarkko Sakkinen
maintainerRe: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 4 lines · Tony Luck
include/linux/mm.h +4
-0+#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else
include/linux/mm.h static inline int seal_check_future_write(int seals, struct vm_area_struct *vma) · line 3299
Quoted 10 lines
include/linux/mm.h +10
-0+static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} + +static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif
These decl's should be in arch/x86/include/asm/sgx.h, and as part of patch that contains the implementations.
/Jarkko
Jarkko Sakkinen
maintainerRe: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 10 lines · Jarkko Sakkinen
Quoted 9 lines · Tony Luck
include/linux/mm.h +9
-0+#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else +static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +
Quoted 8 lines
include/linux/mm.h static inline int seal_check_future_write(int seals, struct vm_area_struct *vma) · line 3299
Quoted 5 lines
include/linux/mm.h +5
-0+static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif These decl's should be in
arch/x86/include/asm/sgx.h, and as part of patch that contains the implementations.
To align with this, I wrote a small patch:
https://lore.kernel.org/linux-sgx/[email protected]/T/#u
/Jarkko
Luck, Tony
reviewerRE: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 10 lines · Jarkko Sakkinen
Quoted 9 lines · Tony Luck
include/linux/mm.h +9
-0+#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else +static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +
Quoted 8 lines
include/linux/mm.h static inline int seal_check_future_write(int seals, struct vm_area_struct *vma) · line 3299
Quoted 5 lines
include/linux/mm.h +5
-0+static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif These decl's should be in
arch/x86/include/asm/sgx.h, and as part of patch that contains the implementations.
But I need to use these functions in arch independent code. Specifically in mm/memory-failure.c and drivers/acpi/apei/einj.c
If I just #include <asm/sgx.h> in those files I'll break the build for other architectures.
-Tony
Jarkko Sakkinen
maintainerRe: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 20 lines · Tony
Quoted 10 lines · Jarkko Sakkinen
Quoted 9 lines · Tony Luck
include/linux/mm.h +9
-0+#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else +static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +Quoted 8 lines
include/linux/mm.h static inline int seal_check_future_write(int seals, struct vm_area_struct *vma) · line 3299
Quoted 5 lines
include/linux/mm.h +5
-0+static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif These decl's should be in
arch/x86/include/asm/sgx.h, and as part of patch that contains the implementations.
Quoted 5 lines
But I need to use these functions in arch independent code. Specifically in
mm/memory-failure.canddrivers/acpi/apei/einj.cIf I just #include <
asm/sgx.h> in those files I'll break the build for other architectures.
What does specifically break the build?
/Jarkko
Re: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 3 lines · Jarkko Sakkinen
Quoted 2 lines
If I just #include <
asm/sgx.h> in those files I'll break the build for other architectures.What does specifically break the build?
Remember, our x86 "<asm/sgx.h>" is:
arch/x86/include/asm/sgx.h
On powerpc, "<asm/sgx.h>" is:
arch/powerpc/include/asm/sgx.h
You'll get a file not found error looking for sgx.h.
That said... Tony, it's probably a bit more friendly if the mm.h code you add:
Quoted 4 lines
include/linux/mm.h +4
-0+#ifdef CONFIG_X86_SGX +int sgx_memory_failure (unsigned long pfn,int flags); +bool sgx_is_epc_page (u64 paddr); +#else
include/linux/mm.h static inline int seal_check_future_write(int seals, struct vm_area_struct *vma) · line 3299
Quoted 10 lines
include/linux/mm.h +10
-0+static inline int sgx_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} + +static inline bool sgx_is_epc_page (u64 paddr) +{ +return false; +} +#endif
was a bit more generic. Maybe something like:
int arch_memory_failure(unsigned long pfn, int flags);
BTW, I don't see sgx_is_epc_page() in arch-generic code. Does it really need to be in mm.h?
Luck, Tony
reviewerRE: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 2 lines
BTW, I don't see
sgx_is_epc_page()in arch-generic code. Does it really need to be inmm.h?
I use it in drivers/acpi/apei/einj.c
Arm is a big user of ACPI. I don't see any Kconfig exclusions for CONFIG_ACPI_APEI_EINJ
-Tony
Luck, Tony
reviewerRE: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
In reply to Jarkko SakkinenQuoted 4 lines
Quoted 2 lines
If I just #include <
asm/sgx.h> in those files I'll break the build for other architectures.What does specifically break the build?
There is no file named arch/arm/include/asm/sgx.h (ditto for other architectures that build memory-failure.c and einj.c).
-Tony
Jarkko Sakkinen
maintainerRe: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 8 lines · Tony
Quoted 4 lines
Quoted 2 lines
If I just #include <
asm/sgx.h> in those files I'll break the build for other architectures.What does specifically break the build?
There is no file named
arch/arm/include/asm/sgx.h(ditto for other architectures that buildmemory-failure.candeinj.c).-Tony
Would it be too obnoxious to flag that include in those files?
/Jarkko
Luck, Tony
reviewerRE: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 1 line
Would it be too obnoxious to flag that include in those files?
Jarkko,
You mean:
#ifdef CONFIG_X86_SGX
#include <asm/sgx.h>
#endif
in mm/memory-failure.h?
That wouldn't help. I need the do-nothing stub definition on other architectures.
I'm going to explore Dave's suggestion of changing the names to something less sgx specific.
-Tony
Luck, Tony
reviewerRE: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 1 line
I'm going to explore Dave's suggestion of changing the names to something less sgx specific.
So now I have the two functions renamed to
arch_memory_failure() and arch_is_platform_page()
in arch/x86/kernel/cpu/sgx/main.c
In arch/x86/include/asm/processor.h
+#ifdef CONFIG_X86_SGX
+int arch_memory_failure(unsigned long pfn, int flags); +#define arch_memory_failure arch_memory_failure +
+bool arch_is_platform_page(u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif
and in include/linux/mm.h
+#ifndef arch_memory_failure
+static inline int arch_memory_failure(unsigned long pfn, int flags) +{
+ return -ENXIO;
+}
+#endif
+#ifndef arch_is_platform_page
+static inline bool arch_is_platform_page(u64 paddr)
+{
+ return false;
+}
+#endif
Dave: Is that what you wanted? If so I can fold these bits back into the appropriate bits of the series. Address other comments. and post v5.
Sean: If you have stuff that needs attention in v4 please holler soon.
-Tony
Re: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
Quoted 23 lines · Tony
(quoted diff) +7
-0+#ifdef CONFIG_X86_SGX +int arch_memory_failure(unsigned long pfn, int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page(u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endifand in
include/linux/mm.h(quoted diff) +12
-0+#ifndef arch_memory_failure +static inline int arch_memory_failure(unsigned long pfn, int flags) +{ + return -ENXIO; +} +#endif +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page(u64 paddr) +{ + return false; +} +#endif
Quoted 2 lines
Dave: Is that what you wanted? If so I can fold these bits back into the appropriate bits of the series. Address other comments. and post v5.
Looks good to me.
These can *also* be done with a
config ARCH_HAS_SPECIAL_MEMORY_FAILURE
bool
in mm/Kconfig.h, and then:
select ARCH_HAS_SPECIAL_MEMORY_FAILURE
in the SGX Kconfig instead of the ifndef's. I prefer the configs personally because they are less ambiguous and can't be screwed up my missing #includes or weird #include ordering problems. But, some folks prefer to avoid polluting the CONFIG_* space.
That's just pure personal preference though. Either way is fine.
Jarkko Sakkinen
maintainerRe: [PATCH v4 5/6] x86/sgx: Hook sgx_memory_failure() into mainline code
In reply to Luck, TonyQuoted 10 lines · Tony
Quoted 1 line
Would it be too obnoxious to flag that include in those files?
Jarkko,
You mean:
#ifdef
CONFIG_X86_SGX
#include <asm/sgx.h>
#endif
Quoted 7 lines
in
mm/memory-failure.h?That wouldn't help. I need the do-nothing stub definition on other architectures.
I'm going to explore Dave's suggestion of changing the names to something less sgx specific.
-Tony
Ah sorry, I get it :-) Yeah, Dave's suggestion makes much more sense.
/Jarkko
Tony Luck
reviewerPATCH v4 6/6 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !sgx_is_epc_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.29.2
Borislav Petkov
maintainerQuoted 2 lines · Tony Luck
Here's version 4 (just 38 more to go if I want to meet the bar set by the base SGX series :-) )
You're off by 1:
https://lore.kernel.org/lkml/[email protected]/
you have only just 37 more.
:-P
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 11 lines · Borislav Petkov
Quoted 2 lines · Tony Luck
Here's version 4 (just 38 more to go if I want to meet the bar set by the base SGX series :-) )
You're off by 1:
https://lore.kernel.org/lkml/[email protected]/
you have only just 37 more.
:-P
LOL, sorry for setting such high standards.
Jarkko Sakkinen
maintainerQuoted 67 lines · Tony Luck
Here's version 4 (just 38 more to go if I want to meet the bar set by the base SGX series :-) )
Changes since v3:
Dave Hansen:
1) Concerns about assigning a default value to the "owner" pointer if the caller ofsgx_alloc_epc_page()called with a NULL value.
Resolved: Sean provided a patch to fix the only caller that was using NULL. I merged it in here.2) Better commit message to explain why
sgx_is_epc_page()is exported.
Done.3) Unhappy with "void *owner" in struct
sgx_epc_page. Would be better to use an anonymous union of all the types.
Done.Sean Christopherson:
1) Races updating bits in flags field.
Resolved: "poison" is now a separate field.2) More races. When poison alert happens while moving a page on/off a free/dirty list.
Resolved: Well mostly. All the run time changes are now done while holding thenode->lock. There's a gap while moving pages from dirty list to free list. But that's a short-ish window during boot, and the races are mostly harmless. Worst is that we might call__eremove()for a page that just got marked as poisoned. But thensgx_free_epc_page()will see the poison flag and do the right thing.Jarkko Sakkinen:
1) Use xarray to keep track of which pages are the special SGX EPC ones.
This spawned a short discussion on whether it was overkill. But xarray makes the source much simpler, and there are improvements in the pipeline for xarray that will make it handle this use case more efficiently. So I made this change.2) Move the sgx debugfs directory under
arch_debugfs_dir. Done.Tony Luck (6):
x86/sgx: Provide indication of life-cycle of EPC pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hooksgx_memory_failure()into mainline code x86/sgx: Add hook to error injection address validation.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/encl.c | 5 +- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 140 ++++++++++++++++-- arch/x86/kernel/cpu/sgx/sgx.h | 14 +- drivers/acpi/apei/einj.c | 3 +- include/linux/mm.h | 15 ++ mm/memory-failure.c | 19 ++- 10 files changed, 196 insertions(+), 27 deletions(-)
Quoted 1 line
base-commit:
e22ce8eb631bdc47a4a4ea7ecf4e4ba499db4f93
Would be nice to get this also to [email protected] in future.
/Jarkko
Luck, Tony
reviewerQuoted 2 lines
Would be nice to get this also to [email protected] in future.
Will add to list for next version.
Thanks
-Tony
Tony Luck
reviewerv5 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckNow version 5.
Changes since v4:
Jarkko Sakkinen:
+ Add [email protected] to Cc: list
+ Remove explicit struct sgx_va_page *va_page type from argument and use in sgx_alloc_va_page(). Just use "void *" as this code doesn't do anything with the internals of struct sgx_va_page.
+ Drop the union of all possible types for the "owner" field in struct sgx_epc_page (sorry Dave Hansen, this went in last time from your comment, but it doesn't seem to add much value). Back to "void *owner;"
+ rename the xarray that tracks which addresses are EPC pages from "epc_page_ranges" to "sgx_epc_address_space".
Dave Hansen:
+ Use more generic names for the globally visible functions that are needed in generic code: sgx_memory_failure -> arch_memory_failure sgx_is_epc_page -> arch_is_platform_page
Tony Luck:
+ Found that ghes code spits warnings for memory addresses that it thinks are bad. Add a check for SGX pages.
Tony Luck (7):
x86/sgx: Provide indication of life-cycle of EPC pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook arch_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/processor.h | 8 + arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/encl.c | 5 +- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 140 ++++++++++++++++-- arch/x86/kernel/cpu/sgx/sgx.h | 14 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 13 ++ mm/memory-failure.c | 19 ++- 12 files changed, 203 insertions(+), 28 deletions(-)
base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v5 1/7 x86/sgx: Provide indication of life-cycle of EPC pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the sgx_epc_page->owner field as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller, sgx_alloc_va_page(), that calls with NULL.
Since there are multiple uses of the "owner" field with different types change the sgx_epc_page structure to define an anonymous union with each of the uses explicitly called out.
Start epc_pages out with a non-NULL owner while they are in DIRTY state.
Fix up the one holdout to provide a non-NULL owner.
Refactor the allocation sequence so that changes to/from NULL value happen together with adding/removing the epc_page from a free list while the node->lock is held.
--- arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 23 ++++++++++++----------- arch/x86/kernel/cpu/sgx/sgx.h | 12 ++++++++---- 5 files changed, 25 insertions(+), 19 deletions(-)
arch/x86/kernel/cpu/sgx/encl.c +3 -2
@@ -667,6 +667,7 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,/** * sgx_alloc_va_page() - Allocate a Version Array (VA) page +* @va_page: struct sgx_va_page connected to this VA page * * Allocate a free EPC page and convert it to a Version Array (VA) page. *
@@ -674,12 +675,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page) {struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (va_page, true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);
arch/x86/kernel/cpu/sgx/encl.h +1 -1
@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (struct sgx_va_page *va_page);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);
arch/x86/kernel/cpu/sgx/main.c +12 -11
@@ -457,7 +457,7 @@ static bool __init sgx_page_reclaimer_init(void)return true; } -static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (int nid) +static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (void *private,int nid) {struct sgx_numa_node *node = &sgx_numa_nodes[nid];struct sgx_epc_page *page =NULL ;
@@ -471,6 +471,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); + page->private = private; sgx_nr_free_pages--;spin_unlock (&node->lock);
@@ -480,6 +481,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)/** * __sgx_alloc_epc_page() - Allocate an EPC page +* @owner: the owner of the EPC page * * Iterate through NUMA nodes and reserve ia free EPC page to the caller. Start * from the NUMA node, where the caller is executing.
@@ -488,14 +490,14 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)* - an EPC page: A borrowed EPC pages were available. * - NULL: Out of EPC pages. */ -struct sgx_epc_page *__sgx_alloc_epc_page (void ) +struct sgx_epc_page *__sgx_alloc_epc_page (void *private) {struct sgx_epc_page *page;int nid_of_current =numa_node_id ();int nid = nid_of_current;if (node_isset (nid_of_current, sgx_numa_mask)) { - page =__sgx_alloc_epc_page_from_node (nid_of_current); + page =__sgx_alloc_epc_page_from_node (private, nid_of_current);if (page)return page; }
@@ -506,7 +508,7 @@ struct sgx_epc_page *__sgx_alloc_epc_page(void)if (nid == nid_of_current)break ; - page =__sgx_alloc_epc_page_from_node (nid); + page =__sgx_alloc_epc_page_from_node (private, nid);if (page)return page; }
@@ -559,7 +561,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page -* @owner: the owner of the EPC page +* @private: per-caller private data * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a
@@ -574,16 +576,14 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)* an EPC page, * -errno on error */ -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim) +struct sgx_epc_page *sgx_alloc_epc_page (void *private,bool reclaim) {struct sgx_epc_page *page;for ( ; ; ) { - page =__sgx_alloc_epc_page (); -if (!IS_ERR (page)) { - page->owner = owner; + page =__sgx_alloc_epc_page (private); +if (!IS_ERR (page))break ; - }if (list_empty (&sgx_active_page_list))return ERR_PTR (-ENOMEM );
@@ -624,6 +624,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->private =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
@@ -652,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; - section->pages[i].owner =NULL ; + section->pages[i].private ="dirty" ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +8 -4
@@ -28,8 +28,12 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; -struct sgx_encl_page *owner; +int flags; +union { +void *private; +struct sgx_encl_page *owner; +struct sgx_encl_page *vepc; + };struct list_head list; };
@@ -77,12 +81,12 @@ static inline void *sgx_get_epc_virt_addr(struct sgx_epc_page *page)return section->virt_addr + index *PAGE_SIZE ; } -struct sgx_epc_page *__sgx_alloc_epc_page (void ); +struct sgx_epc_page *__sgx_alloc_epc_page (void *private);void sgx_free_epc_page (struct sgx_epc_page *page);void sgx_mark_page_reclaimable (struct sgx_epc_page *page);int sgx_unmark_page_reclaimable (struct sgx_epc_page *page); -struct sgx_epc_page *sgx_alloc_epc_page (void *owner,bool reclaim); +struct sgx_epc_page *sgx_alloc_epc_page (void *private,bool reclaim);#ifdef CONFIG_X86_SGX_KVM int __init sgx_vepc_init (void );
Signature · 1 line
2.31.1
Jarkko Sakkinen
maintainerRe: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 10 lines · Tony Luck
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\ ^ | \-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Quoted 8 lines
It would be good to use the
sgx_epc_page->ownerfield as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller,sgx_alloc_va_page(), that calls with NULL.Since there are multiple uses of the "owner" field with different types change the
sgx_epc_pagestructure to define an anonymous union with each of the uses explicitly called out.
But it's still always a pointer.
And not only that, but two alternative fields in that union have *exactly* the same type, so it's kind of artifically representing the problem more complex than it really is.
I'm not just getting, why all this complexity, and not a few casts instead?
I neither get the rename of "owner" to "private". It serves very little value. I'm not saying that "owner" is best name ever but it's not *that* confusing either. That I'm sure that it is definitely not very productive to rename it.
Also there was still this "dirty". We could use ((void *)-1), which was also suggested for earlier revisions.
/Jarkko
Luck, Tony
reviewerRE: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 9 lines
Quoted 3 lines
Since there are multiple uses of the "owner" field with different types change the
sgx_epc_pagestructure to define an anonymous union with each of the uses explicitly called out.But it's still always a pointer.
And not only that, but two alternative fields in that union have *exactly* the same type, so it's kind of artifically representing the problem more complex than it really is.
Bother! I seem to have jumbled some old bits of v4 into this series.
I agree that we just want "void *owner; here. I even made the changes. Then managed to lose them while updating.
I'll find the bits I lost and re-merge them in.
-Tony
Jarkko Sakkinen
maintainerRe: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 10 lines · Tony
Quoted 9 lines
Quoted 3 lines
Since there are multiple uses of the "owner" field with different types change the
sgx_epc_pagestructure to define an anonymous union with each of the uses explicitly called out.But it's still always a pointer.
And not only that, but two alternative fields in that union have *exactly* the same type, so it's kind of artifically representing the problem more complex than it really is.
Quoted 8 lines
Bother! I seem to have jumbled some old bits of v4 into this series.
I agree that we just want "void *owner; here. I even made the changes. Then managed to lose them while updating.
I'll find the bits I lost and re-merge them in.
-Tony
Yeah, ok, cool, thank you. Just reporting what I was observing :-)
/Jarkko
Re: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
In reply to Jarkko SakkinenQuoted 10 lines · Jarkko Sakkinen
Quoted 3 lines
Since there are multiple uses of the "owner" field with different types change the
sgx_epc_pagestructure to define an anonymous union with each of the uses explicitly called out.But it's still always a pointer.
And not only that, but two alternative fields in that union have *exactly* the same type, so it's kind of artifically representing the problem more complex than it really is.
I'm not just getting, why all this complexity, and not a few casts instead?
I suggested this. It makes the structure more self-describing because it explicitly lists the possibles uses of the space in the structure.
Maybe I stare at 'struct page' and its 4 unions too much and I'm enamored by their shininess. But, in the end, I prefer unions to casting.
Jarkko Sakkinen
maintainerRe: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 10 lines · Dave Hansen
Quoted 9 lines · Jarkko Sakkinen
Quoted 3 lines
Since there are multiple uses of the "owner" field with different types change the
sgx_epc_pagestructure to define an anonymous union with each of the uses explicitly called out.But it's still always a pointer.
And not only that, but two alternative fields in that union have *exactly* the same type, so it's kind of artifically representing the problem more complex than it really is.
Quoted 7 lines
Quoted 1 line
I'm not just getting, why all this complexity, and not a few casts instead?
I suggested this. It makes the structure more self-describing because it explicitly lists the possibles uses of the space in the structure.
Maybe I stare at 'struct page' and its 4 unions too much and I'm enamored by their shininess. But, in the end, I prefer unions to casting.
Yeah, packing data into constrained space (as in the case of struct page) is the only application for, where you can speak of a quantitative decision, when you pick union.
/Jarkko
Tony Luck
reviewerPATCH v5 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
--- arch/x86/kernel/cpu/sgx/main.c | 10 ++++++++++ arch/x86/kernel/cpu/sgx/sgx.h | 1 + 2 files changed, 11 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +10 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (epc_page_ranges);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -649,6 +650,9 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ; +xa_store_range (&epc_page_ranges, section->phys_addr, + section->end_phys_addr, section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -660,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&epc_page_ranges, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
arch/x86/kernel/cpu/sgx/sgx.h +1 -0
@@ -54,6 +54,7 @@ struct sgx_numa_node {*/ struct sgx_epc_section {unsigned long phys_addr; +unsigned long end_phys_addr;void *virt_addr;struct sgx_epc_page *pages;struct sgx_numa_node *node;
Signature · 1 line
2.31.1
Re: [PATCH v5 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 655
Quoted 9 lines · Tony Luck
/*
* These variables are part of the state of the reclaimer, and must be accessedarch/x86/kernel/cpu/sgx/main.c +3
-0@@ -649,6 +650,9 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ; +xa_store_range (&epc_page_ranges, section->phys_addr, + section->end_phys_addr, section,GFP_KERNEL );
Did we ever figure out how much space storing really big ranges in the xarray consumes?
Luck, Tony
reviewerRE: [PATCH v5 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 7 lines
arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 655
Quoted 4 lines
arch/x86/kernel/cpu/sgx/main.c +3
-0section->phys_addr = phys_addr; + section->end_phys_addr = phys_addr + size -1 ; +xa_store_range (&epc_page_ranges, section->phys_addr, + section->end_phys_addr, section,GFP_KERNEL );Did we ever figure out how much space storing really big ranges in the xarray consumes?
No. Willy said the existing xarray code would be less than optimal with this usage, but that things would be much better when he applied some maple tree updates to the internals of xarray.
If there is some easy way to measure the memory backing an xarray I'm happy to get the data. Or if someone else can synthesize it ... the two ranges on my system that are added to the xarray are:
$ dmesg | grep -i sgx [ 8.496844] sgx: EPC section 0x8000c00000-0x807f7fffff [ 8.505118] sgx: EPC section 0x10000c00000-0x1007fffffff
I.e. two ranges of a bit under 2GB each.
But I don't think the overhead can be too hideous:
$ grep MemFree /proc/meminfo MemFree: 1048682016 kB
I still have ~ 1TB free. Which is much greater that the 640 KB which should be "enough for anybody" :-).
-Tony
Re: [PATCH v5 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 16 lines · Tony
Quoted 2 lines
Did we ever figure out how much space storing really big ranges in the xarray consumes?
No. Willy said the existing xarray code would be less than optimal with this usage, but that things would be much better when he applied some maple tree updates to the internals of xarray.
If there is some easy way to measure the memory backing an xarray I'm happy to get the data. Or if someone else can synthesize it ... the two ranges on my system that are added to the xarray are:
$ dmesg | grep -i sgx [ 8.496844] sgx: EPC section 0x8000c00000-0x807f7fffff [ 8.505118] sgx: EPC section 0x10000c00000-0x1007fffffffI.e. two ranges of a bit under 2GB each.
Quoted 7 lines
But I don't think the overhead can be too hideous:
$ grep MemFree /proc/meminfo MemFree: 1048682016 kBI still have ~ 1TB free. Which is much greater that the 640 KB which should be "enough for anybody" :-).
There is a kmem_cache_create() for the xarray nodes. So, you should be able to see the difference in /proc/meminfo's "Slab" field. Maybe boot with init=/bin/sh to reduce the noise and look at meminfo both with and without SGX your patch applied, or just with the xarray bits commented out.
I don't quite know how the data structures are munged, but xas_alloc() makes it look like 'struct xa_node' is allocated from radix_tree_node_cachep. If that's the case, you should also be able to see this in even more detail in:
# grep radix /proc/slabinfo radix_tree_node 432305 482412 584 28 4 : tunables 0 0 0 : slabdata 17229 17229 0
again, on a system with and without your new code enabled.
Luck, Tony
reviewerRe: [PATCH v5 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 35 lines · Dave Hansen
Quoted 16 lines · Tony
Quoted 2 lines
Did we ever figure out how much space storing really big ranges in the xarray consumes?
No. Willy said the existing xarray code would be less than optimal with this usage, but that things would be much better when he applied some maple tree updates to the internals of xarray.
If there is some easy way to measure the memory backing an xarray I'm happy to get the data. Or if someone else can synthesize it ... the two ranges on my system that are added to the xarray are:
$ dmesg | grep -i sgx [ 8.496844] sgx: EPC section 0x8000c00000-0x807f7fffff [ 8.505118] sgx: EPC section 0x10000c00000-0x1007fffffffI.e. two ranges of a bit under 2GB each.
Quoted 7 lines
But I don't think the overhead can be too hideous:
$ grep MemFree /proc/meminfo MemFree: 1048682016 kBI still have ~ 1TB free. Which is much greater that the 640 KB which should be "enough for anybody" :-).
There is a
kmem_cache_create()for the xarray nodes. So, you should be able to see the difference in /proc/meminfo's "Slab" field. Maybe boot with init=/bin/sh to reduce the noise and look at meminfo both with and without SGX your patch applied, or just with the xarray bits commented out.I don't quite know how the data structures are munged, but
xas_alloc()makes it look like 'structxa_node' is allocated fromradix_tree_node_cachep. If that's the case, you should also be able to see this in even more detail in:
Quoted 5 lines
# grep radix /proc/slabinfo radix_tree_node 432305 482412 584 28 4 : tunables 0 0 0 : slabdata 17229 17229 0again, on a system with and without your new code enabled.
Booting with init=/bin/sh and running that grep command right away at the prompt:
With the xa_store_range() call commented out of my kernel:
radix_tree_node 9800 9968 584 56 8 : tunables 0 0 0 : slabdata 178 178 0
With xa_store_range() enabled:
radix_tree_node 9950 10136 584 56 8 : tunables 0 0 0 : slabdata 181 181 0
The head of the file says these are the field names:
# name <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab> : tunables <limit> <batchcount> <sharedfactor> : slabdata <active_slabs> <num_slabs> <sharedavail>
So I think this means that I have (9950 - 9800) * 584 = 87600 more bytes allocated. Maybe that's a lot? But percentage-wise is seems in the noise. E.g. We allocate one "struct sgx_epc_page" for each SGX page. On my system I have 4GB of SGX EPC, so around 32 MB of these structures.
-Tony
Re: [PATCH v5 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 7 lines · Tony
# name <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab> : tunables <limit> <batchcount> <sharedfactor> : slabdata <active_slabs> <num_slabs> <sharedavail>So I think this means that I have (9950 - 9800) * 584 = 87600 more bytes allocated. Maybe that's a lot? But percentage-wise is seems in the noise. E.g. We allocate one "struct
sgx_epc_page" for each SGX page. On my system I have 4GB of SGX EPC, so around 32 MB of these structures.
100k for 4GB of EPC is certainly in the noise as far as I'm concerned.
Thanks for checking this.
Tony Luck
reviewerPATCH v5 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Add debugfs files /sys/kernel/debug/sgx/poison_page_list so that system administrators get a list of those pages that have been dropped because of poison.
--- arch/x86/kernel/cpu/sgx/main.c | 30 +++++++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 31 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +29 -1
@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2016-20 Intel Corporation. */ +#include <linux/debugfs.h> #include <linux/file.h> #include <linux/freezer.h> #include <linux/highmem.h>
@@ -43,6 +44,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
@@ -62,6 +64,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +634,10 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); page->private =NULL ; -list_add_tail (&page->list, &node->free_page_list); +if (page->poison) +list_add (&page->list, &sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);
@@ -657,6 +668,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; + section->pages[i].poison =0 ; section->pages[i].private ="dirty" ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
@@ -801,8 +813,21 @@ int sgx_set_attribute(unsigned long *allowed_attributes, }EXPORT_SYMBOL_GPL (sgx_set_attribute); +static int poison_list_show (struct seq_file *m,void *private) +{ +struct sgx_epc_page *page; + +list_for_each_entry (page, &sgx_poison_page_list, list) +seq_printf (m,"0x%lx\n" ,sgx_get_epc_phys_addr (page)); + +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (poison_list); +static int __init sgx_init (void ) { +struct dentry *dir;int ret;int i;
@@ -834,6 +859,9 @@ static int __init sgx_init(void)if (sgx_vepc_init () && ret) goto err_provision; + dir =debugfs_create_dir ("sgx" , arch_debugfs_dir); +debugfs_create_file ("poison_page_list" ,0400 , dir,NULL , &poison_list_fops); +return 0 ; err_provision:
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -28,7 +28,8 @@struct sgx_epc_page {unsigned int section; -int flags; +u16 flags; +u16 poison;union {void *private;struct sgx_encl_page *owner;
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v5 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function arch_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 77 ++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +77 -0
@@ -682,6 +682,83 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&epc_page_ranges, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If there is no owner, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->private) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v5 5/7 x86/sgx: Hook arch_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 13 +++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 38 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +13 -0
@@ -3284,5 +3284,18 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v5 6/7 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !arch_is_platform_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v5 7/7 x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
In reply to Tony LuckSGX EPC pages do not have a "struct page" associated with them so the pfn_valid() sanity check fails and results in a warning message to the console.
Add an additonal check to skip the warning if the address of the error is in an SGX EPC page.
--- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
@@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags)return false; pfn =PHYS_PFN (physical_addr); -if (!pfn_valid (pfn)) { +if (!pfn_valid (pfn) && !arch_is_platform_page (physical_addr)) { pr_warn_ratelimited(FW_WARN GHES_PFX"Invalid address in generic error data: %#llx\n" , physical_addr);
Signature · 1 line
2.31.1
Tony Luck
reviewerv6 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckNow version 6 (what I actually meant to post as v5).
Note that I've dropped [email protected] and [email protected] from the distribution. Time to get some internal agreement on these changes before bothering the x86 maintainers with yet another version.
So I'm looking for Acked-by: or Reviewed-by: on any bits of this series that are worthy, and comments on the problems I need to fix in the not-worthy parts.
Changes since v4 (I'm going to ignore the bogus v5 I posted):
Jarkko Sakkinen:
+ Add [email protected] to Cc: list
+ Remove explicit struct sgx_va_page *va_page type from argument and use in sgx_alloc_va_page(). Just use "void *" as this code doesn't do anything with the internals of struct sgx_va_page.
+ Drop the union of all possible types for the "owner" field in struct sgx_epc_page (sorry Dave Hansen, this went in last time from your comment, but it doesn't seem to add much value). Back to "void *owner;"
+ rename the xarray that tracks which addresses are EPC pages from "epc_page_ranges" to "sgx_epc_address_space".
Dave Hansen:
+ Use more generic names for the globally visible functions that are needed in generic code:
sgx_memory_failure -> arch_memory_failure sgx_is_epc_page -> arch_is_platform_page
+ Commit comment on space used by xarray to track EPC pages.
Tony Luck:
+ Found that ghes code spits warnings for memory addresses that it thinks are bad. Add a check for SGX pages.
Tony Luck (7):
x86/sgx: Provide indication of life-cycle of EPC pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook arch_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/processor.h | 8 + arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/encl.c | 5 +- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 137 ++++++++++++++++-- arch/x86/kernel/cpu/sgx/sgx.h | 7 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 14 ++ mm/memory-failure.c | 19 ++- 12 files changed, 196 insertions(+), 26 deletions(-)
base-commit: e4e737bb5c170df6135a127739a9e6148ee3da82
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v6 1/7 x86/sgx: Provide indication of life-cycle of EPC pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the sgx_epc_page->owner field as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller, sgx_alloc_va_page(), that calls with NULL.
Since there are multiple uses of the "owner" field with different types change the type of sgx_epc_page.owner to "void *.
Start epc_pages out with a non-NULL owner while they are in DIRTY state.
Fix up the one holdout to provide a non-NULL owner.
Refactor the allocation sequence so that changes to/from NULL value happen together with adding/removing the epc_page from a free list while the node->lock is held.
--- arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++---------- arch/x86/kernel/cpu/sgx/sgx.h | 4 ++-- 5 files changed, 18 insertions(+), 16 deletions(-)
arch/x86/kernel/cpu/sgx/encl.c +3 -2
@@ -667,6 +667,7 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,/** * sgx_alloc_va_page() - Allocate a Version Array (VA) page +* @owner: struct sgx_va_page connected to this VA page * * Allocate a free EPC page and convert it to a Version Array (VA) page. *
@@ -674,12 +675,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (void *owner) {struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (owner, true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);
arch/x86/kernel/cpu/sgx/encl.h +1 -1
@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (void *owner);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);
arch/x86/kernel/cpu/sgx/main.c +11 -10
@@ -457,7 +457,7 @@ static bool __init sgx_page_reclaimer_init(void)return true; } -static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (int nid) +static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (void *owner,int nid) {struct sgx_numa_node *node = &sgx_numa_nodes[nid];struct sgx_epc_page *page =NULL ;
@@ -471,6 +471,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); + page->owner = owner; sgx_nr_free_pages--;spin_unlock (&node->lock);
@@ -480,6 +481,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)/** * __sgx_alloc_epc_page() - Allocate an EPC page +* @owner: the owner of the EPC page * * Iterate through NUMA nodes and reserve ia free EPC page to the caller. Start * from the NUMA node, where the caller is executing.
@@ -488,14 +490,14 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)* - an EPC page: A borrowed EPC pages were available. * - NULL: Out of EPC pages. */ -struct sgx_epc_page *__sgx_alloc_epc_page (void ) +struct sgx_epc_page *__sgx_alloc_epc_page (void *owner) {struct sgx_epc_page *page;int nid_of_current =numa_node_id ();int nid = nid_of_current;if (node_isset (nid_of_current, sgx_numa_mask)) { - page =__sgx_alloc_epc_page_from_node (nid_of_current); + page =__sgx_alloc_epc_page_from_node (owner, nid_of_current);if (page)return page; }
@@ -506,7 +508,7 @@ struct sgx_epc_page *__sgx_alloc_epc_page(void)if (nid == nid_of_current)break ; - page =__sgx_alloc_epc_page_from_node (nid); + page =__sgx_alloc_epc_page_from_node (owner, nid);if (page)return page; }
@@ -559,7 +561,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page -* @owner: the owner of the EPC page +* @owner: per-caller page owner * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a
@@ -579,11 +581,9 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)struct sgx_epc_page *page;for ( ; ; ) { - page =__sgx_alloc_epc_page (); -if (!IS_ERR (page)) { - page->owner = owner; + page =__sgx_alloc_epc_page (owner); +if (!IS_ERR (page))break ; - }if (list_empty (&sgx_active_page_list))return ERR_PTR (-ENOMEM );
@@ -624,6 +624,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->owner =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
@@ -652,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; - section->pages[i].owner =NULL ; + section->pages[i].owner = (void *)-1 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +2 -2
@@ -29,7 +29,7 @@struct sgx_epc_page {unsigned int section;unsigned int flags; -struct sgx_encl_page *owner; +void *owner;struct list_head list; };
@@ -77,7 +77,7 @@ static inline void *sgx_get_epc_virt_addr(struct sgx_epc_page *page)return section->virt_addr + index *PAGE_SIZE ; } -struct sgx_epc_page *__sgx_alloc_epc_page (void ); +struct sgx_epc_page *__sgx_alloc_epc_page (void *owner);void sgx_free_epc_page (struct sgx_epc_page *page);void sgx_mark_page_reclaimable (struct sgx_epc_page *page);
Signature · 1 line
2.31.1
Jarkko Sakkinen
maintainerRe: [PATCH v6 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 175 lines · Tony Luck
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\ ^ | \-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the
sgx_epc_page->ownerfield as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller,sgx_alloc_va_page(), that calls with NULL.Since there are multiple uses of the "owner" field with different types change the type of sgx_epc_page.owner to "void *.
Start
epc_pagesout with a non-NULL owner while they are in DIRTY state.Fix up the one holdout to provide a non-NULL owner.
Refactor the allocation sequence so that changes to/from NULL value happen together with adding/removing the
epc_pagefrom a free list while thenode->lockis held.Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++---------- arch/x86/kernel/cpu/sgx/sgx.h | 4 ++-- 5 files changed, 18 insertions(+), 16 deletions(-)arch/x86/kernel/cpu/sgx/encl.c +3
-2@@ -667,6 +667,7 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,/** * sgx_alloc_va_page() - Allocate a Version Array (VA) page +* @owner: struct sgx_va_page connected to this VA page * * Allocate a free EPC page and convert it to a Version Array (VA) page. * @@ -674,12 +675,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (void *owner) {struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (owner, true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);arch/x86/kernel/cpu/sgx/encl.h +1
-1@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (void *owner);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);arch/x86/kernel/cpu/sgx/ioctl.c +1
-1@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);arch/x86/kernel/cpu/sgx/main.c +10
-9@@ -457,7 +457,7 @@ static bool __init sgx_page_reclaimer_init(void)return true; } -static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (int nid) +static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (void *owner,int nid) {struct sgx_numa_node *node = &sgx_numa_nodes[nid];struct sgx_epc_page *page =NULL ;@@ -471,6 +471,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); + page->owner = owner; sgx_nr_free_pages--;spin_unlock (&node->lock);@@ -480,6 +481,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)/** * __sgx_alloc_epc_page() - Allocate an EPC page +* @owner: the owner of the EPC page * * Iterate through NUMA nodes and reserve ia free EPC page to the caller. Start * from the NUMA node, where the caller is executing. @@ -488,14 +490,14 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)* - an EPC page: A borrowed EPC pages were available. * - NULL: Out of EPC pages. */ -struct sgx_epc_page *__sgx_alloc_epc_page (void ) +struct sgx_epc_page *__sgx_alloc_epc_page (void *owner) {struct sgx_epc_page *page;int nid_of_current =numa_node_id ();int nid = nid_of_current;if (node_isset (nid_of_current, sgx_numa_mask)) { - page =__sgx_alloc_epc_page_from_node (nid_of_current); + page =__sgx_alloc_epc_page_from_node (owner, nid_of_current);if (page)return page; }@@ -506,7 +508,7 @@ struct sgx_epc_page *__sgx_alloc_epc_page(void)if (nid == nid_of_current)break ; - page =__sgx_alloc_epc_page_from_node (nid); + page =__sgx_alloc_epc_page_from_node (owner, nid);if (page)return page; }@@ -559,7 +561,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page -* @owner: the owner of the EPC page +* @owner: per-caller page owner * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a @@ -579,11 +581,9 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)struct sgx_epc_page *page;for ( ; ; ) { - page =__sgx_alloc_epc_page (); -if (!IS_ERR (page)) { - page->owner = owner; + page =__sgx_alloc_epc_page (owner); +if (!IS_ERR (page))break ; - }if (list_empty (&sgx_active_page_list))return ERR_PTR (-ENOMEM );@@ -624,6 +624,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->owner =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;
arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 656
Quoted 5 lines
arch/x86/kernel/cpu/sgx/main.c +1
-1@@ -652,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; - section->pages[i].owner =NULL ; + section->pages[i].owner = (void *)-1 ;
Probably should have a named constant.
Anyway, I wonder why we want to do tricks with 'owner', when the struct has a flags field?
Right now its use is so nice and straight forward, and most importantly intuitive.
So what I would do instead of this, would be to add something like
/* Pages, which are being tracked by the page reclaimer. */
#define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0)
/* Pages, which are allocated for use. */
#define SGX_EPC_PAGE_ALLOCATED BIT(1)
This would be set by sgx_alloc_epc_page() and reset by sgx_free_epc_page().
In the subsequent patch you could then instead of
/*
* If there is no owner, then the page is on a free list.
* Move it to the poison page list.
*/
if (!page->owner) {
list_del(&page->list);
list_add(&page->list, &sgx_poison_page_list);
goto out;
}you would
/*
* If there is no owner, then the page is on a free list.
* Move it to the poison page list.
*/
if (!page->flags) {
list_del(&page->list);
list_add(&page->list, &sgx_poison_page_list);
goto out;
}You don't actually need to compare to that flag because the invariant would be that it is set, as long as the page is not explicitly freed.
I think this is a better solution than in the patch set because it does not introduce any unorthodox use of anything.
/Jarkko
Jarkko Sakkinen
maintainerRe: [PATCH v6 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 226 lines · Jarkko Sakkinen
Quoted 175 lines · Tony Luck
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\ ^ | \-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
It would be good to use the
sgx_epc_page->ownerfield as an indicator of where an EPC page is currently in that cycle (owner != NULL means the EPC page is IN-USE). But there is one caller,sgx_alloc_va_page(), that calls with NULL.Since there are multiple uses of the "owner" field with different types change the type of sgx_epc_page.owner to "void *.
Start
epc_pagesout with a non-NULL owner while they are in DIRTY state.Fix up the one holdout to provide a non-NULL owner.
Refactor the allocation sequence so that changes to/from NULL value happen together with adding/removing the
epc_pagefrom a free list while thenode->lockis held.Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++---------- arch/x86/kernel/cpu/sgx/sgx.h | 4 ++-- 5 files changed, 18 insertions(+), 16 deletions(-)arch/x86/kernel/cpu/sgx/encl.c +3
-2@@ -667,6 +667,7 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,/** * sgx_alloc_va_page() - Allocate a Version Array (VA) page +* @owner: struct sgx_va_page connected to this VA page * * Allocate a free EPC page and convert it to a Version Array (VA) page. * @@ -674,12 +675,12 @@ int sgx_encl_test_and_clear_young(struct mm_struct *mm,* a VA page, * -errno otherwise */ -struct sgx_epc_page *sgx_alloc_va_page (void ) +struct sgx_epc_page *sgx_alloc_va_page (void *owner) {struct sgx_epc_page *epc_page;int ret; - epc_page =sgx_alloc_epc_page (NULL , true); + epc_page =sgx_alloc_epc_page (owner, true);if (IS_ERR (epc_page))return ERR_CAST (epc_page);arch/x86/kernel/cpu/sgx/encl.h +1
-1@@ -111,7 +111,7 @@ void sgx_encl_put_backing(struct sgx_backing *backing, bool do_write);int sgx_encl_test_and_clear_young (struct mm_struct *mm,struct sgx_encl_page *page); -struct sgx_epc_page *sgx_alloc_va_page (void ); +struct sgx_epc_page *sgx_alloc_va_page (void *owner);unsigned int sgx_alloc_va_slot (struct sgx_va_page *va_page);void sgx_free_va_slot (struct sgx_va_page *va_page,unsigned int offset);bool sgx_va_page_full (struct sgx_va_page *va_page);arch/x86/kernel/cpu/sgx/ioctl.c +1
-1@@ -30,7 +30,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)if (!va_page)return ERR_PTR (-ENOMEM ); - va_page->epc_page =sgx_alloc_va_page (); + va_page->epc_page =sgx_alloc_va_page (va_page);if (IS_ERR (va_page->epc_page)) { err =ERR_CAST (va_page->epc_page);kfree (va_page);arch/x86/kernel/cpu/sgx/main.c +10
-9@@ -457,7 +457,7 @@ static bool __init sgx_page_reclaimer_init(void)return true; } -static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (int nid) +static struct sgx_epc_page *__sgx_alloc_epc_page_from_node (void *owner,int nid) {struct sgx_numa_node *node = &sgx_numa_nodes[nid];struct sgx_epc_page *page =NULL ;@@ -471,6 +471,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); + page->owner = owner; sgx_nr_free_pages--;spin_unlock (&node->lock);@@ -480,6 +481,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)/** * __sgx_alloc_epc_page() - Allocate an EPC page +* @owner: the owner of the EPC page * * Iterate through NUMA nodes and reserve ia free EPC page to the caller. Start * from the NUMA node, where the caller is executing. @@ -488,14 +490,14 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)* - an EPC page: A borrowed EPC pages were available. * - NULL: Out of EPC pages. */ -struct sgx_epc_page *__sgx_alloc_epc_page (void ) +struct sgx_epc_page *__sgx_alloc_epc_page (void *owner) {struct sgx_epc_page *page;int nid_of_current =numa_node_id ();int nid = nid_of_current;if (node_isset (nid_of_current, sgx_numa_mask)) { - page =__sgx_alloc_epc_page_from_node (nid_of_current); + page =__sgx_alloc_epc_page_from_node (owner, nid_of_current);if (page)return page; }@@ -506,7 +508,7 @@ struct sgx_epc_page *__sgx_alloc_epc_page(void)if (nid == nid_of_current)break ; - page =__sgx_alloc_epc_page_from_node (nid); + page =__sgx_alloc_epc_page_from_node (owner, nid);if (page)return page; }@@ -559,7 +561,7 @@ int sgx_unmark_page_reclaimable(struct sgx_epc_page *page)/** * sgx_alloc_epc_page() - Allocate an EPC page -* @owner: the owner of the EPC page +* @owner: per-caller page owner * @reclaim: reclaim pages if necessary * * Iterate through EPC sections and borrow a free EPC page to the caller. When a @@ -579,11 +581,9 @@ struct sgx_epc_page *sgx_alloc_epc_page(void *owner, bool reclaim)struct sgx_epc_page *page;for ( ; ; ) { - page =__sgx_alloc_epc_page (); -if (!IS_ERR (page)) { - page->owner = owner; + page =__sgx_alloc_epc_page (owner); +if (!IS_ERR (page))break ; - }if (list_empty (&sgx_active_page_list))return ERR_PTR (-ENOMEM );@@ -624,6 +624,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); + page->owner =NULL ;list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 656
Quoted 5 lines
arch/x86/kernel/cpu/sgx/main.c +1
-1@@ -652,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; - section->pages[i].owner =NULL ; + section->pages[i].owner = (void *)-1 ;Probably should have a named constant.
Anyway, I wonder why we want to do tricks with 'owner', when the struct has a flags field?
Right now its use is so nice and straight forward, and most importantly intuitive.
So what I would do instead of this, would be to add something like
/* Pages, which are being tracked by the page reclaimer. */
#defineSGX_EPC_PAGE_RECLAIMER_TRACKEDBIT(0)/* Pages, which are allocated for use. */
#defineSGX_EPC_PAGE_ALLOCATEDBIT(1)This would be set by
sgx_alloc_epc_page()and reset bysgx_free_epc_page().In the subsequent patch you could then instead of
/* * If there is no owner, then the page is on a free list. * Move it to the poison page list. */ if (!page->owner) { list_del(&page->list); list_add(&page->list, &sgx_poison_page_list); goto out; }you would
/* * If there is no owner, then the page is on a free list. * Move it to the poison page list. */ if (!page->flags) { list_del(&page->list); list_add(&page->list, &sgx_poison_page_list); goto out; }
Quoted 6 lines
You don't actually need to compare to that flag because the invariant would be that it is set, as long as the page is not explicitly freed.
I think this is a better solution than in the patch set because it does not introduce any unorthodox use of anything.
And does not contain any special cases, e.g. when you debug something you can always assume that a valid owner pointer is always a legit sgx_encl_page instance.
/Jarkko
Luck, Tony
reviewerRe: [PATCH v6 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 53 lines · Jarkko Sakkinen
Quoted 52 lines · Jarkko Sakkinen
arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 656
Quoted 2 lines · Tony Luck
arch/x86/kernel/cpu/sgx/main.c +1
-1- section->pages[i].owner =NULL ; + section->pages[i].owner = (void *)-1 ;Probably should have a named constant.
Anyway, I wonder why we want to do tricks with 'owner', when the struct has a flags field?
Right now its use is so nice and straight forward, and most importantly intuitive.
So what I would do instead of this, would be to add something like
/* Pages, which are being tracked by the page reclaimer. */
#defineSGX_EPC_PAGE_RECLAIMER_TRACKEDBIT(0)/* Pages, which are allocated for use. */
#defineSGX_EPC_PAGE_ALLOCATEDBIT(1)This would be set by
sgx_alloc_epc_page()and reset bysgx_free_epc_page().In the subsequent patch you could then instead of
/* * If there is no owner, then the page is on a free list. * Move it to the poison page list. */ if (!page->owner) { list_del(&page->list); list_add(&page->list, &sgx_poison_page_list); goto out; }you would
/* * If there is no owner, then the page is on a free list. * Move it to the poison page list. */ if (!page->flags) { list_del(&page->list); list_add(&page->list, &sgx_poison_page_list); goto out; }You don't actually need to compare to that flag because the invariant would be that it is set, as long as the page is not explicitly freed.
Quoted 7 lines
Quoted 2 lines
I think this is a better solution than in the patch set because it does not introduce any unorthodox use of anything.
And does not contain any special cases, e.g. when you debug something you can always assume that a valid owner pointer is always a legit
sgx_encl_pageinstance.
Jarkko,
That's nice. It avoids having to create a fictitious owner for the dirty pages, and for the sgx_alloc_va_page() case. Which in turn means that the owner field in struct sgx_epc_page can remain as "struct sgx_encl_page *owner;" (neatly avoiding DaveH's request that it be an anonymous union of all the possible types, because it is back to just being one type).
Thanks! Will include in next version.
-Tony
Luck, Tony
reviewerRE: [PATCH v6 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 8 lines
That's nice. It avoids having to create a fictitious owner for the dirty pages, and for the
sgx_alloc_va_page()case. Which in turn means that the owner field in structsgx_epc_pagecan remain as "structsgx_encl_page*owner;" (neatly avoiding DaveH's request that it be an anonymous union of all the possible types, because it is back to just being one type).Thanks! Will include in next version.
Also avoids a bunch of refactoring to make sure to set the owner field while holding zone->lock.
I roughly coded it up and the old part 0001 was:
arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++---------- arch/x86/kernel/cpu/sgx/sgx.h | 4 ++-- 5 files changed, 18 insertions(+), 16 deletions(-)
which is by no means huge, but the new part 0001 is
arch/x86/kernel/cpu/sgx/main.c | 4 +++- arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-)
-Tony
Jarkko Sakkinen
maintainerRe: [PATCH v6 1/7] x86/sgx: Provide indication of life-cycle of EPC pages
Quoted 21 lines · Tony
Quoted 8 lines
That's nice. It avoids having to create a fictitious owner for the dirty pages, and for the
sgx_alloc_va_page()case. Which in turn means that the owner field in structsgx_epc_pagecan remain as "structsgx_encl_page*owner;" (neatly avoiding DaveH's request that it be an anonymous union of all the possible types, because it is back to just being one type).Thanks! Will include in next version.
Also avoids a bunch of refactoring to make sure to set the owner field while holding
zone->lock.I roughly coded it up and the old part 0001 was:
arch/x86/kernel/cpu/sgx/encl.c | 5 +++-- arch/x86/kernel/cpu/sgx/encl.h | 2 +- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- arch/x86/kernel/cpu/sgx/main.c | 21 +++++++++++---------- arch/x86/kernel/cpu/sgx/sgx.h | 4 ++-- 5 files changed, 18 insertions(+), 16 deletions(-)
Quoted 7 lines
which is by no means huge, but the new part 0001 is
arch/x86/kernel/cpu/sgx/main.c | 4 +++- arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-)-Tony
This is good to hear. I guess it is then a no brainer to move into this direction then.
/Jarkko
Tony Luck
reviewerPATCH v6 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
--- arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +9 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -649,6 +650,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -660,6 +663,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v6 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Add debugfs files /sys/kernel/debug/sgx/poison_page_list so that system administrators get a list of those pages that have been dropped because of poison.
--- arch/x86/kernel/cpu/sgx/main.c | 30 +++++++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 31 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +29 -1
@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2016-20 Intel Corporation. */ +#include <linux/debugfs.h> #include <linux/file.h> #include <linux/freezer.h> #include <linux/highmem.h>
@@ -43,6 +44,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
@@ -62,6 +64,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +634,10 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); page->owner =NULL ; -list_add_tail (&page->list, &node->free_page_list); +if (page->poison) +list_add (&page->list, &sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++;spin_unlock (&node->lock);
@@ -656,6 +667,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; section->pages[i].flags =0 ; + section->pages[i].poison =0 ; section->pages[i].owner = (void *)-1 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
@@ -800,8 +812,21 @@ int sgx_set_attribute(unsigned long *allowed_attributes, }EXPORT_SYMBOL_GPL (sgx_set_attribute); +static int poison_list_show (struct seq_file *m,void *private) +{ +struct sgx_epc_page *page; + +list_for_each_entry (page, &sgx_poison_page_list, list) +seq_printf (m,"0x%lx\n" ,sgx_get_epc_phys_addr (page)); + +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (poison_list); +static int __init sgx_init (void ) { +struct dentry *dir;int ret;int i;
@@ -833,6 +858,9 @@ static int __init sgx_init(void)if (sgx_vepc_init () && ret) goto err_provision; + dir =debugfs_create_dir ("sgx" , arch_debugfs_dir); +debugfs_create_file ("poison_page_list" ,0400 , dir,NULL , &poison_list_fops); +return 0 ; err_provision:
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -28,7 +28,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;void *owner;struct list_head list; };
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v6 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 77 ++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +77 -0
@@ -681,6 +681,83 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&sgx_epc_address_space, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If there is no owner, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->owner) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v6 5/7 x86/sgx: Hook arch_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to call the arch specific code to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 14 ++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 39 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +14 -0
@@ -3284,5 +3284,19 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v6 6/7 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !arch_is_platform_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v6 7/7 x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
In reply to Tony LuckSGX EPC pages do not have a "struct page" associated with them so the pfn_valid() sanity check fails and results in a warning message to the console.
Add an additonal check to skip the warning if the address of the error is in an SGX EPC page.
--- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
@@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags)return false; pfn =PHYS_PFN (physical_addr); -if (!pfn_valid (pfn)) { +if (!pfn_valid (pfn) && !arch_is_platform_page (physical_addr)) { pr_warn_ratelimited(FW_WARN GHES_PFX"Invalid address in generic error data: %#llx\n" , physical_addr);
Signature · 1 line
2.31.1
Tony Luck
reviewerv7 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckNow version 7
Note that [email protected] and [email protected] are still dropped from the distribution. Time to get some internal agreement on these changes before bothering the x86 maintainers with yet another version.
So I'm looking for Acked-by: or Reviewed-by: on any bits of this series that are worthy, and comments on the problems I need to fix in the not-worthy parts.
Changes since v6:
Jarkko Sakkinen:
Don't use "owner" == NULL vs. != NULL as an indicator of whether an SGX EPC page is free vs. in-use. Just add a new flags bit. Note this drops most of the changes I had in part 0001. Remainder of the patches are largely unchanged except where they check for the new flags bit instead of owner != NULL.
Tony Luck (7):
x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook arch_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/processor.h | 8 ++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/main.c | 121 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 6 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 14 ++ mm/memory-failure.c | 19 ++- 9 files changed, 185 insertions(+), 11 deletions(-)
base-commit: 5816b3e6577eaa676ceb00a848f0fd65fe2adc29
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v7 1/7 x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit SGX_EPC_PAGE_IN_USE that is set when a page is allocated and cleared when the page is freed.
Notes:
1) These transitions are made while holding the node->lock so that future code that checks the flags while holding the node->lock can be sure that if the SGX_EPC_PAGE_IN_USE bit is set, then the page is on the free list.
2) Initially while the pages are on the dirty list the SGX_EPC_PAGE_IN_USE bit is set.
--- arch/x86/kernel/cpu/sgx/main.c | 4 +++- arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/main.c +3 -1
@@ -472,6 +472,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); sgx_nr_free_pages--; + page->flags =SGX_EPC_PAGE_IN_USE ;spin_unlock (&node->lock);
@@ -626,6 +627,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; + page->flags =0 ;spin_unlock (&node->lock); }
@@ -651,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; - section->pages[i].flags =0 ; + section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Allocated pages */ +#define SGX_EPC_PAGE_IN_USE BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Signature · 1 line
2.31.1
Re: [PATCH v7 1/7] x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages
Quoted 20 lines · Tony Luck
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\ ^ | \-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit
SGX_EPC_PAGE_IN_USEthat is set when a page is allocated and cleared when the page is freed.Notes:
1) These transitions are made while holding the
node->lockso that future code that checks the flags while holding thenode->lockcan be sure that if theSGX_EPC_PAGE_IN_USEbit is set, then the page is on the free list.
Quoted 4 lines
2) Initially while the pages are on the dirty list the
SGX_EPC_PAGE_IN_USEbit is set.Signed-off-by Tony Luck <[email protected]>
/Jarkko
Tony Luck
reviewerPATCH v7 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
--- arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +9 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -650,6 +651,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -661,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Re: [PATCH v7 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
Quoted 52 lines · Tony Luck
X86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function
arch_is_platform_page()that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.Note that
arch_is_platform_page()will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 1 file changed, 9 insertions(+)arch/x86/kernel/cpu/sgx/main.c +3
-0@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed @@ -650,6 +651,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;@@ -661,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; }
arch/x86/kernel/cpu/sgx/main.c static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, · line 675
Quoted 10 lines
arch/x86/kernel/cpu/sgx/main.c +6
-0+bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
/Jarkko
Tony Luck
reviewerPATCH v7 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Add debugfs files /sys/kernel/debug/sgx/poison_page_list so that system administrators get a list of those pages that have been dropped because of poison.
--- arch/x86/kernel/cpu/sgx/main.c | 31 ++++++++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 32 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +30 -1
@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2016-20 Intel Corporation. */ +#include <linux/debugfs.h> #include <linux/file.h> #include <linux/freezer.h> #include <linux/highmem.h>
@@ -43,6 +44,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
@@ -62,6 +64,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +634,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =0 ;
@@ -658,6 +670,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
@@ -801,8 +814,21 @@ int sgx_set_attribute(unsigned long *allowed_attributes, }EXPORT_SYMBOL_GPL (sgx_set_attribute); +static int poison_list_show (struct seq_file *m,void *private) +{ +struct sgx_epc_page *page; + +list_for_each_entry (page, &sgx_poison_page_list, list) +seq_printf (m,"0x%lx\n" ,sgx_get_epc_phys_addr (page)); + +return 0 ; +} + +DEFINE_SHOW_ATTRIBUTE (poison_list); +static int __init sgx_init (void ) { +struct dentry *dir;int ret;int i;
@@ -834,6 +860,9 @@ static int __init sgx_init(void)if (sgx_vepc_init () && ret) goto err_provision; + dir =debugfs_create_dir ("sgx" , arch_debugfs_dir); +debugfs_create_file ("poison_page_list" ,0400 , dir,NULL , &poison_list_fops); +return 0 ; err_provision:
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };
Signature · 1 line
2.31.1
Jarkko Sakkinen
maintainerRe: [PATCH v7 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 12 lines · Tony Luck
A memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the
sgx_epc_pagethat can be set for ansgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pagesPoison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
Quoted 6 lines
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Add debugfs files
/sys/kernel/debug/sgx/poison_page_listso that system administrators get a list of those pages that have been dropped because of poison.
So, what would a sysadmin do with that detailed information?
I would decrease the granularity a bit rather add something like this for each node:
/sys/devices/system/node/node[0-9]*/sgx/poisoned_size
which would give the total amount of poisoned memory in bytes for that node.
See the series that I've recently posted:
https://lore.kernel.org/linux-sgx/[email protected]/T/#t
/Jarkko
Luck, Tony
reviewerRE: [PATCH v7 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 5 lines
Quoted 3 lines
Add debugfs files
/sys/kernel/debug/sgx/poison_page_listso that system administrators get a list of those pages that have been dropped because of poison.So, what would a sysadmin do with that detailed information?
It's going to be a rare case that there are any poisoned pages on that list (a large enough cluster will have some systems that have uncorrected recoverable errors in SGX EPC memory).
Even when there are some poisoned pages, there will only be a few. Systems that have thousands of pages with uncorrected memory errors will surely crash because one of those errors is going to either trigger an error marked as fatal, or the error won’t be recoverable by Linux because it is in kernel memory.
A sysadmin might add a script to run during system shutdown (or periodically during run-time) to save the poison page list. Then at startup run:
for addr in cat saved_sgx_poison_page_list
do
echo $addr > /sys/devices/system/memory/hard_offline_page
done
to make poison persistent across reboots.
-Tony
Jarkko Sakkinen
maintainerRe: [PATCH v7 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 18 lines · Tony
Quoted 5 lines
Quoted 3 lines
Add debugfs files
/sys/kernel/debug/sgx/poison_page_listso that system administrators get a list of those pages that have been dropped because of poison.So, what would a sysadmin do with that detailed information?
It's going to be a rare case that there are any poisoned pages on that list (a large enough cluster will have some systems that have uncorrected recoverable errors in SGX EPC memory).
Even when there are some poisoned pages, there will only be a few. Systems that have thousands of pages with uncorrected memory errors will surely crash because one of those errors is going to either trigger an error marked as fatal, or the error won’t be recoverable by Linux because it is in kernel memory.
A sysadmin might add a script to run during system shutdown (or periodically during run-time) to save the poison page list. Then at startup run:
Quoted 8 lines
for addr in
cat saved_sgx_poison_page_list
do
echo $addr >/sys/devices/system/memory/hard_offline_page
doneto make poison persistent across reboots.
-Tony
Couldn't it be a blob with 8 bytes for each address?
/Jarkko
Luck, Tony
reviewerRe: [PATCH v7 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 24 lines · Jarkko Sakkinen
Quoted 23 lines · Tony
Quoted 5 lines
Quoted 3 lines
Add debugfs files
/sys/kernel/debug/sgx/poison_page_listso that system administrators get a list of those pages that have been dropped because of poison.So, what would a sysadmin do with that detailed information?
It's going to be a rare case that there are any poisoned pages on that list (a large enough cluster will have some systems that have uncorrected recoverable errors in SGX EPC memory).
Even when there are some poisoned pages, there will only be a few. Systems that have thousands of pages with uncorrected memory errors will surely crash because one of those errors is going to either trigger an error marked as fatal, or the error won’t be recoverable by Linux because it is in kernel memory.
A sysadmin might add a script to run during system shutdown (or periodically during run-time) to save the poison page list. Then at startup run:
for addr in
cat saved_sgx_poison_page_list
do
echo $addr >/sys/devices/system/memory/hard_offline_page
done
Quoted 5 lines
Quoted 3 lines
to make poison persistent across reboots.
-Tony
Couldn't it be a blob with 8 bytes for each address?
It could be a blob. But that would require some perl/python instead of simple shell to do the above persistence trick.
Or I could just drop the debugfs interface from this patch, waiting until some use case for the data is fleshed out so that it can be done in the most sensible way for that use case.
Untested updated patch below.
-Tony
From 551fbc5822e8faf93ff53f0a2b2448b0b98f1dde Mon Sep 17 00:00:00 2001
From: Tony Luck <[email protected]>
Date: Mon, 27 Sep 2021 13:26:06 -0700
Subject: [PATCH] x86/sgx: Initial poison handling for dirty and free pages
A memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
--- arch/x86/kernel/cpu/sgx/main.c | 14 +++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +13 -1
@@ -43,6 +43,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
@@ -62,6 +63,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +633,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =0 ;
@@ -658,6 +669,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };
Signature · 1 line
2.31.1
Jarkko Sakkinen
maintainerRe: [PATCH v7 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 25 lines · Tony
Quoted 24 lines · Jarkko Sakkinen
Quoted 23 lines · Tony
Quoted 5 lines
Quoted 3 lines
Add debugfs files
/sys/kernel/debug/sgx/poison_page_listso that system administrators get a list of those pages that have been dropped because of poison.So, what would a sysadmin do with that detailed information?
It's going to be a rare case that there are any poisoned pages on that list (a large enough cluster will have some systems that have uncorrected recoverable errors in SGX EPC memory).
Even when there are some poisoned pages, there will only be a few. Systems that have thousands of pages with uncorrected memory errors will surely crash because one of those errors is going to either trigger an error marked as fatal, or the error won’t be recoverable by Linux because it is in kernel memory.
A sysadmin might add a script to run during system shutdown (or periodically during run-time) to save the poison page list. Then at startup run:
for addr in
cat saved_sgx_poison_page_list
do
echo $addr >/sys/devices/system/memory/hard_offline_page
done
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
to make poison persistent across reboots.
-Tony
Couldn't it be a blob with 8 bytes for each address?
It could be a blob. But that would require some perl/python instead of simple shell to do the above persistence trick.
The way I've understood it, a list of values breaks sysfs conventions. There can be only single value per attribute. Even, if the blob is interpreted as a list of integers, it is still a value, as far as sysfs is concerned.
I'd also consider programs written with C, or perhaps Rust, when we (ever) add any new sysfs for SGX. In my opinion, it makes sense to make any uapi things we add accesible to as many tools as we can.
Such a trivially constructed blob is not enormously hard to parse in any language, but at least I don't enjoy parsing list of strings in C code, whereas loading a blob is effortless.
This kind of shows why the current sysfs conventions make sense in the first place: they enforce to design attributes in the manner that they are as reachable as possible. That's why I would follow the conventions in a strict manner.
Finally, I would make a proper sysfs attribute out of this (and a separate patch), which would be available per node.
/Jarkko
Luck, Tony
reviewerRe: [PATCH v7 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 19 lines · Jarkko Sakkinen
Quoted 4 lines · Tony
Quoted 1 line
Couldn't it be a blob with 8 bytes for each address?
It could be a blob. But that would require some perl/python instead of simple shell to do the above persistence trick.
The way I've understood it, a list of values breaks sysfs conventions. There can be only single value per attribute. Even, if the blob is interpreted as a list of integers, it is still a value, as far as sysfs is concerned.
I'd also consider programs written with C, or perhaps Rust, when we (ever) add any new sysfs for SGX. In my opinion, it makes sense to make any uapi things we add accesible to as many tools as we can.
Such a trivially constructed blob is not enormously hard to parse in any language, but at least I don't enjoy parsing list of strings in C code, whereas loading a blob is effortless.
Quoted 7 lines
This kind of shows why the current sysfs conventions make sense in the first place: they enforce to design attributes in the manner that they are as reachable as possible. That's why I would follow the conventions in a strict manner.
Finally, I would make a proper sysfs attribute out of this (and a separate patch), which would be available per node.
Those are all good points. I'm going to drop any interface from this series (because that's above and beyond the goal of "basic machine check support"). We can spend some time to come up with the right interface and add that in a future series.
-Tony
Tony Luck
reviewerPATCH v7 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 77 ++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +77 -0
@@ -683,6 +683,83 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&sgx_epc_address_space, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If flags is zero, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->flags) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v7 5/7 x86/sgx: Hook arch_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to call the arch specific code to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 14 ++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 39 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +14 -0
@@ -3284,5 +3284,19 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v7 6/7 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !arch_is_platform_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v7 7/7 x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
In reply to Tony LuckSGX EPC pages do not have a "struct page" associated with them so the pfn_valid() sanity check fails and results in a warning message to the console.
Add an additional check to skip the warning if the address of the error is in an SGX EPC page.
--- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
@@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags)return false; pfn =PHYS_PFN (physical_addr); -if (!pfn_valid (pfn)) { +if (!pfn_valid (pfn) && !arch_is_platform_page (physical_addr)) { pr_warn_ratelimited(FW_WARN GHES_PFX"Invalid address in generic error data: %#llx\n" , physical_addr);
Signature · 1 line
2.31.1
Tony Luck
reviewerv8 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckNow version 8
Note that [email protected] and [email protected] are still dropped from the distribution. Time to get some internal agreement on these changes before bothering the x86 maintainers with yet another version.
So I'm still looking for Acked-by: or Reviewed-by: on any bits of this series that are worthy, and comments on the problems I need to fix in the not-worthy parts.
Changes since v7
Parts 1 & 2: Added "Reviewed-by" tag from Jarkko (Thanks!!!)
Part 3: Jarkko had many good questions about the debugfs interface
that was included to display addresses of pages on the SGX poison list. I don't have good answers to them all. While this was a useful hook while I was testing these patches (check that all the thousands of SGX pages that into which I had injected errors showed up on the list) it isn't needed for basic recovery. So I dropped the debugfs bits from the patch. We can revisit later when there is a clear use case for what should be provided.
Parts 4-7: Unchanged.
Tony Luck (7):
x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook arch_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
.../firmware-guide/acpi/apei/einj.rst | 19 ++++ arch/x86/include/asm/processor.h | 8 ++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/main.c | 104 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 6 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 14 +++ mm/memory-failure.c | 19 +++- 9 files changed, 168 insertions(+), 11 deletions(-)
base-commit: 5816b3e6577eaa676ceb00a848f0fd65fe2adc29
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v8 1/7 x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit SGX_EPC_PAGE_IN_USE that is set when a page is allocated and cleared when the page is freed.
Notes:
1) These transitions are made while holding the node->lock so that future code that checks the flags while holding the node->lock can be sure that if the SGX_EPC_PAGE_IN_USE bit is set, then the page is on the free list.
2) Initially while the pages are on the dirty list the SGX_EPC_PAGE_IN_USE bit is set.
--- arch/x86/kernel/cpu/sgx/main.c | 4 +++- arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/main.c +3 -1
@@ -472,6 +472,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); sgx_nr_free_pages--; + page->flags =SGX_EPC_PAGE_IN_USE ;spin_unlock (&node->lock);
@@ -626,6 +627,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; + page->flags =0 ;spin_unlock (&node->lock); }
@@ -651,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; - section->pages[i].flags =0 ; + section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Allocated pages */ +#define SGX_EPC_PAGE_IN_USE BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v8 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
--- arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +9 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -650,6 +651,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -661,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v8 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
--- arch/x86/kernel/cpu/sgx/main.c | 14 +++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +13 -1
@@ -43,6 +43,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
@@ -62,6 +63,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +633,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =0 ;
@@ -658,6 +669,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };
Signature · 1 line
2.31.1
Re: [PATCH v8 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 12 lines · Tony Luck
A memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the
sgx_epc_pagethat can be set for ansgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pagesPoison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
Quoted 8 lines
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/main.c | 14 +++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-)
/Jarkko
Tony Luck
reviewerPATCH v8 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 77 ++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +77 -0
@@ -682,6 +682,83 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&sgx_epc_address_space, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If flags is zero, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->flags) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Re: [PATCH v8 4/7] x86/sgx: Add SGX infrastructure to recover from poison
Quoted 11 lines · Tony Luck
Provide a recovery function
sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.Poison found in a free page results in the page being moved from the free list to the poison page list.
Signed-off-by Tony Luck <[email protected]>
/Jarkko
Tony Luck
reviewerPATCH v8 5/7 x86/sgx: Hook arch_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to call the arch specific code to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 14 ++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 39 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +14 -0
@@ -3284,5 +3284,19 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v8 6/7 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !arch_is_platform_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v8 7/7 x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
In reply to Tony LuckSGX EPC pages do not have a "struct page" associated with them so the pfn_valid() sanity check fails and results in a warning message to the console.
Add an additional check to skip the warning if the address of the error is in an SGX EPC page.
--- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
@@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags)return false; pfn =PHYS_PFN (physical_addr); -if (!pfn_valid (pfn)) { +if (!pfn_valid (pfn) && !arch_is_platform_page (physical_addr)) { pr_warn_ratelimited(FW_WARN GHES_PFX"Invalid address in generic error data: %#llx\n" , physical_addr);
Signature · 1 line
2.31.1
Hi Tony,
Quoted 9 lines · Tony Luck
Now version 8
Note that [email protected] and [email protected] are still dropped from the distribution. Time to get some internal agreement on these changes before bothering the x86 maintainers with yet another version.
So I'm still looking for Acked-by: or Reviewed-by: on any bits of this series that are worthy, and comments on the problems I need to fix in the not-worthy parts.
Details of testing:
I was curious how the signaling worked after reading some snippets that a vDSO does not generate a signal. To help my understanding I created the test below in the SGX selftests that implements the test sequence you document in patch 6/7 and with it I can see how the SIGBUS is delivered:
[BEGIN TEST OUTPUT]
# RUN enclave.mce ...
MCE test from pid 2746 on addr 0x7fc879644000
Set up error injection on virt 0x7fc879644000 and press any key to continue test ...
# mce: Test terminated unexpectedly by signal 7
[END TEST OUTPUT]
Below is the test I ran. It only implements steps 3 to 7 from the test sequence you document in patch 6/7. It does still require manual intervention to determine the physical address and trigger the error injection on the physical address. It also currently treats the SIGBUS as a test failure, which I did to help clearly see the signal, but it could be changed to TEST_F_SIGNAL to have a SIGBUS mean success. The test is thus not appropriate for the SGX selftests in its current form but is provided as informational to describe the testing I did. It applies on top of the recent SGX selftest changes from: https://lore.kernel.org/lkml/[email protected]/
---8<---
tools/testing/selftests/sgx/defines.h | 7 +++++ tools/testing/selftests/sgx/main.c | 35 +++++++++++++++++++++ tools/testing/selftests/sgx/test_encl.c | 41 +++++++++++++++++++++++++ 3 files changed, 83 insertions(+)
tools/testing/selftests/sgx/defines.h +7 -0
@@ -24,6 +24,7 @@ enum encl_op_type {ENCL_OP_PUT_TO_ADDRESS ,ENCL_OP_GET_FROM_ADDRESS ,ENCL_OP_NOP , +ENCL_OP_MCE , ENCL_OP_MAX, };
@@ -53,4 +54,10 @@ struct encl_op_get_from_addr { uint64_t addr; }; +struct encl_op_mce { +struct encl_op_header header; +uint64_t addr; +uint64_t value; +uint64_t delay_cycles; +};#endif /* DEFINES_H */
tools/testing/selftests/sgx/main.c +35 -0
@@ -594,4 +594,39 @@ TEST_F(enclave, pte_permissions)EXPECT_EQ (self->run.exception_addr,0 ); } +TEST_F_TIMEOUT(enclave, mce, 600) +{ +struct encl_op_mce mce_op; +unsigned long data_start; + +ASSERT_TRUE (setup_test_encl (ENCL_HEAP_SIZE_DEFAULT , &self->encl, _metadata)); + +memset (&self->run,0 ,sizeof (self->run)); + self->run.tcs = self->encl.encl_base; + + data_start = self->encl.encl_base + +encl_get_data_offset (&self->encl) + +PAGE_SIZE ; + +printf ("MCE test from pid %d on addr 0x%lx\n" ,getpid (), data_start); +/* +* Sanity check to ensure it is possible to write to page that will +* have its permissions manipulated. +*/ + +printf ("Set up error injection on virt 0x%lx and press any key to continue test ...\n" , data_start); +getchar (); + mce_op.value =MAGIC ; + mce_op.addr = data_start; + mce_op.delay_cycles =600000000 ; + mce_op.header.type =ENCL_OP_MCE ; + +EXPECT_EQ (ENCL_CALL (&mce_op, &self->run, true),0 ); + +EXPECT_EEXIT (&self->run); +EXPECT_EQ (self->run.exception_vector,0 ); +EXPECT_EQ (self->run.exception_error_code,0 ); +EXPECT_EQ (self->run.exception_addr,0 ); +} +TEST_HARNESS_MAIN
tools/testing/selftests/sgx/test_encl.c +41 -0
65 lines not on this page · raw message
Tony Luck
reviewerv9 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckPosting latest version to a slightly wider audience.
The big picture is that SGX uses some memory pages that are walled off from access by the OS. This means they:
1) Don't have "struct page" describing them
2) Don't appear in the kernel 1:1 map
But they are still backed by normal DDR memory, so errors can occur.
Parts 1-4 of this series handle the internal SGX bits to keep track of these pages in an error context. They've had a fair amount of review on the linux-sgx list (but if any of the 37 subscribers to that list not named Jarkko or Reinette want to chime in with extra comments and {Acked,Reviewed,Tested}-by that would be great).
Linux-mm reviewers can (if they like) skip to part 5 where two changes are
made: 1) Hook into memory_failure() in the same spot as device mapping 2) Skip trying to change 1:1 map (since SGX pages aren't there).
The hooks have generic looking names rather than specifically saying "sgx" at the suggestion of Dave Hansen. I'm not wedded to the names, so better suggestions welcome. I could also change to using some "ARCH_HAS_PLATFORM_PAGES" config bits if that's the current fashion.
Rafael (and other ACPI list readers) can skip to parts 6 & 7 where there are hooks into error injection and reporting to simply say "these odd looking physical addresses are actually ok to use). I added some extra notes to the einj.rst documentation on how to inject into SGX memory.
Tony Luck (7):
x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook arch_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
.../firmware-guide/acpi/apei/einj.rst | 19 ++++ arch/x86/include/asm/processor.h | 8 ++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/main.c | 104 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 6 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 14 +++ mm/memory-failure.c | 19 +++- 9 files changed, 168 insertions(+), 11 deletions(-)
base-commit: 64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v9 1/7 x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit SGX_EPC_PAGE_IN_USE that is set when a page is allocated and cleared when the page is freed.
Notes:
1) These transitions are made while holding the node->lock so that future code that checks the flags while holding the node->lock can be sure that if the SGX_EPC_PAGE_IN_USE bit is set, then the page is on the free list.
2) Initially while the pages are on the dirty list the SGX_EPC_PAGE_IN_USE bit is set.
--- arch/x86/kernel/cpu/sgx/main.c | 4 +++- arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/main.c +3 -1
@@ -472,6 +472,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); sgx_nr_free_pages--; + page->flags =SGX_EPC_PAGE_IN_USE ;spin_unlock (&node->lock);
@@ -626,6 +627,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; + page->flags =0 ;spin_unlock (&node->lock); }
@@ -651,7 +653,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index; - section->pages[i].flags =0 ; + section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Allocated pages */ +#define SGX_EPC_PAGE_IN_USE BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Signature · 1 line
2.31.1
Re: [PATCH v9 1/7] x86/sgx: Add new sgx_epc_page flag bit to mark in-use pages
Quoted 15 lines · Tony Luck
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\ ^ | \-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit
SGX_EPC_PAGE_IN_USEthat is set when a page is allocated and cleared when the page is freed.Notes:
Quoted 7 lines
1) These transitions are made while holding the
node->lockso that future code that checks the flags while holding thenode->lockcan be sure that if theSGX_EPC_PAGE_IN_USEbit is set, then the page is on the free list.2) Initially while the pages are on the dirty list the
SGX_EPC_PAGE_IN_USEbit is set.
This needs to state _why_ pages are marked as IN_USE from the get-go. Ignoring the "Notes", the whole changelog clearly states the the DIRTY state does _not_ require special handling, but then "Add SGX infrastructure to recover from poison" goes and relies on it being set.
Alternatively, why not invert it and have SGX_EPC_PAGE_FREE? That would have clear semantics, the poison recovery code wouldn't have to assume that !flags means "free", and the whole changelog becomes:
Add a flag to explicitly track whether or not an EPC page is on a free list, memory failure recovery code needs to be able to detect if a poisoned page is free so that recovery can know if it's safe to "steal" the page.
Tony Luck
reviewerPATCH v9 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
--- arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +9 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -650,6 +651,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -661,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
kernel test robot
build botRe: [PATCH v9 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
I love your patch! Yet something to improve:
Hi Tony,
I love your patch! Yet something to improve:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on hnaz-mm/master tip/x86/sgx v5.15-rc6 next-20211021] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tony-Luck/x86-sgx-Add-new-sgx_epc_page-flag-bit-to-mark-in-use-pages/20211012-035926 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: x86_64-randconfig-a011-20211011 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9c7bd2907252bfbf4948be9855e3535319e1e9e4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Tony-Luck/x86-sgx-Add-new-sgx_epc_page-flag-bit-to-mark-in-use-pages/20211012-035926 git checkout 9c7bd2907252bfbf4948be9855e3535319e1e9e4 # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
ld: arch/x86/kernel/cpu/sgx/main.o: in function `sgx_setup_epc_section':
>> arch/x86/kernel/cpu/sgx/main.c:654: undefined reference to `xa_store_range'
vim +654 arch/x86/kernel/cpu/sgx/main.c
635
636 static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,
637 unsigned long index,
638 struct sgx_epc_section *section)
639 {
640 unsigned long nr_pages = size >> PAGE_SHIFT;
641 unsigned long i;
642
643 section->virt_addr = memremap(phys_addr, size, MEMREMAP_WB);
644 if (!section->virt_addr)
645 return false;
646
647 section->pages = vmalloc(nr_pages * sizeof(struct sgx_epc_page));
648 if (!section->pages) {
649 memunmap(section->virt_addr);
650 return false;
651 }
652
653 section->phys_addr = phys_addr;
> 654 xa_store_range(&sgx_epc_address_space, section->phys_addr,
655 phys_addr + size - 1, section, GFP_KERNEL);
656
657 for (i = 0; i < nr_pages; i++) {
658 section->pages[i].section = index;
659 section->pages[i].flags = SGX_EPC_PAGE_IN_USE;
660 section->pages[i].owner = NULL;
661 list_add_tail(§ion->pages[i].list, &sgx_dirty_page_list);
662 }
663
664 return true;
665 }
666
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Tony Luck
reviewerPATCH v9 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
--- arch/x86/kernel/cpu/sgx/main.c | 14 +++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +13 -1
@@ -43,6 +43,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
@@ -62,6 +63,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +633,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =0 ;
@@ -658,6 +669,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
arch/x86/kernel/cpu/sgx/sgx.h +2 -1
@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };
Signature · 1 line
2.31.1
Re: [PATCH v9 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 11 lines · Tony Luck
A memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the
sgx_epc_pagethat can be set for ansgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pagesPoison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
Explain why atomic would be needed. I lived in this code for a few years and still had to look at the source to remember that the reclaimer can set flags without taking node->lock.
Quoted 24 lines
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Reviewed-by Jarkko Sakkinen <[email protected]>Tested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/main.c | 14 +++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-)arch/x86/kernel/cpu/sgx/main.c +1
-0@@ -43,6 +43,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed
arch/x86/kernel/cpu/sgx/main.c static void __sgx_sanitize_pages(struct list_head *dirty_page_list) · line 66
Quoted 4 lines
arch/x86/kernel/cpu/sgx/main.c +1
-0@@ -62,6 +63,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) {
Does this need READ_ONCE (and WRITE_ONCE in the writer) to prevent reloading page->poison since the sanitizer doesn't hold node->lock, i.e. page->poison can be set any time? Honest question, I'm terrible with memory ordering rules...
arch/x86/kernel/cpu/sgx/main.c static void __sgx_sanitize_pages(struct list_head *dirty_page_list) · line 68
Quoted 2 lines
arch/x86/kernel/cpu/sgx/main.c +2
-0+list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list);
list_move()
Quoted 7 lines
arch/x86/kernel/cpu/sgx/main.c +3
-0+continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
arch/x86/kernel/cpu/sgx/main.c void sgx_free_epc_page(struct sgx_epc_page *page) · line 638
Quoted 7 lines
arch/x86/kernel/cpu/sgx/main.c +3
-1@@ -626,7 +633,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &sgx_poison_page_list);
sgx_poison_page_list is a global list, whereas node->lock is, well, per node. On a system with multiple EPCs, this could corrupt sgx_poison_page_list if multiple poisoned pages from different nodes are freed simultaneously.
Quoted 31 lines
arch/x86/kernel/cpu/sgx/main.c +3
-0+else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =0 ;@@ -658,6 +669,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =SGX_EPC_PAGE_IN_USE ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }arch/x86/kernel/cpu/sgx/sgx.h +2
-1@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };Signature · 2 lines
-- 2.31.1
Luck, Tony
reviewerRe: [PATCH v9 3/7] x86/sgx: Initial poison handling for dirty and free pages
Quoted 9 lines · Sean Christopherson
Quoted 8 lines · Tony Luck
A memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the
sgx_epc_pagethat can be set for ansgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Quoted 7 lines
Quoted 3 lines
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags.
Explain why atomic would be needed. I lived in this code for a few years and still had to look at the source to remember that the reclaimer can set flags without taking
node->lock.
Will add explanation.
Quoted 26 lines
Quoted 26 lines
In both cases place the poisoned page on a list of poisoned epc pages to make sure it will not be reallocated.
Reviewed-by Jarkko Sakkinen <[email protected]>Tested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>--- arch/x86/kernel/cpu/sgx/main.c | 14 +++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-)arch/x86/kernel/cpu/sgx/main.c +1
-0@@ -43,6 +43,7 @@ static nodemask_t sgx_numa_mask;static struct sgx_numa_node *sgx_numa_nodes;static LIST_HEAD (sgx_dirty_page_list); +static LIST_HEAD (sgx_poison_page_list);/* * Reset post-kexec EPC pages to the uninitialized state. The pages are removed @@ -62,6 +63,12 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list)
Quoted 8 lines
arch/x86/kernel/cpu/sgx/main.c static void __sgx_sanitize_pages(struct list_head *dirty_page_list) · line 66
Quoted 3 lines
arch/x86/kernel/cpu/sgx/main.c +1
-0page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +if (page->poison) {Does this need
READ_ONCE(andWRITE_ONCEin the writer) to prevent reloadingpage->poisonsince the sanitizer doesn't holdnode->lock, i.e.page->poisoncan be set any time? Honest question, I'm terrible with memory ordering rules...
I think it's safe. I set page->poison in arch_memory_failure() while holding node->lock in kthread context. So not "at any time".
This particular read is done without holding the lock ... and is thus racy. But there are a zillion other races early in boot before the EPC pages get sanitized and moved to the free list. E.g. if an error is reported before they are added to the sgx_epc_address_space xarray, then all this code will just ignore the error as "not in Linux controlled memory".
-Tony
Tony Luck
reviewerPATCH v9 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 77 ++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +77 -0
@@ -682,6 +682,83 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&sgx_epc_address_space, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If flags is zero, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->flags) { +list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Re: [PATCH v9 4/7] x86/sgx: Add SGX infrastructure to recover from poison
Quoted 6 lines · Tony Luck
arch/x86/kernel/cpu/sgx/main.c +6
-0+ section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */
arch/x86/kernel/cpu/sgx/main.c bool arch_is_platform_page(u64 paddr) · line 742
Quoted 10 lines
arch/x86/kernel/cpu/sgx/main.c +10
-0+if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If flags is zero, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->flags) {
If the flag is inverted, this becomes
if (page->flags & SGX_EPC_PAGE_FREE) {arch/x86/kernel/cpu/sgx/main.c bool arch_is_platform_page(u64 paddr) · line 744
Quoted 2 lines
arch/x86/kernel/cpu/sgx/main.c +2
-0+list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list);
list_move(), and needs the same protection for sgx_poison_page_list.
Quoted 24 lines
arch/x86/kernel/cpu/sgx/main.c +17
-0+ goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the Signature · 2 lines
-- 2.31.1
Luck, Tony
reviewerRe: [PATCH v9 4/7] x86/sgx: Add SGX infrastructure to recover from poison
Quoted 20 lines · Sean Christopherson
Quoted 6 lines · Tony Luck
arch/x86/kernel/cpu/sgx/main.c +6
-0+ section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ arch/x86/kernel/cpu/sgx/main.c bool arch_is_platform_page(u64 paddr) · line 742
Quoted 10 lines
arch/x86/kernel/cpu/sgx/main.c +10
-0+if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If flags is zero, then the page is on a free list. +* Move it to the poison page list. +*/ +if (!page->flags) {If the flag is inverted, this becomes
Quoted 1 line
if (page->flags & SGX_EPC_PAGE_FREE) {I like the inversion. I'll switch to SGX_EPC_PAGE_FREE
Quoted 5 lines
arch/x86/kernel/cpu/sgx/main.c bool arch_is_platform_page(u64 paddr) · line 744
Quoted 3 lines
arch/x86/kernel/cpu/sgx/main.c +2
-0+list_del (&page->list); +list_add (&page->list, &sgx_poison_page_list);
list_move(), and needs the same protection forsgx_poison_page_list.
Didn't know list_move() existed. Will change all the lis_del+list_add into list_move.
Also change the sgx_poison_page_list from global to per-node. Then the adds will be safe (accessed while holding the node->lock).
Thanks for the review.
-Tony
Tony Luck
reviewerPATCH v9 5/7 x86/sgx: Hook arch_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to call the arch specific code to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 14 ++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 39 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +14 -0
@@ -3284,5 +3284,19 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.31.1
Re: [PATCH v9 5/7] x86/sgx: Hook arch_memory_failure() into mainline code
Quoted 115 lines · Tony Luck
Add a call inside
memory_failure()to call the arch specific code to check if the address is an SGX EPC page and handle it.Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make
set_mce_nospec()skip SGX pages when trying to adjust the 1:1 map.Tested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>---
arch/x86/include/asm/processor.h | 8 ++++++++arch/x86/include/asm/set_memory.h| 4 ++++ include/linux/mm.h | 14 ++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------4 files changed, 39 insertions(+), 6 deletions(-)arch/x86/include/asm/processor.h +0
-0@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, };arch/x86/include/asm/processor.h +8
-0+#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /*
_ASM_X86_PROCESSOR_H*/arch/x86/include/asm/set_memory.h +0
-0@@ -2,6 +2,7 @@ #ifndef _ASM_X86_SET_MEMORY_H #define _ASM_X86_SET_MEMORY_H
+#include <linux/mm.h>
#include <asm/page.h>
#include <asm-generic/set_memory.h>arch/x86/include/asm/set_memory.h +0
-0@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap) unsigned long decoy_addr; int rc;
+ /* SGX pages are not in the 1:1 map */
+ if (arch_is_platform_page(pfn << PAGE_SHIFT))
+ return 0;
/*
* We would like to just call:
*set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);include/linux/mm.h +0
-0@@ -3284,5 +3284,19 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma) return 0; }include/linux/mm.h +14
-0+#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ + return -ENXIO; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ + return false; +} +#endif +#endif /*
__KERNEL__*/
#endif /*_LINUX_MM_H*/mm/memory-failure.c +0
-0@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags) if (!sysctl_memory_failure_recovery) panic("Memory failure on page %lx", pfn);
+ mutex_lock(&mf_mutex);
+
p =pfn_to_online_page(pfn);
if (!p) {
+ res =arch_memory_failure(pfn, flags);
+ if (res == 0)
+ gotounlock_mutex;
+
if (pfn_valid(pfn)) {
pgmap =get_dev_pagemap(pfn, NULL);
- if (pgmap)
- return memory_failure_dev_pagemap(pfn, flags, - pgmap); + if (pgmap) {
+ res = memory_failure_dev_pagemap(pfn, flags, + pgmap); + gotounlock_mutex;
+ }
}
pr_err("Memory failure: %#lx: memory outside kernel control\n", pfn);
- return-ENXIO;
+ res =-ENXIO;
Quoted 8 lines
+ goto
unlock_mutex;
}
- mutex_lock(&mf_mutex);
-
try_again:
if (PageHuge(p)) {
res =memory_failure_hugetlb(pfn, flags);
/Jarkko
Tony Luck
reviewerPATCH v9 6/7 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !arch_is_platform_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.31.1
Re: [PATCH v9 6/7] x86/sgx: Add hook to error injection address validation
Quoted 51 lines · Tony Luck
SGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
Tested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>---
.../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++-2 files changed, 21 insertions(+), 1 deletion(-)Documentation/firmware-guide/acpi/apei/einj.rst +0
-0@@ -181,5 +181,24 @@ You should see something like this in dmesg::[22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0channel_mask:1 rank:0)
Documentation/firmware-guide/acpi/apei/einj.rst +19
-0+Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error +For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +0
-0@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects(base_addr, size, IORESOURCE_SYSTEM_RAM, IORES_DESC_NONE)
Quoted 8 lines
!=
REGION_INTERSECTS) && (region_intersects(base_addr, size, IORESOURCE_MEM, IORES_DESC_PERSISTENT_MEMORY)- !=REGION_INTERSECTS)))
+ !=REGION_INTERSECTS) &&
+ !arch_is_platform_page(base_addr)))
return-EINVAL;
inject:
/Jarkko
Tony Luck
reviewerPATCH v9 7/7 x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
In reply to Tony LuckSGX EPC pages do not have a "struct page" associated with them so the pfn_valid() sanity check fails and results in a warning message to the console.
Add an additional check to skip the warning if the address of the error is in an SGX EPC page.
--- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
@@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags)return false; pfn =PHYS_PFN (physical_addr); -if (!pfn_valid (pfn)) { +if (!pfn_valid (pfn) && !arch_is_platform_page (physical_addr)) { pr_warn_ratelimited(FW_WARN GHES_PFX"Invalid address in generic error data: %#llx\n" , physical_addr);
Signature · 1 line
2.31.1
Re: [PATCH v9 7/7] x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
Quoted 19 lines · Tony Luck
SGX EPC pages do not have a "struct page" associated with them so the
pfn_valid()sanity check fails and results in a warning message to the console.Add an additional check to skip the warning if the address of the error is in an SGX EPC page.
Tested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>---
drivers/acpi/apei/ghes.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/apei/ghes.c +0
-0@@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags) return false;
Quoted 7 lines
pfn =PHYS_PFN(physical_addr);
- if (!pfn_valid(pfn)) {
+ if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {pr_warn_ratelimited(FW_WARN GHES_PFX "Invalid address in generic error data: %#llx\n", physical_addr);
/Jarkko
Jarkko Sakkinen
maintainerQuoted 47 lines · Tony Luck
Posting latest version to a slightly wider audience.
The big picture is that SGX uses some memory pages that are walled off from access by the OS. This means they:
1) Don't have "struct page" describing them
2) Don't appear in the kernel 1:1 mapBut they are still backed by normal DDR memory, so errors can occur.
Parts 1-4 of this series handle the internal SGX bits to keep track of these pages in an error context. They've had a fair amount of review on the linux-sgx list (but if any of the 37 subscribers to that list not named Jarkko or Reinette want to chime in with extra comments and {Acked,Reviewed,Tested}-by that would be great).
Linux-mm reviewers can (if they like) skip to part 5 where two changes are
made: 1) Hook intomemory_failure()in the same spot as device mapping 2) Skip trying to change 1:1 map (since SGX pages aren't there).The hooks have generic looking names rather than specifically saying "sgx" at the suggestion of Dave Hansen. I'm not wedded to the names, so better suggestions welcome. I could also change to using some "
ARCH_HAS_PLATFORM_PAGES" config bits if that's the current fashion.Rafael (and other ACPI list readers) can skip to parts 6 & 7 where there are hooks into error injection and reporting to simply say "these odd looking physical addresses are actually ok to use). I added some extra notes to the
einj.rstdocumentation on how to inject into SGX memory.Tony Luck (7):
x86/sgx: Add newsgx_epc_pageflag bit to mark in-use pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hookarch_memory_failure()into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages toghes_do_memory_failure().../firmware-guide/acpi/apei/einj.rst | 19 ++++ arch/x86/include/asm/processor.h | 8 ++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/main.c | 104 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 6 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 14 +++ mm/memory-failure.c | 19 +++-
Quoted 4 lines
9 files changed, 168 insertions(+), 11 deletions(-)base-commit:
64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
I think you instructed me on this before but I've forgot it:
how do I simulate this and test how it works?
/Jarkko
Luck, Tony
reviewerQuoted 2 lines
I think you instructed me on this before but I've forgot it:
how do I simulate this and test how it works?
Jarkko,
You can test the non-execution paths (e.g. where the memory error is reported by a patrol scrubber in the memory controller) by:
# echo 0x{some_SGX_EPC_ADDRESS} > /sys/devices/system/memory/hard_offline_pageThe execution paths are more difficult. You need a system that can inject errors into EPC memory. There are some hints in the Documenation changes in part 0006.
Reinette posted some changes to sgx tests that she used to validate.
-Tony
Tony Luck
reviewerv10 cover Basic recovery for machine checks inside SGX
In reply to Tony Luckv10 (based on v5.15-rc6)
Changes since v9:
ACPI reviewers (Rafael): No changes to parts 6 & 7.
MM reviewers (Horiguchi-san): No changes to part 5.
Jarkko:
Added Reviewed-by tags to remaining patches. N.B. I kept the tags on parts 1, 3, 4 because changes based on Sean feedback didn't seem consequential. Please let me know if you disagree and see new problems introduced by me trying to follow Sean's feedback.
Sean:
1) Reverse the polarity of the neutron flow (sorry, Dr Who fan will always autocomplete a sentence that begins "reverse the polarity" that way.) Actual change is for the new flag bit. Instead of marking in-use pages with the new bit, mark free pages instead. This avoids the weirdness where I marked the pages on the dirty list as "in-use", when clearly they are not.
2) Race conditions adding poisoned pages to the global list of poisoned pages.
Fixed this by changing from a global list to a per-node list. Additions are protected by the node->lock.
3) Use list_move() instead of list_del(); list_add() Fixed both places I used this idiom.
4) Race looking at page->poison when cleaning dirty pages. Added a comment documenting why losing this race isn't overly harmful.
Tony Luck (7):
x86/sgx: Add new sgx_epc_page flag bit to mark free pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook arch_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/include/asm/processor.h | 8 ++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/main.c | 113 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 7 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 14 +++ mm/memory-failure.c | 19 ++- 9 files changed, 179 insertions(+), 10 deletions(-)
base-commit: 519d81956ee277b4419c723adfb154603c2565ba
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v10 1/7 x86/sgx: Add new sgx_epc_page flag bit to mark free pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit SGX_EPC_PAGE_IS_FREE that is set when a page is added to a free list and cleared when the page is allocated.
Notes:
1) These transitions are made while holding the node->lock so that future code that checks the flags while holding the node->lock can be sure that if the SGX_EPC_PAGE_IS_FREE bit is set, then the page is on the free list.
2) Initially while the pages are on the dirty list the SGX_EPC_PAGE_IS_FREE bit is cleared.
--- arch/x86/kernel/cpu/sgx/main.c | 2 ++ arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 5 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +2 -0
@@ -472,6 +472,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); sgx_nr_free_pages--; + page->flags =0 ;spin_unlock (&node->lock);
@@ -626,6 +627,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; + page->flags =SGX_EPC_PAGE_IS_FREE ;spin_unlock (&node->lock); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Pages on free list */ +#define SGX_EPC_PAGE_IS_FREE BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v10 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
--- arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +9 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -650,6 +651,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -661,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
kernel test robot
build botRe: [PATCH v10 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages
I love your patch! Yet something to improve:
Hi Tony,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/x86/sgx]
[also build test ERROR on rafael-pm/linux-next hnaz-mm/master v5.16-rc1 next-20211118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tony-Luck/x86-sgx-Add-new-sgx_epc_page-flag-bit-to-mark-free-pages/20211019-052547 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 71eba1c0939e3b1ad1b71fe0171de30e265437e3 config: x86_64-randconfig-r001-20211025 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a461fa64bb37cffd73f683c74f6b0780379fc2ca)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bb9a962c5c9e30df5df1546cf8843b3ba3f1476a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tony-Luck/x86-sgx-Add-new-sgx_epc_page-flag-bit-to-mark-free-pages/20211019-052547 git checkout bb9a962c5c9e30df5df1546cf8843b3ba3f1476a
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: xa_store_range >>> referenced by main.c:654 (arch/x86/kernel/cpu/sgx/main.c:654) >>> kernel/cpu/sgx/main.o:(sgx_setup_epc_section) in archive arch/x86/built-in.a
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Tony Luck
reviewerPATCH v10 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags (Currently just sgx_reclaimer_lock which protects the SGX_EPC_PAGE_RECLAIMER_TRACKED bit in page->flags).
In both cases place the poisoned page on a per-node list of poisoned epc pages to make sure it will not be reallocated.
--- arch/x86/kernel/cpu/sgx/main.c | 26 +++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 4 +++- 2 files changed, 28 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +25 -1
@@ -62,6 +62,24 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +/* +* Checking page->poison without holding the node->lock +* is racy, but losing the race (i.e. poison is set just +* after the check) just means __eremove() will be uselessly +* called for a page that sgx_free_epc_page() will put onto +* the node->sgx_poison_page_list later. +*/ +if (page->poison) { +struct sgx_epc_section *section = &sgx_epc_sections[page->section]; +struct sgx_numa_node *node = section->node; + +spin_lock (&node->lock); +list_move (&page->list, &node->sgx_poison_page_list); +spin_unlock (&node->lock); + +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +644,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &node->sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =SGX_EPC_PAGE_IS_FREE ;
@@ -658,6 +680,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =0 ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
@@ -724,6 +747,7 @@ static bool __init sgx_page_cache_init(void)if (!node_isset (nid, sgx_numa_mask)) {spin_lock_init (&sgx_numa_nodes[nid].lock);INIT_LIST_HEAD (&sgx_numa_nodes[nid].free_page_list); +INIT_LIST_HEAD (&sgx_numa_nodes[nid].sgx_poison_page_list);node_set (nid, sgx_numa_mask); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -1
@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };
@@ -42,6 +43,7 @@ struct sgx_epc_page {*/ struct sgx_numa_node {struct list_head free_page_list; +struct list_head sgx_poison_page_list;spinlock_t lock; };
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v10 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the per-node poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 76 ++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +76 -0
@@ -693,6 +693,82 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&sgx_epc_address_space, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If the page is on a free list, move it to the per-node +* poison page list. +*/ +if (page->flags &SGX_EPC_PAGE_IS_FREE ) { +list_move (&page->list, &node->sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v10 5/7 x86/sgx: Hook arch_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to call the arch specific code to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 14 ++++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 39 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +14 -0
@@ -3284,5 +3284,19 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.31.1
Re: [PATCH v10 5/7] x86/sgx: Hook arch_memory_failure() into mainline code
Quoted 16 lines · Tony Luck
Add a call inside
memory_failure()to call the arch specific code to check if the address is an SGX EPC page and handle it.Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make
set_mce_nospec()skip SGX pages when trying to adjust the 1:1 map.Reviewed-by Jarkko Sakkinen <[email protected]>Tested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>---
...
Quoted 12 lines
include/linux/mm.h +4
-0@@ -3284,5 +3284,19 @@ static inline int seal_check_future_write(int seals, struct vm_area_struct *vma)return 0 ; } +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ;
include/linux/mm.h static inline int seal_check_future_write(int seals, struct vm_area_struct *vma) · line 3300
Quoted 10 lines
include/linux/mm.h +10
-0+} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif +
How about putting these definitions near the other related functions in the same file (like below)?
...
extern void shake_page(struct page *p);
extern atomic_long_t num_poisoned_pages __read_mostly; extern int soft_offline_page(unsigned long pfn, int flags);
// here?
/*
* Error handlers for various types of pages.
*/
enum mf_result {
Otherwise, the patch looks good to me.
Thanks,
Naoya Horiguchi
Luck, Tony
reviewerRE: [PATCH v10 5/7] x86/sgx: Hook arch_memory_failure() into mainline code
Quoted 9 lines
How about putting these definitions near the other related functions in the same file (like below)?
...
extern voidshake_page(struct page *p);
externatomic_long_tnum_poisoned_pages__read_mostly; extern intsoft_offline_page(unsigned long pfn, int flags);// here?
Makes sense to group together with these other RAS bits. I'll move the definitions here.
Quoted 3 lines
Otherwise, the patch looks good to me.
Reviewed-by Naoya Horiguchi <[email protected]>
Thanks for the review!
-Tony
Tony Luck
reviewerPATCH v10 6/7 x86/sgx: Add hook to error injection address validation
In reply to Tony LuckSGX reserved memory does not appear in the standard address maps.
Add hook to call into the SGX code to check if an address is located in SGX memory.
There are other challenges in injecting errors into SGX. Update the documentation with a sequence of operations to inject.
--- .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++ drivers/acpi/apei/einj.c | 3 ++- 2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/firmware-guide/acpi/apei/einj.rst +19 -0
@@ -181,5 +181,24 @@ You should see something like this in dmesg:: [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0 [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) +Special notes for injection into SGX enclaves: + +There may be a separate BIOS setup option to enable SGX injection. + +The injection process consists of setting some special memory controller +trigger that will inject the error on the next write to the target +address. But the h/w prevents any software outside of an SGX enclave +from accessing enclave pages (even BIOS SMM mode). + +The following sequence can be used: + 1) Determine physical address of enclave page + 2) Use "notrigger=1" mode to inject (this will setup + the injection address, but will not actually inject) + 3) Enter the enclave + 4) Store data to the virtual address matching physical address from step 1 + 5) Execute CLFLUSH for that virtual address + 6) Spin delay for 250ms + 7) Read from the virtual address. This will trigger the error + For more information about EINJ, please refer to ACPI specification version 4.0, section 17.5 and ACPI 5.0, section 18.6.
drivers/acpi/apei/einj.c +2 -1
@@ -544,7 +544,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, ((region_intersects (base_addr, size,IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) !=REGION_INTERSECTS ) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) - != REGION_INTERSECTS))) + !=REGION_INTERSECTS ) && + !arch_is_platform_page(base_addr))) return -EINVAL; inject:
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v10 7/7 x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
In reply to Tony LuckSGX EPC pages do not have a "struct page" associated with them so the pfn_valid() sanity check fails and results in a warning message to the console.
Add an additional check to skip the warning if the address of the error is in an SGX EPC page.
--- drivers/acpi/apei/ghes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
@@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags)return false; pfn =PHYS_PFN (physical_addr); -if (!pfn_valid (pfn)) { +if (!pfn_valid (pfn) && !arch_is_platform_page (physical_addr)) { pr_warn_ratelimited(FW_WARN GHES_PFX"Invalid address in generic error data: %#llx\n" , physical_addr);
Signature · 1 line
2.31.1
Tony Luck
reviewerv11 cover Basic recovery for machine checks inside SGX
In reply to Tony LuckBoris,
I took this series out of lkml/x86 for a few revisions, I think the last one posted to lkml was v5. So much has changed since then that it might be easier to just look at this as if it were v1 and ignore the earlier history.
First four patches add infrastructure within the SGX code to track enclave pages (because these pages don't have a "struct page" as they aren't directly accessible by Linux). All have "Reviewed-by" tags from Jarkko (SGX maintainer).
Patch 5 hooks into memory_failure() to invoke recovery if the physical address is in enclave space. This has a "Reviewed-by" tag from Naoya Horiguchi the maintainer for mm/memory-failure.c
Patch 6 is a hook into the error injection code and addition to the error injection documentation explaining extra steps needed to inject into SGX enclave memory.
Patch 7 is a hook into GHES error reporting path to recognize that SGX enclave addresses are valid and need processing.
-Tony
Tony Luck (7):
x86/sgx: Add new sgx_epc_page flag bit to mark free pages x86/sgx: Add infrastructure to identify SGX EPC pages x86/sgx: Initial poison handling for dirty and free pages x86/sgx: Add SGX infrastructure to recover from poison x86/sgx: Hook arch_memory_failure() into mainline code x86/sgx: Add hook to error injection address validation x86/sgx: Add check for SGX pages to ghes_do_memory_failure()
.../firmware-guide/acpi/apei/einj.rst | 19 +++ arch/x86/Kconfig | 1 + arch/x86/include/asm/processor.h | 8 ++ arch/x86/include/asm/set_memory.h | 4 + arch/x86/kernel/cpu/sgx/main.c | 113 +++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 7 +- drivers/acpi/apei/einj.c | 3 +- drivers/acpi/apei/ghes.c | 2 +- include/linux/mm.h | 13 ++ mm/memory-failure.c | 19 ++- 10 files changed, 179 insertions(+), 10 deletions(-)
base-commit: 3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
Signature · 1 line
2.31.1
Tony Luck
reviewerPATCH v11 1/7 x86/sgx: Add new sgx_epc_page flag bit to mark free pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit SGX_EPC_PAGE_IS_FREE that is set when a page is added to a free list and cleared when the page is allocated.
Notes:
1) These transitions are made while holding the node->lock so that future code that checks the flags while holding the node->lock can be sure that if the SGX_EPC_PAGE_IS_FREE bit is set, then the page is on the free list.
2) Initially while the pages are on the dirty list the SGX_EPC_PAGE_IS_FREE bit is cleared.
--- arch/x86/kernel/cpu/sgx/main.c | 2 ++ arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 5 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +2 -0
@@ -472,6 +472,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); sgx_nr_free_pages--; + page->flags =0 ;spin_unlock (&node->lock);
@@ -626,6 +627,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; + page->flags =SGX_EPC_PAGE_IS_FREE ;spin_unlock (&node->lock); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Pages on free list */ +#define SGX_EPC_PAGE_IS_FREE BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Signature · 1 line
2.31.1
[tip: x86/sgx] x86/sgx: Add new sgx_epc_page flag bit to mark free pages
The following commit has been merged into the x86/sgx branch of tip:
The following commit has been merged into the x86/sgx branch of tip:
Commit-ID: d6d261bded8a57aed4faa12d08a5b193418d3aa4 Gitweb: https://git.kernel.org/tip/d6d261bded8a57aed4faa12d08a5b193418d3aa4 Author: Tony Luck <[email protected]> AuthorDate: Tue, 26 Oct 2021 15:00:44 -07:00 Committer: Dave Hansen <[email protected]> CommitterDate: Mon, 15 Nov 2021 11:13:16 -08:00
x86/sgx: Add new sgx_epc_page flag bit to mark free pages
SGX EPC pages go through the following life cycle:
DIRTY ---> FREE ---> IN-USE --\
^ |
\-----------------/Recovery action for poison for a DIRTY or FREE page is simple. Just make sure never to allocate the page. IN-USE pages need some extra handling.
Add a new flag bit SGX_EPC_PAGE_IS_FREE that is set when a page is added to a free list and cleared when the page is allocated.
Notes:
1) These transitions are made while holding the node->lock so that future code that checks the flags while holding the node->lock can be sure that if the SGX_EPC_PAGE_IS_FREE bit is set, then the page is on the free list.
2) Initially while the pages are on the dirty list the SGX_EPC_PAGE_IS_FREE bit is cleared.
--- arch/x86/kernel/cpu/sgx/main.c | 2 ++ arch/x86/kernel/cpu/sgx/sgx.h | 3 +++ 2 files changed, 5 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +2 -0
@@ -472,6 +472,7 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid) page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);list_del_init (&page->list); sgx_nr_free_pages--; + page->flags =0 ;spin_unlock (&node->lock);
@@ -626,6 +627,7 @@ void sgx_free_epc_page(struct sgx_epc_page *page)list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; + page->flags =SGX_EPC_PAGE_IS_FREE ;spin_unlock (&node->lock); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -0
@@ -26,6 +26,9 @@/* Pages, which are being tracked by the page reclaimer. */ #define SGX_EPC_PAGE_RECLAIMER_TRACKED BIT(0) +/* Pages on free list */ +#define SGX_EPC_PAGE_IS_FREE BIT(1) +struct sgx_epc_page {unsigned int section;unsigned int flags;
Tony Luck
reviewerPATCH v11 2/7 x86/sgx: Add infrastructure to identify SGX EPC pages
In reply to Tony LuckX86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray. N.B. adds CONFIG_XARRAY_MULTI to the SGX dependecies. So "select" that in arch/x86/Kconfig for X86/SGX.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
--- arch/x86/Kconfig | 1 + arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 2 files changed, 10 insertions(+)
arch/x86/Kconfig +1 -0
@@ -1902,6 +1902,7 @@ config X86_SGX select SRCU select MMU_NOTIFIER select NUMA_KEEP_MEMINFO if NUMA + select XARRAY_MULTI help Intel(R) Software Guard eXtensions (SGX) is a set of CPU instructions that can be used by applications to set aside private regions of code
arch/x86/kernel/cpu/sgx/main.c +9 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -650,6 +651,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -661,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
[tip: x86/sgx] x86/sgx: Add infrastructure to identify SGX EPC pages
The following commit has been merged into the x86/sgx branch of tip:
The following commit has been merged into the x86/sgx branch of tip:
Commit-ID: 40e0e7843e23d164625b9031514f5672f8758bf4 Gitweb: https://git.kernel.org/tip/40e0e7843e23d164625b9031514f5672f8758bf4 Author: Tony Luck <[email protected]> AuthorDate: Tue, 26 Oct 2021 15:00:45 -07:00 Committer: Dave Hansen <[email protected]> CommitterDate: Mon, 15 Nov 2021 11:13:16 -08:00
x86/sgx: Add infrastructure to identify SGX EPC pages
X86 machine check architecture reports a physical address when there is a memory error. Handling that error requires a method to determine whether the physical address reported is in any of the areas reserved for EPC pages by BIOS.
SGX EPC pages do not have Linux "struct page" associated with them.
Keep track of the mapping from ranges of EPC pages to the sections that contain them using an xarray. N.B. adds CONFIG_XARRAY_MULTI to the SGX dependecies. So "select" that in arch/x86/Kconfig for X86/SGX.
Create a function arch_is_platform_page() that simply reports whether an address is an EPC page for use elsewhere in the kernel. The ACPI error injection code needs this function and is typically built as a module, so export it.
Note that arch_is_platform_page() will be slower than other similar "what type is this page" functions that can simply check bits in the "struct page". If there is some future performance critical user of this function it may need to be implemented in a more efficient way.
Note also that the current implementation of xarray allocates a few hundred kilobytes for this usage on a system with 4GB of SGX EPC memory configured. This isn't ideal, but worth it for the code simplicity.
--- arch/x86/Kconfig | 1 + arch/x86/kernel/cpu/sgx/main.c | 9 +++++++++ 2 files changed, 10 insertions(+)
arch/x86/Kconfig +1 -0
@@ -1917,6 +1917,7 @@ config X86_SGX select SRCU select MMU_NOTIFIER select NUMA_KEEP_MEMINFO if NUMA + select XARRAY_MULTI help Intel(R) Software Guard eXtensions (SGX) is a set of CPU instructions that can be used by applications to set aside private regions of code
arch/x86/kernel/cpu/sgx/main.c +9 -0
@@ -20,6 +20,7 @@ struct sgx_epc_section sgx_epc_sections[SGX_MAX_EPC_SECTIONS];static int sgx_nr_epc_sections;static struct task_struct *ksgxd_tsk;static DECLARE_WAIT_QUEUE_HEAD (ksgxd_waitq); +static DEFINE_XARRAY (sgx_epc_address_space);/* * These variables are part of the state of the reclaimer, and must be accessed
@@ -650,6 +651,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, } section->phys_addr = phys_addr; +xa_store_range (&sgx_epc_address_space, section->phys_addr, + phys_addr + size -1 , section,GFP_KERNEL );for (i =0 ; i < nr_pages; i++) { section->pages[i].section = index;
@@ -661,6 +664,12 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,return true; } +bool arch_is_platform_page (u64 paddr) +{ +return !!xa_load (&sgx_epc_address_space, paddr); +} +EXPORT_SYMBOL_GPL (arch_is_platform_page); +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Tony Luck
reviewerPATCH v11 3/7 x86/sgx: Initial poison handling for dirty and free pages
In reply to Tony LuckA memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags (Currently just sgx_reclaimer_lock which protects the SGX_EPC_PAGE_RECLAIMER_TRACKED bit in page->flags).
In both cases place the poisoned page on a per-node list of poisoned epc pages to make sure it will not be reallocated.
--- arch/x86/kernel/cpu/sgx/main.c | 26 +++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 4 +++- 2 files changed, 28 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +25 -1
@@ -62,6 +62,24 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +/* +* Checking page->poison without holding the node->lock +* is racy, but losing the race (i.e. poison is set just +* after the check) just means __eremove() will be uselessly +* called for a page that sgx_free_epc_page() will put onto +* the node->sgx_poison_page_list later. +*/ +if (page->poison) { +struct sgx_epc_section *section = &sgx_epc_sections[page->section]; +struct sgx_numa_node *node = section->node; + +spin_lock (&node->lock); +list_move (&page->list, &node->sgx_poison_page_list); +spin_unlock (&node->lock); + +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +644,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &node->sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =SGX_EPC_PAGE_IS_FREE ;
@@ -658,6 +680,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =0 ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
@@ -724,6 +747,7 @@ static bool __init sgx_page_cache_init(void)if (!node_isset (nid, sgx_numa_mask)) {spin_lock_init (&sgx_numa_nodes[nid].lock);INIT_LIST_HEAD (&sgx_numa_nodes[nid].free_page_list); +INIT_LIST_HEAD (&sgx_numa_nodes[nid].sgx_poison_page_list);node_set (nid, sgx_numa_mask); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -1
@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };
@@ -42,6 +43,7 @@ struct sgx_epc_page {*/ struct sgx_numa_node {struct list_head free_page_list; +struct list_head sgx_poison_page_list;spinlock_t lock; };
Signature · 1 line
2.31.1
[tip: x86/sgx] x86/sgx: Initial poison handling for dirty and free pages
The following commit has been merged into the x86/sgx branch of tip:
The following commit has been merged into the x86/sgx branch of tip:
Commit-ID: 992801ae92431761b3d8ec88abd5793d154d34ac Gitweb: https://git.kernel.org/tip/992801ae92431761b3d8ec88abd5793d154d34ac Author: Tony Luck <[email protected]> AuthorDate: Tue, 26 Oct 2021 15:00:46 -07:00 Committer: Dave Hansen <[email protected]> CommitterDate: Mon, 15 Nov 2021 11:13:16 -08:00
x86/sgx: Initial poison handling for dirty and free pages
A memory controller patrol scrubber can report poison in a page that isn't currently being used.
Add "poison" field in the sgx_epc_page that can be set for an sgx_epc_page. Check for it:
1) When sanitizing dirty pages
2) When freeing epc pages
Poison is a new field separated from flags to avoid having to make all updates to flags atomic, or integrate poison state changes into some other locking scheme to protect flags (Currently just sgx_reclaimer_lock which protects the SGX_EPC_PAGE_RECLAIMER_TRACKED bit in page->flags).
In both cases place the poisoned page on a per-node list of poisoned epc pages to make sure it will not be reallocated.
--- arch/x86/kernel/cpu/sgx/main.c | 26 +++++++++++++++++++++++++- arch/x86/kernel/cpu/sgx/sgx.h | 4 +++- 2 files changed, 28 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/sgx/main.c +25 -1
@@ -62,6 +62,24 @@ static void __sgx_sanitize_pages(struct list_head *dirty_page_list) page = list_first_entry(dirty_page_list, struct sgx_epc_page, list); +/* +* Checking page->poison without holding the node->lock +* is racy, but losing the race (i.e. poison is set just +* after the check) just means __eremove() will be uselessly +* called for a page that sgx_free_epc_page() will put onto +* the node->sgx_poison_page_list later. +*/ +if (page->poison) { +struct sgx_epc_section *section = &sgx_epc_sections[page->section]; +struct sgx_numa_node *node = section->node; + +spin_lock (&node->lock); +list_move (&page->list, &node->sgx_poison_page_list); +spin_unlock (&node->lock); + +continue ; + } + ret =__eremove (sgx_get_epc_virt_addr (page));if (!ret) {/*
@@ -626,7 +644,11 @@ void sgx_free_epc_page(struct sgx_epc_page *page)spin_lock (&node->lock); -list_add_tail (&page->list, &node->free_page_list); + page->owner =NULL ; +if (page->poison) +list_add (&page->list, &node->sgx_poison_page_list); +else +list_add_tail (&page->list, &node->free_page_list); sgx_nr_free_pages++; page->flags =SGX_EPC_PAGE_IS_FREE ;
@@ -658,6 +680,7 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, section->pages[i].section = index; section->pages[i].flags =0 ; section->pages[i].owner =NULL ; + section->pages[i].poison =0 ;list_add_tail (§ion->pages[i].list, &sgx_dirty_page_list); }
@@ -724,6 +747,7 @@ static bool __init sgx_page_cache_init(void)if (!node_isset (nid, sgx_numa_mask)) {spin_lock_init (&sgx_numa_nodes[nid].lock);INIT_LIST_HEAD (&sgx_numa_nodes[nid].free_page_list); +INIT_LIST_HEAD (&sgx_numa_nodes[nid].sgx_poison_page_list);node_set (nid, sgx_numa_mask); }
arch/x86/kernel/cpu/sgx/sgx.h +3 -1
@@ -31,7 +31,8 @@struct sgx_epc_page {unsigned int section; -unsigned int flags; +u16 flags; +u16 poison;struct sgx_encl_page *owner;struct list_head list; };
@@ -42,6 +43,7 @@ struct sgx_epc_page {*/ struct sgx_numa_node {struct list_head free_page_list; +struct list_head sgx_poison_page_list;spinlock_t lock; };
Tony Luck
reviewerPATCH v11 4/7 x86/sgx: Add SGX infrastructure to recover from poison
In reply to Tony LuckProvide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the per-node poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 76 ++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +76 -0
@@ -693,6 +693,82 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&sgx_epc_address_space, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If the page is on a free list, move it to the per-node +* poison page list. +*/ +if (page->flags &SGX_EPC_PAGE_IS_FREE ) { +list_move (&page->list, &node->sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Signature · 1 line
2.31.1
[tip: x86/sgx] x86/sgx: Add SGX infrastructure to recover from poison
The following commit has been merged into the x86/sgx branch of tip:
The following commit has been merged into the x86/sgx branch of tip:
Commit-ID: a495cbdffa30558b34f3c95555cecc4fd9688039 Gitweb: https://git.kernel.org/tip/a495cbdffa30558b34f3c95555cecc4fd9688039 Author: Tony Luck <[email protected]> AuthorDate: Tue, 26 Oct 2021 15:00:47 -07:00 Committer: Dave Hansen <[email protected]> CommitterDate: Mon, 15 Nov 2021 11:13:16 -08:00
x86/sgx: Add SGX infrastructure to recover from poison
Provide a recovery function sgx_memory_failure(). If the poison was consumed synchronously then send a SIGBUS. Note that the virtual address of the access is not included with the SIGBUS as is the case for poison outside of SGX enclaves. This doesn't matter as addresses of code/data inside an enclave is of little to no use to code executing outside the (now dead) enclave.
Poison found in a free page results in the page being moved from the free list to the per-node poison page list.
--- arch/x86/kernel/cpu/sgx/main.c | 76 +++++++++++++++++++++++++++++++++- 1 file changed, 76 insertions(+)
arch/x86/kernel/cpu/sgx/main.c +76 -0
@@ -693,6 +693,82 @@ bool arch_is_platform_page(u64 paddr) }EXPORT_SYMBOL_GPL (arch_is_platform_page); +static struct sgx_epc_page *sgx_paddr_to_page (u64 paddr) +{ +struct sgx_epc_section *section; + + section =xa_load (&sgx_epc_address_space, paddr); +if (!section) +return NULL ; + +return §ion->pages[PFN_DOWN (paddr - section->phys_addr)]; +} + +/* +* Called in process context to handle a hardware reported +* error in an SGX EPC page. +* If the MF_ACTION_REQUIRED bit is set in flags, then the +* context is the task that consumed the poison data. Otherwise +* this is called from a kernel thread unrelated to the page. +*/ +int arch_memory_failure (unsigned long pfn,int flags) +{ +struct sgx_epc_page *page =sgx_paddr_to_page (pfn <<PAGE_SHIFT ); +struct sgx_epc_section *section; +struct sgx_numa_node *node; + +/* +* mm/memory-failure.c calls this routine for all errors +* where there isn't a "struct page" for the address. But that +* includes other address ranges besides SGX. +*/ +if (!page) +return -ENXIO ; + +/* +* If poison was consumed synchronously. Send a SIGBUS to +* the task. Hardware has already exited the SGX enclave and +* will not allow re-entry to an enclave that has a memory +* error. The signal may help the task understand why the +* enclave is broken. +*/ +if (flags &MF_ACTION_REQUIRED ) +force_sig (SIGBUS ); + + section = &sgx_epc_sections[page->section]; + node = section->node; + +spin_lock (&node->lock); + +/* Already poisoned? Nothing more to do */ +if (page->poison) + goto out; + + page->poison =1 ; + +/* +* If the page is on a free list, move it to the per-node +* poison page list. +*/ +if (page->flags &SGX_EPC_PAGE_IS_FREE ) { +list_move (&page->list, &node->sgx_poison_page_list); + goto out; + } + +/* +* TBD: Add additional plumbing to enable pre-emptive +* action for asynchronous poison notification. Until +* then just hope that the poison: +* a) is not accessed - sgx_free_epc_page() will deal with it +* when the user gives it back +* b) results in a recoverable machine check rather than +* a fatal one +*/ +out: +spin_unlock (&node->lock); +return 0 ; +} +/** * A section metric is concatenated in a way that @low bits 12-31 define the * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
Tony Luck
reviewerPATCH v11 5/7 x86/sgx: Hook arch_memory_failure() into mainline code
In reply to Tony LuckAdd a call inside memory_failure() to call the arch specific code to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 13 +++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 38 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -853,4 +853,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -98,6 +99,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +13 -0
@@ -3124,6 +3124,19 @@ extern void shake_page(struct page *p);extern atomic_long_t num_poisoned_pages__read_mostly ;extern int soft_offline_page (unsigned long pfn,int flags); +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif /* * Error handlers for various types of pages.
mm/memory-failure.c +13 -6
@@ -1632,21 +1632,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);
Signature · 1 line
2.31.1
[tip: x86/sgx] x86/sgx: Hook arch_memory_failure() into mainline code
The following commit has been merged into the x86/sgx branch of tip:
The following commit has been merged into the x86/sgx branch of tip:
Commit-ID: 03b122da74b22fbe7cd98184fa5657a9ce13970c Gitweb: https://git.kernel.org/tip/03b122da74b22fbe7cd98184fa5657a9ce13970c Author: Tony Luck <[email protected]> AuthorDate: Tue, 26 Oct 2021 15:00:48 -07:00 Committer: Dave Hansen <[email protected]> CommitterDate: Mon, 15 Nov 2021 11:13:16 -08:00
x86/sgx: Hook arch_memory_failure() into mainline code
Add a call inside memory_failure() to call the arch specific code to check if the address is an SGX EPC page and handle it.
Note the SGX EPC pages do not have a "struct page" entry, so the hook goes in at the same point as the device mapping hook.
Pull the call to acquire the mutex earlier so the SGX errors are also protected.
Make set_mce_nospec() skip SGX pages when trying to adjust the 1:1 map.
--- arch/x86/include/asm/processor.h | 8 ++++++++ arch/x86/include/asm/set_memory.h | 4 ++++ include/linux/mm.h | 13 +++++++++++++ mm/memory-failure.c | 19 +++++++++++++------ 4 files changed, 38 insertions(+), 6 deletions(-)
arch/x86/include/asm/processor.h +8 -0
@@ -855,4 +855,12 @@ enum mds_mitigations { MDS_MITIGATION_VMWERV, }; +#ifdef CONFIG_X86_SGX +int arch_memory_failure (unsigned long pfn,int flags); +#define arch_memory_failure arch_memory_failure + +bool arch_is_platform_page (u64 paddr); +#define arch_is_platform_page arch_is_platform_page +#endif +#endif /* _ASM_X86_PROCESSOR_H */
arch/x86/include/asm/set_memory.h +4 -0
@@ -2,6 +2,7 @@#ifndef _ASM_X86_SET_MEMORY_H#define _ASM_X86_SET_MEMORY_H +#include <linux/mm.h> #include <asm/page.h> #include <asm-generic/set_memory.h>
@@ -99,6 +100,9 @@ static inline int set_mce_nospec(unsigned long pfn, bool unmap)unsigned long decoy_addr;int rc; +/* SGX pages are not in the 1:1 map */ +if (arch_is_platform_page (pfn <<PAGE_SHIFT )) +return 0 ;/* * We would like to just call: * set_memory_XX((unsigned long)pfn_to_kaddr(pfn), 1);
include/linux/mm.h +13 -0
@@ -3231,6 +3231,19 @@ extern void shake_page(struct page *p);extern atomic_long_t num_poisoned_pages__read_mostly ;extern int soft_offline_page (unsigned long pfn,int flags); +#ifndef arch_memory_failure +static inline int arch_memory_failure (unsigned long pfn,int flags) +{ +return -ENXIO ; +} +#endif + +#ifndef arch_is_platform_page +static inline bool arch_is_platform_page (u64 paddr) +{ +return false; +} +#endif /* * Error handlers for various types of pages.
mm/memory-failure.c +13 -6
@@ -1651,21 +1651,28 @@ int memory_failure(unsigned long pfn, int flags)if (!sysctl_memory_failure_recovery)panic ("Memory failure on page %lx" , pfn); +mutex_lock (&mf_mutex); + p =pfn_to_online_page (pfn);if (!p) { + res =arch_memory_failure (pfn, flags); +if (res ==0 ) + goto unlock_mutex; +if (pfn_valid (pfn)) { pgmap =get_dev_pagemap (pfn,NULL ); -if (pgmap) -return memory_failure_dev_pagemap (pfn, flags, - pgmap); +if (pgmap) { + res =memory_failure_dev_pagemap (pfn, flags, + pgmap); + goto unlock_mutex; + } }pr_err ("Memory failure: %#lx: memory outside kernel control\n" , pfn); -return -ENXIO ; + res = -ENXIO ; + goto unlock_mutex; } -mutex_lock (&mf_mutex); - try_again:if (PageHuge (p)) { res =memory_failure_hugetlb (pfn, flags);