Skip to contentSkip to conversation

Bluetooth btusb.c: Add pr_info() for logging.

PATCH In review Sumedh W. Jambekar 3 participants 3 messages Jun 22, 2025 – Jun 23, 2025 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth btusb.c: Add pr_info() for logging.

In this commit, the pr_info() call is added in the probe function for logging purposes. This is done as part of the assignment in the LFD103 course.

---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/bluetooth/btusb.c +1 -0
index 9ab661d2d1e6..5ecb9a61a33b 100644
@@ -3858,6 +3858,7 @@ static int btusb_probe(struct usb_interface *intf,
 	unsigned ifnum_base;
 	int i, err, priv_size;
 
+    pr_info("SWJ changed the btusb driver in the Linux Kernel\n");
 	BT_DBG("intf %p id %p", intf, id);
 
 	if ((id->driver_info & BTUSB_IFNUM_2) &&
Signature · 1 line
2.43.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=974616

---Test result---

Test Summary:

CheckPatch                    PENDING   0.41 seconds
GitLint                       PENDING   0.31 seconds
SubjectPrefix                 FAIL      0.36 seconds
BuildKernel                   PASS      25.30 seconds
CheckAllWarning               PASS      27.98 seconds
CheckSparse                   PASS      31.31 seconds
BuildKernel32                 PASS      25.26 seconds
TestRunnerSetup               PASS      491.56 seconds
TestRunner_l2cap-tester       PASS      25.90 seconds
TestRunner_iso-tester         PASS      50.41 seconds
TestRunner_bnep-tester        PASS      6.02 seconds
TestRunner_mgmt-tester        PASS      134.71 seconds
TestRunner_rfcomm-tester      PASS      9.53 seconds
TestRunner_sco-tester         PASS      15.08 seconds
TestRunner_ioctl-tester       PASS      10.31 seconds
TestRunner_mesh-tester        PASS      7.58 seconds
TestRunner_smp-tester         PASS      8.95 seconds
TestRunner_userchan-tester    PASS      6.40 seconds
IncrementalBuild              PENDING   0.56 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Sumedh W. Jambekar
Quoted 3 lines · Sumedh W. Jambekar

In this commit, the pr_info() call is added in the probe function for logging purposes. This is done as part of the assignment in the LFD103 course.

Do not submit junk contributions to upstream as part of your course work. This is a burden on upstream, and you failed to even run it through checkpatch.pl which would have shown that you used the wrong spacing.

This is a good way to get blocked upstream, don't send another patch unless it is something that can be merged upstream.

Quoted 19 lines

---
 drivers/bluetooth/btusb.c | 1 +

 1 file changed, 1 insertion(+)
drivers/bluetooth/btusb.c +0 -0
index 9ab661d2d1e6..5ecb9a61a33b 100644
@@ -3858,6 +3858,7 @@ static int btusb_probe(struct usb_interface
 *intf,
  	unsigned ifnum_base;
  	int i, err, priv_size;


+    pr_info("SWJ changed the btusb driver in the Linux Kernel\n"); BT_DBG("intf %p id %p", intf, id);

  if ((id->driver_info & BTUSB_IFNUM_2) &&