shared/shell: Fix not calling pre_run for main menu
Luiz Augusto von Dentz
maintainerPATCH 1/1 shared/shell: Fix not calling pre_run for main menu
From: Luiz Augusto von Dentz <[email protected]>
When calling bt_shell_run the main menu pre_run was not being called which cause tools with just one menu to not work as intended.
--- src/shared/shell.c | 3 +++ 1 file changed, 3 insertions(+)
src/shared/shell.c +3 -0
@@ -1449,6 +1449,9 @@ int bt_shell_run(void)int status;const struct queue_entry *submenu; +if (data.menu && data.menu->pre_run) + data.menu->pre_run (data.menu); +for (submenu =queue_get_entries (data.submenus); submenu; submenu = submenu->next) {struct bt_shell_menu *menu = submenu->data;
Signature · 1 line
2.49.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=978742
---Test result---
Test Summary:
CheckPatch PENDING 0.30 seconds GitLint PENDING 0.21 seconds BuildEll PASS 20.30 seconds BluezMake PASS 2704.02 seconds MakeCheck PASS 20.18 seconds MakeDistcheck PASS 197.80 seconds CheckValgrind PASS 274.51 seconds CheckSmatch WARNING 302.89 seconds bluezmakeextell PASS 128.26 seconds IncrementalBuild PENDING 0.27 seconds ScanBuild PASS 906.82 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Thu, 3 Jul 2025 13:32:28 -0400 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
When calling
bt_shell_runthe main menupre_runwas not being called which cause tools with just one menu to not work as intended.[...]
Here is the summary with links:
- [BlueZ,v1] shared/shell: Fix not calling pre_run for main menu
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=655421a96263
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html