Skip to contentSkip to conversation

Bluetooth: btintel: Check if controller is ISO capable on btintel_classify_pkt_type

PATCH Applied Luiz Augusto von Dentz 4 participants 8 messages Jul 9, 2025 – Jul 10, 2025 1 message not in the archive Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 Bluetooth: btintel: Check if controller is ISO capable on btintel_classify_pkt_type

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -1
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
 	 * Distinguish ISO data packets form ACL data packets
 	 * based on their connection handle value range.
 	 */
-	if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+	if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
 		__u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
 		if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
Signature · 1 line
2.50.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=980685

---Test result---

Test Summary:

CheckPatch                    PENDING   0.47 seconds
GitLint                       PENDING   0.28 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      23.88 seconds
CheckAllWarning               PASS      27.05 seconds
CheckSparse                   PASS      29.49 seconds
BuildKernel32                 PASS      23.52 seconds
TestRunnerSetup               PASS      463.59 seconds
TestRunner_l2cap-tester       PASS      25.41 seconds
TestRunner_iso-tester         PASS      36.03 seconds
TestRunner_bnep-tester        PASS      5.96 seconds
TestRunner_mgmt-tester        FAIL      133.27 seconds
TestRunner_rfcomm-tester      PASS      11.23 seconds
TestRunner_sco-tester         PASS      15.16 seconds
TestRunner_ioctl-tester       PASS      10.14 seconds
TestRunner_mesh-tester        FAIL      11.48 seconds
TestRunner_smp-tester         PASS      8.96 seconds
TestRunner_userchan-tester    PASS      6.30 seconds
IncrementalBuild              PENDING   0.64 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
LL Privacy - Add Device 3 (AL is full) Failed 0.238 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases

Mesh - Send cancel - 1                               Timed out    2.124 seconds
Mesh - Send cancel - 2                               Timed out    1.999 seconds

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

author maintainer
#2 lore raw
In reply to Luiz Augusto von Dentz

Hi Sean,

Quoted 33 lines · Luiz Augusto von Dentz

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--
Quoted 1 line

2.50.0

Can you try with the changes above?

Signature · 1 line
Luiz Augusto von Dentz

A message that is not in the archive (sent off-list or not yet received): CABtds-0U4mD9kr708UdB+SAHRvBAPYrEaOSCjKkqTDXjJpWOUw@mail.gmail.com

author maintainer
#4 lore raw

Hi Sean,

Quoted 54 lines · Sean Rhodes

Hi Luiz

Yes, works perfectly with that patch.

Thanks

Sean

Quoted 44 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 33 lines · Luiz Augusto von Dentz

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--
Quoted 1 line

2.50.0

Can you try with the changes above?

--
Luiz Augusto von Dentz

Please add Tested-by so we can move to get it merged, I do intend to send a pull request later this week.

Signature · 1 line
Luiz Augusto von Dentz
#5 lore raw

Like thus? Sorry, not too familiar with the email patches.

Quoted 34 lines

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--

2.50.0

Quoted 64 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 54 lines · Sean Rhodes

Hi Luiz

Yes, works perfectly with that patch.

Thanks

Sean

Quoted 44 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 33 lines · Luiz Augusto von Dentz

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--
Quoted 1 line

2.50.0

Can you try with the changes above?

--
Luiz Augusto von Dentz

Please add Tested-by so we can move to get it merged, I do intend to send a pull request later this week.

--
Luiz Augusto von Dentz

author maintainer Tested-by Sean Rhodes
#6 lore raw

Hi Sean,

Quoted 2 lines · Sean Rhodes

Like thus? Sorry, not too familiar with the email patches.

Just do:

Quoted 102 lines
Quoted 34 lines

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--

2.50.0

Quoted 64 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 54 lines · Sean Rhodes

Hi Luiz

Yes, works perfectly with that patch.

Thanks

Sean

Quoted 44 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 33 lines · Luiz Augusto von Dentz

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--
Quoted 1 line

2.50.0

Can you try with the changes above?

--
Luiz Augusto von Dentz

Please add Tested-by so we can move to get it merged, I do intend to send a pull request later this week.

--
Luiz Augusto von Dentz

Signature · 1 line
Luiz Augusto von Dentz
Tested-by
#7 lore raw
Quoted 118 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 2 lines · Sean Rhodes

Like thus? Sorry, not too familiar with the email patches.

Just do:

Quoted 94 lines
Quoted 34 lines

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--

2.50.0

Quoted 56 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 52 lines · Sean Rhodes

Hi Luiz

Yes, works perfectly with that patch.

Thanks

Sean

Quoted 42 lines · Luiz Augusto von Dentz

Hi Sean,

Quoted 33 lines · Luiz Augusto von Dentz

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -2
index 55cc1652bfe4..06575a0b9aee 100644
@@ -2670,7 +2670,7 @@ static u8 btintel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
         * Distinguish ISO data packets form ACL data packets
         * based on their connection handle value range.
         */
-       if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+       if (iso_capable(hdev) && hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
                __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
 
                if (hci_handle(handle) >= BTINTEL_ISODATA_HANDLE_BASE)
--
Quoted 1 line

2.50.0

Can you try with the changes above?

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines

--
Luiz Augusto von Dentz

Please add Tested-by so we can move to get it merged, I do intend to send a pull request later this week.

--
Luiz Augusto von Dentz

--
Luiz Augusto von Dentz

#8 lore raw
In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 10 lines · On Wed, 9 Jul 2025 15:13:33 -0400 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

Due to what seem to be a bug with variant version returned by some firmwares the code may set hdev->classify_pkt_type with btintel_classify_pkt_type when in fact the controller doesn't even support ISO channels feature but may use the handle range expected from a controllers that does causing the packets to be reclassified as ISO causing several bugs.

[...]

Here is the summary with links:
- [v1] Bluetooth: btintel: Check if controller is ISO capable on btintel_classify_pkt_type

    https://git.kernel.org/bluetooth/bluetooth-next/c/1eea42b9d33f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html