Bluetooth: btintel: Add support for BlazarIW core
PATCH 1/1 Bluetooth: btintel: Add support for BlazarIW core
Need to add support for BlazarIW Bluetooth core used in Wildcat Lake platform.
--- drivers/bluetooth/btintel.c | 3 +++ drivers/bluetooth/btintel_pcie.c | 1 + 2 files changed, 4 insertions(+)
drivers/bluetooth/btintel.c +3 -0
@@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,case 0x1d :/* BlazarU (BzrU) */ case 0x1e :/* BlazarI (Bzr) */ case 0x1f :/* Scorpious Peak */ +case 0x22 :/* BlazarIW (BzrIW */ break ;default : bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
@@ -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)case 0x1d :case 0x1e :case 0x1f : +case 0x22 :hci_set_msft_opcode (hdev,0xFC1E );break ;default :
@@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)case 0x1d :case 0x1e :case 0x1f : +case 0x22 :/* Display version information of TLV type */ btintel_version_info_tlv (hdev, &ver_tlv);
drivers/bluetooth/btintel_pcie.c +1 -0
@@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct hci_dev *hdev)switch (INTEL_HW_VARIANT (ver_tlv.cnvi_bt)) {case 0x1e :/* BzrI */ case 0x1f :/* ScP */ +case 0x22 :/* BzrIW */ /* Display version information of TLV type */ btintel_version_info_tlv (hdev, &ver_tlv);
Signature · 1 line
2.43.0
Dear Kiran,
Am 23.07.25 um 08:26 schrieb Kiran K:
Quoted 2 lines
Need to add support for BlazarIW Bluetooth core used in Wildcat Lake platform.
Need to … sounds strange for a commit message.
Where is the id from? It’d be great if you added the datasheet name and revision.
Also, how did you test this?
Quoted 12 lines
Signed-off-by Vijay Satija <[email protected]>Signed-off-by Kiran K <[email protected]>--- drivers/bluetooth/btintel.c | 3 +++ drivers/bluetooth/btintel_pcie.c | 1 + 2 files changed, 4 insertions(+)drivers/bluetooth/btintel.c +0
-0
drivers/bluetooth/btintel.c int btintel_version_info_tlv(struct hci_dev *hdev, · line 487
Quoted 4 lines
drivers/bluetooth/btintel.c +1
-0@@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,case 0x1d :/* BlazarU (BzrU) */ case 0x1e :/* BlazarI (Bzr) */ case 0x1f :/* Scorpious Peak */ +case 0x22 :/* BlazarIW (BzrIW */
Missing closing ).
Quoted 24 lines
drivers/bluetooth/btintel.c +2
-0break ;default : bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",@@ -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)case 0x1d :case 0x1e :case 0x1f : +case 0x22 :hci_set_msft_opcode (hdev,0xFC1E );break ;default :@@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)case 0x1d :case 0x1e :case 0x1f : +case 0x22 :/* Display version information of TLV type */ btintel_version_info_tlv (hdev, &ver_tlv);drivers/bluetooth/btintel_pcie.c +0
-0
drivers/bluetooth/btintel_pcie.c static int btintel_pcie_setup_internal(struct hci_dev *hdev) · line 2155
Quoted 7 lines
drivers/bluetooth/btintel_pcie.c +1
-0@@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct hci_dev *hdev)switch (INTEL_HW_VARIANT (ver_tlv.cnvi_bt)) {case 0x1e :/* BzrI */ case 0x1f :/* ScP */ +case 0x22 :/* BzrIW */ /* Display version information of TLV type */ btintel_version_info_tlv (hdev, &ver_tlv);
The rest looks good.
Kind regards,
Paul
Hi Paul,
Thanks for the comments.
Quoted 8 lines
-----Original Message-----
From: Paul Menzel <[email protected]>
Sent: Wednesday, July 23, 2025 11:51 AM
To: K, Kiran <[email protected]>
Cc: [email protected]; Srivatsa, Ravishankar <[email protected]>; Vijay Satija <[email protected]>
Subject: Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core
Quoted 8 lines
Dear Kiran,
Am 23.07.25 um 08:26 schrieb Kiran K:
Quoted 2 lines
Need to add support for BlazarIW Bluetooth core used in Wildcat Lake platform.
Need to … sounds strange for a commit message.
Ack. I will modify the commit message.
Quoted 3 lines
Where is the id from? It’d be great if you added the datasheet name and revision.
Id comes from hardware requirements which is maintained in JIRAs.
Quoted 2 lines
Also, how did you test this?
It was tested on silicon. May be I can add the firmware download messages from dmesg.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Vijay Satija <[email protected]>Signed-off-by Kiran K <[email protected]>--- drivers/bluetooth/btintel.c | 3 +++ drivers/bluetooth/btintel_pcie.c | 1 + 2 files changed, 4 insertions(+)
Quoted 11 lines
drivers/bluetooth/btintel.c int btintel_version_info_tlv(struct hci_dev *hdev, · line 487
Quoted 9 lines
drivers/bluetooth/btintel.c +1
-0@@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,case 0x1d :/* BlazarU (BzrU) */ case 0x1e :/* BlazarI (Bzr) */ case 0x1f :/* Scorpious Peak */ +case 0x22 :/* BlazarIW (BzrIW */ Missing closing ).
Ack
Quoted 41 lines
drivers/bluetooth/btintel.c int btintel_version_info_tlv(struct hci_dev *hdev,
Quoted 4 lines
drivers/bluetooth/btintel.c +0
-0break ;default : bt_dev_err(hdev, "Unsupported Intel hardware variant(0x%x)", @@
Quoted 1 line
-3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct
hci_dev*hdev, u8
hw_variant)drivers/bluetooth/btintel.c static int btintel_setup_combined(struct hci_dev
Quoted 8 lines
case
0x1d:
case0x1e:
case0x1f:drivers/bluetooth/btintel.c +1
-0+case 0x22 :hci_set_msft_opcode (hdev,0xFC1E );break ;default :@@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev*hdev)
drivers/bluetooth/btintel_pcie.c static int btintel_pcie_setup_internal(struct
Quoted 13 lines
drivers/bluetooth/btintel.c +1
-0case 0x1d :case 0x1e :case 0x1f : +case 0x22 :/* Display version information of TLV type */ btintel_version_info_tlv (hdev, &ver_tlv);drivers/bluetooth/btintel_pcie.c +0
-0@@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct
hci_dev*hdev)drivers/bluetooth/btintel_pcie.c static int btintel_pcie_setup_internal(struct hci_dev *hdev) · line 2155
Quoted 7 lines
drivers/bluetooth/btintel_pcie.c +1
-0switch (INTEL_HW_VARIANT (ver_tlv.cnvi_bt)) {case 0x1e :/* BzrI */ case 0x1f :/* ScP */ +case 0x22 :/* BzrIW */ /* Display version information of TLV type */ btintel_version_info_tlv (hdev, &ver_tlv);The rest looks good.
Quoted 3 lines
Kind regards,
Paul
Thanks,
Kiran
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=984974
---Test result---
Test Summary:
CheckPatch PENDING 0.29 seconds GitLint PENDING 0.21 seconds SubjectPrefix PASS 0.13 seconds BuildKernel PASS 24.06 seconds CheckAllWarning PASS 26.65 seconds CheckSparse PASS 30.00 seconds BuildKernel32 PASS 24.11 seconds TestRunnerSetup PASS 471.66 seconds TestRunner_l2cap-tester PASS 25.25 seconds TestRunner_iso-tester PASS 40.21 seconds TestRunner_bnep-tester PASS 6.16 seconds TestRunner_mgmt-tester FAIL 133.14 seconds TestRunner_rfcomm-tester PASS 9.54 seconds TestRunner_sco-tester PASS 14.99 seconds TestRunner_ioctl-tester PASS 10.14 seconds TestRunner_mesh-tester FAIL 11.69 seconds TestRunner_smp-tester PASS 8.65 seconds TestRunner_userchan-tester PASS 6.42 seconds IncrementalBuild PENDING 0.95 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
LL Privacy - Set Device Flag 1 (Device Privacy) Failed 0.156 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.160 seconds Mesh - Send cancel - 2 Timed out 1.989 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
Quoted 5 lines · Kiran K
Need to add support for BlazarIW Bluetooth core used in Wildcat Lake platform.
Signed-off-by Vijay Satija <[email protected]>Signed-off-by Kiran K <[email protected]>
Do you have a "tested-by" too?
Is there an "lspci" or similar output that could be added to the commit message that would help identify this device?
Typo mentioned in the comments below.
Cheers
Quoted 15 lines
---
drivers/bluetooth/btintel.c | 3 +++
drivers/bluetooth/btintel_pcie.c | 1 +2 files changed, 4 insertions(+)drivers/bluetooth/btintel.c +0
-0@@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,case
0x1d: /* BlazarU (BzrU) */
case0x1e: /* BlazarI (Bzr) */
case 0x1f: /* Scorpious Peak */
drivers/bluetooth/btintel.c int btintel_version_info_tlv(struct hci_dev *hdev, · line 487
Quoted 1 line
drivers/bluetooth/btintel.c +1
-0+case 0x22 :/* BlazarIW (BzrIW */
Missing closing paren
<snip>
Quoted 5 lines · Bastien Nocera
Quoted 4 lines · Kiran K
Need to add support for BlazarIW Bluetooth core used in Wildcat Lake
platform.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Vijay Satija <[email protected]>Signed-off-by Kiran K <[email protected]>Do you have a "tested-by" too?
Is there an "lspci" or similar output that could be added to the commit
message that would help identify this device?
FWIW, Vijay's address doesn't work. Would be good to have a working one, otherwise please remove his name from the commit message.
Quoted 25 lines
Typo mentioned in the comments below.
Cheers
Quoted 15 lines
---
drivers/bluetooth/btintel.c | 3 +++
drivers/bluetooth/btintel_pcie.c | 1 +2 files changed, 4 insertions(+)drivers/bluetooth/btintel.c +0
-0@@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,case
0x1d: /* BlazarU (BzrU) */
case0x1e: /* BlazarI (Bzr) */
case 0x1f: /* Scorpious Peak */drivers/bluetooth/btintel.c int btintel_version_info_tlv(struct hci_dev *hdev, · line 487
Quoted 1 line
drivers/bluetooth/btintel.c +1
-0+case 0x22 :/* BlazarIW (BzrIW */ Missing closing paren
<snip>