Skip to contentSkip to conversation

soc: qcom: fix module autoloading

PATCH In review Krzysztof Kozlowski 3 participants 4 messages Apr 10, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom: fix module autoloading

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table.

---
 drivers/soc/qcom/pmic_pdcharger_ulog.c | 1 +
 drivers/soc/qcom/rpm_master_stats.c    | 1 +
 2 files changed, 2 insertions(+)
drivers/soc/qcom/pmic_pdcharger_ulog.c +1 -0
index 238cd38589dc..5f9ea3fe6d6d 100644
@@ -150,6 +150,7 @@ static const struct rpmsg_device_id pmic_pdcharger_ulog_rpmsg_id_match[] = {
 	{ "PMIC_LOGS_ADSP_APPS" },
 	{}
 };
+MODULE_DEVICE_TABLE(rpmsg, pmic_pdcharger_ulog_rpmsg_id_match);
 
 static struct rpmsg_driver pmic_pdcharger_ulog_rpmsg_driver = {
 	.probe = pmic_pdcharger_ulog_rpmsg_probe,
drivers/soc/qcom/rpm_master_stats.c +1 -0
index 9ca13bcf67d3..c5745e20e736 100644
@@ -148,6 +148,7 @@ static const struct of_device_id rpm_master_table[] = {
 	{ .compatible = "qcom,rpm-master-stats" },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, rpm_master_table);
 
 static struct platform_driver master_stats_driver = {
 	.probe = master_stats_probe,
Signature · 1 line
2.34.1
#1 lore raw
Quoted 5 lines · Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table.

---

These were omitted intentionally, as these are both debug drivers.

Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer

Konrad

#2 lore raw
Quoted 11 lines · Konrad Dybcio
Quoted 5 lines · Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table.

---

These were omitted intentionally, as these are both debug drivers.

Makes sense to me, could we have a comment added that clarifies this intention?

Quoted 2 lines

Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer

Not sure if that is necessary, and IMO it wouldn't convey that MODULE_DEVICE_TABLE() was omitted intentionally.

Regards,
Bjorn

#3 lore raw
Quoted 13 lines · Bjorn Andersson
Quoted 11 lines · Konrad Dybcio
Quoted 5 lines · Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table.

---

These were omitted intentionally, as these are both debug drivers.

Quoted 8 lines

Makes sense to me, could we have a comment added that clarifies this intention?

Quoted 2 lines

Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer

Not sure if that is necessary, and IMO it wouldn't convey that MODULE_DEVICE_TABLE() was omitted intentionally.

I think this deserves a comment, so no one will be doing my same again (it's part of bigger effort).

Best regards,
Krzysztof